- 18 Sep, 2019 40 commits
-
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: Ib26cd65ad27cb8f339a701654e5b65d20559e5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809497Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697610}
-
sreejakshetty@chromium.org authored
- Evict documents from BackForwardCache after 15secs. This can also be controlled by finch experiment using the field trial parameter:"TimeToLiveInBackForwardcache". - Design Document: https://docs.google.com/document/d/1tGva3Xl4_kRTlKSgTc1v_JA59wo2q81W1ctPj7vPX3Q/edit?usp=sharing Bug: 987187 Change-Id: Ieb61303b25e971a70042c439b520a4f296a200b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801152 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697609}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: I039efa85ff4cb4e28708e83201cf034b25987ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808216 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697608}
-
jonross authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1808810 as apparently another of the WebGLGreenTriangle tests has begun demonstarting the same flakes. This marks it as Skip on Intel. TBR=ynovikov@chromium.org TEST=vulkan_pixel_skia_gold_test Pixel_WebGLGreenTriangle_NoAA_Alpha Bug: 1004840 Change-Id: Idaf0d683e0c31ce12600d545181d63b0bb16a580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810823Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#697607}
-
chrome://flags/deprecatedYann Dago authored
Visual: http://screen/uNyrKqcrQvM Bug: 1004923 Change-Id: I94cc8988ec1f8f542ce7496c8acce5fc14f2ce98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808263Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#697606}
-
Nico Weber authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/faee8bc70570..2ecd66c696c4 $ git log faee8bc70..2ecd66c69 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 thakis Remove a few TODO(GYP)s that look obsolete. 2019-08-29 jose.dapena Cherry-pick "Do not override clang compiler internal builtins" in ICU 2019-08-30 jose.dapena Cherry-pick "Remove obsolete U_HAVE_STD_ATOMICS and similar @internal macros." in ICU Created with: roll-dep src/third_party/icu TBR=jshin Bug: 819294 Change-Id: I764954ad1d8675d3b614b120fdbb1fe2e607b946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810797Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697605}
-
Dave Tapuska authored
I believe the original change crrev.com/ae8ee33c introduced the problematic code. A related page could be in a detached state. BUG=1002513 Change-Id: I84cab50cda65f0a66ac407fc89f35bbd2b2ff7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808115Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#697604}
-
Andrew Grieve authored
Noticed during milestone binary size review. Bug: 982762 Change-Id: If14512c734f726ad6bc74feb539d954ca177eb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803394 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#697603}
-
Tim van der Lippe authored
Example invocation of the script: ./refactor-folder-to-es-modules.sh ui It will consequently refactor all files in the ui folder to JavaScript modules. It will also update the BUILD.gn variables to remove the references from the old all_devtools_files into the new modules variables. Change-Id: I35ad6360b15d1aff250afffc8a28774c4e8cc1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808867Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Cr-Commit-Position: refs/heads/master@{#697602}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1979b8bb5f78..859cb8a7e034 git log 1979b8bb5f78..859cb8a7e034 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 fmayer@google.com Merge "Add header_libs to gen_android_bp." Created with: gclient setdep -r src/third_party/perfetto@859cb8a7e034 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I5d164b1c2edc7c8c75adc92d051b78d0f3e5a5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810341Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697601}
-
Mohamed Amir Yosef authored
Change-Id: Ib4b42e493f6799681798c39165424111977fb21a Bug: 1002000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800869 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697600}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1dafd21b2cb..a84a61e89596 Created with: gclient setdep -r src-internal@a84a61e89596 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3cfa16cd84da8eb898bbf21de8830bfc07aadd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810340Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697599}
-
Nicolas Ouellet-Payeur authored
This is a reland of 2da81153 Original change's description: > [BrowserSwitcher] Enable BHO unittests on CQ > > Bug: 950039 > Change-Id: I96c208a9e3f9d75cd56ff04a7c7d97427635cc1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790147 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695206} Bug: 950039 Change-Id: I64aef9d8c47b630d0e4b628f4928520e8d07b9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808326Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#697598}
-
Stepan Khapugin authored
This reverts commit 05d76942. This change was introduced to work around an iOS 13 bug which is now fixed. Therefore it can be reverted. Bug: 988431, 875918, 873544 Change-Id: If0d0ecb7a3f22097f662e01a35d631b2a997be9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807251 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#697597}
-
Anna Malova authored
Bug: 952302 Change-Id: I3e6e37098db9e511c62d5b275b9f64e233f958e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730917 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697596}
-
Paul Lewis authored
Bug: 843923 Change-Id: I5f186e003edcf7170359aa6e5906b98a61160269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781586Reviewed-by:
-
Daniel Bratell authored
Change-Id: I2f3488320103441a2d7cf99aecbf8a8ec76c04a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804337Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#697594}
-
Miyoung Shin authored
This CL converts SerialService{Ptr, Request} in content to the new Mojo type. Bug: 955171 Change-Id: I764b3209cd35ec5593088c4b81e32167f3417b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810503 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#697593}
-
Gabriel Charette authored
This is the complimentary testing docs to the Threading and Tasks usage docs. Updated in-code comments to reflect the current reality better too. R=fdoray@chromium.org Bug: 1002654 Change-Id: Ic9f4227e462ddc7180a1a6f3005935f1203ff064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798985 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Mark Cogan authored
The closing-last-incognito-tab experiment has been default-on for nearly a year. This CL deletes the flag. Bug: 893314 Change-Id: Iafb145e66c8279cca034c04238b7dc3dca1f92f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807247Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#697591}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f948db6228fd..dd0dff1c35d2 git log f948db6228fd..dd0dff1c35d2 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 kjlubick@google.com [canvaskit] roll to 0.7.0 Created with: gclient setdep -r src/third_party/skia@dd0dff1c35d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I519aa7f4dfe6f415435f8a8d5081900b0f6fc700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810011Reviewed-by:
-
Mikel Astiz authored
The flakes are most notable on Mac but occur on multiple platforms. TBR=rajendrant@chromium.org BUG=1004547 Change-Id: Ia17fb182e574244b1f792729fa493f31a3aed529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807307Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697589}
-
Greg Thompson authored
This change restores sizes coverage of mini_installer.exe, setup.exe, chrome_proxy.exe, elevation_service.exe, and notification_helper.exe. Coverage was lost during the migration to //tools/binary_size/sizes.py. It is restored by adding a missing data_dep on the Windows installer and adding some missing files to the sizes script. Bug: 930325,961548 Change-Id: I3b30afdd7b8f7c40016dc7c6409a473bac817fc1 CC: jbudorick@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807236 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697588}
-
Tanisha Mandre authored
- Test that the delete button is visible in edit mode when a card is selected. - Tests that bot the delete button and the 'add payment method' button are visible in edit mode and are correctly enabled/disabled. Bug:1004349 Change-Id: I53bc9b0a4089fdf085db58f60cd2cc64650916ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807298 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36658f46..8d5e8816 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic09b93f69cc7996304d8ce901d291ad9fdffce62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810719Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697586}
-
Anton Bikineev authored
This is to fix number of regressions in browsing/rendering_desktop benchmarks which occurred after heap collections became trivially finalizable. Bug: 1002372 Change-Id: I61267729c616e9cb83d5c3ccb61699fdae6d1cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807120Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#697585}
-
henrika authored
Bug: 1003735 Change-Id: I6f81d6ffb7d677f56060395a8124e1e38930b6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807305 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697584}
-
Vasiliy Telezhnikov authored
This CL removes DCHECK for very long presentation times if the time override is active. Some tests override and fast forward time which cause large time difference between swap and present and triggers this check. Bug: 1004792 Change-Id: Id02e371fe23ccccb5638fbd6c94ddb5b7f69d8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809603 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697583}
-
Antonio Gomes authored
This CL is the main CL that moves peer_connection_dependency_factory.cc|h from content/renderer/media/webrtc to Blink. Given that is has many dependencies on content/renderer/p2p and other content classes, this work had various predecessor CLs, including: - 1804541, 1795667, 1795669, 1795671, 1798266, 1798274, 1799102, 1799085, 1801068, 1803260, 1803454. Additionally, some other content/ files that PeerConnectionDependencyFactory relies on could be moved independently to Blink easily, so this CL moves them altogether. It includes the following files: - host_address_request.cc|h - ipc_socket_factory.cc|h - mdns_responder_adapter.cc|h - port_allocator.cc|h - socket_client_impl.cc|h - socket_dispatcher.cc|h ... all from content/renderer/p2p, that got moved to third_party/blink/renderer/platform/p2p. Last, the following Blink (temporary header) got moved out of the API layer, so its method signature could get updated properly: - third_party/blink/public/platform/modules/p2p/socket_client_delegate.h (moved to) third_party/blink/renderer/platform/p2p/socket_client_delegate.h For the sake of simplicity, this CL: - keeps the ownership of PeerConnectionDependencyFactory in content's RenderThreadImpl. In a follow up CL, the ownership will moved to a suitable place in Blink. A possibility is to keep it as a global object (DEFINE_STATIC_LOCAL). BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I0dada58c447f0c8559ca4b590121f3313a1eebc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805159 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Mohamed Abdelhalim authored
This is the 4th CL of multiple CLs to remove the usages of NavigationHandleImpl completely and replace it with NavigationRequest. This CL includes removing usages of functions of NavigationHandleImpl from NavigationSimulatorImpl, and replacing them with functions of NavigationRequest. Bug: 995268 Change-Id: I4a538610cd78b7e6e8c207900318a35310d3fc4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807113 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Tanisha Mandre authored
- MobileAddCreditCard.CreditCardAdded: When a valid credit card is saved. - MobileAddCreditCard.AddPaymentMethodButton: When the 'Add Payment method' button is tapped. - MobileAddCreditCard.UseCameraButton: When a user tries to scan a credit card by tapping the 'Use Camera' button. - obileCreditCardScanner.ScannedCardNumberModified: When a user scans a credit card using the Credit Card Scanner but corrects the scanned number. - MobileCreditCardScanner.ScannedExpiryMonthModified: When a user scans a credit card using the Credit Card Scanner but corrects the scanned expiry month. - MobileCreditCardScanner.ScannedExpiryYearModified: When a user scans a credit card using the Credit Card Scanner but corrects the scanned expiry year. Bug: 989432 Change-Id: I0b0500dbced496eb47deee1d448a2fcb6790dc67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784615 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#697580}
-
Stefan Zager authored
With embedded_content_view_ set to its new value before the call to Dispose(), that method will no longer recurse back into SetEmbeddedContentView (and again into Dispose()). Change-Id: I4397616d1b41159380145ef364d88a6448909900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802116Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a1178b9bda47..1979b8bb5f78 git log a1178b9bda47..1979b8bb5f78 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 ilkos@google.com Merge "Parse appended data and add the symbols table" Created with: gclient setdep -r src/third_party/perfetto@1979b8bb5f78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I64b62212f9f63098ddf63ff8d6c3ab1a67eb9cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810785Reviewed-by:
-
http://reviews.llvm.org/rL371729Nico Weber authored
Bug: none Change-Id: Ib4091f42f4687bca810648fd25afcebc474be7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810798 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#697577}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink::mojom::FileChooser interface. Bug: 955171, 978694 Change-Id: I3ebd6685c5b5c08e3c92dbea172ceeadb3d93c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789305Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3254b433188..d1dafd21b2cb Created with: gclient setdep -r src-internal@d1dafd21b2cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I50071c45affd525e54e9ea79ab2bef3fc52c9d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810459 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Hirokazu Honda authored
VEA unittest deal with a native graphics buffer by DMABUF based VideoFrame in native_input mode. This CL changes VEA unittest to use GpuMemoryBuffer based VideoFrame. Bug: 1001413 Test: video_encode_accelerator_unittest on kevin and eve Change-Id: I18c4d1ff40bf9764fc0923739af55d55f4ac83e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808939 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#697574}
-
Arthur Hemery authored
This was initially made to run on Release builds because of a lack of opinon about it. We'd prefer to have an actual Debug build now. Related to https://chromium-review.googlesource.com/c/chromium/tools/build/+/1801697 Change-Id: Ie0d89334207af382d54fd27a1c40a6c56ba69cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803443 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#697573}
-
Friedrich Horschig authored
(This is a modified reland of https://crrev.com/c/1793082) The keyboard accessory was still using the old announcement. It would shout "Passwords available" which isn't wrong since passwords fallbacks are available but it is very imprecise, incomplete and misleading if the accessory is filled with Address autofill suggestion. Bug: 1005147 Change-Id: Ie31261aafef6665f8f256abb186cbb4a54fd2852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807243 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#697572}
-
Sylvain Defresne authored
When using IdentityTestEnvironmentProfileAdaptor, it is required to register the testing factories when creating the Profile, as the adaptor will expect the IdentityManager to have been created with certain fakes. If the factories are not set, then it is possible to encounter Undefined Behaviour (as IdentityTestEnvironment cast some of the objects to the expected fake subclasses) in the worst case or just non-fonctioning test (calling undefined methods) on certain platforms. Fix ExternalProviderImplChromeOSTest to use the proper factory by registering them in the super class. Bug: 982751 Change-Id: Id116ee5b0df4b69ccf31a152c3c0318aaf94ef45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809158 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#697571}
-
