GitLab

This CL implements the retry functionality used in download home.

Currently interrupted download that can't resume can retry. Cancelled
download potentially can also be retried.

TBR=dtrainor@chromium.org

Bug: 883387
Change-Id: I13e9ad9511d8e15c1b3432184f1376cf3dcf9319
Reviewed-on: https://chromium-review.googlesource.com/c/1278267
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612802}

PDFium started exporting them in its public config, so these are now
redundant.

Change-Id: I2f7a476059a0aefd1e46b59463dbe9e90a64af32
Reviewed-on: https://chromium-review.googlesource.com/c/1357210Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612801}

I am not part or this team anymore and neither is John.
Replacing ourselves with the team TL.

Change-Id: I6ec7c488def2403806894a5dad462774ac2281c0
Reviewed-on: https://chromium-review.googlesource.com/c/1356227Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612800}

This CL breaks out the code that inspects an individual file within a
ZIP archive. This will be shared between the ZIP and RAR inspection,
when RAR files begin doing content inspection.

Bug: 909778
Change-Id: I7acf1cabd472f112f2ed7c31735688cae7a6d122
Reviewed-on: https://chromium-review.googlesource.com/c/1354103
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612799}

Windows generally doesn't seem to echo the HmacSecret extension in their
response to AuthenticatorMakeCredential. However, AuthenticatorImpl already
parses the hmacSecret response value out of the authenticator data, so we
should not fail the request over this.

Bug: 898718
Change-Id: I1e732ab189f240df2be09ec89135af143634238f
Reviewed-on: https://chromium-review.googlesource.com/c/1357460
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612798}

This is a reland of 1d979043

Original change's description:
> macOS Sandbox: Port fontloading test to V2 sandbox.
> 
> This removes all of the obsolete unit testing code from the V1 sandbox.
> 
> Bug: 902597
> Change-Id: I426e3b815e0bf23036815750aab350adbb22e068
> Reviewed-on: https://chromium-review.googlesource.com/c/1327527
> Commit-Queue: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612416}

Bug: 902597
Change-Id: I2088dd954956be6d704add7ee8e07bc629df8eb9
Reviewed-on: https://chromium-review.googlesource.com/c/1357217Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612797}

It will use static method globals which originally froze when
protobuf tool was run after compiling with CL.EXE. This allows
MSVC based builds to be re-enabled. The next official release
of protobuf should no longer need this patch as the code around
singletons has been rewritten to no longer have this issue
present in this release of protobuf.

https://bugs.chromium.org/p/webrtc/issues/detail?id=9695

Change-Id: I729bd66429774cf9845a7ae754173722f31a208a
Reviewed-on: https://chromium-review.googlesource.com/c/1297536Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612796}

This CL:
- Makes SplashActivity singleTask
- Introduces InitialSplashActivity to launch SplashActivity. Otherwise,
  whenever the user taps the WebAPK's app icon the WebAPK is relaunched
  and the ChromeActivity which is on top of SplashActivity is killed

BUG=907951
TEST=LaunchTest.*

Change-Id: Ibc06b1b3fc2aea49ad26bf1043aebec595fb68cf
Reviewed-on: https://chromium-review.googlesource.com/c/1340516
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612795}

Add labels for artist and title that are shown if
we have the metadata from the session.

BUG=893296

Change-Id: I9bab7dd6c31c711c3552dbac975477808ec9311a
Reviewed-on: https://chromium-review.googlesource.com/c/1321258
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612794}

The value of the autofill::prefs::kAutofillProfileValidity pref
name does not match the actual value being used to populate the
priority pref from the server.

Thie CL changes this constant from autofill.profile_validity to
autofill_profile_validity to match what's actually being synced.

Change-Id: I151874de8dde861dff280e1fc0e53e2ee1b60d84
Bug: 910596
Reviewed-on: https://chromium-review.googlesource.com/c/1356863
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612793}

The test legitimately fails when "prerender" value gets removed from
visibilityState as it is done in http://crrev.com/c/1356120

Unblock this change by removing the test. Traditional prerenders should
no longer happen, while nostate-prefetch should not ever look at
visibility state.

TBR=mattcary@chromium.org

Bug: 908582, 755921
Change-Id: I44da809f924b2730ac2b00fd85a1d1e484a3aacb
Reviewed-on: https://chromium-review.googlesource.com/c/1356939Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612792}

Except for sample_apk, which looks like it's a valid app on its own.

Motivation:
 * Trying to add a new JNI generator, and these targets were being
 difficult due to the tests having (unused) native methods that the
 under_test apk did not have.
 * The under_test apks didn't really make sense on their own anyways, so
 it's more efficent to just combine them.

Bug: 898261
Change-Id: I23571ea61230daefccb8e0e14689d3f872080136
Reviewed-on: https://chromium-review.googlesource.com/c/1352853Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612791}

This reverts commit b6e2cb9b.

Reason for revert: Causing WebKitLayout tests failure on linux:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76109
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76108

Original change's description:
> [EventTiming] Always buffer firstInput
> 
> Before, we'd buffer the firstInput entry only if it happened before
> onload. This CL forces firstInput to always be buffered. This means
> EventTiming code is called more in some tests, so the event hardware
> timestamp is no longer guaranteed to be nonzero, and a couple of xr
> tests require double RAF to avoid competing with the swap promises from
> Event Timing.
> 
> Bug: 841224, 843184
> 
> Change-Id: I942b934c387798c100da4ecfff52affb66ab94e8
> Reviewed-on: https://chromium-review.googlesource.com/c/1355880
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612703}

TBR=tdresser@chromium.org,npm@chromium.org

Change-Id: I4b2456f4b9f44798b3157bea960d84f72a50a8bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 841224, 843184
Reviewed-on: https://chromium-review.googlesource.com/c/1357404Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612790}

With Windows Japanese and Korean layouts, the OS returns
duplicate values so it appears that multiple keys return
the '\' char.

It should return the currency symbol (yen or won) instead
of the '\', but J and K codepage history means that
Windows will conveniently (or not) map these characters
to the backslash.

See:
https://web.archive.org/web/20131023080358/http://blogs.msdn.com:80/b/michkap/archive/2005/09/17/469941.aspx
for some history/background.

Bug: 910649
Change-Id: If27e4e46959fccd3da292365c521d7f3c4bb2a9b
Reviewed-on: https://chromium-review.googlesource.com/c/1356875Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612789}

Change-Id: Ic0f5e9a51da75f0e5f6e197a475b2920522c6336
Reviewed-on: https://chromium-review.googlesource.com/c/1357425Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612788}

This change fixes a UI bug where a hidden password was not correctly
updated when both the <password-list-item> and <password-edit-dialog>
were setting the same password at the same time.

Bug: 910081
Change-Id: If1ac5298ceebe1f12003083d87a85d1fa66a1f71
Reviewed-on: https://chromium-review.googlesource.com/c/1354275Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612787}

Previously when painting outlines we used LayoutObject::AddOutlineRects()
which adds outline rects in flipped blocks direction. The previous
flipping code in ObjectPainter::PaintOutline() was incomplete, and we
also missed the flipping in other places.

Add LayoutObject::PhysicalOutlineRects() which flips the outline rects
correctly.

Remove internals.outlineRects and internals.focusRingRects and convert
the layout tests using them into unit tests.

Bug: 910643

Change-Id: Ib8b3e0c7cd646e60378c09955ba26334f0f7f9e9
Reviewed-on: https://chromium-review.googlesource.com/c/1352503Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612786}

This converts Android WebView code to use the base-layer definition of
whether to enable developer-only features (in this case, the command
line). This also comments the BuildInfo method to mention Android's
definition of debuggability (IS_DEBUGGABLE), which could improve
discoverability.

Although this is a change in logic, this should not impact real
behavior, since "not equal to 'user'" should in practice be the same as
"equal to 'userdebug' or 'eng'," since these are the only three valid
values.

R=agrieve@google.com, tobiasjs@google.com

Bug: 908668
Test: N/A
Change-Id: I6007d564078a899567226a3777c02bfcffc16f75
Reviewed-on: https://chromium-review.googlesource.com/c/1351733
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612785}

This reverts commit b5edc37e.

Reason for revert: suspected to cause flaky failures in
SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames
While https://chromium-review.googlesource.com/1053907 enabled
the VizHitTestDrawQuad feature in fieldtrial_testing_config.json,
it doesn't seem to be applied to content_browsertests,
so this CL actually enabled that feature in this test and
possibly caused the flakiness. See crbug/910586.

Original change's description:
> Enable VizHitTestDrawQuad feature by default on TOT for cros.
>
> The OOPIF bug on cros was fixed
> https://bugs.chromium.org/p/chromium/issues/detail?id=877762,
> re-enabling VizHitTestDrawQuad by default for cros platforms.
>
> Bug: 804888
> Change-Id: I93cd237bc0631b6e1f77ae59232937697ce45ef2
> Reviewed-on: https://chromium-review.googlesource.com/c/1337644
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Ria Jiang <riajiang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608637}

TBR=sadrul@chromium.org,riajiang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 804888, 910586
Change-Id: Ic42c16a2b0547878e1e794069f2057f18a74b337
Reviewed-on: https://chromium-review.googlesource.com/c/1356887
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612784}

The tests sometimes use the personal data manager factory,
as in ChromeBrowsingDataRemoverDelegateUnittest.
The factory should distinguish between the two.

For the tests we should use the fake test source of autofill
profile validation, and not the real one.

Change-Id: I694bf487fc42176cfa874567908774f0f971094a
Reviewed-on: https://chromium-review.googlesource.com/c/1351771Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#612783}

To test it locally make sure that threaded scrolling is disabled and
use --enable-blink-features=OverscrollCustomization.
For further details please check the design doc:
https://docs.google.com/document/d/1CJgCg7Y31v5MbO14RDHyBAa5Sf0ZnPVtZMiOFCNbgWc/edit?usp=sharing

Bug: 907601
Change-Id: If3269ee73ac6c8d986b82ec451d8c50ad5fcc226
Reviewed-on: https://chromium-review.googlesource.com/c/1348850Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612782}

Updates the name to be consistent with the terminology used in the
corresponding protocol buffer and design docs. Also updates the comment.

Bug: 851163
Change-Id: I4f20f1e53d8db50301e0a23a34a03099968692b6
Reviewed-on: https://chromium-review.googlesource.com/c/1357301Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612781}

Upon entering an incremental step without stack such objects can be
flushed to a worklist that is processed in the regular marking loop as
the objects are definitely constructed at this point.

Bug: 843903
Change-Id: Ie4acbb7a58e7bedaee3b7806bdd18ca306ff14d7
Reviewed-on: https://chromium-review.googlesource.com/c/1350751
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612780}

Also moved xml.dict to //third_party/libxml/fuzz/.

Bug: 584819
Change-Id: Ie4bd02f3ae2559ce11676297ee1ed078901aa5e8
Reviewed-on: https://chromium-review.googlesource.com/c/1355853Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612779}

Updates the VR UI model to allow an array of controllers, each of which
will be rendered as part of the UI. This update introduces a concept of
a "primary controller" (largely for porting convenience) that is
currently always the controller at index 0 of the array. We may want to
improve the logic around that in future CLs.

Bug: 873274
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1a91f6550f4d051d35d872118c822f1b6716c614
Reviewed-on: https://chromium-review.googlesource.com/c/1171519
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612778}

Update the relevant failing ClientOnReceivedError2Test tests
(listed below) to not check for empty headers. Request headers
in onReceivedError callback may or may not be empty, this is
an implementation detail. In the network service code path
they may e.g. contain user agent, see https://crbug.com/893573.

Also add a comment in tests explaining this.

Fixed tests:
-ClientOnReceivedError2Test.testIframeSubresource
-ClientOnReceivedError2Test.testImageSubresource
-ClientOnReceivedError2Test.testMainFrame
-ClientOnReceivedError2Test.testUserGesture
-ClientOnReceivedError2Test.testUserGestureForIframeSubresource

BUG=893573,841556

Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ic6322c7d9720b62709c2b506639108ed2a36a188
Reviewed-on: https://chromium-review.googlesource.com/c/1356801Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612777}

This reverts commit 53e8b2a2.

Reason for revert: crbug.com/910704

Original change's description:
> Perfetto: Stop splitting _COMPLETE events
> 
> The current Perfetto backend splits _COMPLETE trace events into
> separate _BEGIN and _END pairs, as it's not very feasible to modify
> existing events after they're written into the Shared Memory Buffers.
> 
> This is causing some issues with the trace-viewer which has some
> assumptions about the ordering of begin/end events vs. async events,
> and is also bloating the sizes of traces and adding extra
> overhead for the perf infra.
> 
> Instead, we now keep the _COMPLETE events in an internal stack in
> TLS and only emit them when we have their duration.
> 
> R=​eseckler@chromium.org,skyostil@chromium.org
> 
> Bug: 909728,888558
> Change-Id: I80e37264de66d8bbcb6c9095d21047957fd6eb9f
> Reviewed-on: https://chromium-review.googlesource.com/c/1354503
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612360}

TBR=oysteine@chromium.org,skyostil@chromium.org,eseckler@chromium.org

Change-Id: I0cda9ab36248042c3889d810bfd07a6d03a6d58e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 909728, 888558
Reviewed-on: https://chromium-review.googlesource.com/c/1357500Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612776}

This CL changes the print preview handler to set kSettingHeaderFooterURL
using url_formatter::FormatUrl rather than extracting the GURL::spec()
directly. In particular, this allows safe IDNs to be displayed as
unicode rather than punycode in the header/footer (matching how they are
displayed in the omnibox).

Bug: 910344
Change-Id: Iabed0e1821df29e5c2a5b6fc9953fa6d8cb3e10d
Reviewed-on: https://chromium-review.googlesource.com/c/1356235Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612775}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/625db3890df8..6af3c5cbe4c7


git log 625db3890df8..6af3c5cbe4c7 --date=short --no-merges --format='%ad %ae %s'
2018-11-30 33432579+alan-baker@users.noreply.github.com Clean uses of EvalInt32IfConst (#2145)
2018-11-30 ale64bit@users.noreply.github.com Validate PushConstants annotation and type (#2140)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@6af3c5cbe4c7

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I44eee178e652ecc7220ab0f3fde123235a214e34
Reviewed-on: https://chromium-review.googlesource.com/c/1357345Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612774}

- Add a kClientWindowHasContent property to pass the info
  from client to Window Service;
- DesktopWindowTreeHostMus sets the property based on layer type
  and opacity of Widget::InitParams;
- Check kClientWindowHasContent property as part of the remote
  window has-content check for occlusion tracking;

Bug: 908629
Change-Id: I23c582d7135d50b70ba0776cb0368da59fe5d8c7
Reviewed-on: https://chromium-review.googlesource.com/c/1354439Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612773}

MASS REFACTOR - please consider fixing rather than reverting.

The jclass parameter is never used in static JNI functions because we generate
bindings ourselves for functions that are called by native.

This CL removes the jclass parameter from all JNI methods by refactoring all current
JNI method declarations that contain a jclass and stops the JNI generator
from generating stubs that pass jclass to our implementation.

This change is also being done to support the conversion of all non-static native
methods to static native methods and then all static natives to the new JNI interface.
When this is done proguard will be able to obfuscate classes that contain native methods.
And native methods that don't rely on native

TBR=agrieve # wide-reaching mechanical refactor

Bug: 898660
Change-Id: Ie2932564d58933a2f4bcd23fe47723e147cf87d8
Reviewed-on: https://chromium-review.googlesource.com/c/1352518
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612772}

This code was not used

Change-Id: I57c742e34811807e091d8a833fa89ac0487e64bf
Reviewed-on: https://chromium-review.googlesource.com/c/1356128Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612771}

In the accessibility tree, each popup menu and its submenus have a
native window. When using popup menus, the AtkWindow for the native
window of the active menu should always have the ATK 'active' property.
We listen to events associated with the lifetime active popup menus and
use them to properly manage the 'active' property on this constellation
of AtkWindows.

Bug: 895921
Bug: 896392
Change-Id: I7a5e148feb8486bab7984f19c7ee2532b1fd16f0
Reviewed-on: https://chromium-review.googlesource.com/c/1335586
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612770}

Bug: 907929
Change-Id: I6cc9d7a908010c204fc8060802c7ee453363ffa3
Reviewed-on: https://chromium-review.googlesource.com/c/1349455
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612769}

Using wpt-import in Chromium 11e0d834.
With Chromium commits locally applied on WPT:
b6e2cb9b "[EventTiming] Always buffer firstInput"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mstensho@chromium.org:
  external/wpt/css/css-break

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I8e830b280b458cdd488856f7289319f5beaaf14e
Reviewed-on: https://chromium-review.googlesource.com/c/1357310
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612768}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/199f50b66cb0..010497f89102


Created with:
  gclient setdep -r src-internal@010497f89102

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I4324a32bb363bbe01b5b9e31874b2a9f12f6050f
Reviewed-on: https://chromium-review.googlesource.com/c/1357347Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612767}

Bug: 725197
Change-Id: I24e0f3ff08ebd26f0621c2e16154f34a3dfd5467
Reviewed-on: https://chromium-review.googlesource.com/c/1355771
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612766}

This CL polishes the comment for transient flag in DownloadUrlParameters.

Change-Id: I06732268dc08889cc195b61d3140560acc9e5242
Reviewed-on: https://chromium-review.googlesource.com/c/1357380Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612765}

https://chromium.googlesource.com/catapult.git/+log/35457f076227..559cacb8fdf1


git log 35457f076227..559cacb8fdf1 --date=short --no-merges --format='%ad %ae %s'
2018-11-30 benjhayden@chromium.org Move Catapult Android Tryserver to LUCI.


Created with:
  gclient setdep -r src/third_party/catapult@559cacb8fdf1

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:825432
TBR=sullivan@chromium.org

Change-Id: I45252f26469927cd0ebc9f70724b1d04ce2a7178
Reviewed-on: https://chromium-review.googlesource.com/c/1357346Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612764}

The name "SlimmingPaintV2" has led to confusion about what exactly is in
"v2". This renames the in-development feature to "CompositeAfterPaint".
Tasks left to do:
1) Remove the --enable-slimming-paint-v2 flag
2) Remove the SlimmingPaintV2 runtime enabled feature
3) Move the virtual tests from virtual/spv2 to virtual/composite-after-paint
4) Move the flag-specific expectations to enable-features=CompositeAfterPaint


This patch has been generated from the following commands:

cd third_party/blink
git grep -l SlimmingPaintV2 | xargs sed -i "" 's/SlimmingPaintV2/CompositeAfterPaint/'
git grep -l "slimming paint v2" | xargs sed -i "" 's/slimming paint v2/composite after paint/'
git grep -l "slimming paint V2" | xargs sed -i "" 's/slimming paint V2/composite after paint/'
git grep -l "Slimming Paint v2" | xargs sed -i "" 's/Slimming Paint v2/Composite After Paint/'
git grep -l "Slimming Paint V2" | xargs sed -i "" 's/Slimming Paint V2/Composite After Paint/'
git grep -l "Slimming paint v2" | xargs sed -i "" 's/Slimming paint v2/Composite after paint/'
git grep -l "Slimming paint V2" | xargs sed -i "" 's/Slimming paint V2/Composite after paint/'
git grep -l "enable-slimming-paint-v2" | xargs sed -i "" 's/enable-slimming-paint-v2/enable-composite-after-paint/'
git grep -l "spv2" | xargs sed -i "" 's/spv2/cap/'
git grep -l "SPv2" | xargs sed -i "" 's/SPv2/CAP/'
git grep -l "SPV2" | xargs sed -i "" 's/SPV2/CAP/'
git grep -l "enable_s_pv2" | xargs sed -i "" 's/enable_s_pv2/enable_cap/'
git grep -l "kSlimmingPaintV2" | xargs sed -i "" 's/kSlimmingPaintV2/kCompositeAfterPaint/'
git mv third_party/blink/renderer/core/paint/stub_chrome_client_for_spv2.h third_party/blink/renderer/core/paint/stub_chrome_client_for_cap.h
git checkout -- perf_tests/bindings/resources/data/blink-dev.json
git checkout -- perf_tests/svg/resources/CrawFishGanson.svg
git checkout -- renderer/build/scripts/blinkbuild/name_style_converter.py
git checkout -- renderer/build/scripts/blinkbuild/name_style_converter_test.py
git checkout -- web_tests/VirtualTestSuites
git checkout -- renderer/platform/exported/web_runtime_features.cc
git checkout -- public/platform/web_runtime_features.h
git checkout -- web_tests/FlagExpectations/enable-blink-features=LayoutNG
git checkout -- web_tests/FlagExpectations/enable-blink-gen-property-trees
git checkout -- web_tests/FlagExpectations/enable-slimming-paint-v2
git checkout -- web_tests/SlowTests
git checkout -- web_tests/TestExpectations
git checkout -- web_tests/animations/resources/composited-animation-test.js
git checkout -- web_tests/virtual/spv2/compositing/README.txt
git checkout -- web_tests/virtual/spv2/fast/block/README.txt
git checkout -- web_tests/virtual/spv2/fast/borders/README.txt
git checkout -- web_tests/virtual/spv2/fast/clip/README.txt
git checkout -- web_tests/virtual/spv2/fast/css/README.txt
git checkout -- web_tests/virtual/spv2/fast/overflow/README.txt
git checkout -- web_tests/virtual/spv2/fast/repaint/README.txt
git checkout -- web_tests/virtual/spv2/paint/README.txt
git checkout -- web_tests/virtual/spv2/paint/subpixel/README.txt
git checkout -- web_tests/virtual/spv2/svg/README.txt
git checkout -- web_tests/virtual/threaded/animations/composited-animation-independent-transform-cancel.html
git checkout -- web_tests/virtual/threaded/animations/compositor-independent-transform-properties.html
git checkout -- renderer/platform/runtime_enabled_features.json5
{
  name: "CompositeAfterPaint",
  implied_by: ["SlimmingPaintV2"],
},
git cl format

I then manually cleaned up some instances of "composite after paint" being
"CompositeAfterPaint" as well as some grammar.

Bug: 909899
Change-Id: Iec0a803b997ada7c58c9c0446bbca23451de08dd
Reviewed-on: https://chromium-review.googlesource.com/c/1355247Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612763}