GitLab

Fix code that was implicitly depending on logging.h or its
dependencies.

For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.

This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.

Bug: 1031540
Change-Id: Ib8732b1732c3a92dc2a81eaf1e58fa063db45f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157007
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760545}

Add SecondaryAccountConsentLogger to log the consent.

Bug: 1043108, 1070656
Change-Id: Ife29a9a5fe16e0133a838324b210fe377f2e57d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115471
Commit-Queue: Anastasiia N <anastasiian@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760544}

There is a bug that the save prompt is not shown if the password value
is set as an empty value by JavaScript before form submitted. The bug is
a regression since crrev.com/c/2029514 (M81 stable), but it is enough
reasonable. So, this patch fixes FormParser instead of reverting the CL.

In the current implementation, FormParser is treated as parsing error if
|value| is empty. On the other hand, according to crrev.com/c/1404093,
if |typed_value| is present, we preferentially use it rather than
|value|. Similarly, this patch makes FormParser use |typed value|
preferentially even if |value| is empty.

Reproducible sites:
  - https://m.naver.com
  - https://zino.dev (This is a minimal test page I wrote)

Bug: 1042196
Change-Id: I6652822fd7fe268b54647434c23c68d41abf5010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154644Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko  <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760543}

Bug: b/146151793
Test: None
Change-Id: I5df1739ce29d9fec4480988ef3a405a93de9d1e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072473Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760542}

Bug: None
Change-Id: I5d03b6ef8853bdb58b09335c591014cb573fdae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153885
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760541}

This CL introduces a BrowserContextHandle interface that provides a
pointer to a native BrowserContext, and can be used to by components to
take a BrowserContext reference within Java code. Clank's Profile class
implements this interface, which allows us to pass a Profile to
components that need a BrowserContext. In the future, WebLayer's Profile
representation will also implement this interface.

This change was motivated by the componentization efforts underway as
part of the WebLayer project, several of which would benefit from a Java
representation of the BrowserContext.

Bug: 1058600
Change-Id: I65778791731c8d1f1529f06eab543774a60155ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130674
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760540}

To include extraCommand and ITrustedWebActivityCallback for location
delegation.

Bug: 1069506
Change-Id: I333a652db193167606360c7d4da7482e904b5f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130771Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760539}

Fix code that was implicitly depending on logging.h or its
dependencies.

For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.

This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.

Bug: 1031540
Change-Id: If0ae65768b8b03077e06c70d37a221b7a4392971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157085
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760538}

The bindings stored on the RenderProcess object are not longer needed
and can safely be removed. Once that is done, the MockRenderProcess
becomes a trivial object providing no extra functionality, so this CL
goes a step further and removes it as well.

Bug: 1069939
Change-Id: I79e047faa0a418b7362a303b5d45210de394b97e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145815
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760537}

If the saving of passwords is generally disabled from settings, or if
the save passwords prompt can't be shown, the toggle should not be
shown either.

Bug: 1044930
Change-Id: I017ed562cfc1dc10eddf31306d0e7730cd5206a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149332
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760536}

Fix code that was implicitly depending on logging.h or its
dependencies.

For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.

This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.

Bug: 1031540
Change-Id: If22a9fad1fb5c1fa306e539ff8aa27c020f3ec5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156415
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760535}

This ports
https://github.com/ChromeDevTools/debugger-protocol-viewer/pull/115 to
Chromium.

Note that the DOM domain depends on Page (as getNodeForLocation has a
reference to Page), but if you would add this to the .pdl there would be
a circular dependency between Page and DOM. Thus, the generated code
does not compile if you add this dependency. This probably requires
follow-up work to either remove the circular dependency or update the
code generator to handle a circular dependency.

Change-Id: I11b444c4af5498c83ca8471e507f93f5dd6485e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148744
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760534}

This method marks the currently submitted credentials to be not movable
to the account store of the user with the passed GaiaIdHash.

Bug: 1032992
Change-Id: Ic292de0adae08e0d5de95c09fca381603329c1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152588
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760533}

Fix code that was implicitly depending on logging.h or its
dependencies.

For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.

This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.

Bug: 1031540
Change-Id: I3e650161f9647c8a3ac1d8ad03059fecc6cc8f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157125
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760532}

Previously, the tests waited for action_timeout(), to wait for LBS to
load the rules and write some files. As expected, this is fairly flaky,
and it slows down the tests.

Now, `BrowserSwitcherService' exposes a new event for testing, which
fires once LBS has loaded the rules. This should reduce flakes by
listening for the event instead of using an unreliable timeout.

Also rewrote some tests in a synchronous style, which improves
readability.

Bug: 1044619, 1070400
Change-Id: If1a2093cfe3bface73a46896ff2bc95b80ab2f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152885
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760531}

Replace WebContentsImpl::GetUkmSourceIdForLastCommittedSource with a
RenderFrameHost-based method.

- RenderFrameHost-based method works correctly for non-current frames,
  unlike WebContentsImpl-based method.
- GetPageUkmSourceId (page load == main-frame committed cross-document
  navigation) should be more intuitive than
  GetUkmSourceIdForLastCommittedSource.

BUG=1061899
R=alexmos@chromium.org,rkaplow@chromium.org
TBR=alexmos@chromium.org
CC=​​​​bmcquade@chromium.org,csharrison@chromium.org

Change-Id: I66d1520fbcb8ea4b59d7d0c3cbcbdbfa16516789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132393Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760530}

The ui::TouchEditable menu recently changed to use its own constants
for command IDs rather than abusing IDS constants; the uses of these
constants in //components/pdf were missed.

Bug: 10707568
Change-Id: I5ccd267b032bc4dfe4841efd6203dc53b6fddb96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154908Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760529}

This is recorded to determine how often the size of a sequence grows
above 10000 tasks, and whether it is reasonable to upload a process
dump when that happens.

Bug: 1071862
Change-Id: Ia0e7ea5a48d5086bfd4c7aa9c121fa3ccb381ad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154845
Auto-Submit: François Doray <fdoray@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760528}

Fix code that was implicitly depending on logging.h or its
dependencies.

For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.

This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.

Bug: 1031540
Change-Id: I34bdf1c886255c953706e98910abdb4204efd2de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157068
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760527}

This change moves LayerTreeView into blink. The compositing tree
is now owned by the WidgetBase which is a member of all widget
implementations. RenderWidget will have a handle to the LayerTreeHost
but ownership of the pointers now resides in blink.


Change-Id: I00a629fef2a7ca6630625ff55ad6ce47b69ce0c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076058Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760526}

Fix code that was implicitly depending on logging.h or its
dependencies.

For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.

This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.

Bug: 1031540
Change-Id: I8278d85744f0cb92c11e1b0b3c00eae6ad62ee87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157066
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760525}

The frame_sequence_tracker.h file has 3 classes in it:
1. FrameSequenceMetrics: this class keeps track of necessary info to
   report throughput metrics.
2. FrameSequenceTracker: this class owns a FrameSequenceMetrics
   object. It tracks various frame productions and record these info
   in the FrameSequenceMetrics object.
3. FrameSequenceTrackerCollection: this class contains a set of
   FrameSequenceTrackers.

Other high level classes like LayerTreeHostImpl just talk to
FrameSequenceTrackerCollection.

This CL breaks the file into 3 classes, to make it more obvious.
Basically, frame_sequence_metrics.h is the lowest level and contains
all fundamental types and operations.

Bug: None
Change-Id: I94ac5902ab9f4b6e5857b8c6878cbed2916fb5b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155213Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760524}

This CL removes logging of grouping metrics that is based on
|icon_url_for_uma|, mostly provided by FaviconCache. This is a
prefactoring CL before removing the FaviconCache completely.

Bug: 978775
Change-Id: If33ab5f6c73acba5acf5239556d66e95b69f47a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156489
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760523}

This change applies the BindOnceRewriter in //chrome/browser/devtools.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=pfeldman@chromium.org

Bug: 714018
Change-Id: I8247fc695ed397a148f7e42f3d2c6529c03673a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132213
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760522}

This reverts commit ae8f4133.

Reason for revert: Crashes

Original change's description:
> [Media History] Retain refs and remove fatal
> 
> Retains refs to the store when using callbacks
> and also change the fatal -> error for sql
> errors since it is making bots crash.
> 
> Change-Id: Ie27d43f2044700e1b299d2a34406b1eb2fc9412b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149405
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#759814}

TBR=beccahughes@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib90f55a1176af4ace35d0e421fc5b0ba667ccadd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157165Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760521}

Read system setting and set preferred_color_scheme. Refactor code a bit
to mirror password_echo_enabled. Same as password_echo_enabled, check
system changes when fragment becomes foreground.

Bug: 1070701
Change-Id: Iafcbf6886f8d2f1be474d87759d546182be1562f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153829Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760520}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4cd3c7a92530..be6eaf0a3d07


Created with:
  gclient setdep -r src-internal@be6eaf0a3d07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com
Change-Id: Iea5caa4d72518b047e60f1e0f411b0998f94b1a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156443Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#760519}

There is an issue in NVIDIA driver, vkCreateSwapChianKHR() will fail
with sandbox on Windows, if the gpu::SurfaceHandle(HWND) is created by
browser process. Workaround the issue, by creating a child HWND use to
create VulkanSurface.

Bug: 962633,1068742
Change-Id: I471db2e1db673fece37a5746b5e42a8cf9d12965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152707
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760518}

BUG=950273
R=poromov

Change-Id: I9ca6bec9a05b179d8cfe31c5f4a78a76bb20cbdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153764Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760517}

BUG=b:151160990
TEST=chromeos_unittests --gtest_filter="IpPeripheralServiceClientTest.*"

Change-Id: I7ae2cd64a7c0dc4ae927142e015a8930965462d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134805
Commit-Queue: Pablo Ceballos <pceballos@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760516}

BUG=1071247

Change-Id: I145041673b9e9779d2a342178cf26146da12cc41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156108Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760515}

The aim is to remove Criteria as a concept and use Assertions
directly in Runnables.

BUG=1071247

Change-Id: Ia68c918d3a0759333abbaaa1db236f1147b8ed8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156070Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760514}

The policy unittests need to bring up a real ChromeBrowserState because
some prefs are registered in
BookmarkModelFactory::RegisterBrowserStatePrefs().

BUG=None

Change-Id: Ie2dddb0e41d739f240e447caf0dcaa525c22562a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155984
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760513}

https://chromium.googlesource.com/angle/angle.git/+log/6b265ec1dc9d..8c693ae8890f

git log 6b265ec1dc9d..8c693ae8890f --date=short --first-parent --format='%ad %ae %s'
2020-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 454ab259c1b8..8824107d57d3 (1 commits)
2020-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader d25ce8725224..068611f07d28 (8 commits)

Created with:
  gclient setdep -r src/third_party/angle@8c693ae8890f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: tobine@google.com
Change-Id: I5fce99e6cd6fdbee4ab1af1b2ad37bf7b4bc1243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156437Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#760512}

I can find only one reference to it: within //third_party/catapult.
I believe catapult uses vpython, so shouldn't need this.

It was added in 776da3a8, but the code
there doesn't look to exist anymore.

Bug: None
Change-Id: Ie9636ad86474310b6ea4432dcad0e00cb2bcbfb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156746
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760511}

Initialize Vulkan for both Skia Vulkan and for Skia Dawn on Linux.
Vulkan and Dawn both require OOP-R, so replace use_vulkan() with either
use_skia_vulkan() or use_oopr(), depending on context.

Bug: 1021566
Change-Id: I68c4f789252fa700bd78ec01a44e03df6f1fc0b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135006Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760510}

This CL changes WebappInfo#setWebappIntentExtras() to copy the desired
intent extras from the source intent instead of operating on WebappInfo.
This is part 1/3 of removing WebappInfo usage in WebappLauncherActivity.

The CL also merges WebappIntentUtils#copyWebApkShellLaunchTime() and
WebappIntentUtils#copyNewStyleWebApkSplashShownTime() into
WebappIntentUtils#copyWebApkLaunchIntentExtras().

BUG=1069311
TEST=WebappIntentUtilsTest

Change-Id: I8cd014aab4ea7f39dfceca479901cb5a95231c8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146788Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760509}

https://skia.googlesource.com/skia.git/+log/5d440647d3a2..449b1157a738

git log 5d440647d3a2..449b1157a738 --date=short --first-parent --format='%ad %ae %s'
2020-04-20 brianosman@google.com Plumb SkMatrixProvider throughout Ganesh

Created with:
  gclient setdep -r src/third_party/skia@449b1157a738

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jcgregorio@google.com
Change-Id: Ida36a5d259fd00ebfee9e8bfc2ca2a55670a079c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156444Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#760508}

This merges kDevTools and kEnabled Blink GC trace categories so that
all Blink GC events that are enabled by default are also emitted to
"devtools.timeline" category. This allows offline/postmortem
investigation of GC performance issues based on JSON trace.

There is not need to change DevTools frontend because it whitelists
trace events by name.

Bug: 1072352
Change-Id: Ie827727b6fe62335c849c107438b45eb41edaa88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156496
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760507}

Currently on Windows when the browser UI thread finds out the HWND is
about to resized it blocks until any pipelined swap buffer calls have
been issued. This is because if swap buffer is called when the
framebuffer and window size don't match D3D will scale the texture to
fit which stretches everything.

For software compositing this doesn't appear to be an issue because D3D
isn't involved. The direct composition path also doesn't appear to need
this, since it creates a child HWND in the GPU process and draws to
that. The child HWND isn't being resized by the browser so there is no
stretching. This CL changes the UI thread so it only blocks for ANGLE
D3D without direct composition path.

Bug: 859168
Change-Id: Ie8ca1a661cdc06537e85b5be292c148ebc0503e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152998
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760506}