- 03 Aug, 2020 40 commits
-
-
Chris Sharp authored
Bug: 1018157 Change-Id: I0aa69eb02c01d1e06c0c6c8353d5a2f4bf8752ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295704 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794269}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596434376-45a7a59068fd7ea7cf40a05d52ae81f0a49abd4e.profdata to chrome-mac-master-1596475240-d93356acbdf692b1bcca469d15900f1aa84583f0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I4f551982a8d21b90daa18cee02e7142a07f0d45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335601 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794268}
-
Avi Drissman authored
In the past, this wasn't done for Canary because the idea was for it to be as identical to the normal Chrome Stable as possible. Now that we're making Chromes to run side-by-side to Chrome Stable, they need their own identity lest visual issues like the one in the linked bug appear. This relands commits 21e6c4e1 and 34b007d8. They were reverted because they broke crash uploading; the change in this CL of crashpad_mac.mm addresses that. Bug: 1109411 Change-Id: Ib85d773a8ade79422826fe99d88254cd40a35b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333074Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794267}
-
Jesse McKenna authored
This change makes the following updates to IdleWakeups' README: * Add compilation instructions * Change example usage for Edge from "MicrosoftEdge" (old Edge) to "msedge" (new Chromium-based Edge) * Rename from ReadMe.txt to README.md to match others in the repo * Fix example usage syntax for Firefox * Update Firefox usage to reflect that Firefox is now multi-process * A few other small grammatical tweaks Change-Id: Ia1918180c914b1af8b99fa93f3e346e67f7ff1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335334 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#794266}
-
Toni Barzic authored
The test has started failing on official builds after CL:2333141. That change prevents home button bounds animations that would not actually change the button's bounds. It looks like removed compositing requests (caused by setting identical button bounds/transform) caused OverviewSessionFlingTest.BasicFling to end before sufficient number of grid fling animation steps get handled. This updates the test to wait for compositing to start during each test iteration (as animation steps depend on compositing). BUG=None Change-Id: I0ed5946be12300e8e450d2796acf7e7318f8c914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333742 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#794265}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/eac38cfbc1de..1ea3a22f521e 2020-08-03 tommek@google.com Adding a validation for destroyed textures in Queue::WriteTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I97c38be922e259658589916a14fb217be455a70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335608Reviewed-by:
-
Alex Chau authored
chrome/services/sharing/* chrome/services/sharing/* - Introduced RequestConnection and DisconnectFromEndpoint for establishing and cancelling a connection with remote endpoints chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of RequestConnection/DisconnectFromEndpoint. NearbyConnectionsManager uses RequestConnection to establish connection, automatically accept the connection and return a NearbyConnection socket-like object that send/receive byte payloads to/from remote endpoints. chrome/browser/nearby_sharing/nearby_connection_impl* - Socket like class that send/receive byte payloads to/from remote endpoints. Its lifecycle is managed by NearbyConnectionsManager Bug: 1076008 Change-Id: Ic7433772c8f072821a3eab3ea48b1c15f236296a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317785Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#794263}
-
Clark DuVall authored
This effectively reverts https://crrev.com/c/2200082, which optimized memory usage by re-creating the WebLayer context without INCLUDE_CODE. This unfortunately leads to a bug where the library path is no longer correct, and WebLayer cannot find the native libs. For more info, see the discussion on https://crrev.com/c/2333305. Bug: 1111508, 1061512 Change-Id: Ia17654bc760ec7f2fc7e3d25e323643de26151fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335500 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794262}
-
Travis Skare authored
Change-Id: I8a68ead67e71e01843dad72681e1e786a313a45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330298 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#794261}
-
Xinghui Lu authored
Screenshot: http://screen/zaaBRbPGsTd Bug: 1097310 Change-Id: I26b76f2071d4e2ee5b4fc5ff04868b24bed88a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316829 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794260}
-
Xing Liu authored
This CL pulls the attributes for Android checkbox to a style in components/browser_ui. Bug: 1110521 Change-Id: I20c4e879498677e700d296feb7a8ba6107a1c127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335404Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794259}
-
Sebastien Lalancette authored
Adding: - Open in New Tab - Open in New Incognito Tab - Open in New Window (if Multi-Window is supported and iPad) This CL also adds two method to allow creating OpenInNewTab and OpenInNewIncognitoTab action via methods taking in a |block| parameter instead of the existing methods taking in URLs. The reason is that some components need to add extra configurations to their UrlLoadParams before loading the URL. Having both types of methods allow simple components to easily get the action, and more complex components to create a specific action based on their needs. Bug: 1093302 Change-Id: I46eab2378b11aace8e66955b332c3fa02e2dca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333366 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#794258}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6f029c304ca..b5aa09d7531b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I38f3ee3bac5c3f4cd245c0cab1b0a1138a08a1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335564Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5dec09c44de..45929d74770b 2020-08-03 janscheffler@chromium.org Migrate `front_end/main` to `devtools_entrypoint` 2020-08-03 t-olfly@microsoft.com Source Order Viewer Experiment Location 2020-08-03 janscheffler@chromium.org Migrate `front_end/protocol_monitor` to `devtools_entrypoint` 2020-08-03 janscheffler@chromium.org Migrate `front_end/input` to `devtools_entrypoint` 2020-08-03 janscheffler@chromium.org Migrate `front_end/web_audio` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4bf6bf34202a56b7c090a5c08598dee954c83de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335597Reviewed-by:
-
Nick Diego Yamane authored
WaylandConnection initialization is considered done once at least one of the wl_outputs advertised gets its "done" event (ie: all its metadata was already received, ie: size, origin, mode, etc), which has been working well so far, at least with the Wayland compositors tested until now. It turns out that such initialization is broken for multi-screen scenarios, where the compositor sends events in the following order: ... wl_registry::global for wl_output object 1 wl_registry::global for wl_output object 2 wl_output::geometry for wl_output 1 wl_output::mode for wl_output 1 <-- output 1 ready wl_output::geometry for wl_output 2 wl_output::mode for wl_output 2 <-- output 2 ready ... This is how Exo compositor sends the events, which leads Ozone/Wayland to crash at startup. To fix it, this patch modifies code that deals with wl_output and WaylandScreen so that it only creates display::Display objects for wl_outputs once they are "ready" (ie: all required metadata already received from the server). In addition, some cleanup and minor fixes are made. R=tonikitoo@igalia.com Bug: 1111905 Test: Covered by unit tests. Change-Id: I25d23c5a76d0b2ab900bab4460344cf908db07e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332844 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#794255}
-
Xiaocheng Hu authored
Bug: 443467 Change-Id: I8e6ddb0381bfe9aee8cbfe63bdf0dc644569b0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330056 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#794254}
-
Tom Anderson authored
R=sky Bug: 955316 Change-Id: I24701fa5e7c51d2469f980acafbe61a1e078818e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335477 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4b9b34558fe5..7b9da25e1b8b 2020-08-03 ethannicholas@google.com Can now swizzle SkSL scalars 2020-08-03 jvanverth@google.com Revise GrMtlGpu::onUpdateBackendTexture. 2020-08-03 herb@google.com add chrome bug triage to the Sheriff's Documentation 2020-08-03 herb@google.com move source padding to the AtlasLocator 2020-08-03 brianosman@google.com Always send premul paint color to shader FPs 2020-08-03 johnstiles@google.com Enable ClangTidy check modernize-make-unique. 2020-08-03 jvanverth@google.com Fix texture errors on iOS Metal 2020-08-03 reed@google.com Add arc methods to path builder 2020-08-03 jvanverth@google.com Remove unused dynamic allocation code from GrMtlResourceProvider. 2020-08-03 cwallez@chromium.org GN: Add support for GN's framework variable in the toolchain 2020-08-03 johnstiles@google.com Increase ClangTidy code coverage by enabling features. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I7e86849b892cceaa00bf1930970d8603c34a41fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335562Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596459406-112652fc3cbb93a8d59d2edad7ed0033698f8002.profdata to chrome-win32-master-1596470392-1db0b1fcfff2e5dea91624929cca8d9002b8d6ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iad21a6bcb5d093bac10eb2b767fbf7185f9e351c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335594Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: I422630785b5b3a441de4a6bd627e7525c6e64bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296061 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/981002aea991..9dedfc814fbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rajendrant@google.com,gayane@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033067,chromium:1108305,chromium:1111514,chromium:1112125 Tbr: rajendrant@google.com,gayane@google.com Change-Id: Ifd83a974f420cadfc1137810517672b58f109e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794249}
-
Clark DuVall authored
This is how WebLayer will be run in the field, and there are some edge cases where it's hard for the client app to call initializeWebViewCompatibilityMode() before WebLayer is used. This also removes some of the version checking logic which was needed when we supported versions < 82. Now 82 is our minimum version, so this should no longer be needed. Bug: 1111511 Change-Id: Iedce8bc31b82d1a38d5910dc1c3d3b6c5edd6258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333056Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794248}
-
David Tseng authored
AX-Relnotes: Volume key adjustments no longer stop read to end/Search+R in ChromeVox. Test: currently manual; automated tests tbd. Fixed: 913264 Change-Id: I61503592b2e2262b5e2036c895341a1301d60739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333051Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794247}
-
Andrei-Laurențiu Olteanu authored
Implement GetAvailableRoutines that exposes the same interface from cros_healthd to chrome-trusted. Add converters for types used by GetAvailableRoutines. Bug: b:162051831 Change-Id: I925dc22824a8adb52cc33b3296d80c21ed7d32ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312417Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#794246}
-
Ulan Degenbaev authored
Bug: 1085129 Change-Id: I5ad0528aac918934395eca23b0bb66157638e9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329592Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794245}
-
Andrew Xu authored
Usually the clipboard history menu is anchored at the caret's location. This CL anchors the history menu at the cursor's location when there is no textfield. In addition, some apps may provide unreliable caret's bounds, such as Google Doc. The menu is also anchored at the cursor's location in that case. Subsequent CLs will solve the unreliable caret bounds thoroughly. A browser test is created to protect this feature. Bug: 1110027 Change-Id: I30f31b0ab89542b5c7f63ebd25257dc765f57929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328191 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794244}
-
Mihai Sardarescu authored
This CL removes the hack to write the CHROME_CONNECTED cookie using a WKWebView and instead uses the cookie manager API. This works well as the Chrome iOS cookie manager is now backed by the WKHTTPCookieStore. Bug: 1102794 Change-Id: Ida2d74372616ce8331eadbde507fb131e4afa0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323901 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#794243}
-
David Grogan authored
Flex gaps had no problems in the M84 rollout. Bug: 762679 Change-Id: Ib776156c3344998cb460feb24e224d0281321966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334471 Commit-Queue: David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#794242}
-
Sujie Zhu authored
We plan to launch to 100% stable so set AutofillEnableSurfacingServerCardNickname enabled by default. Bug: 1059087 Change-Id: Ide8962f9995c4bea2f95a137b4f53578bb2b2561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334102Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#794241}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4b656a010be5..c6f029c304ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic3c5876255acff987fd65c696221f5013300b6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335335Reviewed-by:
-
Matt Jones authored
TabsTests are almost completely deflaked with the exception of text occasionally be incorrectly selected in testTabSwitcherCollapseSelection. This speculative fix will hopefully deflake by scrolling the correct direction in the test and above what should be empty space on the web page and adding arbitrarily long content area to scroll on. Flakes can be found here: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testTabSwitcherCollapseSelection Bug: 799728 Change-Id: I47eb6e9e5439fe545d71889a75886fdee2edf618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334821Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b5aa09d7531b..9a482652ab18 2020-08-03 treehugger-gerrit@google.com Merge "trace-processor: Add extensions once" 2020-08-03 treehugger-gerrit@google.com Merge "Update language to comply with Android's inclusive language guidance" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8878097ee47c6a2a8d4b8b9d5a165510b2ed0fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335551Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d6c02e4a..e2a0b5a6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If61a8d4c2cc3d4216861992608dd84a22a1d6a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334577Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794237}
-
Rohit Rao authored
Multiple test files were defined classes named TestWebState in the global namespace, which is an ODR violations and was causing crashes in ios_chrome_unittests. Since these are all test-specific helpers, this CL moves them into anonymous namespaces. BUG=None Change-Id: If9ca07916e8d0a5063bb45abe3f971f58c224150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335336Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794236}
-
Carlos IL authored
Adds a rectangle that gradients from omnibox background color to transparent on the left side of the omnibox, and an inverted one to the right. The rectangles are used as gradient masks when an elide animation is running, to smooth out the color transition at the end. The mask is fixed size, except if they would obscure the not-elided part of the URL, in which case they shrink. Screencast of change (public link): https://docs.google.com/presentation/d/1AGXJNkt8_oQyPLSDOfAGduscL0LRCCUcZq5XtJo2eC0/edit?usp=sharing Bug: 1106467 Change-Id: Ic5029bbc850285ebe4e5e76a5a3d810c965f7e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321883 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#794235}
-
Michael Giuffrida authored
With legacy supervised profiles no longer available, these classes can be removed. Bug: None Change-Id: I90a014ca6c862b8ac3040032e0355bf3e635b756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318560 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794234}
-
Guillaume Jenkins authored
Adds support for the CloudPolicyOverridesPlatformPolicy policy, which controls whether policies fetched from CBCM should take precedence over policies found on the device. This policy is a requirement for launching CBCM. For now, it is declared as a Future policy for iOS until iOS CBCM is launched. Bug: 1066495 Change-Id: I5b2ce20e2f2b435992f84747a47a3c2ea0f14273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332322Reviewed-by:
-
Yue Zhang authored
* Adjust height of the title from 58px to 64px. * Add a 16px top margin to the title. Bug: 1077458 Change-Id: I1c82831e873432f206379bebef11cf604ce3eaac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335497Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#794232}
-
Liquan (Max) Gu authored
Change: * Separate ProvidePaymentInformation into two parts - the business logic goes into recordShowEventAndTransactionAmount and remains in PRImpl, the UI logic remains in providePaymentInformation (renamed into providePaymentInformationToPaymentRequestUI for clarity) and gets moved into PaymentUIsManager. * For the sake of decoupling UI and the business logic in enableUserInterfaceAfterPaymentRequestUpdateEvent(), the inline business logic is moved out of the method. Bug: 1102522 Change-Id: Ifb639c31bf0f3abcd56e415c8cce1d933a4fdd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324571 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794231}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/01a0945e034b..6c7b829e5473 2020-08-03 tikuta@chromium.org remove reference to jumbo build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:994387 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I5a4d9609f39735708c21314447cba7237b87f1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335550Reviewed-by:
-
