- 23 Jul, 2019 40 commits
-
-
Daniel Rubery authored
To distinguish multiple, parallel requests from the same user, we need a token that is per-request. This is added to the DeepScanningClientResponse, and returned when the user first uploads a file. It will then be passed within each FCM message to identify which request the message corresponds to. Bug: 980784 Change-Id: Ic8176ea21b891187a6a346d0c58dfe9d466bb7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715540 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680207}
-
Gil Dekel authored
This CL modifies ImageDecodeAcceleratorProxy::IsImageSupported() to allow simple WebPs decoding. For now, it just verifies that WebP image's dimensions are within the supported decoding size. Bug: 877694 Test: TBD Change-Id: Idcb72d913a369815219401621cc7e45c09f6c430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707172 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#680206}
-
Justin Cohen authored
Bug: 982896 Change-Id: I7a945e29ac499c7f494c36d29c05d215331e6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715635 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#680205}
-
Jack Lynch authored
This change adds an axe tests for the DOM breakpoints pane in the Sources panel. Bug: 963183 Change-Id: Iceee51c818d768f26d5d1f6fd6856036f7f92b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650462 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#680204}
-
Andrew Comminos authored
Now that v8::CpuProfilerOptions supports a parametric sample interval, pass this in. Report the multiple-clamped sample interval in the returned blink::Profiler object. Bug: 956688 Change-Id: I7d567f2a1d6b0d93d521850a347e9e3c69a7adce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699016Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#680203}
-
Alexander Alekseev authored
Bug: 975854 Change-Id: Id60fa45ad48871dcdbe4d00dcd95e356bc08545e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713984Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#680202}
-
Alexander Alekseev authored
Bug: 975426 Change-Id: Ie08f859ae9e40676b57540cf67d8ebe12236a737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713603Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#680201}
-
Tsuyoshi Horo authored
https://crrev.com/c/1712507 made this test flaky. Bug: 986337, 983023 Change-Id: I62eb6cb417bf5acce91f88b3b9e85d4c667906b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714294Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680200}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/0b5bfaebe8ba..89b9af539b58 $ git log 0b5bfaebe..89b9af539 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 fayang gfe-relnote: Move Http2PriorityWriteScheduler from gfe/gfe2/spdy/ to third_party/spdy/core/ to allow QUIC to use it. No functional change expected, not flag protected. 2019-07-23 wub No-op 2019-07-23 nharper Fix return type of QuicSpdyClientBase::latest_response_code 2019-07-23 bnc Change QuicSpdyStreamBodyBuffer API to decouple from QuicStreamSequencer. 2019-07-23 fayang gfe-relnote: Add IsStreamReady() interface to WriteScheduler and implement the interface in subclasses. No functional expected. Not protected. 2019-07-22 bnc Call MarkConsumed() only once in QuicSpdyStreamBodyBuffer::MarkBodyConsumed() with a combined byte count. 2019-07-22 renjietang Add debugging logs for Priority frames. 2019-07-23 quiche-dev Initial export of QUIC BBRv2. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: I8b97fc5cc2c17da86c7ef1f397198ca2116614ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715885 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#680199}
-
dpapad authored
Bug: 965770 Change-Id: Iad5894729b88c65f93258dd2bb5b91f9d1328f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715402 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#680198}
-
Xiyuan Xia authored
SessionManager is released in PostMainMessageLoopRun that happens before PostDestroyThreads. ml::UserActivityManager is released with DbusServices PostDestroyThreads. Hence it crashes on shutdown when trying to un-observe SessionManager. This CL adds a OnSessionManagerDestroyed to SessionManagerObserver interface so that ml::UserActivityManager could clean up in time. Bug: 987010 Change-Id: I05043a3e0b946bfb9e733ad476dacc35e9a9a3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715401Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680197}
-
Gil Dekel authored
This CL fixes all #include <va/va.h> orderings across the media/gpu folder to satisfy the style guide [1] and Tricium. [1] https://git.io/fjDCc Bug: None Test: jpeg_decode_accelerator_unittest && chrome compiles Change-Id: I3ccdf63db155b61ec5c7091c78e75ea91b3ae897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715409 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#680196}
-
Ian Kilpatrick authored
As above, this changes the Node* parameter to be const. There should be no behaviour change. Change-Id: I2df4a08c98cb7df7a9959a422c5e4b968df2d497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714808Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#680195}
-
Sergey Ulanov authored
Now base::fuchsia::ServiceDirectory is a wrapper around OutgoingDirectory. Most code outside of //base/fuchsia still uses base::fuchsia::ServiceDirectory and should continue function the same way as it did before. Bug: 920920 Change-Id: I3e37aa91d89aa6cf0a650754e12222036c23bddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659603 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#680194}
-
Ben Pastene authored
R=jbudorick Bug: 986904 Change-Id: I97def4f72d4df881492d11111aa80d6f215d8267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715548 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#680193}
-
Eugene But authored
This CL is a part of ios/web restructuring proposed here: https://docs.google.com/document/d/1C2YIU0rDbH5wz2VI6nk0COrktwY3DbF-e7QbMIAKEJc/edit Bug: 942244 Change-Id: Ifd5cee307d197f877864e1700de8be0704f48707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709842 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#680192}
-
Mugdha Lakhani authored
Revive suspended periodic Background Sync registrations. Bug: 925297 Change-Id: Ib2d692858c37ce2619efa40cf6b074488227fcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710647 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#680191}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4d5a1973..40355312 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I456e98dcf9165cb4874cd2d8af8c73a4fd00a676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715887Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680190}
-
Yi Gu authored
WorkletAnimation supports negative playback rate (crrev.com/c/1423537) now. However, the playback rate is not used when calculating the current time. TBR=smcgruer@chromium.org Bug: 986925 Change-Id: I3a9a924ce15f05aa30588004d815fdfa9d60ded1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714153 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#680189}
-
Jeremy Chinsen authored
Currently PDFiumEngine::EnlargePage() and PDFiumEngine::InsetPage() have common logic for retrieving the inset sizes given the current layout and position of the page in the document. This CL adds PDFiumEngine::GetInsetSizes() which extracts the logic for retrieving insets sizes and puts it into a helper function. This helps manage the complexity of PDFiumEngine. Change-Id: I2aabba1f08770dbc16e033c64607627675ff0b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715904 Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#680188}
-
Chris Morin authored
Add the ArcBootCompletedBroadcast feature flag to those exposed to chromeos. This is needed by arcvm-launch to determine what commandline parameters should be passed to the Android kernel. BUG=b:136128691 TEST=dbus-send Change-Id: I748b33ace2bab84c79075c9ee920e35bd7b56ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715398Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Chris Morin <cmtm@chromium.org> Cr-Commit-Position: refs/heads/master@{#680187}
-
Ryan Sturm authored
This adds an arm to separate async vs sync script, so we can see if there is a big effect when NoState prefetching async script. Bug: 93446 Change-Id: Ic04a30b2af3ee0517dca88d5cbb754d619003f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707054Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#680186}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7480fc89c7ee..6d863b5a5ead Created with: gclient setdep -r src-internal@6d863b5a5ead The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: Iaf618e9956e40f6b8271245f60c4593d060a3c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715396Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680185}
-
Joey Arhar authored
Bug: 849483, 868407 Change-Id: I6ab375a857d248b68122222367ce908cb349b42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659528 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#680184}
-
Brian Sheedy authored
The fix from https://crrev.com/c/1713749 appears to fix the issue of not getting minidumps to symbolize on all platforms, so re-enable the minidump tests on all supported platforms. Bug: 634156 Change-Id: Iabc150bb525c294d875105ef4dd48b57c14249f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715395Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#680183}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15baa953a54e..829144cc76fe git log 15baa953a54e..829144cc76fe --date=short --no-merges --format='%ad %ae %s' 2019-07-23 brianosman@google.com Better bot coverage for (Vk, Mtl) x MSAA Created with: gclient setdep -r src/third_party/skia@829144cc76fe The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: Ie187030baf35036f6734d7ee33183005db6f61e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680182}
-
Daniel Rubery authored
This histogram has expired. It's also been historically stable and not useful, so we can obsolete it. Bug: 975709 Change-Id: I787b6851fc99d8826249c82ca62fa28e8d2837bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715236Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#680181}
-
Alex Cooper authored
Updates webxr_test_asserts with chromium's more verbose asserts for easier debugging of tests, and removes the asserts from xr-test-utils so that all asserts can be referenced from webxr_test_asserts. Bug: 985156 Change-Id: Ie8d2ca70dd18a7e1759fe2b4d83b02076fcf91c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715916 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#680180}
-
James Forshaw authored
This CL changes the dynamic resolving of the attribute functions to static linking as the APIs are available on all supported platforms. At the same time the opportunity to cleanup the code to more modern standards has been taken. Bug: 986625 Change-Id: Iafeed84a46fda8c0a21ad32e19af29c7a2c9a52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714216 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#680179}
-
Yi Gu authored
This patch removes one unused override function and makes some variables private. Bug: None Change-Id: Iffe10827abd4ef5fcbccc70393fa6d4167f223df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711975Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680178}
-
Kyle Horimoto authored
The string in question is "Enter", which appears on the confirmation button. In this context, "Enter" is used as a verb. However, the description for this string was unclear and was confused with "Enter", the name of the key on a keyboard. A translator was confused by the ambiguous description and chose to use "Enter" exactly as it appeared. This CL updates the description for clarity. Bug: 983097 Change-Id: I13fe1a2e97f0b71bf4c6195c40c4728bc2237916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714185 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680177}
-
Sergey Ulanov authored
Previously base::SysInfo was using uname(), but uname() depends on fuchsia.device.NameProvider API which may not be accessible in all processes. This change updates SysInfo to use zx_system_get_version() to get OS version. Bug: 986952 Change-Id: Ie3324180040933a509124147efd743de1f112416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715631 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#680176}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb19-30.html BUG=412078 NOTRY=true TBR=jschuh@chromium.org Change-Id: I428f516dde42a88ebc900c71eb7899b76da36950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715539 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680175}
-
Maksym Onufriienko authored
Fixed ios13-beta build by adding shards:1 because test_runner does not support multi-sharding command https://chromium-swarm.appspot.com/task?id=46388c76bc6f6410 Change-Id: I426b3ecc8790508656b31ac9f6fbf7d54245ff92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715565Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#680174}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ec869c11c79d..1a62d1623e3b git log ec869c11c79d..1a62d1623e3b --date=short --no-merges --format='%ad %ae %s' 2019-07-23 vapier@chromium.org use six to control metaclass settings Created with: gclient setdep -r src/third_party/chromite@1a62d1623e3b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id539584827a3b7490ba109b3ba4536e95e354e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715438Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680173}
-
Istiaque Ahmed authored
Bug: 985936 Change-Id: I1c907018d39be097129e863ec464e35acf8bdb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715525 Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#680172}
-
Glenn Hartmann authored
My original CL https://chromium-review.googlesource.com/c/chromium/src/+/1708416 left out some <statistics> tags inside the <history> tags. I think I got them all. Bug: 982362 Change-Id: Ia5c178c5ab2ab07f4ef6ab4012bf72c90616ecf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714369Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680171}
-
Josh Nohle authored
Adds fake implementations of CryptAuthFeatureStatusGetter and CryptAuthFeatureStatusGetterImpl::Factory for use in unit tests. Bug: 951969 Change-Id: I4f467effb33f426697225f7e9d53e574933b8fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711210 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680170}
-
Christopher Grant authored
With native feature modules, generation of the main library (and feature libraries) is a two-step process: 1. Link a single, combined library (with partitions inside it) 2. Use llvm-objcopy to split out the main lib and feature libs This implies that: - libchrome.so's ninja inputs are not .o and .a files - The .map file now relates to the combined library, not the partitions, although it can naturally be used to analyze the partitions. Bug: 982334 Change-Id: I345f618f30639e7637ee905776a50c9cf5686773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708204 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#680169}
-
Ken Rockot authored
This refactors the Video Capture service and its clients to use the simpler service model described in https://docs.google.com/document/d/1M0-K0gi1xXO0f_-YKSH2LFVh4RJY-xe9T9VaGFOSXb0/edit. The DeviceFactoryProvider interface is renamed to VideoCaptureService and previous binders for other top-level interfaces (TestingControls and cros.mojom.CrosImageCapture) have been added to the interface. Service lifetime is no longer managed by manual ref-count but is instead automated using new Mojo interface idling bevhaior. The behavior should effectively mirror the service's behavior before this change. Namely: - The service stays alive as long as any receivers are bound other than the main interface pipe (previously DeviceFactoryProvider, now VideoCaptureService). Once this condition is no longer met, the service is considered idle. - On non-Android platforms, when out-of-process Video Capture is enabled, the service process is killed after 5 seconds of continuous idling. - On Android, the service process does not tear itself down ever. - If out-of-process Video Capture is not enabled, all clients will use the same shared in-browser instance of the service, which lives forever. This also ends up deleting a bunch of tests for the service which effectively tested behavior that's no longer applicable, like lifetime behavior built around VideoCaptureService (nee DeviceFactoryProvider) connection. Bug: 977637 Change-Id: I96ccf3558be7d173041de0de70251d841dd519f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710051Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#680168}
-