- 18 Oct, 2019 40 commits
-
-
Jan Wilken Dörrie authored
This is a reland of 9293d5c8 Original change's description: > GCC: Fix base::internal::InvokeFuncImpl > > GCC doesn't like that the Value data member has no out-of-line > definition. The problem is triggered specifically only when compiling > > components/services/leveldb/leveldb_database_impl.cc > > which has lambda functions returning locally-defined classes. > > The current code works as-is in C++17 mode which introduces the concept > of inline variables, but in C++14 we need either an explicit out-of-line > definition or a function member instead of a data member. > > Use std::integral_constant for defining the value. > > Bug: 819294 > Change-Id: I5c68e14ce3fa9d8b4d8a2cb42d7f9b53938aabf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862451 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jüri Valdmann <juri.valdmann@qt.io> > Cr-Commit-Position: refs/heads/master@{#706384} Bug: 819294 Change-Id: I3d5a52ddc6815516e2239f9347c60de06bf765a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865212Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#707329}
-
Chris Dziemborowicz authored
GlibcGetSizeEstimate calls a function pointer whose value is obtained dynamically with a call to dlsym. When compiled with Clang's Control Flow Integrity (CFI) checks (in particular -fsanitize=cfi-icall), the compiler cannot reason about the contents of the function pointer, so it elects to emit a ud2 "Undefined Instruction" opcode to kill the process instead of calling the function: 00000000055eaa50 <_ZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_$bd8608a96952500691d600ccbd08bddd.cfi>: 55eaa50: 55 push %rbp 55eaa51: 48 89 e5 mov %rsp,%rbp 55eaa54: 8a 05 9e e9 dd 05 mov 0x5dde99e(%rip),%al # b3c93f8 <_ZGVZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_E6fn_ptr> 55eaa5a: 84 c0 test %al,%al 55eaa5c: 75 36 jne 55eaa94 <_ZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_$bd8608a96952500691d600ccbd08bddd.cfi+0x44> 55eaa5e: 48 8d 3d 93 e9 dd 05 lea 0x5dde993(%rip),%rdi # b3c93f8 <_ZGVZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_E6fn_ptr> 55eaa65: e8 56 39 d6 ff callq 534e3c0 <__cxa_guard_acquire> 55eaa6a: 85 c0 test %eax,%eax 55eaa6c: 74 26 je 55eaa94 <_ZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_$bd8608a96952500691d600ccbd08bddd.cfi+0x44> 55eaa6e: 48 8d 35 79 e9 95 fb lea -0x46a1687(%rip),%rsi # f493ee <_ZN5blinkL36kDefaultNativeMemorySamplingIntervalE+0x1d8c8e> 55eaa75: 48 c7 c7 ff ff ff ff mov $0xffffffffffffffff,%rdi 55eaa7c: e8 8f 9d 76 05 callq ad54810 <dlsym@plt> 55eaa81: 48 89 05 68 e9 dd 05 mov %rax,0x5dde968(%rip) # b3c93f0 <_ZZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_E6fn_ptr> 55eaa88: 48 8d 3d 69 e9 dd 05 lea 0x5dde969(%rip),%rdi # b3c93f8 <_ZGVZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_E6fn_ptr> 55eaa8f: e8 dc 39 d6 ff callq 534e470 <__cxa_guard_release> 55eaa94: 0f 0b ud2 55eaa96: cc int3 55eaa97: cc int3 55eaa98: cc int3 55eaa99: cc int3 55eaa9a: cc int3 55eaa9b: cc int3 55eaa9c: cc int3 55eaa9d: cc int3 55eaa9e: cc int3 55eaa9f: cc int3 This change uses the base::UnsanitizedCfiCall utility to bypass the cfi-icall check for this function call. This is necessary in cases where a dynamically loaded function needs to be called. This change also stores the function pointer in read-only memory using base::ProtectedMemory, which is the recommended pattern to prevent the pointer from being modified to hijack control flow. See, for example, the implementation of GetMonitors [1] and https://crbug.com/771365. [1] https://cs.chromium.org/chromium/src/ui/base/x/x11_display_util.cc?l=23-58&rcl=5cdcaedb360ea99534aed54eddd552275705f1b9 Note: The issue is reproducible in Chromium Linux x64 builds built with is_cfi=true (the default) and use_allocator=none (not the default). By default, Chromium Linux x64 builds use_allocator=tcmalloc instead. The issue was originally encountered in a build of Chromium Embedded Framework, which builds with is_cfi=true and use_allocator=none for Linux x64 builds. Change-Id: I286db32657b76d8dddd9b99902144cab584e3547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868513 Auto-Submit: Chris Dziemborowicz <chrisdz@google.com> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Chris Dziemborowicz <chrisdz@google.com> Cr-Commit-Position: refs/heads/master@{#707328}
-
Matt Menke authored
Also add a value to enable it for a particular NetworkSession, though currently nothing enables it. Followup CLs will add field trials and enterprise policies to do so, and also hook up Network Service APIs to correctly add entries to the cache for a particular NetworkIsolationKey. Bug: 993801 Change-Id: I37887a018d9462ecabb80b924b4c44d3ddbee270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863469Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707327}
-
Peter Kasting authored
Bug: 82078 Change-Id: If21fe11af38287e0e61e19edb595411d96805e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867811 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707326}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/95524e4897be..5c7866ef4586 git log 95524e4897be..5c7866ef4586 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 eseckler@google.com processor: Extract ftrace tokenization into FtraceModule/Tokenizer 2019-10-17 treehugger-gerrit@google.com Merge "trace_processor: add set bits iterator" Created with: gclient setdep -r src/third_party/perfetto@5c7866ef4586 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141459049 Change-Id: I9097fc18183708cf28c158f5950f8609a9338744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868504Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707325}
-
Wanming Lin authored
This CL enables SuspendNFCOperations/ResumeNFCOperations in mock NFC backend and handles NFC push operations and reading operations in suspended state. Bug: 996250, 520391 Change-Id: Id32f8b720cab8a2e80f20772a9c7d02578671206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864391 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#707324}
-
Noel Gordon authored
All directory items now derive from TreeItem: this constant is unused, and can be removed. Also use this.rowElement for the labelElement in class TreeItem, so it works in the FILE_NG_ENABLED case as well. Bug: 992819 Change-Id: I1997e7884adf3a956294acdcf043dec487160e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868355 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707323}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e99b9182214f..3cdd6444cf91 git log e99b9182214f..3cdd6444cf91 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 rharrison@google.com Check text->str before destroying (#2981) 2019-10-17 kubak@google.com Disallow use of OpCompositeExtract/OpCompositeInsert with no indices (#2980) 2019-10-17 rharrison@google.com Add fuzzer for spirv-dis call path (#2977) 2019-10-17 rharrison@google.com Check binary->code existence before destroying (#2979) 2019-10-17 akb825@gmail.com Improved CMake install step. (#2963) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3cdd6444cf91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Bug: None Change-Id: I94bcdd8a19fd9d1cf4e4f2b6a087adc88d272abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869009Reviewed-by:
-
sandromaggi authored
Add a test for selecting an option. Add a test for getting outer HTML. Bug: b/141853667 Change-Id: If420e913d4be4e3eb43614aa9faddcb7524399e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863019 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707321}
-
Antonio Gomes authored
BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I9ec5df81e870536e4b9a97d9e4f21678c14da57b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867151Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#707320}
-
Alan Cutter authored
This CL moves the "last update check time" from RAM to disk via the HostContentSettingsMap which is backed by the PrefService. This persists the timestamp between browser restarts and also allows the user to clear the timestamp when clearing browsing history for the origin. Update throttling is tested by: ManifestUpdateManagerBrowserTest.CheckIsThrottled Bug: 926083 Change-Id: I4f4ebb3c54de302610c40f65a7dfbf9622754dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828785 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#707319}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c336dd1cb69c..119e2197b75e git log c336dd1cb69c..119e2197b75e --date=short --no-merges --format='%ad %ae %s' 2019-10-18 peah@webrtc.org AEC3: General cleanup after multichannel changes 2019-10-18 phoglund@webrtc.org Rewrite the lib link test to just be a binary. 2019-10-18 saza@webrtc.org AEC3: Update SpectrumBuffer API Created with: gclient setdep -r src/third_party/webrtc@119e2197b75e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ibb989f72e91b4104932062ecbc61abe9cd749a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868503Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a missing label to the ManagePasswordsReferrer entry in enums.xml and adds a required comment to the C++ enum definition. Bug: 1013257 Change-Id: I62da6edd7a7161bc2b2b5c127d0232fce027df49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868994 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#707317}
-
Michael van Ouwerkerk authored
Also: * Refactor SharingBrowserTest to be explicit that there are always two sync clients, and set features for both "devices" so that default values don't matter * Clean up context menu helper method Bug: 1006264,989875 Change-Id: Ifc845eae13cef1c54bf982f5df7c9a3ea8f5f63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866512 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707316}
-
Mikhail Khokhlov authored
This CL enables processing of all supported formats by Results Processor instead of Telemetry. Bug: 981349 Change-Id: I5bbbb09002babbe9122f55914922ef0340a36bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864677 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#707315}
-
Niels Möller authored
Previous cl in this series: https://chromium-review.googlesource.com/c/chromium/src/+/1836496 Bug: webrtc:9378 Change-Id: Ib44219631559dd702c10675bfc41a198e822c893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862449 Auto-Submit: Niels Möller <nisse@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#707314}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12fa2ef9c6d1..72d92573ab57 Created with: gclient setdep -r src-internal@72d92573ab57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Icffc6bd28059ecf9ae1f7444d7597102ba3de91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868510Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707313}
-
Friedrich Horschig authored
The experiments for label disambiguation and substring matching autofill suggestions are still ongoing. Therefore, update owners and extend the expiry milestone. Bug: None Change-Id: I61dfbaf0b281e71dd6c0a6e908ddf2677047bcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868992Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#707312}
-
Miyoung Shin authored
This CL converts CameraHalDispatcherRequest and BindingSet<CameraHalDispatcher> in media to the new Mojo type. Bug: 955171 Change-Id: I2345178fc387d0db1b2b3b43d787d439ac517404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863090 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707311}
-
Lowell Manners authored
Rather than synchronously deleting all pages in the BackForwardCache when there is a conflicting BrowsingInstance, call EvictFramesInBrowsingInstance which asynchronously deletes only the conflicting pages. Calling evict is safer than immediately deleting frames, which can lead to UAF bugs. Change-Id: I4e453c3c1dacc5ed764cc344efbc26f24d7fe115 Bug: 993337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844964 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#707310}
-
Yoshifumi Inoue authored
This patch Introduces |NGInlineCursor| member functions to utilize in |NGCartPosition|[1]: - MoveToFirstLogicalLeaf() - MoveToPreviousLine() - Property getter * HasSoftWrapToNextLine() * IsGeneratedText() * IsText() * CurrentNode() [1] http://crrev.com/c/1866101 Utilize NGInlineCursor in NGCaretPosition Bug: 982194 Change-Id: I9f261ebe0fe680ddc98f39a44f3c1c9dd26ef3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868358 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707309}
-
Christian Dullweber authored
Most requests/callers have a NetworkIsolationKey to provide the top_level_origin but a few are still missing. Remove the DCHECK to avoid crashes in Canary. Callers that don't supply a top_level_origin will fall back to site_for_cookies, which is more restrictive. Bug: 1015548 Change-Id: Ic2b7e08e56427f1e4a6600cd813948c2d462b396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868991 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
The old name made more sense before commit 87be7af4 ("wake lock: Implement new proposed API"), when we had a clear separation of concern between WakeLock, WakeLockController and WakeLockStateRecord. After that commit, WakeLockController was merged into WakeLock, and WakeLockStateRecord became a manager of WakeLockSentinel instances, so rename the class to make the name more descriptive. Bug: 257511 Change-Id: Ic6d5f6059cc8fbd315eaf5f158d822cb1d487cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864661 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707307}
-
Wei Lee authored
format We use {width: data_size, height: 1} as size of gbm buffer to store data for BLOB format. Since height might be aligned and makes plane.size bigger than the actual data_size, we change to use plane.stride to represent the data size. Doing so, it won't fail for NativePixmapHandle validation. Bug: b/142105578 Test: ./jpeg_encode_accelerator_unittest Change-Id: Iaf93b0ae7834d2310e1bdfe9cf76be489a3747f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868931Reviewed-by: -
Yuta Kitamura authored
They are very flaky on Fuchsia. Bug: 1014916 Change-Id: Id848846490fd3763fa4538c4ffb25463b6b17804 Tbr: parastoog@google.com Tbr: mmenke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869051 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#707305}
-
Antonio Gomes authored
BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Idb9ef67a8a97181eccf9406b46434e30cf2f72ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867489Reviewed-by:
-
Yutaka Hirano authored
This is the first CL to implement QuicTransport. This CL - creates a directory in blink, - introduces a new blink runtime feature flag, and - defines QuicTransport IDL interface behind the flag, Bug: 1011392 Change-Id: Id432cee2b6d5df6ab4a4c3e8aa6828d5a7937dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868569Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#707303}
-
Marc Treib authored
Introduces a GetMutableEntityForSyncId helper, the code for which was duplicated many times before, and updates a few comments. Bug: none Change-Id: I775a5912990be1d80d7476ff2af8177b05928f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866633Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707302}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6426ba4c. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" ba49a3d6 "autofocus: Change the timing of 'flush autofocus candidates'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If392822cca320841b4af57d361784ec6f5a4126f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868889Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707301}
-
Antonio Gomes authored
BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ia9e4ca1ea07c0386972a5f113972f3e2be3bb27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867449Reviewed-by:
-
Noel Gordon authored
TreeItem handles the item content creation, label, tree parent_ etc so remove local FakeItem code related to that. Bug: 992819 Change-Id: Ice70bf57e9e739a4dc806c5e3973f893be5e7bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868212Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
-
Pâris MEULEMAN authored
This adds a failing assert when SigninManager.Signin is triggered while the primary account is already set in IdentityManager. Bug: 995201 Change-Id: Ib404f930694ea82aada3bac5a144dac096fa1541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824267Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#707298}
-
Huanzhong Huang authored
Reserve space for (lazy-loaded) cookie controls toggle Bug: 967668 Change-Id: Ia6fa8e84590c8512fcd6cb84f72f7db339b69e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865222 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707297}
-
Friedrich Horschig authored
With this CL, the peeking height is set depending on whether a second suggestion will be half visible. Additionally, various paddings and margins are adjusted to match the specs. The see the differences with layout bounds, find screenshots in the linked bug. Bug: 1009331 Change-Id: Ib522938becca2012efbd30200f8a19e6c56c5380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866629 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
This is a reland of 71c00bee Original change's description: > Welcome screen: Fix language list initialization > > Change ResolveLanguageListInThreadPool so that it uses AppLocale instead > of default locale if exists. > > Bug: 955397 > Change-Id: I6947dd89e297adea3fd019e38d083e45419ea282 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704098 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#706436} Bug: 955397 Change-Id: I9b6bc855f0a87eadab42af14d5e3d797f77d6a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865227 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#707295}
-
Michael Lippautz authored
This unblocks fully deprecating the methods that take v8::Value. Switching Blink to fully use references based on v8::Data is future work. Bug: v8:9841 Change-Id: I263ae03e9c6057b84fe84bbeff59a0bfbba01c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868949 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707294}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6dee176c8d7d..c6db4a035a17 git log 6dee176c8d7d..c6db4a035a17 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 6652f0b64287..a68a80a4dbf9 (1 commits) Created with: gclient setdep -r src/third_party/angle@c6db4a035a17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:None Change-Id: Ibf16bda63c21dafa64ded15626905c649dcecb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868969Reviewed-by:
-
Tim van der Lippe authored
With the removal of the terminal, we no longer need this experiment. BUG=1011466 Change-Id: I0c097d33d09329eae41079504d825041f082e1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866930 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#707292}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7bf8699dd1ce..c336dd1cb69c git log 7bf8699dd1ce..c336dd1cb69c --date=short --no-merges --format='%ad %ae %s' 2019-10-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8a67b116..f29003dd (707122:707259) Created with: gclient setdep -r src/third_party/webrtc@c336dd1cb69c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Id55eb5681de8dd6f4336b87758b1fd2791817aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868910Reviewed-by:
-
Miyoung Shin authored
This CL converts AudioDecoderClient{AssociatedPtr, AssociatedPtrInfo} and AssociatedReceiver<AudioDecoderClient> in media to the new Mojo type, and uses pending_associated_remote<AudioDecoderClient> in audio_decoder.mojom. Bug: 955171 Change-Id: I0639e2bbbd97b0f5aebc958a739dae4e1769240f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865162 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
