- 03 Aug, 2017 26 commits
-
-
malaykeshav authored
This patch implements the core logic for Pixel Canvas while hiding it behind a compositor switch (Disabled by default). Pixel Canvas enables all canvas draw commands to be recorded at pixel size, helping eliminate a majority of fractional device scale factor bugs. This also allows devices to work at all non discrete fractional scales with reduced(or no) overhead. Subsequent changes will fix bugs that happen when this mode is enabled. This is to avoid one massive CL. DesignDoc=go/pixel-canvas Slides=go/pixel-canvas-slide BUG=720596 COMPONENT=Canvas, View, Layer, Paint Context, Paint Recorder CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2877483003 Cr-Commit-Position: refs/heads/master@{#491587}
-
Jeremy Roman authored
The branches of this if statement are identical. Change-Id: Icc61de50c3bf18d0df2e5cc616aecef0a38e51b8 Reviewed-on: https://chromium-review.googlesource.com/598998Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491586}
-
Marijn Kruisselbrink authored
With this, serializing involves one copy (from the SerializedScriptValue internal buffer to the serialized mojo message), but deserializing still involves two copies: 1) from the serialized mojo message to a vector<uint8_t>, and 2) from that vector to the SerializedScriptValue internal buffer. Reducing copies in deserialization should be somewhat easier after onion-souping message ports. Change-Id: I5275b96a00f3de646bb5ed9be768d8821ec7dd94 Reviewed-on: https://chromium-review.googlesource.com/592459 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491585}
-
Istiaque Ahmed authored
Bug: 689520 Change-Id: I65adecbed9babdb9d09fdf05f3daebcb966360ac Reviewed-on: https://chromium-review.googlesource.com/587669 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491584}
-
Vadim Tryshev authored
Answer card eats Space, so that pressing space while it's selected doesn't add space to the search box. So if you start typing a query with a space, you might be not able to enter space. Other kinds of results don't eat space. Now not eating Space. Bug=712331 Change-Id: If7bb4224d6d2597bd50e31eececc184d7f401904 Reviewed-on: https://chromium-review.googlesource.com/595154Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/heads/master@{#491583}
-
Nico Weber authored
This reverts commit c1fdd91d. Reason for revert: Warning still fires in at least one file: FAILED: obj/third_party/usrsctp/usrsctp/sctp_callout.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes @obj/third_party/usrsctp/usrsctp/sctp_callout.obj.rsp /c ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c /Foobj/third_party/usrsctp/usrsctp/sctp_callout.obj /Fd"obj/third_party/usrsctp/usrsctp_c.pdb" In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c:48: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_pcb.h:56: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_structs.h:42: ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_header.h(53,9): error: unterminated '#pragma pack (push, ...)' at end of file [-Werror,-Wpragma-pack] #pragma pack (push, 1) ^ ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_header.h(606,9): note: did you intend to use '#pragma pack (pop)' instead of '#pragma pack()'? #pragma pack () ^ pop Original change's description: > Roll src/third_party/usrsctp/usrsctplib/ 2f6478eb8..76bea922c (48 commits) > > Picks up 76bea922c, a fix for a new Clang warning. > > https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/2f6478eb8d40..76bea922c32b > > $ git log 2f6478eb8..76bea922c --date=short --no-merges --format='%ad %ae %s' > 2017-07-28 hans Use '#pragma pack (pop)' instead of '#pragma pack ()' > 2017-07-26 tuexen Check return value of if_indextoname(). > 2017-07-25 tuexen Remove duplicate statement. > 2017-07-24 tuexen Add --enable-programs to configure script. > 2017-07-20 tuexen Sync with sctp-idata. > 2017-07-19 tuexen Sync with sctp-idata. > 2017-07-19 tuexen Sync with sctp-idata. > 2017-07-19 tuexen Sync with sctp-idata. > 2017-07-18 weinrank update compiler settings for sanitizers > 2017-07-18 weinrank adding sanitizer support - first try > 2017-07-16 weinrank tsctp: fix compiler warning > 2017-07-16 weinrank revert unreachable code changes > 2017-07-16 weinrank Revert "Unreachable code when in "__Userspace__"" > 2017-07-16 weinrank Compiler flags: don't check for unreachable code > 2017-07-16 weinrank tsctp: Windows compile fix > 2017-07-16 weinrank Fix compiler warnings for more strict compiler flags > 2017-07-16 weinrank Fix shadowed variable complain > 2017-07-16 weinrank Unreachable code when in "__Userspace__" > 2017-07-16 weinrank CFLAGS: don't set Werror by default > 2017-07-16 weinrank More strict compiler flags > 2017-07-15 tuexen Sycn with sctp-idata. > 2017-07-15 weinrank CMake beautification > 2017-07-15 weinrank CMake cleanup > 2017-07-14 weinrank CMAKE refactoring > 2017-07-13 weinrank correct include_directories path > 2017-07-12 weinrank CMAKE refactoring > 2017-07-11 weinrank ignore build directory > 2017-07-04 tuexen Sync with sctp-idata. > 2017-06-25 tuexen Remove unused code on Windows (which would not work). > 2017-06-25 tuexen This should dead code. Try on buildbot. > 2017-06-25 tuexen More signed/unsigned issues. > 2017-06-25 tuexen Address some signed/unsigned issues. > 2017-06-25 tuexen Improve build scripts. > 2017-06-25 tuexen Silence a warning when using older versions of clang. > 2017-06-25 tuexen Silence a warning showing up on clang 4. > 2017-06-25 tuexen I missed this in the last commit... > 2017-06-25 tuexen Remove datachan_serv.c. > 2017-06-25 tuexen Address signess issues. > 2017-06-25 tuexen Address windows type mismatches. > 2017-06-25 tuexen Fix a bug reported in https://github.com/sctplab/usrsctp/pull/150/files > 2017-06-25 tuexen Use lowercase names for include files. > 2017-06-23 tuexen Sync with El Capitan sources. > 2017-06-23 tuexen Sync with sctp-idata. > 2017-06-23 tuexen Sync FBSDID. > 2017-06-23 tuexen Fix FreeBSD compilation. > 2017-06-23 tuexen Add -Wno-address-of-packed-member to build system. > 2017-06-23 tuexen Sync with FreeBSD sources. > 2017-05-15 anselm.scholl Fix truncation with snprintf in buffer: > > Created with: > roll-dep src/third_party/usrsctp/usrsctplib > > BUG=749197 > > Change-Id: I2b05f13a523679beaa2fb8dc75bbf0ea190c7129 > Reviewed-on: https://chromium-review.googlesource.com/594656 > Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491010} TBR=hans@chromium.org,deadbeef@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 749197 Change-Id: Idfef3d4c6217297113d0700a9317a89b4b90bac8 Reviewed-on: https://chromium-review.googlesource.com/598711Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#491582}
-
Tom Anderson authored
BUG=751812 R=thestig@chromium.org TBR=rkc@chromium.org Change-Id: I3d8ff471df1377c9c4cf184044abd14700b8b8cf Reviewed-on: https://chromium-review.googlesource.com/599029Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491581}
-
Blake O'Hare authored
Bug: Change-Id: Ib98fc75298e45bae591c2a97f533052722ce4d0e Reviewed-on: https://chromium-review.googlesource.com/593417Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Keigo Oka <oka@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491580}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bfb1b022..747d3ecd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifad63fc70f5fb5cd7a9227166fa47d792877ee92 Reviewed-on: https://chromium-review.googlesource.com/598989Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491579}
-
Blake O'Hare authored
Bug: Change-Id: I556360f66c447777e20c0a6c5933859ed1e925b9 Reviewed-on: https://chromium-review.googlesource.com/597556Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491578}
-
Ian Clelland authored
Several errors have crept in to the comments in Blink, as APIs have changed and comments haven't been kept up to date. Additionally, the Great Blink Rename renamed almost every method and instance variable, without touching comments. This CL brings the comments in WebKit/public/platform in line with reality. Bug: 643310 Change-Id: I76f1365c2b8aaf3098fb88063c842a9464ac37c4 Reviewed-on: https://chromium-review.googlesource.com/598109 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491577}
-
Greg Kerr authored
Bug: 749839 Change-Id: Ie95fc3c6574377e278474c1709b7270847016b44 Reviewed-on: https://chromium-review.googlesource.com/596422Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491576}
-
Scott Chen authored
The subpage's main container is too short and contents are leaking out of it. This CL makes it such that the main-container spans full height and puts the overflow scrolling on the parent detail-view element. Bug: 741226 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic0fe061435bc82544058533126e5eba75be8f357 Reviewed-on: https://chromium-review.googlesource.com/598504Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491575}
-
Scott Violet authored
Prior to this patch system modal windows had to be attached to a display, otherwise the request to set modal failed. This is problematic as the order done by NativeWidgetAura is to set modality, then add. BUG=692282 TEST=covered by test Change-Id: Ibb5f96f7e44eac205eb39244bd61bca23ce45b03 Reviewed-on: https://chromium-review.googlesource.com/599147Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491574}
-
Steven Holte authored
Move system profile persistence to MetricsService. Bug: Change-Id: I5c31dc53de267dd9699a83af926f8a575bab18a0 Reviewed-on: https://chromium-review.googlesource.com/592689 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#491573}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d3efed..8aa0768 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1f88e9213f4387e38b4b9d1059d7ee9a419d755f Reviewed-on: https://chromium-review.googlesource.com/599015Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#491572}
-
Victor Miura authored
The Polymer page set is using deprecated feature (/deep/ selector) and needs to be updated before re-enabling. BUG=746729,750876 Change-Id: Iac5eb3651d6c22f59e18c8271c9eb5270b44c3d6 Reviewed-on: https://chromium-review.googlesource.com/594908 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491571}
-
Raymes Khoury authored
This removes the RequireSecureOriginsForPepperMediaRequests flag which has shipped to stable. It also removes the metric Pepper.SecureOrigin.MediaStreamRequest which was used to determine when we would be able to ship the feature. Bug: 526324 Change-Id: I9fb91f66429f90b159bbc8cc0186fbd94809faff Reviewed-on: https://chromium-review.googlesource.com/595371Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#491570}
-
Etienne Pierre-Doray authored
DisassemblerNoOp is a Disassembler that does not look for reference, and used as fallback for patching Elements not recognised as executable. Bug: 729154 Change-Id: I4cbf355fb59bcf7df12b9e6d81029c771c52f215 Reviewed-on: https://chromium-review.googlesource.com/599023Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#491569}
-
Eric Karl authored
We avoid stencil buffers on certain Intel GPUs with a known leak. From looking at UMA, it appears that this leak may apply even when the GPU isn't the active one (on a multi-GPU system). Expanding the workaround to handle this case as well. R=vmiura Bug: 713854 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I32eb73416eae4740635f50922b0bd673e75b9af0 Reviewed-on: https://chromium-review.googlesource.com/599123Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#491568}
-
Khushal authored
The suffix is meant to be applied on histograms which have the CompositorTimingHistoryProcess prefix. Use Scheduling.Renderer.ReadyToActivateToActivationDuration2 and Scheduling.Browser.ReadyToActivateToActivationDuration2 instead of Scheduling.ReadyToActivateToActivationDuration2 for the suffix. This was accidentally added incorrectly in https://chromium-review.googlesource.com/c/566184 R=mpearson@chromium.org Change-Id: Iee935f6e9216038ec746b076d2b8d69789d7d666 Reviewed-on: https://chromium-review.googlesource.com/598935Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#491567}
-
Devlin Cronin authored
Update the FileReader class to use the new task scheduling API, as well as the dedicated Extensions-related file task runner. Bug: 689520 Bug: 750122 Change-Id: I3dd119e9c6bc368ab0186e599a4a67df02b872d6 Reviewed-on: https://chromium-review.googlesource.com/594010 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491566}
-
Mike Klein authored
Change-Id: Ica8e8564d79eb34766203712511bdbbed58f78c4 Reviewed-on: https://chromium-review.googlesource.com/598995Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#491565}
-
Chris Kuiper authored
This generates and uses one audio session id for all media tracks and a second one for non-media tracks. Static functions are provided for cast manager to read those ids. In addition, the AudioTrack instances are created using builders now. There are two ways to read the ids: 1) From native code: #include "chromecast/media/cma/backend/android/audio_sink_manager.h" int media_id = -1, non_media_id = -1; bool success = AudioSinkManager::GetSessionIds(&media_id, &non_media_id); 2) From Java: import org.chromium.chromecast.cma.backend.android int media_id = AudioSinkAudioTrackImpl.getSessionIdMedia(); int non_media_id = AudioSinkAudioTrackImpl.getSessionIdNonMedia(); Bug: internal b/64159457 Test: Produced TTS and Music output, verified logs. Change-Id: Ibd9ca6221904c735a9f0347b546955bf05c0c3cc Reviewed-on: https://chromium-review.googlesource.com/597072Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#491564}
-
Brett Wilson authored
The paths are specified as initializer lists to avoid parsing them. We will likely need to add on a different capability to support callers that have only dynamic paths, but I think we will want to support this format either way. Updates flat_set and flat_map documentation with a missing function. Bug: 646113 Change-Id: I105b958afa7c514147f259c6be1e3608518d7734 Reviewed-on: https://chromium-review.googlesource.com/589779 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#491563}
-
Quinten Yearsley authored
This flag shouldn't affect test runs here; see bug. Bug: 748623 Change-Id: Ic4937b1ad174c60bc758e22851177d69105293a0 Reviewed-on: https://chromium-review.googlesource.com/585359Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#491562}
-
- 02 Aug, 2017 14 commits
-
-
Jeremy Roman authored
V8 always internalizes strings when doing property lookup, so this can only save the work of heap-allocating a new string that will just be looked up later, and likely already exists in the internalized string table (e.g. because it is the key of a property, or because it occurs as a string literal). Found mainly by searching for string literals passed to V8String. Other similar cases may yet remain. No perf measurement was done, but this seems like it's easily the nicer thing to do in these cases. Change-Id: Idd645a83495f5ec1323f3ce87548d0f2a16aca19 Reviewed-on: https://chromium-review.googlesource.com/598540Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491561}
-
Sunny Sachanandani authored
I removed the optimizations in SyncPointClientImpl where it'd skip generating sync tokens if there was no existing release sync token. That caused a 5% cpu time regression in the video benchmarks. I also added some tests to verify that sync tokens are being generated at the right places. R=jbauman BUG=750872 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: If739e3fb6705cf8b0739fc029ed3bd75dc43eabf Reviewed-on: https://chromium-review.googlesource.com/596424Reviewed-by:
John Bauman <jbauman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#491560}
-
Tsuyoshi Horo authored
We are planning to start the field trial experiment of off-main-thread-fetch optimization. But in the current implementation, web developers need to enable 'Network in workers' experiment of DevTools to show the network requests from workers in DevTools if the optimization is enabled in their Chrome. It is very troublesome for them while debugging PWA. To avoid this problem, this CL enables the network capability in worker unconditionally. Bug: 443374 Change-Id: I5ed24996cd0ff30a5bd22ce1067f653a5c68ae9b Reviewed-on: https://chromium-review.googlesource.com/595294Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491559}
-
Jeremy Roman authored
This was erroneously picked up by the Blink reformat; the method name is still lowercase at this point, so we were generating a find-and-create call when a find-only call suffices. https://chromium.googlesource.com/chromium/src/+/1c4d759e Tested by manually inspecting generator output. Change-Id: Ic7b6a4936b8bb7558e0ca21eddee23ca84348647 Reviewed-on: https://chromium-review.googlesource.com/599000Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491558}
-
Tsuyoshi Horo authored
Bug: 443374 Change-Id: I001c3981e17430f8786eec2a7d475c0c994e2f5e Reviewed-on: https://chromium-review.googlesource.com/597573Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491557}
-
Miao-chen Chou authored
Since the observation of the local powered state change and the receiver of enable/disable requests from Android is in arc_bluetooth_service are in arc_setting_service and arc_bluetooth_bridge separately, the power state can get out of sync or restore to the wrong state due to the lack of coordination between these two pieces of information. Issues: - The powered state can get out-of-sync between Android and Chrome if the power state of adapter is repeatedly toggled from Chrome setting. - If the powered state is ON before deep suspend/resume, the state will turn to OFF after resume and turn immediately back to ON on Chrome. However without waiting for the previous disable intent to finish, arc_setting_service sends the enable intent right after while Android Bluetooth statck is still processing the disable intent. Also there is a 3~4 seconds delay for bringing down to complete on Android Bluetooth stack. Besides, the enable intent is treated as a no op if the ongoing intent is disable. So after 3~4 seconds Android sends a disable request to Chrome while the powered state is ON on Chrome, so the powered state fall to the wrong one, disable, instead. The changes includes: - moving the observation of Bluetooth adapter from arc_settings_service to arc_bluetooth_bridge, - changing the cycle of observing Bluetooth adapter from living along with ARC Bluetooth instance to living along with ARC Bluetooth bridge, - adding IntentHelperObserver to listen to the OnInstanceReady event and fire the initial powered state of Bluetooth to Android via intent, - adding two queues and a timer to track the powered state changes initiated by either Chrome or Android and to track the completion of the power changes initiated by Chrome, - and adding helper functions to enqueue/dequeue the power change intents and to compress the toggling of state to reduce the intents sent to Android. BUG=b:62578573 TEST=(1) On Android start-up, verify that the powered state is synchronized between Android and Chrome. (2) After Repeatedly toggling Bluetooth powered state, the state remains synchronized between Android and Chrome. (3) Put device into deep suspend and resume, the state restores to the previous state. Change-Id: I753839e2bb9228703492ebd23703cf8b67494998 Reviewed-on: https://chromium-review.googlesource.com/580314 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#491556}
-
Tom Sepez authored
Broken at 4ec75161 The busted FYI bot build is: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/27173 TBR=mbarbella@chromium.org Change-Id: If4cad6ae90bab1c6ae12d65d568fbda8975ef50c Reviewed-on: https://chromium-review.googlesource.com/598453 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491555}
-
MinChen authored
Changes, Updates opacity of app list if dragging happened on the opened app list. Updates opacity of start page in peeking state during dragging. Since each page of app list can be dragged, remove the first page restriction in UpdateOpacity. After changes, when dragging the opened app list. The opacity of app list will also updates during dragging. Bug: 748620 Change-Id: Ic93edcaf28e422117bbdd3a5fa100ebcd5c9842d Reviewed-on: https://chromium-review.googlesource.com/594682 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491554}
-
Vladislav Kaznacheev authored
Start the animation a bit earlier, invoke the Assistant a bit later. (see the bug for details). Bug: 751752 Change-Id: Ic141fc6a1955f49fd26a7eab9e7128d0c1197fd0 Reviewed-on: https://chromium-review.googlesource.com/598774Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#491553}
-
Reilly Grant authored
This change modifies the MojoInterfaceInterceptor so that the 'interfacerequest' event, fired when a request for the intercepted interface is made, is dispatched in a new microtask instead of synchronously. This has the benefit of not reentering JavaScript to execute event handlers synchronously which is both different from the usual case for binding interfaces that are provided by other processes and avoids the possibilty of attempting to dispatch this event to JavaScript from a scope where script is forbidden. Change-Id: I08b8c25a04da047381a3786af08b62979ca7b837 Reviewed-on: https://chromium-review.googlesource.com/594716Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491552}
-
Xida Chen authored
In a previous CL: https://chromium-review.googlesource.com/c/579690 where we refactor the Canvas2DLayerBridge, we did not null check before passing calling the ReleaseMailboxImageResource. This CL does the null check. Bug: 751445 Change-Id: I86f59e8176a44ef53d591a560a4c0c4b6cad2676 Reviewed-on: https://chromium-review.googlesource.com/597226 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491551}
-
btolsch authored
This change lets other test files avoid using the DiscoveryNetworkMonitor singleton and converts TestBrowserThreadBundle to ScopedTaskEnvironment. Bug: 698943 Change-Id: Ib69cd42901b739e651a87cafa2ca4a2e214c48e2 Reviewed-on: https://chromium-review.googlesource.com/595017 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491550}
-
jdoerrie authored
This change removes the deprecated SetBooleanWithoutPathExpansion from base::Value. Existing usages are replaced by SetKey(key, Value(bool)). Bug: 646113 Change-Id: I4d7f1a60909765ec6a956360312c11b32173429f Reviewed-on: https://chromium-review.googlesource.com/590448 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#491549}
-
Chris Harrelson authored
This was added to prevent crashes. Let's remove it now to see if those crashes were fixed, and to uncover more failure cases, which may shed light on similar crash bugs we cannot reproduce. Bug: 708372 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1e89c3fcc859af65d82c9945a14cbf5aac8ef8c8 Reviewed-on: https://chromium-review.googlesource.com/598452Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491548}
-