- 17 Oct, 2019 40 commits
-
-
Connor Clark authored
Instead of in _onMessage. Bug: 1011228 Change-Id: I56699d605ed2cae36361031f1ecf071ee3110e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854642 Commit-Queue: Connor Clark <cjamcl@google.com> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707097}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the FrameSinkVideoConsumerFrameCallbacks interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I32d5ad59de88e231ce86670725ca1473491f7998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860534Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#707096}
-
Michael Ludwig authored
This is a preparatory step to make it easy to apply RPDQ effects from any of the DrawXQuad() functions in SkiaRenderer, so that bypassing a RenderPass doesn't depend on the underlying quad's material. Bug: 1013735 Change-Id: I81e55c7f469673ba618abc54ebf72feff88e0e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860294 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#707095}
-
David Van Cleve authored
This patch adds a new class, EsniContent, that serves to aggregate the results of several ESNI (TLS 1.3 Encrypted Server Name Indication, draft 4) DNS records and surface them to the connection stack. An ESNI DNS query response contains a list of ESNI records, each of which comprises a "key object" and an optional list of IP addresses associated with the key object. Aggregating the records should ensure that: - each key is only stored once (the spec allows keys to be up to ~60K in size) - it is fast to determine which IP addresses have associated keys, and to iterate over these associated keys (for purposes of prioritizing addresses in connection establishment) To do this, an EsniContent object stores a set of bytestrings (the distinct key objects) and a map from each IP address to a set of handles to the keys associated with that IP address. R=ericorth Bug: 1003494 Change-Id: I0ff2478ef6db6bd9fcb4a685444d96076ed26eae Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862730 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#707094}
-
Dan Beam authored
Fixed: 1013837 Change-Id: I468696fd398714693609fe0aacb45425fc49361d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857606 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#707093}
-
Andrew Grieve authored
Converts run_benchmark to use the newer generate_wrapper() template. Deletes other uses, which I don't think were used at all. This also adds a call to "normpath" to generate_wrapper.py so that @WrappedPath()s don't look odd (e.g.: one was: "bin/../.") Bug: 816629 Change-Id: I5aa5dc7c2033e3386712f7162fe7371dc47661fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866556 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#707092}
-
Christopher Cameron authored
TBR=sdy Bug: 1013250 Change-Id: I9090602c6af0d01b971b6a9764e21d9c1e50987f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864319Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#707091}
-
John Delaney authored
This CL adds two optional finch params that give control over how intervention reporting works the interventions. The first param enables/disables sending intervention reports when the intervention is enabled. Reports are enabled by default. The second param, provides the option of only sending intervention reports and not unloaded the ads when the intervention is enabled. This is not enabled by default. Reports sent in reporting only mode have a different message that indicates the ad was not unloaded. Bug: 1012292 Change-Id: Id8ec48f881b19adf7495c55ba43089e643ef3f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865628 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707090}
-
David Grogan authored
32758180 regressed but 84c273ae depends on it so they both have to go. I will fix after the 79 branch. Revert "[LayoutNG] Implement flex-wrap:wrap-reverse" This reverts commit 84c273ae. Revert "[LayoutNG] Implement flexbox item alignment" This reverts commit 32758180. Bug: 845235, 1015475 Change-Id: I24a20d54e79608650426130e2ec106e35bdfde63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866434Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707089}
-
Michael Spang authored
FONTCONFIG_SYSROOT is set by //base in the test harness to run without system fonts to keep test results predictable. This broke loading any fonts in our extra fonts directory added via FcConfigAppFontAddDir(), which can cause crashes in cast_shell_browsertests: [192088:192088:1016/200749.741977:FATAL:resource_data_source.cc(63)] Check failed: -1 != idr (-1 vs. -1) path: fonts/GoogleSans-Regular.ttf (this happens because if the font can't be found via fontconfig, we try to look in resources since that's what happens on Android. We don't have those resources on Linux, so it crashes). We had fixed this with a local patch to fonts.conf, but we can remove that if we account FONTCONFIG_SYSROOT when adding the extra directory. Bug: b/142153810 Test: cast_shell_browsertests Change-Id: I761f1760b3b493de509774474b6dce7d727c665d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865263Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707088}
-
Sebastien Marchand authored
Change-Id: I1878099286948f968e39f27cf808dcf69960b152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864623 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#707087}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1b3fb455bf18..c98b1ee7e410 git log 1b3fb455bf18..c98b1ee7e410 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 perezju@chromium.org [Telemetry] Remove unused PageTestTestCase 2019-10-17 bsheedy@chromium.org Add CrOS local/remote disable support Created with: gclient setdep -r src/third_party/catapult@c98b1ee7e410 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:921000,chromium:1014177 Change-Id: I1a2e79da82b99609923cb737baa5338c8b9fb76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707086}
-
Aran Gilman authored
Bug: 952034, 1015190 Change-Id: I940c5114ff5dcf47d02b31caafdff1393abb3e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850597 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707085}
-
Ionel Popescu authored
This CL adds support for updating the in-page time element when an invalid value is selected from the popup. A value can be invalid because it doesn't fit the rules determined by step, min, max attribute. For time picker the invalid values can't be disabled in the popup since a value is composed from multiple columns (e.g. min=10:20, 21 minute cell should be disabled when hour cell < 10). Tests are added to validate the new behavior. Bug: 1004997 Change-Id: Ia91c8b23b572915bf78d59166fd8aaf80ae9ab4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866068Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707084}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0284f460cf1be16a18d7b769f6d618656a2f1fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867197Reviewed-by:
-
Peng Huang authored
Bug: 887018 Change-Id: If07eed9cdd9ab49d35c7df7f48bd4a1f9563be0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867202 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#707082}
-
Garrett Beaty authored
Bug: 1011908 Change-Id: Ib3e5f2c75fb7584055b608a94324ebd5ca60895f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863121 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#707081}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c71d85bc4e71..db8df1765017 git log c71d85bc4e71..db8df1765017 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 saza@webrtc.org Add AEC3 config json parsing fuzzer 2019-10-17 sprang@webrtc.org Split RTPSender into pre- and post-pacer parts. 2019-10-17 phoglund@webrtc.org Add a test which breaks if libwebrtc.a don't pull in the right symbols. 2019-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 08af4873..60f3e975 (706400:706891) Created with: gclient setdep -r src/third_party/webrtc@db8df1765017 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I2ab3128da85bda3e68c83b812f290b28d148c882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866435Reviewed-by:
-
Jonathan Backer authored
This CL sets the active URL for SkiaRenderer and it's use of GLRendererCopier. This should help attribute GPU thread crashes back to SkiaRenderer. Bug: 1011420 Change-Id: I1fc0e75881d6cf76f26039ab888bd4161de5073b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866615Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707079}
-
Sigurdur Asgeirsson authored
Change-Id: I2d01fc0a7ffdb3b5b73f02cf07461c4832745904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865598Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707078}
-
Yao Xiao authored
Bug: 1010242 Change-Id: I4c075a96f8ffff302eded56bb277e61a3164064b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856886Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#707077}
-
Gavin Williams authored
-The clear button search label needs to be set so screen readers can properly describe the button's function. This will add a clear label to search bar clear buttons used in Chrome browser and OS settings. Bug: 1007589 Change-Id: Ib3dc560e9c946e73344832210b21f768da92b0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863739Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#707076}
-
John Abd-El-Malek authored
This reverts commit 44cfe871. Reason for revert: failing on bots Original change's description: > weblayer: fullscreen related tests > > This is a good basic set. I would like more, but they require > js injection. > > BUG=none > TEST=test*Fullscreen* > > Change-Id: I0a605e4aefe3b0be6b9a754e437aa496f1e059bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866271 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706942} TBR=sky@chromium.org,cduvall@chromium.org Change-Id: Ic591f0d4ff0cb5410ecc5046d4d92285c20d8472 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864625Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707075}
-
Garrett Beaty authored
Bug: 1011908 Change-Id: I5c0ab0c93178bfbacaa920b5bb2b130ac2aa633c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865536Reviewed-by:
-
Daniel Rubery authored
It seems there's some confusion about exactly how the policy should behave, so disable it for M79 while we clarify the semantics. Bug: 1015484 Change-Id: I21f62e06277ec34bc64c611324234fdf8e5949be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867089Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#707073}
-
Garrett Beaty authored
These changes simplify migrating to starlark by removing spurious diffs from the semantic diff. The repo_url, refs and header_id fields have no effect when builder_view_only is true because builder views do not display headers and do not display a list of changes being tested. lucicfg enforces referential consistency, so a couple of non-existent builders were removed. It also prevents a builder from being duplicated in a builder view, so there was one repeated builder removed from tryserver.chromium.mac console. Bug: 1011908 Change-Id: Iec1ee893e27b6c4edec3ab546ab9485453cacede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851911 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Leonard Grey authored
This increases coverage somewhat, though there's still a ways to go. Bug: 1009106 Change-Id: Ia569e7b3630380a5f0abb2401b180550dd321328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865425Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#707071}
-
Justin Cohen authored
Update matchers to not use GREYMatchers anymore Remove -testInvocations call for iOS 10.2 Add support for shared EarlGreyScopedBlockSwizzler. Add helper util to call -presentSafeMode. Bug: 987646 Change-Id: I783e84af095b87f84d2502c14a308dc41a6eef54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863950Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707070}
-
Anubha Mathur authored
Fix accessibility bug: In the sensors tool, when the reset button under Device orientation was clicked, the screen reader did not read anything out to inform user that the orientation was changed. Now whenever the device orientation updates, the new setting is read out. If the update was only read out when reset button was pressed, the experience would not be consistent, and the alert wouldn't be read out for subsequent resets, which is why the update is read out on every change. Gif: https://imgur.com/a/1YeTX2l Bug: 963183 Change-Id: Id4f82c4af8db1857af832d4b221d60cd1eea578c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750194 Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707069}
-
Tommy Li authored
Currently, the process of reverting to the user text is broken for on-focus suggestions. After using the arrow keys to choose a match, pressing Escape does not work. Escape selects the top match, which normally works, but in ZeroSuggest, the textfield contents could be a non-prefix of the first suggestion. This CL reverts the textfield to the input that was sent to the Autocomplete controller, which should work for on-focus suggestions. This also adds a test. Bug: 1012990, 996516, 963173 Change-Id: Id19aaf961591dc0c81bf9083b639233c5f8e4420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865551Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#707068}
-
Sam Fortiner authored
Move layer list dumping to a format and code that is aligned between CAP and non-CAP code paths. This will smooth the transition for enabling CAP. Additionally, this will remove some of the dependencies on stale/deprecated GraphicsLayer information for those dumps. Bug: 999336 Change-Id: I0f1a1715a4d73802c3cb05333dafc9d85d0cf15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809659Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707067}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48aa52f7305a..f483d4ee4696 git log 48aa52f7305a..f483d4ee4696 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 jmadill@chromium.org Vulkan: Move SwiftShader ICD json to root_out_dir. Created with: gclient setdep -r src/third_party/angle@f483d4ee4696 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:b/142756865 Change-Id: Ia3afc491beaf59973fb97d2fec3d8e693165b92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867037Reviewed-by:
-
Daniele Castagna authored
There is some stuttering when viewing protected content with a DP MST dongle attached. Looking at a trace it looks like we spend a lot of time (200ms) in DrmDisplay::GetHDCPState, in particular in drm_->GetConnector. This patch caches the connector used to check if HDCP is available. It additionally downgrades log severity when the HDCP properties is not found to INFO, since it can happen every 2 seconds. Bug: 1001211 Change-Id: I77eb86b2e55f0fd4640560ae2e38d64d5e2b2174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864354Reviewed-by:
-
Yann Dago authored
Bug: 1013598 Change-Id: I19dbb6981eae07d45c0d760f41f4f42508b80929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856799Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#707064}
-
Max Moroz authored
Added fuzzy padding to the Key value generation, plus included two known colliding values to be used with approximately 1% chance. I was trying to discover crbug.com/973943 with this improvement, but have not succeeded so far. However, the fuzz target seems to be running much faster now and keeps discovering new coverage starting from the existing corpus. This is a good indicator that the change makes sense. I've also compared the code coverage reports locally to make sure those pieces of code under key size checks are now getting executed, such as: https://chromium-coverage.appspot.com/reports/706240_fuzzers_only/linux/chromium/src/net/disk_cache/blockfile/entry_impl.cc.html#L449 and https://chromium-coverage.appspot.com/reports/706240_fuzzers_only/linux/chromium/src/net/disk_cache/blockfile/entry_impl.cc.html#L793 Also fixed a presubmit warning regarding the use of std::to_string. Bug: 990644, 973943 Change-Id: I0c7560f700ccaf5e25bda2e1d56f3cb613bbe91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865408Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707063}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1f088ab877cb..94e600d98301 git log 1f088ab877cb..94e600d98301 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 thestig@chromium.org Verify font resource dictionaries. 2019-10-17 thestig@chromium.org Add a JavaScript test for AFDate_FormatEx(). Created with: gclient setdep -r src/third_party/pdfium@94e600d98301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1013868,chromium:572901 Change-Id: I7c900f247a67da175eabf06115ad04fe1f9d3f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867029Reviewed-by:
-
Justin Cohen authored
This reverts commit eda4c3ea. Reason for revert: This change is masking some exception failures. Original change's description: > [ios] Speed up egtest failures by skipping _recordFailure. > > _recordFailure internally spends a very long time symbolicating > on iOS13. Skipping this seems to be safe. > > Bug:991338 > > Change-Id: I74c2872cd82de0840a6bcdd0f799703b5eb9bdb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725137 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684557} TBR=rohitrao@chromium.org,justincohen@chromium.org,monufriienko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 991338 Change-Id: I66223c64e6236dbea9feb8ac74e7c29b832e2eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866990Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707061}
-
Mounir Lamouri authored
This reverts commit 2d943658. Reason for revert: feature got all the approvals. Original change's description: > Revert "[Lock screen media controls] Enable by default" > > This reverts commit 00d10067. > > Reason for revert: feature not ready to launch in M78, reverting in trunk then merging. > > Original change's description: > > [Lock screen media controls] Enable by default > > > > Enable the lock screen media controls by default > > since these are shipping in M78. > > > > BUG=965546 > > > > Change-Id: I159052753625fe4eb8bf3653bf2c7bdffe09615e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773325 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#690893} > > TBR=jamescook@chromium.org,beccahughes@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 965546 > Change-Id: I97211dd536f71ee8fed4b08b1124089343f797a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826043 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700041} TBR=jamescook@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965546 Change-Id: I567d6fa05394e31df3d5e9a35f9c3bcc8af600ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867196Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#707060}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/930722709254..3e2416ee17a9 Created with: gclient setdep -r src-internal@3e2416ee17a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:1011937) Change-Id: I4c3a166f46df3ff8a22b8f9d0764ab7c02492453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866433Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707059}
-
Peng Huang authored
The crashes is becaued color spaces of DDL recorder colorspace and framebuffer sk surfaces do not match. Bug: none Change-Id: Ib970536c78eb2a9452528b0f99deecc067446247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866738Reviewed-by:
-
