- 20 Apr, 2020 40 commits
-
-
gogerald authored
Change-Id: I8b922761cf9bb18af70e09dfa78b3711fcb067ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157245 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760554}
-
Xiaoqian Dai authored
I cannot repro on my eve or caroline device, but according to comment#4 in bug 1050195, and comment#9 in bug 1050330, it seems theoretically it can be caused by aync reading of the lid angle driver "cros-ec-lid-angle". So when the device first starts or comes out from sleep, the driver "cros-ec-lid-angle" is not present yet, so Chrome is doing its own lid angle calculation, and later when the reading result comes back and"cros-ec-lid-angle" flag is properly set, Chrome does not do the lid angle calculation anymore, but the old lid angle is not reset to 0.f, so it might interfere with the tablet state calculation. Bug: 1050195, 1050330 Change-Id: I9c650ee2becbabfb20101a192ebfa5eeb7b677dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153899 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#760553}
-
arthursonzogni authored
Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/2152797/1 improves ./stale-image.html For consistency and because the test looks slightly nicer, this patch applies the same kind of refactoring to ./stale-css.html Bug: 1070117 Change-Id: I5a30c105aca4c2bde0962004f9a97e4fbde2ab4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152798 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#760552}
-
Jonathan Wright authored
Change libpng build configuration to optimize for speed on Arm platforms. This allows the compiler to inline some of the NEON filter functions and significantly increase performance. Binary size increase is minimal (<10KB increase in normalized Android APK size.) Bug: 1071398 Change-Id: I109dea8b490bfdd2c0a80e2f1259797f1485e14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149331Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#760551}
-
arthursonzogni authored
Mainly for improving my own understanding. I would like to make some tests about CSP vs stale-while-revalidate for issue 1070117 This patch: 1) Use Promise(s) instead of callback(s). This unwrap the logic flow. 2) Make "last_modified_count" to count the number of new version being served. Previously, it was a bit confusing to me. 3) Extend the test to check the "revalidated" version is served on the 3rd load. 4) Small misc refactorings. Bug: 1070117 Change-Id: Ifba23d78e539eb50262244f59e7c16e1b9ca56ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154786Reviewed-by:
-
danakj authored
We remove the secondary window bool in renderer as we no longer need to rely on it to avoid logging in devtools inspector windows. The devtools tests disable console logging in WebTestRuntimeFlags, and if we correctly replicate it to the inspector window's renderer processes (both for the first test and for subsequent ones), then no logs will be produced in the inspector. The tests in /devtools/ have console logging disabled in TestInterfaces::ConfigureForTestWithURL(), which is propagates as a WebTestRuntimeFlag to all windows and frame tree fragments - including the inspector secondary window. The /inspector-protocol/ tests similarly use console logging to drive their tests, and have a secondary window, though provided through other means seen below: #2 0x55d55b531129 content::WebContentsImpl::Init() #3 0x55d55b527234 content::WebContentsImpl::CreateWithOpener() #4 0x55d55b526f34 content::WebContents::Create() #5 0x55d55b938b57 content::Shell::CreateNewWindow() #6 0x55d55b93ce57 content::ShellDevToolsManagerDelegate::CreateNewTarget() #7 0x55d55b0d8296 content::protocol::TargetHandler::CreateTarget() #8 0x55d55b0d840e content::protocol::TargetHandler::CreateTarget() #9 0x55d55aebcbcf content::protocol::Target::DomainDispatcherImpl::createTarget() #10 0x55d55ae7fdf8 std::__1::__function::__policy_invoker<>::__call_impl<>() #11 0x55d55a3d6913 v8_crdtp::UberDispatcher::DispatchResult::Run() #12 0x55d55b0793a0 content::DevToolsSession::HandleCommandInternal() #13 0x55d55b0792cb content::DevToolsSession::HandleCommand() #14 0x55d55b07c688 base::internal::Invoker<>::RunOnce() #15 0x55d55b7fa48e content::DevToolsManagerDelegate::HandleCommand() #16 0x55d55b0791eb content::DevToolsSession::DispatchProtocolMessageInternal() #17 0x55d55b078d96 content::DevToolsSession::DispatchProtocolMessage() #18 0x55d55b94ade5 content::DevToolsProtocolTestBindings::HandleMessageFromTest() Thus we disable console logging in /inspector-protocol/ tests also to not cause regressions due to unexpected logs appearing in the secondary window. Lastly, web platform tests log to stderr instead of the console to avoid including browser-specific console logs in test expectations. However we were only setting the "IsWebPlatformTestMode" in the main frame renderer, so web platform tests that use window.open() would include logging from that window unintentionally. We move the web platform test mode into the WebTestRuntimeFlags set, so that it is propagated to all renderer processes, allowing secondary windows to stop console logging, and also allowing them to perform other tasks correctly as a bonus, such as translating URLs to the correct location. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I4ba2deb635e57d2a1f293e849e01190135064064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153891Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#760549}
-
Ben Kelly authored
This feature is gated behind the "ThrottleInstallingServiceWorker" feature flag and uses the "limit" field trial param to control how many outstanding requests to permit. This CL includes the following changes: * Changes ResourceFetcher and associated classes to use FrameOrWorkerScheduler instead of FrameScheduler. * Moves FrameOrWorkerScheduler::GetWeakPtr() from private to public so that ResourceFetcher and friends can use it. * Factors the outstanding throttle limit into a virtual method on ResourceFetcherProperties. This makes it easier to expose a different limit for workers vs frames. * Moves existing frame throttle limits from ResourceLoadScheduler to FrameResourceFetcherProperties. * Updates the features controlling frame throttle limits to use the new base::Feature and base::FeatureParam<> syntax. * Introduces a ResourceLoadScheduler::ThrottleOptionOverride enum that be set on the ResourceFetcher to override default ThrottleOption behavior. * Makes ServiceWorkerGlobalScope set a ThrottleOptionOverride, expose its new throttle limit, and update the scheduler to enable throttling while in the installing state. * Adds a significant new content browsertest that validates installing service workers throttle requests based on the feature and field trial param. Bug: 1035448 Change-Id: Icdbe82ef8db1573cd5acb26e53946166ac3bdbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015880 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#760548}
-
Steve Kobes authored
Also declare the capacity of the HeapVector for the attribution list, accept it in the LayoutShift constructor, and allow the binding layer to cache the FrozenArray. Bug: 1053510 Change-Id: If0dde547631d3fd95d087d7b8d2116055e382b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153002 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#760547}
-
Michael Ershov authored
For key_type == KEY_DEVICE the key_name_ is empty that causes stable device public key to be returned. To return public key for the newly generated key pair, key_name_for_spkac_ should be used instead. Bug: 1045895 Change-Id: I5fd16b4605a16aefa8e48394f86d6a99e51eb6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157070Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#760546}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: Ib8732b1732c3a92dc2a81eaf1e58fa063db45f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157007 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#760545}
-
Anastasiia Nikolaienko authored
Add SecondaryAccountConsentLogger to log the consent. Bug: 1043108, 1070656 Change-Id: Ife29a9a5fe16e0133a838324b210fe377f2e57d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115471 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#760544}
-
Jinho Bang authored
There is a bug that the save prompt is not shown if the password value is set as an empty value by JavaScript before form submitted. The bug is a regression since crrev.com/c/2029514 (M81 stable), but it is enough reasonable. So, this patch fixes FormParser instead of reverting the CL. In the current implementation, FormParser is treated as parsing error if |value| is empty. On the other hand, according to crrev.com/c/1404093, if |typed_value| is present, we preferentially use it rather than |value|. Similarly, this patch makes FormParser use |typed value| preferentially even if |value| is empty. Reproducible sites: - https://m.naver.com - https://zino.dev (This is a minimal test page I wrote) Bug: 1042196 Change-Id: I6652822fd7fe268b54647434c23c68d41abf5010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154644Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#760543}
-
Albert Chaulk authored
Bug: b/146151793 Test: None Change-Id: I5df1739ce29d9fec4480988ef3a405a93de9d1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072473Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#760542}
-
Xiaohui Chen authored
Bug: None Change-Id: I5d03b6ef8853bdb58b09335c591014cb573fdae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153885 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This CL introduces a BrowserContextHandle interface that provides a pointer to a native BrowserContext, and can be used to by components to take a BrowserContext reference within Java code. Clank's Profile class implements this interface, which allows us to pass a Profile to components that need a BrowserContext. In the future, WebLayer's Profile representation will also implement this interface. This change was motivated by the componentization efforts underway as part of the WebLayer project, several of which would benefit from a Java representation of the BrowserContext. Bug: 1058600 Change-Id: I65778791731c8d1f1529f06eab543774a60155ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130674 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#760540}
-
Ella Ge authored
To include extraCommand and ITrustedWebActivityCallback for location delegation. Bug: 1069506 Change-Id: I333a652db193167606360c7d4da7482e904b5f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130771Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#760539}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: If0ae65768b8b03077e06c70d37a221b7a4392971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157085 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#760538}
-
Nasko Oskov authored
The bindings stored on the RenderProcess object are not longer needed and can safely be removed. Once that is done, the MockRenderProcess becomes a trivial object providing no extra functionality, so this CL goes a step further and removes it as well. Bug: 1069939 Change-Id: I79e047faa0a418b7362a303b5d45210de394b97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145815 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#760537}
-
Ioana Pandele authored
If the saving of passwords is generally disabled from settings, or if the save passwords prompt can't be shown, the toggle should not be shown either. Bug: 1044930 Change-Id: I017ed562cfc1dc10eddf31306d0e7730cd5206a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149332 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760536}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: If22a9fad1fb5c1fa306e539ff8aa27c020f3ec5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156415 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Tim van der Lippe authored
This ports https://github.com/ChromeDevTools/debugger-protocol-viewer/pull/115 to Chromium. Note that the DOM domain depends on Page (as getNodeForLocation has a reference to Page), but if you would add this to the .pdl there would be a circular dependency between Page and DOM. Thus, the generated code does not compile if you add this dependency. This probably requires follow-up work to either remove the circular dependency or update the code generator to handle a circular dependency. Change-Id: I11b444c4af5498c83ca8471e507f93f5dd6485e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148744 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#760534}
-
Mohamed Amir Yosef authored
This method marks the currently submitted credentials to be not movable to the account store of the user with the passed GaiaIdHash. Bug: 1032992 Change-Id: Ic292de0adae08e0d5de95c09fca381603329c1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152588 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#760533}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: I3e650161f9647c8a3ac1d8ad03059fecc6cc8f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157125 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#760532}
-
Nicolas Ouellet-Payeur authored
Previously, the tests waited for action_timeout(), to wait for LBS to load the rules and write some files. As expected, this is fairly flaky, and it slows down the tests. Now, `BrowserSwitcherService' exposes a new event for testing, which fires once LBS has loaded the rules. This should reduce flakes by listening for the event instead of using an unreliable timeout. Also rewrote some tests in a synchronous style, which improves readability. Bug: 1044619, 1070400 Change-Id: If1a2093cfe3bface73a46896ff2bc95b80ab2f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152885 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#760531}
-
Alexander Timin authored
Replace WebContentsImpl::GetUkmSourceIdForLastCommittedSource with a RenderFrameHost-based method. - RenderFrameHost-based method works correctly for non-current frames, unlike WebContentsImpl-based method. - GetPageUkmSourceId (page load == main-frame committed cross-document navigation) should be more intuitive than GetUkmSourceIdForLastCommittedSource. BUG=1061899 R=alexmos@chromium.org,rkaplow@chromium.org TBR=alexmos@chromium.org CC=bmcquade@chromium.org,csharrison@chromium.org Change-Id: I66d1520fbcb8ea4b59d7d0c3cbcbdbfa16516789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132393Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760530}
-
Elly Fong-Jones authored
The ui::TouchEditable menu recently changed to use its own constants for command IDs rather than abusing IDS constants; the uses of these constants in //components/pdf were missed. Bug: 10707568 Change-Id: I5ccd267b032bc4dfe4841efd6203dc53b6fddb96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154908Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760529}
-
Francois Doray authored
This is recorded to determine how often the size of a sequence grows above 10000 tasks, and whether it is reasonable to upload a process dump when that happens. Bug: 1071862 Change-Id: Ia0e7ea5a48d5086bfd4c7aa9c121fa3ccb381ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154845 Auto-Submit: François Doray <fdoray@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#760528}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: I34bdf1c886255c953706e98910abdb4204efd2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157068 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#760527}
-
Dave Tapuska authored
This change moves LayerTreeView into blink. The compositing tree is now owned by the WidgetBase which is a member of all widget implementations. RenderWidget will have a handle to the LayerTreeHost but ownership of the pointers now resides in blink. Change-Id: I00a629fef2a7ca6630625ff55ad6ce47b69ce0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076058Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#760526}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: I8278d85744f0cb92c11e1b0b3c00eae6ad62ee87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157066 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#760525}
-
Xida Chen authored
The frame_sequence_tracker.h file has 3 classes in it: 1. FrameSequenceMetrics: this class keeps track of necessary info to report throughput metrics. 2. FrameSequenceTracker: this class owns a FrameSequenceMetrics object. It tracks various frame productions and record these info in the FrameSequenceMetrics object. 3. FrameSequenceTrackerCollection: this class contains a set of FrameSequenceTrackers. Other high level classes like LayerTreeHostImpl just talk to FrameSequenceTrackerCollection. This CL breaks the file into 3 classes, to make it more obvious. Basically, frame_sequence_metrics.h is the lowest level and contains all fundamental types and operations. Bug: None Change-Id: I94ac5902ab9f4b6e5857b8c6878cbed2916fb5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155213Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL removes logging of grouping metrics that is based on |icon_url_for_uma|, mostly provided by FaviconCache. This is a prefactoring CL before removing the FaviconCache completely. Bug: 978775 Change-Id: If33ab5f6c73acba5acf5239556d66e95b69f47a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156489 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760523}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/devtools. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=pfeldman@chromium.org Bug: 714018 Change-Id: I8247fc695ed397a148f7e42f3d2c6529c03673a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132213 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: -
Becca Hughes authored
This reverts commit ae8f4133. Reason for revert: Crashes Original change's description: > [Media History] Retain refs and remove fatal > > Retains refs to the store when using callbacks > and also change the fatal -> error for sql > errors since it is making bots crash. > > Change-Id: Ie27d43f2044700e1b299d2a34406b1eb2fc9412b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149405 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759814} TBR=beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib90f55a1176af4ace35d0e421fc5b0ba667ccadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157165Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#760521}
-
Bo Liu authored
Read system setting and set preferred_color_scheme. Refactor code a bit to mirror password_echo_enabled. Same as password_echo_enabled, check system changes when fragment becomes foreground. Bug: 1070701 Change-Id: Iafcbf6886f8d2f1be474d87759d546182be1562f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153829Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760520}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4cd3c7a92530..be6eaf0a3d07 Created with: gclient setdep -r src-internal@be6eaf0a3d07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: Iea5caa4d72518b047e60f1e0f411b0998f94b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156443Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760519}
-
Peng Huang authored
There is an issue in NVIDIA driver, vkCreateSwapChianKHR() will fail with sandbox on Windows, if the gpu::SurfaceHandle(HWND) is created by browser process. Workaround the issue, by creating a child HWND use to create VulkanSurface. Bug: 962633,1068742 Change-Id: I471db2e1db673fece37a5746b5e42a8cf9d12965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152707 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#760518}
-
Brian Malcolm authored
BUG=950273 R=poromov Change-Id: I9ca6bec9a05b179d8cfe31c5f4a78a76bb20cbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153764Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#760517}
-
Pablo Ceballos authored
BUG=b:151160990 TEST=chromeos_unittests --gtest_filter="IpPeripheralServiceClientTest.*" Change-Id: I7ae2cd64a7c0dc4ae927142e015a8930965462d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134805 Commit-Queue: Pablo Ceballos <pceballos@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Ted Choc authored
BUG=1071247 Change-Id: I145041673b9e9779d2a342178cf26146da12cc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156108Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760515}
-
