- 14 May, 2018 40 commits
-
-
Ryan Sleevi authored
//components/certificate_transparency is logically stuff that would belong in //chrome/browser/net ideally, and //net potentially in the much longer term, but for various reasons lives in between. Update the OWNERS to reflect that BUG=none Change-Id: I1046e6cda5b9233d3aa20cabb77f69fe79cbada1 Reviewed-on: https://chromium-review.googlesource.com/1055737Reviewed-by:
Eran Messeri <eranm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558360}
-
erikchen authored
This CL is a refactor with no intended behavior change. Previously, observers were using the |index| parameter and comparing against TabStripModel::active_index() to determine if the detached tab was active. This relies on assumptions about the timing of TabDetachedAt(), which will soon be changed. Bug: 842194 Change-Id: I282bcd42a17701f8f3347d535b2bebfa6d7fd8fa Reviewed-on: https://chromium-review.googlesource.com/1055748Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558359}
-
Corentin Wallez authored
https://chromium-review.googlesource.com/c/chromium/src/+/655801 modified the code tweaking the GPU Info with driver-provided information and added a an ASSERT that didn't exist previously. It gets triggered probably because the driver returns information that doesn't match our SystemInfo. BUG=chromium:842650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ife295b97d050814d6173ca96626fe1cc7c4bd3a5 Reviewed-on: https://chromium-review.googlesource.com/1057421Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558358}
-
Peng Huang authored
Bug: 644851 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5457797bc7166e9af193c3ff3f248c146833c58d Reviewed-on: https://chromium-review.googlesource.com/1055615Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558357}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d936a701..d58b7e0b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5bc1844c2601ac3f373d7b5c071be58252a9c7ec Reviewed-on: https://chromium-review.googlesource.com/1057463Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558356}
-
Bailey Berro authored
Adds username and password as parameters to SmbSerice::Mount and the corresponding internal functions. Bug: chromium:757625 Change-Id: I8e5f9ea4f9779746703d066098408afc4489f620 Reviewed-on: https://chromium-review.googlesource.com/1054690 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558355}
-
Eugene But authored
Wait until the navigation is committed before stopping the load. Bug: 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f8d65bd2ee6e4a6617257ad83e19cc9a9ba5c2e Reviewed-on: https://chromium-review.googlesource.com/1054707Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558354}
-
https://pdfium.googlesource.com/pdfium.git/+log/e20f0c4938f8..22c24441a3a4 $ git log e20f0c493..22c24441a --date=short --no-merges --format='%ad %ae %s' 2018-05-14 npm Merge some values of JBig2_Result Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idcc8a73f0133d64caa10b840b94e93eca5b24ea5 Reviewed-on: https://chromium-review.googlesource.com/1057690 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558353}
-
Emily Hanley authored
Bug: 840427 Change-Id: I80c13fefb4e5594ad29a6511845415584d7ea11a Reviewed-on: https://chromium-review.googlesource.com/1047854Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#558352}
-
Brian Osman authored
There are only 7 ColorFormat values. Bug: chromium:842483 Change-Id: I92e10ed9147b8df607fd5ea62e9a0a5f2300c14c Reviewed-on: https://chromium-review.googlesource.com/1057452Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#558351}
-
Charlie Andrews authored
R=nednguyen@chromium.org Bug: 842232 Change-Id: Idf15bbf2fe41f79b173b79ab5d290002d8ef65c7 Reviewed-on: https://chromium-review.googlesource.com/1057828Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#558350}
-
Sarah Hu authored
This contains the fix for Msan failures. This CL adds some basic fingerprint UI to views lock screen to support fingerprint fishfood. The detailed specs are not ready and may be subject to change. So it may need to be polished in the future for adding animation, adjusting styles etc. Current mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCHm5Lyh8lQ6SZ3vjzwd3Uo8wMSJbxAVNpw TBR=tsepez@chromium.org Bug: 835357 Change-Id: I5daed01a18b2235e8331c3d48bbfe5b63c491672 Reviewed-on: https://chromium-review.googlesource.com/1047958Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#557254} Reviewed-on: https://chromium-review.googlesource.com/1054091 Cr-Commit-Position: refs/heads/master@{#558349}
-
Michael Giuffrida authored
Adds an ML model to score tabs based on whether they will be reactivated. Currently this is only used in tests; a future CL will add an experiment to use these scores as part of the tab discarder's tab selection algorithm. The model includes hard-coded weights generated by tf.native. This is documented in tab_ranker/native_inference.md. Bug: 836898 Change-Id: I6445de4d80fa5c5c1487d4fa2a90e9f118f9c691 Reviewed-on: https://chromium-review.googlesource.com/1028583Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#558348}
-
James Cook authored
Previously we were using the "root location" as the screen coordinates for events sent to pointer watchers. This was sometimes incorrect on secondary displays. Instead, plumb around the display id for the event and compute the correct screen coordinates in the //ui/views/mus layer. This is needed to get the touch hud app working with the new Window Service on Chrome OS. TBR=tsepez@chromium.org Bug: 608547, 840380 Test: added to views_mus_unittests and aura_unittests Change-Id: I46e90b76ec1562a5277a5679d8a4a9d64fd4333c Reviewed-on: https://chromium-review.googlesource.com/1056205Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#558347}
-
Ian Vollick authored
Like bindings, we now recur updating anims if we are or will be seen. Also removes flag to disable truncated treewalks. Bug: 842644 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I26ac8a140c86b3ef223d00677a710709ca207cea Reviewed-on: https://chromium-review.googlesource.com/1057347 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#558346}
-
Emily Hanley authored
Bug: 840427 Change-Id: Icd9263f3f03ef9f38a4bc2fbc52ea5da28e520a2 Reviewed-on: https://chromium-review.googlesource.com/1057435Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#558345}
-
Wez authored
This test previously used the WaitingURLFetcherDelegate helper's APIs to run a RunLoop on the main thread, and wait for it to be quit by a fetch completing on the Sequence. However, this violated the constraint that the RunLoop may only be created, run and destroyed from the same thread. Bug: 729716 Change-Id: I4b699d17da7888527ef8d22f8e73a7f91236ef23 Reviewed-on: https://chromium-review.googlesource.com/1056265 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558344}
-
xlai authored
This CL uploads the markdown doc and diagrams. It does not cause behavior change to code. Bug: None Change-Id: Ica44a4a82c8af951b5ad6d79e760ebeb0cceae71 Reviewed-on: https://chromium-review.googlesource.com/1054165Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558343}
-
Dirk Pranke authored
If //build/vs_toolchain.py is changed (or any file it imports, including gn_helpers.py), we should bypass `analyze` on the trybots because we may need to rebuild everything. (Technically, we only need to do this on Win hosts, but we don't have a good way of filtering that at the moment). This is needed when updating the VS toolchain, including SDK updates. This change makes it so that a full build will be requested. The build will be a NOP unless the toolchain has actually changed, in which case the changed command lines will make all of the compile commands dirty. Bug: 842111 Change-Id: I2222798c7c8fd691383a0eca1414d1e8afdb55f8 Reviewed-on: https://chromium-review.googlesource.com/1055869Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558342}
-
Hans Wennborg authored
The test does pass on some bots, e.g. [1], and it's not clear why it was being excluded. If there's a legitimate reason for it not running on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the test to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: Ib7fdf46abf1ddf6b9fdb63c908c1f35040e4d468 Reviewed-on: https://chromium-review.googlesource.com/1057727 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558341}
-
Alexander Timin authored
Do not apply resource load throttling to background pages with active websocket or webrtc connection to prevent breakage and disconnects. Change-Id: Ifd603a2b55cae415b113095df9145217da2b4196 Reviewed-on: https://chromium-review.googlesource.com/1042313Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558340}
-
Bailey Berro authored
The username and workgroup of ChromAD users will now be passed to the SmbProvider Mount function in the smbprovider Dameon. The ParseUserPrincipalName function and corresponding tests are adapted from AuthPolicy's SambaHelper. BUG=chromium:757625 TEST=unittests Change-Id: Ia25396224d9c873161adb2da3741c54cdd1209cf Reviewed-on: https://chromium-review.googlesource.com/1052914Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#558339}
-
Sahel Sharify authored
This will be helpful in narrowing down the root cause of wheel scroll issues. Change-Id: Icf0e9e157f7d9a5224652ecc51d99f22008de8fb Reviewed-on: https://chromium-review.googlesource.com/1054495Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558338}
-
Benoit Lize authored
Only sends page load metrics to sessions that are allowed to get them. Bug: 842648 Change-Id: Ifc82941096d02f448af261656811aca4c9097b2b Reviewed-on: https://chromium-review.googlesource.com/1057232 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558337}
-
Joe Downing authored
We've received 3 LGTMs for our blink I2S so I'm enabling the API: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/isXS3f3Tqo8 I am marking the API as 'stable' for M68 and will remove the runtime flag after the next branch point. BUG=680809 Change-Id: If805053651d5ffb3d9963bf176faf9c67dfa5e40 Reviewed-on: https://chromium-review.googlesource.com/1054329Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#558336}
-
John Z Wu authored
These tests were flaky because submitting a form causes a navigation on top of loading the test page. These two navigations happening at the same time can cause some race conditions ending in a DCHECK. By directing the form to 'about:blank', it avoids the extra navigation. Bug: 834660,842122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If535a18fdc277d0c6766967cdbeea2f85fa415dc Reviewed-on: https://chromium-review.googlesource.com/1056411 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558335}
-
Chris Kuiper authored
This is a temporary change until P becomes available which makes this a public function. Bug: internal b/76437011 Test: verified via volume table dump at Cast startup. Change-Id: Ie3d736f70429147dfd30c4abb8f9311c0d82c83f Reviewed-on: https://chromium-review.googlesource.com/1031100Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#558334}
-
Charlie Harrison authored
It also looks like we can remove the ShouldBeginRequest from RDHD, which I've done here. TBR=pasko@chromium.org Bug: 841473 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I238fe589cc192ccec47242350e6bc847f8da65cc Reviewed-on: https://chromium-review.googlesource.com/1052889Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558333}
-
Wez authored
ResourceDispatcherHostImpl is a UI-thread-owned class which also does work on the IO thread. It is built to intrinsically rely on being destroyed only after all threads but the main thread have been torn- down - the BrowserMainLoop invokes a Shutdown() API which posts a task to perform teardown of state which is used on the IO thread, which is thereby guaranteed to have run before the object is deleted. Internally a WeakPtrFactory is also used, to ensure that replies posted to the object on the IO thread are dropped if the object has already performed its IO-thread teardown. However, although the WeakPtrs were bound to tasks run on the IO thread, the factory itself was being left to implicitly InvalidateWeakPtrs() on destruction (i.e. on the UI thread). This CL adds explicit InvalidateWeakPtrs() on the IO thread, during the IO-thread teardown task. Bug: 729716 Change-Id: Idce31d52476df529dd5a877dc06747426c4e19c6 Reviewed-on: https://chromium-review.googlesource.com/1056255 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558332}
-
Alexandros Frantzis authored
Add an unowned GpuFence parameter to the GLImage::ScheduleOverlayPlane method and forward it to internal consumers (e.g., NativePixmap) where needed. Bug: 828393 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I195f4ee9d0a9af886cb12ce27d2ce26ebd47684a Reviewed-on: https://chromium-review.googlesource.com/1021511Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#558331}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5140f9a8e424..4c3cb3767f5a $ git log 5140f9a8e..4c3cb3767 --date=short --no-merges --format='%ad %ae %s' 2018-05-13 reed implement SkScalar versions in terms of float versions 2018-05-14 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 5fd1cfaae..2a0def7f6 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ib7de6e241cc17f43b75a2181d6d3a3efd3e229f9 Reviewed-on: https://chromium-review.googlesource.com/1057361Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558330}
-
Rakina Zata Amni authored
We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the GetNearestFindResult function to mojo. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Mojoify FindInPage::FindMatchRects (parent of this CL) crrev.com/c/1049770 Add FindInPage mojo interface with ClearActiveFindMatch crrev.com/c/1027393 Future CLs: Mojoify other find-in-page functions Bug: 819919 Change-Id: Id4852ed3902128594f3a29f7aa55d80d7f1f9a06 Reviewed-on: https://chromium-review.googlesource.com/1051143 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#558329}
-
Adithya Srinivasan authored
Bug: 781655 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I1345c5084f5dfe6788710d96d37103125f6cb6c0 Reviewed-on: https://chromium-review.googlesource.com/1036230Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#558328}
-
Friedrich Horschig authored
With this CL, the KeyboardAccessory is wired up to add icons of provided tabs to a TabLayout that replaces the previous Recyclerview. The existing LazyViewBinder is used to simplify the old implementation. Bug: 828832 Change-Id: I60569a3be6c99c23cc17b9838967ef3ab0a1c8df Reviewed-on: https://chromium-review.googlesource.com/1047669 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#558327}
-
Alexandr Ilin authored
The autocomplete predictor database contains entries related to a page the user has visited even after this page was removed from the history. These entries are cleaned up after only the startup. This CL adds this clean up after every removal from history. Bug: 838897 Change-Id: Ia56de868cddf8bb0a28d288265b884c0e67458d5 Reviewed-on: https://chromium-review.googlesource.com/1043868 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#558326}
-
Gauthier Ambard authored
This CL adds the accessibility labels and ordering for the popup menus. Bug: 833425, 842032, 831587 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I06bd6821144aee96c47374fd44e4a811831fc704 Reviewed-on: https://chromium-review.googlesource.com/1057307 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558325}
-
François Beaufort authored
As part of the origin trial, we should record usage with UseCounter, as that can be automatically monitored by the origin trials infrastructure. Bug: 806249 Change-Id: I7978d33f57c9d31ecc2b18a410c66475f3971ddb Reviewed-on: https://chromium-review.googlesource.com/1055396 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#558324}
-
Liquan(Max) Gu authored
User Timing L3 allows user to use arbitrary timestamps and add custom information for performance timeline (performance.mark and performance.measure). This CL implements the performance.measure part of Custom User Timing, Basically, it allows custom start and end timestamps of performance.measure, and support passing in custom details via an overloaded API. The new feature is hidden behind a runtime-enabled-flag called "UserTimingL3". This feature is set to <Missing> status. Bug: 758385 Change-Id: I5722f5e99a0188e3a5b191bf3bfe007e8b274086 Reviewed-on: https://chromium-review.googlesource.com/871507 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558323}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/2157d8fa6f7e..9e345c911714 $ git log 2157d8fa6..9e345c911 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 alan.coopersmith Further fix to visibility flag testing with Solaris Studio compilers. 2018-05-08 wl [autofit] Avoid potential SEGV if running out of memory. 2018-05-07 madigens CMake: Allow using project as subfolder in other project 2018-05-07 wl [build] Suppress configure's `nothing to be done' message. 2018-05-04 mpsuzuki Support symbol visibility features of Sun / Oracle C compilers. Reported by Kiyoshi Kanazawa: https://lists.gnu.org/archive/html/freetype-devel/2018-05/msg00008.html Thanks to the suggestions by Alexei and Alan Coopersmith. 2018-05-02 madigens Unbreak CMake Windows installation 2018-05-02 wl Remove FT_CONFIG_OPTION_PIC and related code. 2018-05-01 wl * Version 2.9.1 released. ========================= 2018-04-26 wl Another fix for handling invalid format 2 cmaps. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1084 Change-Id: Id8538bd3a13b2b8dd504a7de3d737b13104e7c7b Reviewed-on: https://chromium-review.googlesource.com/1055728Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558322}
-
Ryan Sleevi authored
https://crrev.com/550137 introduced base::data(), along with a specialization for strings to return mutable pointers. Update callers of base::string_as_array() to use base::data() instead. Note that this does come with an observable behaviour change: string_as_array() returns nullptr for empty strings, while base::data() returns the pointer to the NUL terminator (in line with std::data()). However, this can be observed to be safe from the existing callers, due to the preceding resizes that ensure non-empty() strings, or the existing logic to handle empty strings. Bug: 828324 TBR=caitkp@chromium.org, lazyboy@chromium.org, miu@chromium.org, sergeyu@chromium.org Change-Id: I1fb5824b7115ff2b9ebf032f74a860e4cf3f52c6 Reviewed-on: https://chromium-review.googlesource.com/1056014 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#558321}
-