GitLab

Revert of Add debug information for crbug.com/289715 (patchset #5 id:80001 of https://codereview.chromium.org/810883007/)

Reason for revert:
Remove debugging information that was collected for crbug.com/289715

Original issue's description:
> Add debug information for crbug.com/289715
>
> Add temporary debugging information to determine whether a callback happens
> after the targeted URLRequestHttpJob was already deleted or whether a callback
> happens after its transaction was deleted.
>
> BUG=289715
>
> Committed: https://crrev.com/aec005dce78bc2c2513f4e49343b8baad751a852
> Cr-Commit-Position: refs/heads/master@{#310822}

TBR=mmenke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=289715

Review URL: https://codereview.chromium.org/907033002

Cr-Commit-Position: refs/heads/master@{#315298}

They can already do the same via the new user manager.

Also, allow child users to edit their name via about:settings -> Edit. Same reason.

BUG=456744

Review URL: https://codereview.chromium.org/872263005

Cr-Commit-Position: refs/heads/master@{#315297}

BUG=437566

Review URL: https://codereview.chromium.org/900203003

Cr-Commit-Position: refs/heads/master@{#315296}

BUG=436912

Review URL: https://codereview.chromium.org/770563003

Cr-Commit-Position: refs/heads/master@{#315295}

BUG=453704
TEST=place small image on Drive and Downloads, and check if the thumbnail box/circle
is filled in grid view and list view.

Review URL: https://codereview.chromium.org/904393003

Cr-Commit-Position: refs/heads/master@{#315294}

Move the chrome.documentScan extension API from chrome/ to extensions/.

BUG=455695

Review URL: https://codereview.chromium.org/899523004

Cr-Commit-Position: refs/heads/master@{#315293}

BUG=456547

Review URL: https://codereview.chromium.org/906223003

Cr-Commit-Position: refs/heads/master@{#315292}

BUG=302040
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/899973006

Cr-Commit-Position: refs/heads/master@{#315291}

mojo redefines ArraySizeHelper in the mojo namespace. When arraysize is used
in the mojo namespace, with both version in scope, the compiler, on android, is complaining that the reference is
not unique. To prevent this, qualify the usage of ArraySizeHelper in
base/macros.h

Review URL: https://codereview.chromium.org/804023002

Cr-Commit-Position: refs/heads/master@{#315290}

Design doc: https://docs.google.com/document/d/1Ms5wHyGtVzdH0MOF46olgnTj4k9opQGYzMSrk-LJckM

Based on fhorschig's https://chromereviews.googleplex.com/108977013/

BUG=443606

Review URL: https://codereview.chromium.org/769153007

Cr-Commit-Position: refs/heads/master@{#315289}

Convert webstorePrivate functions from ChromeAsyncExtensionFunction (which is deprecated) to UIThreadExtensionFunction.

Review URL: https://codereview.chromium.org/885443010

Cr-Commit-Position: refs/heads/master@{#315288}

Now that we're setting the 'skip_zero_click' flag in 'notifySignedOut',
we ought to respect it when generating the list of items for 'request()'

BUG=450581
R=vabr@chromium.org, vasilii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/896803003

Cr-Commit-Position: refs/heads/master@{#315287}

Current implementation causes same multiple listeners wait for an event after we load page several times. E.g. in ChromeOS: add user->cancel->add user. After login we get multiple identical messages.

BUG=426316
TEST=manual

Review URL: https://codereview.chromium.org/905653003

Cr-Commit-Position: refs/heads/master@{#315286}

It should not be necessary to declare this variable at the top of this
gyp file. If it is necessary to declare this variable, this is not the
place to declare it anyway (which also looks pretty random).

BUG=None
TEST=components_unittests
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/866553004

Cr-Commit-Position: refs/heads/master@{#315285}

 * Prefetch metadata before entries are added to file list.
 * Notify the cache of entry changes.

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/904003002

Cr-Commit-Position: refs/heads/master@{#315284}

BUG=402344
TEST=select some items, drag the separator for navigation list, and check that the 'n files selected' label is synced with the separator's position.

Review URL: https://codereview.chromium.org/904403002

Cr-Commit-Position: refs/heads/master@{#315283}

Revert of Copy the contents of the ASan/Win blacklist to work around http://llvm.org/PR22431 (patchset #2 id:20001 of https://codereview.chromium.org/886073003/)

Reason for revert:
r315281 rolls ASan/Win past LLVM r228156, which includes the fix for PR22431

Original issue's description:
> Copy the contents of the ASan/Win blacklist to work around http://llvm.org/PR22431
>
> BUG=454283
>
> Committed: https://crrev.com/7949a66919a6d288451e3a818a843ea39025bd74
> Cr-Commit-Position: refs/heads/master@{#314139}

TBR=glider@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454283

Review URL: https://codereview.chromium.org/904413003

Cr-Commit-Position: refs/heads/master@{#315282}

This should fix issue 453209 and give better diagnostics for issue 452788

BUG=453209,452788,345874
TBR=rnk@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/908763003

Cr-Commit-Position: refs/heads/master@{#315281}

R=vabr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/913433002

Cr-Commit-Position: refs/heads/master@{#315280}

Revert of Revert of Roll android_tools f6e2370:2a860d8 (patchset #1 id:1 of https://codereview.chromium.org/890633003/)

Reason for revert:
Builders now updated

Original issue's description:
> Revert of Roll android_tools f6e2370:2a860d8 (patchset #2 id:20001 of https://codereview.chromium.org/900273003/)
>
> Reason for revert:
> Builders now updated
>
> Original issue's description:
> > Roll android_tools f6e2370:2a860d8
> >
> > This rolls in an update to android_tools.gyp that provides targets for
> > Google Play Sevices libraries.
> >
> > BUG=450675
> >
> > Committed: https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d
> > Cr-Commit-Position: refs/heads/master@{#315037}
>
> TBR=mcilroy@chromium.org,rmcilroy@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=450675

TBR=mcilroy@chromium.org,rmcilroy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450675

Review URL: https://codereview.chromium.org/908843002

Cr-Commit-Position: refs/heads/master@{#315279}

BUG=450356
R=blundell@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/904443003

Cr-Commit-Position: refs/heads/master@{#315278}

Revert of DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback (patchset #1 id:1 of https://codereview.chromium.org/892413007/)

Reason for revert:
Remove DumpWithoutCrashing() from URLRequestHttpJob again.

See crbug.com/432398 for stacktraces uncovered by this.

Original issue's description:
> DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback
>
> BUG=432398
>
> Committed: https://crrev.com/cb3d31dcc6d70edcf3f53e028fe9ec650f228c64
> Cr-Commit-Position: refs/heads/master@{#315052}

TBR=mmenke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=432398

Review URL: https://codereview.chromium.org/906223002

Cr-Commit-Position: refs/heads/master@{#315277}

Cr-Commit-Position: refs/heads/master@{#315276}

Since the scores come from an external service, they should be forced
into the [0, 1] range, instead of assuming they are in that range. (We
cannot accept any arbitrary score, because then that would allow the
service to prioritize its results over other services, and would also
break the "known results" prioritization scheme.)

BUG=456641

Review URL: https://codereview.chromium.org/906133003

Cr-Commit-Position: refs/heads/master@{#315275}

Update app list background color to match new mocks.

BUG=442021

Review URL: https://codereview.chromium.org/907813002

Cr-Commit-Position: refs/heads/master@{#315274}

This CL makes the start page fully fill the app list bounds. This will
ensure the start page WebContents has maximal space. In order to do this,
this CL decouples code from some layout assumptions and uses more
future-proof calculations instead.

BUG=453205

Review URL: https://codereview.chromium.org/889403005

Cr-Commit-Position: refs/heads/master@{#315273}

This CL fixes an issue with the app list not showing the start page
logo in ChromeOS Guest Mode. This was happening because no start page
service was being created for incognito contexts.

This will also cause voice search to be enabled in the app list in
Guest Mode.

BUG=440484

Review URL: https://codereview.chromium.org/879033003

Cr-Commit-Position: refs/heads/master@{#315272}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/45af7a2..465217f

TBR=

Review URL: https://codereview.chromium.org/906923002

Cr-Commit-Position: refs/heads/master@{#315271}

This CL updates the experimental app list's apps grid view layout to
precisely match mocks. The experimental app list is now 768x570.

BUG=442022

Review URL: https://codereview.chromium.org/898253002

Cr-Commit-Position: refs/heads/master@{#315270}

A lot of the code is now much more readable.

Review URL: https://codereview.chromium.org/911483002

Cr-Commit-Position: refs/heads/master@{#315269}

BUG=

Review URL: https://codereview.chromium.org/898263002

Cr-Commit-Position: refs/heads/master@{#315268}

BUG=chrome-os-partner:36486
TEST=none

Review URL: https://codereview.chromium.org/910613002

Cr-Commit-Position: refs/heads/master@{#315267}

There is no reason for this method to be non-const.

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/898273002

Cr-Commit-Position: refs/heads/master@{#315266}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5bb4863..45af7a2

TBR=

Review URL: https://codereview.chromium.org/885683006

Cr-Commit-Position: refs/heads/master@{#315265}

This CL fixes an issue with the experimental app list search where the
app results would sometimes not show up. This was being caused by the
display type not being updated when the result was copied from the
mixer, causing recommendation results not to change into tile results.

BUG=456060

Review URL: https://codereview.chromium.org/909773002

Cr-Commit-Position: refs/heads/master@{#315264}

Review URL: https://codereview.chromium.org/906913002

Cr-Commit-Position: refs/heads/master@{#315263}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b486083..e6b1a60

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/911493003

Cr-Commit-Position: refs/heads/master@{#315262}

Revert of [Chromoting] Remove wildcard ('*') from remoting_all target. (patchset #8 id:140001 of https://codereview.chromium.org/896743004/)

Reason for revert:
It cause ChromiumOS.Chromium and PFQ bots to fail. The reason might because chroot didn't have "dpkg-architecture" command. The correct solution might be add "dpkg-architecture" command to chroot. But this CL currently break PFQ and a bunch of bots. So revert it for immediate fix.
See crbug.com/456491

Original issue's description:
> [Chromoting] Remove wildcard ('*') from remoting_all target.
>
> Support for the wildcard is going away in GN, so this helps prepare for the transition away from GYP.
>
> This cl adds dummy targets so that that logic for when the proper targets should be build can be kept in the platform-specific files.
>
> Some of the conditions in the host gyp files needed to be restructured so that the dummy targets would be defined only when necessary.  The updated conditions caused a lot of lines to be re-indented, but the target definitions are the same (except for the new dummy targets).
>
> BUG=
>
> Committed: https://crrev.com/9fb75ed89c0ae4ced679576f9cf030cc8c30e928
> Cr-Commit-Position: refs/heads/master@{#315150}

TBR=kelvinp@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/905223002

Cr-Commit-Position: refs/heads/master@{#315261}

This CL animates the app list search box shadow as it transitions from
any page to the search result page.

BUG=453653

Review URL: https://codereview.chromium.org/889593003

Cr-Commit-Position: refs/heads/master@{#315260}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/360c0d1..5bb4863

TBR=

Review URL: https://codereview.chromium.org/897493003

Cr-Commit-Position: refs/heads/master@{#315259}