- 20 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82f373c0d713..2d2f82c00aeb 2020-10-20 brianosman@google.com Always declare sk_FragColor in GLSL, even if unused 2020-10-20 ethannicholas@google.com added SkSLNodeArrayWrapper 2020-10-20 reed@google.com update dox for drawPaint 2020-10-20 johnstiles@google.com Wrap built-in symbol tables during inlining. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I29b88419a03de489725889c724b0aa4bec7809db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487912Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819160}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c5a7978..a08f3d9f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id27a730ec9aefd211354b6817ef012c4e94ddbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488367Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819159}
-
yilkal authored
The description and mock can be seen in the comments in the bug report. Bug: 1134567 Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#819158}
-
Xida Chen authored
There is a test that is already removed, the code for disabling the test is still there. This CL removes the code that disabling the test. Bug: 728034 Change-Id: I47a6c3e98e8fee64ad776e4ff2c230d0f2733a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488121Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#819157}
-
Nate Chapin authored
Change-Id: I906080d37902a87ebbe22c52503972928c10e7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481786 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Sorin Jianu authored
The current limit is too low and the component build fails parsing the file when the updater is invoked with --install --install-from-out-dir Bug: 1140730 Change-Id: I297d1e1ddf1435faa9304a7084c84a7170227b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488714Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819155}
-
Giovanni Panaro authored
Bug: 1114103 Change-Id: I9fdb97d06cadc5dde6672e9df7e2baca35ab0b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450711 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#819154}
-
Yulun Wu authored
Fix bug where login shelf buttons background color constant and darken wallpaper background color constant were combined incorrectly. Bug: 1137798 Change-Id: Ib0584a990bcb40c4886ede2e402d2f8864705597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487831Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819153}
-
Jonathan Ross authored
Currently we are hitting shard timeouts for angle_perftests on the Android FYI 64 Perf (Pixel 2) bot. Even when we pass it's barely under the 20 minute shard time. This adds a 4th shard for just that configuration. TEST=angle_perftests Bug: 1140626 Change-Id: Ib87d323a28e7c7703bc1af77246a89f2d8087413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488044Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#819152}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/df17a76102df..ee18f390eead 2020-10-20 bclayton@google.com LLVM: Replace legacy ORC JIT with new API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If6693aaec84dcf0a25b89661998ba517639fa4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488583Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c55cd6b43d55..637786a9a862 2020-10-20 cnorthrop@google.com Tests: Add Arena of Valor trace 2020-10-20 geofflang@google.com Generate CONTEXT_LOST errors on every GL call. 2020-10-20 geofflang@google.com Add Queries and Setters for resource initialization state. 2020-10-20 courtneygo@google.com Vulkan: functionally complete worker thread 2020-10-20 jmadill@chromium.org Fix missing validation cache update on VAO binding. 2020-10-20 jmadill@chromium.org Suppress timing out GLES 31 tests on GL/Linux. 2020-10-20 syoussefi@chromium.org Vulkan: Pull generic SPIR-V transform functionality into base class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132514,chromium:1137241,chromium:1139398 Tbr: jonahr@google.com Test: Test: angle_perftest --gtest_filter="*arena*" Change-Id: I5c86409d0607b087df8fc86d0e6f5c4386b6d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488022Reviewed-by:
-
phillis authored
InstallOsHooks after InstallWebAppFromInfo is finished for apps that are drag installed from chrome://apps page. Bug: 1138816 Change-Id: Icdd3ee98bd93da20e73633ad602645896535f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485048Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819149}
-
Dave Tapuska authored
Checking that the fullscreen element is non-null implicitly means that fullscreen has already been granted. Verified via: out/Release/chrome --register-pepper-plugins="out/Release/libppapi_example_mouse_lock.so;application/x-ppapi-example-mouse-lock" BUG=1097816 Change-Id: I125da5db68346f5cc90279110ce676c70cf27c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488124 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#819148}
-
ckitagawa authored
This CL attempts to fix a crash that was happening when attempting to use a render frame host that might have been deleted or was in the process of being deleted. Bug: 1140163 Change-Id: I9abeaad7c84fa0409c5c152e69610da1db4b44c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485585 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819147}
-
Yue Ru Sun authored
Bug: 873866 Change-Id: I36b283ee1f2b7dbe878834c2083a1383fda6ddca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471799Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#819146}
-
Vitaly Buka authored
This experimental build option to mark binaries as compatible with Shadow Stack of Control-flow Enforcement Technology (CET). THe option is not any close to enable in official builds, it's here for convenice of evaluation. As it passes base_unittests and components_unittests. Bug: 1136224 Change-Id: I6fcd61c2e76066b444cc37c88228273838300243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454988Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#819145}
-
Ian Struiksma authored
This causes no change in generated json, but allows the migration to newer win10 version to be more straightforward. Bug: 1124829 Change-Id: I483eedee77cb247d81fd32ec874675f53c26b18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488679 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#819144}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/299fe92af960..e03bf7b4af92 2020-10-20 thestig@chromium.org Prevent undefined behavior in CFX_DIBBase::GetOverlapRect(). 2020-10-20 tsepez@chromium.org Make core/fxge/{fx_dib.h,dib/fx_dib_main.cpp} consistently named. 2020-10-20 tsepez@chromium.org Move some FXDIB_Format functions from .h to .cpp file 2020-10-20 tsepez@chromium.org Make FXDIB_format an enum class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1097499 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3388f2c572925d3853eb8b3cf8c6e09c8df3c3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487811Reviewed-by:
-
Michael Irani authored
If you navigate to "Manage what you sync" page and then back, the arrow pointing back to "Manage what you sync" is not highlighted when in ChromeVox mode Steps: 1. People 2. Sync and Google Services 3. Manage what you sync 4. Back button Bug: 1029954 Test: Manual Change-Id: I92fc08efdb1f2ea5f1e06232e08df23ab6f03910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488603 Auto-Submit: Michael Irani <michaelirani@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819142}
-
Katie Dillon authored
[scheduling] Don't pass a queue to record task time on budget pools for find in page and compositor experiments. The cpu time budget pool doesn't use the queue that it is passed when it records task run time, so we will pass nullptr in those spots instead. This will allow us to avoid passing a raw pointer to a TaskQueue in a spot we don't need it as a pre-requisite to this CL: crrev.com/c/2453591. Change-Id: Ifc7de7e94e667c1de1d4bc4de30203becc03fafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485346Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#819141}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I8bcde93c568033282759908ec3e9c212d5ce756b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469464 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#819140}
-
Gang Wu authored
This reverts commit 65967617. Reason for revert: compile failed on https://ci.chromium.org/p/chrome/builders/ci/chromium-internal-arm-builder-rel/5946 Original change's description: > Chime: Add an initialize method. > > Chime needs to be initialized during ChromeApplication.java's startup > code. > > This CL adds ChimeSession.initialize() entry point API, and a upstream > placeholder function for Chime DFM. > > Also clean up the feature flag JNI call for Chime, now it can directly > depends on chrome/browser/flags:java. > > Bug: 1136305 > Change-Id: Id8424fc22d2f419860318b12bd8753da448cd50b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466897 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818755} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org Change-Id: I2936cf940241987cc92c12af396658cafc953ace No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487816Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819139}
-
Victor Costan authored
Bug: 1140635 Change-Id: Idfc0091f79e3efccd3a22de879db698b9bf2bc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487837 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819138}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4deb1ed9573d..0ce89c83f8ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC reillyg@google.com,mcnee@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1121527,chromium:1134209,chromium:1140474,chromium:912681 Tbr: reillyg@google.com,mcnee@google.com Change-Id: I71cc641e663c5f205f2cf1de16b81260e2851730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488388Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819137}
-
Thomas Lukaszewicz authored
The tab search feature will only support a fixed entry point in the tab strip region view going forward. This change removes the implementation of the tab search button that sits flush with the new tab button in the tab strip. This reverts most of the changes introduced in the following CLs: https://crrev.com/c/2333341 https://crrev.com/c/2377550 Bug: 1099917 Change-Id: I4013e3724968374b8616550c54d562da1366d0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487252 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819136}
-
Eric Orth authored
All configured DoH providers should now only be queried at most once per DNS transaction. Recent timeout logic has extended the time period Chrome will wait for these servers in cases where there is no fallback available to non-DoH. Bug: 1109792,1105138 Change-Id: I661a8ff480dac4b73fb4f66cd28a237139e54433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471717 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819135}
-
Peter Kasting authored
Bug: none Change-Id: I979c06fa784573603570fd82eff7f55b20029cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483382 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#819134}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I186efa519eaafc7673399d948538d6709b70424f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487812Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e557087870b0..e9c99e93e75e 2020-10-20 dsinclair@chromium.org Add algorithm include. 2020-10-20 jdapena@igalia.com IWYU: unique_ptr usage in ChunkedCommandSerializer requires including <memory> 2020-10-20 dsinclair@chromium.org Remove HOMEPAGE_URL from cmake project. 2020-10-20 dsinclair@chromium.org Use CMAKE_CURRENT_SOURCE_DIR for third_party/khronos. 2020-10-20 dsinclair@chromium.org Skip None paths when looking for modules If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:957519 Tbr: dsinclair@google.com Change-Id: I42ffe871e35ffd718c54b3e5325dec36b0003234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488581Reviewed-by:
-
Ian Struiksma authored
We are not yet migrating chrome.tests pool. Until we move bots from 1703 to 1909, keep chrome_sizes on previous version so they are not starved for resources. Bug: 1124829 Change-Id: I780bb5e6e4b23ccb30c27efb769afd14eb6f6116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488740Reviewed-by:
-
Yuke Liao authored
This CL enables also_build_ash_chrome gn arg on linux-lacros-rel to support building both lacros chrome and ash-chrome inside the same checkout. Bug: 1129223 Change-Id: Ic549cd1c00ca2830314b4e8fd8e7fb700dc59b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487696Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819130}
-
Tim Volodine authored
Extend expiration milestone for the BatteryStatus.StartAndroid histogram. Also add second owners line with a path reference to the owners file. BUG=1088646 Change-Id: I99dcfd289bcfcc3bc491bf50fa7a80c6908bcd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485152 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#819129}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3fc3588cdf37..2fb0633adec8 2020-10-20 bsheedy@chromium.org [devil] Dump dmesg on pkill failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789 Tbr: skyostil@google.com Change-Id: I0f423ac84b7911796dc03c38583ab63d981d3ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487949Reviewed-by:
-
Koji Ishii authored
1. css/css-text/hyphens/hyphens-auto-010.html This test requires the last word of the paragraph to be hyphenated, which Blink currently intentionally doesn't today. Changes the test not to require this behavior because this test is for testing general hyphenation behavior, not the behavior of the last word. 2. css/css-text/hyphens/hyphens-auto-inline-010.html This test requires "guidelines" to be hyphenated, but the Minikin engine does not hyphenate this word. Replace it with "regulation", which is used in `hyphens-auto-010` above. TBR=yosin@chromium.org, tkent@chromium.org Bug: 1022415 Change-Id: I9e0abafa618cd03a4989df668ea49308408e81a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483724Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819127}
-
Shengfa Lin authored
Capitalize does not work well for unicode in the middle of a word. Patch Selenium atoms code regular expression to handle this case Bug: chromedriver:3611 Change-Id: I99dc7cbfef6af7db9590ad2e9e4d94e5bd765d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430768Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#819126}
-
cfredric authored
This makes the expectations more declarative, and makes it easier to express more complicated invariants. Note that in the previous implementation, kV8Screen_Height_AttributeGetter was listed twice among the expected keys, but the test did not verify that the |metrics| map contained two such keys (not that that is possible). |IsSupersetOf| is built on the idea of a multiset, so it does support checking for repeated expected elements. Change-Id: Ia2d617ed826b023bd67f5352e7094fd1136a6e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480964Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#819125}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //content/browser/renderer_host. Bug: 1113033 Change-Id: Idd9eb8b885f092cc0c30792b1efc9d6a040bc1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472342 Commit-Queue: Norman Rosas <normando@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#819124}
-
Robert Ogden authored
This is redundant, but will help direct changes to the right reviewer. Change-Id: Ic4e92f3364d503bbe66864011efc249065592df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488704Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#819123}
-
Gang Wu authored
This reverts commit 987fb106. Reason for revert: crbug.com/1140670 this CL make org.chromium.chrome.browser.sync.ManageSyncSettingsTest#testTrustedVaultKeyRetrieval flaky on Lollipop Phone Tester Original change's description: > [Android] Don't subclass ChromeActivityTestRule in SyncTestRule > > Removes subclassing of ChromeActivityTestRule in SyncTestRule. This > subclassing meant that every test using SyncTestRule would start > ChromeActivity before starting the test. This was producing several > issues: > 1. It's hard and confusing to use SyncTestRule in tests that start > other activity types: FRE tests, bookmark tests, settings tests. > 2. It makes tests longer. > 3. It might make tests flaky. > > Some tests need ChromeActivity to be started, so this CL adds a bunch of > explicit ChromeTabbedActivityTestRule fields along with calls to > startMainActivityOnBlankPage. > > This CL also fixes and cleans up FirstRunTest. Tests will be enabled in > a separate CL (in case they're still flaky). > > Bug: 616456, 1135990 > Change-Id: I5a3d4a27f051cdfc4df2d4dc12a27899084b91db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450291 > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818891} TBR=treib@chromium.org,bsazonov@chromium.org Change-Id: I5182024c7f07cb2bf038f4baf18833073474b751 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 616456 Bug: 1135990 Bug: 1140670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488344 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
-
Rafael Cintron authored
gfx::GpuFenceHandle already has a notion of a null handle on all supported platforms. Hence, we don't need to have the corresponding mojo fields also be nullable. Bug: 1131616 Change-Id: Ie31775da704aefd26da41516455d397b67c67a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485629Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819121}
-
