GitLab

This reverts commit bf228a61.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reuse kArcIntentHelperPackageName in c/b/
> 
> Reusing kArcIntentHelperPackageName where needed. Also adding a method
> to reuse such package name + a custom string appended to it, this is
> AppendStringToIntentHelperPackageName.
> 
> Bug: None
> Test: Build.
> Change-Id: I1b9115b808533e1e5ed3339b7f3747496ca2f0c3
> Reviewed-on: https://chromium-review.googlesource.com/764396
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Commit-Queue: David Jacobo <djacobo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516326}

TBR=yusukes@chromium.org,sky@chromium.org,djacobo@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None

Revert because it is breaking the build https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/79362

Change-Id: I2cd3a0c2b526d542242e14eeb9ed363b784f7795
Reviewed-on: https://chromium-review.googlesource.com/769047Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516342}

This reverts commit bf228a61.

Reason for revert: Didn't compile properly on CrOS (which we missed due to a bad CQ configuration).

Original change's description:
> Reuse kArcIntentHelperPackageName in c/b/
> 
> Reusing kArcIntentHelperPackageName where needed. Also adding a method
> to reuse such package name + a custom string appended to it, this is
> AppendStringToIntentHelperPackageName.
> 
> Bug: None
> Test: Build.
> Change-Id: I1b9115b808533e1e5ed3339b7f3747496ca2f0c3
> Reviewed-on: https://chromium-review.googlesource.com/764396
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Commit-Queue: David Jacobo <djacobo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516326}

TBR=yusukes@chromium.org,sky@chromium.org,djacobo@chromium.org

Change-Id: Idfef3e2b248c5a1339bb97c47be0f3a6cdf84ba3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/769187Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516341}

Tool is no longer used.

Bug: 632021
Change-Id: Ib3fc75c0fdfa0d60ae9187e3009572ba694a7f3c
Reviewed-on: https://chromium-review.googlesource.com/768733Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516340}

This CL adds a test with a frame having a child iframe that renders an
image. the parent should only get a first-paint entry even after the
child has rendered the image.

An upstream spec issue had been filed to clarify:
https://github.com/w3c/paint-timing/issues/22

Bug: 736114
Change-Id: Idc0910a7acc8f8af3bf9634a7e6827805fe8d370
Reviewed-on: https://chromium-review.googlesource.com/766393
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516339}

According to the flakiness dashboard, layout test virtual/gpu/fast/canvas/
canvas-imageSmoothingQuality.html is now passing on Linux and Win, but still
failing on Mac trybots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-imageSmoothingQuality.html

This CL updates the fail tag to reflect this behavior.

Bug: 693568
Change-Id: Ibd2974c9c02706d0ad5d6b0c342e2dc1112ead34
TBR: junov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/768948Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516338}

Bug: 721395
Change-Id: I06b833910c11c345b0995c0ff3f7de5f64c56b82
Reviewed-on: https://chromium-review.googlesource.com/760037Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516337}

Add a new vector to keep track of all newly inserted events.  This
vector is processed once in the audio thread to clamp the start time
of the event if needed.  Once processed, this vector is cleared.

Previously, the clamp check would process the entire event list to see
if any event needed to be clamped.  Most of the time, this is wasted
because there are no events to be clamped because they're all in the
future or because they've already been clamped.

Also removed unneeded member functions and variables.

Bug: 780125
Test: 
Change-Id: I73b871d8fa87a68e482cb98d48af33e05d1f0cfb
Reviewed-on: https://chromium-review.googlesource.com/747071Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516336}

The SignedInAccounts modal has a button to show the
Settings screen, in which case the modal should be
dismissed before presenting the Settings screen.

This CL makes presentation happen inside the completion
block of the dismissal. Otherwise, the presentation
will fail because |self.presentingViewController| is
still busy presenting another screen. Also,
|self.presentingViewController| must be set to another
variable to be used for presentation, otherwise, it will
be nil after dismissal.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia67e19816a4010a630f9679bae709b4f7307a3be
Reviewed-on: https://chromium-review.googlesource.com/767587Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516335}

If no fieldset element is found the first time
UpdateAncestorDisabledState is run, future traversals to search for
fieldset elements are skipped.

This reduces time spent in HTMLInputElement::InsertedInto and
HTMLInputElement::RemovedFrom by about 3% each.

Bug: 
Change-Id: Id70b60f4d815dd2fa2067ea2971e57f6d9bb2922
Reviewed-on: https://chromium-review.googlesource.com/739182Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516334}

This change makes worker use results of GetLocalChanges when preparing commit
contribution. EnqueueForCommit is not used and therefore removed.

With this change the expectation is that ModelTypeWorker::entities_ only
accumulate entities in two scenarios:
- Between calls to ProcessGetUpdatesResponse and ApplyUpdates remote updates are
  accumulated
- Between calls to GetContribution and OnCommit response local changes are
  maintained

Encryption is still done at ModelTypeWorker. There are a couple of important
scenarios related to encryption:
- After processor nudges worker about local changes worker should remember about
  that nudge in case cryptographer is not ready. When cryptographer becomes
  ready worker should nudge a NudgeHandler, processor is not going to reissue
  the nudge.
- When worker receives corrupt encrypted update it should skip the update and
  continue with the rest of entities in the batch. It shouldn't block datatype.

Another important scenario concerns commit failures. When commit fails on the
server NonBlockingTypeCommitContribution would not include corresponding
CommitResponseData in the response_list. Wth this change worker is not
retaining/recommitting entities so processor should do that.

This CL includes bunch of random small cleanups I stumbled upon while reviewing
implementation.

BUG=740757
R=skym@chromium.org

Reviewed-on: https://chromium-review.googlesource.com/729520
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511258}
Change-Id: I753173b6638d802c2057472f7a612e1b8f876d4c
Reviewed-on: https://chromium-review.googlesource.com/753983
Cr-Commit-Position: refs/heads/master@{#516333}

Re-enable listing/fuzzing of some messages lost by jumbo conversion.
Suppress one batch that is obsolescent.

Change-Id: I563b493732f6523901be450fbf88c667717ead76
Reviewed-on: https://chromium-review.googlesource.com/767208Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516332}

The implementation of IsContextDestroyed creates a dependency to
ExecutionContext. This CL keeps ActiveScriptWrappableBase in
platform/bindings and moves ActiveScriptWrappable to bindings/core.

Bug: 750674
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic9710f5d209c2a028b1e4393b70a94d9334efb26
Reviewed-on: https://chromium-review.googlesource.com/744802
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516331}

Convert the tests for mac over to use mojo input messages instead
of legacy chrome IPC. Other tests have already been converted this
mac specific test was the last one.

BUG=722928

Change-Id: Icc4995439e8110e6237605fa9436678a468e97cb
Reviewed-on: https://chromium-review.googlesource.com/753245
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516330}

WebLocalFrameImpl sets is_directional_ value to false
explicitly for building SelectionTemplate.
By default the is_directional_ value is false in
SelectionTemplate so we don't need to explicitly set.

Bug: 740804
Change-Id: I8f332d441b0265a230240fec30e892c4d55d4776
Reviewed-on: https://chromium-review.googlesource.com/765751Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#516329}

RenderThreadImpl's logic has a fair amount of duplication with ui::Gpu.
In particular, RenderThreadImpl shouldn't need to cache the
GpuChannelHost, since it is available directly from the ui::Gpu.

Bug: 566273
Change-Id: I6cfb9f28b46bce64c4f83aa5f2fcb4263c171018
Reviewed-on: https://chromium-review.googlesource.com/767594Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516328}

This has following two changes.
- Rename ManagedNetworkConfigurationHandlerTest to
  ManagedNetworkConfigurationHandlerMockTest, and then deprecate it.
- Introduce a new ManagedNetworkConfigurationHandlerTest test fixture,
  which uses Fake implementation instead of gmock.
- Migrated four tests using policy/shill_policy_on_unconfigured_wifi1.json
  into new test fixture.

BUG=234463
TEST=Ran bots.

Change-Id: I50114a323605eafd9e67accb1232c72783d3c572
Reviewed-on: https://chromium-review.googlesource.com/766407
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516327}

Reusing kArcIntentHelperPackageName where needed. Also adding a method
to reuse such package name + a custom string appended to it, this is
AppendStringToIntentHelperPackageName.

Bug: None
Test: Build.
Change-Id: I1b9115b808533e1e5ed3339b7f3747496ca2f0c3
Reviewed-on: https://chromium-review.googlesource.com/764396Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516326}

There is a need to compile V8 using CLANG and gcc-toolchain
option, in order to support CLANG on those targets which
don't have Debian RootFs (Release 6 and MIPS64BE).

This patch enables custom compilation using GN by
removing those flags that are set by the custom compiler.

Bug: 
Change-Id: Ia9b2f0fac1f76a2ad98d190fd307aa60229e8eeb
Reviewed-on: https://chromium-review.googlesource.com/763449Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516325}

https://chromium.googlesource.com/catapult.git/+log/445e9e3fa409..c44654bacfc5

$ git log 445e9e3fa..c44654bac --date=short --no-merges --format='%ad %ae %s'
2017-11-14 perezju [Telemetry] Remove purge_ashmem dependency

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I1566d3529ef711b1ed4e1e729249e3575bca3c7d
Reviewed-on: https://chromium-review.googlesource.com/768342
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516324}

This CL introduces a NavigationAndFirstPaintObserver and uses it in
place of content::TestNavigationObserver.

Bug: 778248
Change-Id: I9c42e384c48a4f5b2b85ca02ed931adf0178e086
Reviewed-on: https://chromium-review.googlesource.com/767388
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516323}

A few things are changed in this dialog:
* New browsertests to test permanent and temporary errors
  as well as the progress/success overlay.
* The layout structure has changed to accomodate for a
  better progress overlay (FillLayout with both contents and
  the overlay).
* Various hard-coded constants for distance and inset were replaced
  by common layout constants.
* One extra browsertest on Mac.

I'm not claiming this file is now perfect but it's a step in a
better direction.

Bug: 781581
Test: out/Default/browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive --dialog=CardUnmaskPromptViewBrowserTest.InvokeDialog_expired
Change-Id: I43a0a2337c58856abe7574621d70429572ebd87c
Reviewed-on: https://chromium-review.googlesource.com/764647
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516322}

This CL has no functional change. It modifies UiElement::Hittest to take a ray
as input in preperation for keyboard UI element support.

Bug: 780135
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2788ec50ad1b23aea48489e6c6e7034775fc83e6
Reviewed-on: https://chromium-review.googlesource.com/767507Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516321}

Changes the messaging for nonfatal "unused build arg" messages to be
"WARNING" instead of "ERROR" when they are nonfatal and clarify that
the build has continued. Previously it would print "ERROR" and
continue anyway which was confusing.

Add an Err object move constructor and de-inline the assignment
operator (previously implicit).

Bug: 500696
Change-Id: Id6056b7a4d33466485f9e138a890e211f447817f
Reviewed-on: https://chromium-review.googlesource.com/762086
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516320}

Convert ReadingListWebStateObserver to directly track
registration with the observed WebState instead of relying
on the deprecated code in WebStateObserver.

Remove class ReadingListWebStateObserverUserDataWrapper
and instead convert ReadingListWebStateObserver to be
a WebStateUserData.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I726919cf9c29b7040a907f01c95f462595e30192
Reviewed-on: https://chromium-review.googlesource.com/766751
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516319}

On ATK accessibility model, embedded hyperlinks accessibility nodes should
be exposed as ATK objects implementing AtkHyperlinkImpl interface. This
interface should provide the get_hyperlink method that returns an
AtkHyperlink object with the hyperlink URL and status.

This implementation is equivalent to the one found in Firefox and in
WebKitGTK: it will return always one anchor, that will point to the
link embedding object.

It does not implement the get_start_index and get_end_index yet.

Bug: 783447
Change-Id: I72163b1cce18c7cc3c8f732d5eaa45987b86a420
Reviewed-on: https://chromium-review.googlesource.com/762316Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516318}

serialize value of clip attribute expected as comma-seperated.
So change it from space-separated to comma-seperated.

Bug: 779873
Change-Id: Ia2726bd1fcfa0b5c9e4eca1fcd71a4d4f269c332
Reviewed-on: https://chromium-review.googlesource.com/760178Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#516317}

Most data pak files are generated at build time using a
Python script (see tools/grit/grit/format/data_pak.py),
but the C++ data pack writer can also be used at runtime
by the ThemeService (see ThemeService::SetTheme()).

The Python pak writer was recently changed to support
version 5 of the format that introduces a resource
alias table to reduce the size of the final pak files,
in the case of resource data duplication. This is mostly
important for localized strings paks.

While the C++ data pack reader and writer were updated
to support this new format, the WritePack() method didn't
try to find resource duplicates and build an appropriate
alias table.

This CL fixes the C++ writer, to detect resource data
duplication and build an appropriate alias table when
it is detected. After this patch, both the Python and
C++ code should behave identically.

+ Fix slightly misleading comment documenting the header
  formats (using uint instead of int values in the
  description, the code is already correct).

+ Use ScopedFileWriter convenience class to simplify
  error handling and cleanup.

+ Use for '(const auto& item : collection)' to simplify
  scanning over maps.

+ Add a sanity check to fail if there are more than 2^16
  resources to write (since the format only supports up
  to 65536 resources per pak file).

BUG=None
R=agrieve@chromium.org,asvitkine@chromium.org,sadrul@chromium.org

Change-Id: Ic04eb68558026ff48835ed0e9e44ba539b3a52a8
Reviewed-on: https://chromium-review.googlesource.com/737636Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516316}

This didn't show up as slow in any traces (I didn't even look). Just
came upon this micro-optimization when trying to learn what happens
during normal start-up.

Should be faster just by virtue of referencing fewer classes, and
avoiding a reflective call made by isVrEnabled().

Change-Id: I2256be591079917018037bb5881bee1a5c8888da
Reviewed-on: https://chromium-review.googlesource.com/766949Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516315}

The comment refers to code in Browser::ActiveTabChanged, not
BrowserView::OnTabChanged. See code block below

https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?type=cs&q=Browser+ActiveTabChanged&sq=package:chromium&l=1064-1067

This is particularly misleading as one might try to find
the reference in BrowserView::OnActiveTabChanged, which has no
direct reference to the comment in OmniboxViewViews::OnTabChanged.

Change-Id: I71e79e3fe6e874b569e9d4b6da122852eccd3d37
Reviewed-on: https://chromium-review.googlesource.com/767367
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516314}

It seems like on iOS 11 the autoresize masks don't work well when the
device is rotated. Since suggestions rows don't really need the mask
since the frame of each view is exactly calculated and set every time it
changes the size, remove the use of autoresize masks.

including long and short suggestions, answers; specifically verify that
text is not clipped in unexpected ways even when rotating to landscape
and back.

Bug: 768374
Test: Please test by displaying all possible suggestions in omnibox,
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia00b60187b3d99e7e09dcd82d107c6a809492316
Reviewed-on: https://chromium-review.googlesource.com/760937
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516313}

Convert FaviconWebStateDispatcherTest to directly track
registration with the observed WebState instead of relying
on the deprecated code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I40a70007d5dfab9c13439daf40bf361145bb830c
Reviewed-on: https://chromium-review.googlesource.com/766790
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516312}

This reverts commit a270ee75.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add aura::WindowOcclusionTracker.
> 
> aura::WindowOcclusionTracker notifies interested windows
> when their occlusion state change.
> 
> This will be used to release resources and throttle execution
> of occluded tabs.
> 
> Time to recompute occlusion on a Samsung Chromebook Pro:
>  100 partially occluded windows*: 108us
>  50 partially occluded windows*: 50us
> * window 0 at position (x=0;y=0), window 1 at position (x=1;y=1),
>   window 2 at position (x=2;y=2), etc.
> Benchmark code:
> https://chromium-review.googlesource.com/c/chromium/src/+/718979
> 
> 
> Bug: 738387
> Change-Id: I65e9e3eb58461e14eda280a133f0acb23a9f1c40
> Reviewed-on: https://chromium-review.googlesource.com/679206
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516293}

TBR=sadrul@chromium.org,fdoray@chromium.org

Change-Id: Ib9d0056b520f8fef13d97f0736dbde197c14882d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 784879
Reviewed-on: https://chromium-review.googlesource.com/768168Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516311}

Test:
  ninja -C out\debug
  python content\shell\tools\breakpad_integration_test.py ^
      --build-dir=out\debug ^
      --binary=out\debug\content_shell.exe

Bug: 466890
Change-Id: I76bf5c3e165d450d401aa3ac689cb0b5b49f3511
Reviewed-on: https://chromium-review.googlesource.com/760549Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516310}

ExtensionEnableFlow tries to re-enable a disabled extension, but did not
account for extensions that cannot be re-enabled by enterprise policy.
This would result in the ExtensionEnableFlow trying to re-enable the
extension (which would fail), and then notifying the delegate that the
re-enable was successful (which it wasn't).

This could lead to an infinite loop in the app list, where an
ExtensionAppItem would try to launch, see the extension needed to be
re-enabled, try to re-enable the extension through the
ExtensionEnableFlow, see that it was successful, and try to launch.

Fix this by checking if the extension must remain disabled in the
ExtensionEnableFlow and responding appropriately. Add a regression test
for the same.

Bug: 783831

Change-Id: I53cddecc895a9602f0884fa022b68ea7a6c2d667
Reviewed-on: https://chromium-review.googlesource.com/764851
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516309}

Any custom View may provide ThemeProvider. TypographyProvider
implementation should have possibility to consult the ThemeProvider in
similar way NativeTheme can be consulted.

Bug: 691891
Change-Id: I4d67dfa870d9c439292f74c96e408bb7a9471059
Reviewed-on: https://chromium-review.googlesource.com/730583
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516308}

MediaRouterMojoImpl::JoinRoute() requires that we find the MediaRouteProvider associated with a presentation ID.
By associating each MediaRoute with a presentation ID, we can look up the associated MRP.
The change to add presentation ID to MediaRoute on the component extension side has landed as cl/173960916.

Bug: 779155, 761493
Change-Id: I4bf7d6fb3a832ef4720bfc1952198fd2036350b2
Reviewed-on: https://chromium-review.googlesource.com/757796Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516307}

https://skia.googlesource.com/skia.git/+log/5b65a84b990e..1662257bdaaa

$ git log 5b65a84b9..1662257bd --date=short --no-merges --format='%ad %ae %s'
2017-11-10 bungeman Alloc glyph image correctly for SkMask::k3D_Format.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I89bd7e88b9f3c4fe934a3bcddfe1c86f661d144c
Reviewed-on: https://chromium-review.googlesource.com/768470Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516306}

This reverts commit 0a8e88e5.

Reason for revert: Broke build.
https://luci-milo.appspot.com/buildbot/internal.client.clank_tot/clang-clankium-tot-builder/52982

Original change's description:
> [Payments] Capability matching for payment handlers on desktop.
> 
> Before this patch, payment handlers for "basic-card" would always be
> shown in desktop payments UI, even if their "capabilities" field did not
> match the merchant's request.
> 
> This patch sends the full PaymentMethodData array to the
> ServiceWorkerPaymentAppFactory, so the factory can compare the
> "capabilities" of payment handlers for "basic-card" to the merchant's
> requested PaymentMethodData. The factory compares the capabilities only
> for "basic-card".
> 
> After this patch, a payment handler for "basic-card" shows up in desktop
> payments UI only if its "capabilities" field matches the merchant
> request.
> 
> Bug: 777470
> Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278
> Reviewed-on: https://chromium-review.googlesource.com/744541
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>
> Commit-Queue: Mathieu Perreault <mathp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516295}

TBR=rouslan@chromium.org,mathp@chromium.org,gogerald@chromium.org

Change-Id: I25260d461ebd180c817c5cf2943faaaee74245f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 777470
Reviewed-on: https://chromium-review.googlesource.com/768604Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516305}

This CL cleans up code in ChildAccountService and related classes
without any changes to the behavior:
1. Use lambdas instead of anonymous classes.
2. Remove unused parameters.

Bug: None
Change-Id: If6a19bfb8b8cde27d35986325d218740e9337d52
Reviewed-on: https://chromium-review.googlesource.com/766968Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516304}

Is currently failing on the Android WebView L/M bots.

BUG=784868
TBR=wychen@chromium.org
NOTRY=true

Change-Id: I061577724093cae3ab1d3440ffa93757cf556ec5
Reviewed-on: https://chromium-review.googlesource.com/768721Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516303}