- 20 Apr, 2020 40 commits
-
-
Camillo Bruni authored
This adds test for document.write in different situations with modules that were previously not tested or documented to the same extent. This also adds a test for future top-level await implementation. - JavaScript proposal: https://github.com/tc39/proposal-top-level-await - HTML proposal: https://github.com/whatwg/html/pull/4352 Bug: 1022182, v8:9344 Change-Id: I873df1e6aab2aa1ac6f7bf1b842059053f4a7cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134132Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#760411}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //media. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=jcliang@chromium.org Bug: 714018 Change-Id: I51100250f1323f6a5fdc55060fb41d6fcb4dbf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132450 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#760410}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I4699c69b30b9879df0d04e123d247c19231ca31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156325Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#760409}
-
Noel Gordon authored
Remove one level of #ifdef indent to make that part of the code easier to read. Change the accelerated routine name to end in _simd as is our way elsewhere in chromium zlib. Minor: adjust the comments around the performance claims, and move the important comments re CHROMIUM_ZLIB_NO_CASTAGNOLI into that block. Bug: 1032721 Change-Id: Icb4044f3b87277d67f0ff004ac70813af0a91f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148893Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760408}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //ui. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 714018 Change-Id: I741a996064d7932749e6970992b333d0ae94cb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132214Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760407}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/android. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=twellington@chromium.org Bug: 714018 Change-Id: Ib7bc83521f16b2ce741ff1ddc3e8b42aa9d1099f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132149Reviewed-by:David Trainor <dtrainor@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760406}
-
Hwanseung Lee authored
Currently payments uses the deprecated org.chromium.url.URI class, so we should replace URL class with GURL class. it chagned to pass GURL instead of string uri as a parameter. and add isURLValid() function in order to check validation of GURL. Bug: 1065577 Change-Id: I25ba336ea740b83e8672723c242c0a580d549a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141472Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#760405}
-
Maggie Cai authored
This CL fixes an error in common apps navigation throttle. After load app icons, we should return true to indicate we need to defer the navigation. Otherwise it will cause DCHECK error when resume navigation. BUG=853604 Change-Id: Ic618686070ab7eb237adf7b194de61cdceafcfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155764Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#760404}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ib92bf1b0c667b07a1c7efe106f1ca36b0569bd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155748 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#760403}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::ApplyPolicyUpdates(). Bug: 1055677 Change-Id: I85329c4651dc53851c77183b889b2abb76d2f9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154638 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760402}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/chromeos/file_system_provider. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=yamaguchi@chromium.org Bug: 714018 Change-Id: Id9aed7e19e1c1511e90ddbb5a53c862d5faaa0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132371Reviewed-by:Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760401}
-
Luciano Pacheco authored
Bug: 992821,1062902 Change-Id: I93d530b6963a9b1f9f15b8f674869e9321d4c2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155762 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760400}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/chromeos/dbus. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 714018 Change-Id: I322fc624930cfeb5fcebc0f24c243a408cee4af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132328Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760399}
-
Victor Hugo Vianna Silva authored
Instead of retrieving the SignInViewController on the fly, now a getter callback is bound on construction. A corresponding setter method is added that can be used to overwrite the callback in unit tests. Bug: 1070944 Change-Id: I26a7f81a580766c8ddd37281f365d8b876651b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153438Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#760398}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ied3e43e81c38bc6f941e87dc4ca35e7bef1ad1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155745 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
Remove Windows and Mac configs since work on those platforms is finished. Leave Sandbox for Linux as the only feature for experimentation. Bug: 1019245 Change-Id: I36a141ce875af5813dad14a230a1356beb4af059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153052Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#760396}
-
Koji Ishii authored
In the phase 1 of LayoutNG, two different "generated text" were added. This patch: 1. Distinguish them as "StyleGenerated" and "LayoutGenerated". 2. Add |LayoutObject::IsStyleGenerated| 3. Implement |NGFragmentItem::IsGenerated| not to require |NGPhysicalTextFragment|. 4. Change |NGPhysicalTextFragment::IsGenerated| to compute the value, the same way as |NGFragmentItem|. Some perf tests show up to ~3% regressions, but probably a noise because they don't call this function. This is part of preparations to avoid creating intermediate |NGPhysicalTextFragment| when |NGFragmentItem| is enabled. This patch has no behavior changes. Bug: 982194 Change-Id: Iddf4c37071d52bd7abbc98538411aa5fd5ea803e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154633Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760395}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1071928 Change-Id: I369d9bfd4024cea36397c7b9546b72903bf15302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155759Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760394}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c9327e48e9c..2657867e1fcb git log 0c9327e48e9c..2657867e1fcb --date=short --first-parent --format='%ad %ae %s' 2020-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 53f694b34a8d..99655bcf85ca (11 commits) Created with: gclient setdep -r src/third_party/skia@2657867e1fcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: If08c3c9f859b24843f3eb5d838bf311197d3ba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760393}
-
Hirokazu Honda authored
When application requests simulcast, libwebrtc configures temporal layers on each stream. If VaapiVEA and V4L2VEA refuses the temporal layer encoding, then we cannot make use of HW encoders on ChromeOS in simulcast case. Ignoring temporal layers and producing a simple stream causes a little less flexibility on a video call background, but not so critical. So V4L2VEA and VaapiVEA ignores the request as intended. Bug: 1030199, 1071089 Test: webrtc.RTCPeerConnection.* Change-Id: Iff153d76c05a1a994a609b97956dbb1fe041c627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154359 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#760392}
-
Yutaka Hirano authored
https://crrev.com/c/2132902 introduced case-sensitivity unintentionally. Fix it. Having a test for COEP header parsing for responses coming from service workers in reporting.https.html is not good. Create a separate test file and remove the corresponding test case from reporting.https.html. Bug: 887967 Change-Id: I50da8ee5e38162fbb81699fc1c55f5b4cb9cd903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154364 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Ramin Halavati authored
IndependentOTRProfileManager is deprecated. Usage of it in HatsWebDialog is replaced by profile API functions. Bug: 1033903 Change-Id: Ie531e0c319351c20ea69d9faa2065803a2e08573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153073 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#760390}
-
Peter Kotwicz authored
This CL adds two new tests for the lightweight first run experience. The motivation for the new tests is because the purpose of removing the WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME in WebappLauncherActivity#tryCreateWebappInfo() is to make the lightweight FRE logic work correctly but the logic was not tested in the FRE context. BUG=None Change-Id: I5958a7333722f10de1e3599b07d82be9e9e39446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147042 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#760389}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30b6825fa7b1..b4af53b2ac23 git log 30b6825fa7b1..b4af53b2ac23 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b4af53b2ac23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I978a69c56d54a05c386d6cd929231348675838fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156111Reviewed-by:
-
Yoichi Osato authored
Stop saving the request if OutOfBlinkCors is enabled. This is because |fallback_request_for_service_worker_| is needed only when OutOfBlinkCors is disabled. Bug: 787704 Change-Id: Idae728e80f4b229b236790494b61c28687fdbb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128004 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#760387}
-
Yutaka Hirano authored
The special treatment was added as https://crrev.com/c/1220257. That was needed because at that time blob URLs are handled in CorsURLLoader. Now it is handled in storage::BlobURLLoader, so we don't need the logic here. Bug: None Change-Id: I2ba642cee12304b4f8cd4e4eca4f8afaab3ff4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129379Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#760386}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9f46e3dd5e11..3f4e5c456306 git log 9f46e3dd5e11..3f4e5c456306 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 63069047+pmistryNV@users.noreply.github.com Add support for extension GL_ARB_shader_image_size (#2185) Created with: gclient setdep -r src/third_party/glslang/src@3f4e5c456306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Idef2ee34f567f2db9bd87c5eebd3c60e688140c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156110Reviewed-by:
-
Matt Giuca authored
Adds cmp and dmurph as general owners; oyiptong as file handler owner. Change-Id: I0d2e92704610f4d5f915f31768a77b22fb9ba4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153530 Auto-Submit: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Keishi Hattori authored
This reverts commit 1e7636e6. Reason for revert: It didn't unblock a problem that I was expecting this to. Original change's description: > Remove CooperativeScheduling code > > Remove CooperativeScheduling code as it is not actively developed. > > Change-Id: I74f8bee019652b04dd8e9fc2cf54e9bf83b6a4e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154637 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760368} TBR=haraken@chromium.org,keishi@chromium.org Change-Id: I9803d69a71eb1c25f94e40124850413c3e3c37e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155752Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#760383}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: I665a0ab0d51e42284bade8979b8563245def8877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153732Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#760382}
-
Patrick Meiring authored
As recommended by the app service team, to avoid Plugin VM app code polluting the built-in app publisher. TEST=unit_tests --gtest_filter=*PluginVm* TEST=cros_sdk -- tast run -buildbundle=pita $DUT_IP pita.* Bug: 1069426 Change-Id: I63bfe5f2c1040a0add937b7ddef4693a3e709fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151767 Commit-Queue: Patrick Meiring <meiring@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#760381}
-
Wanming Lin authored
WPT test directories should named after the shortname of the spec, this CL renames wpt/wake-lock to wpt/screen-wake-lock and moves system wake lock related tests to web_tests/wake-lock since there's no w3c spec for system wake lock at present. This CL also moves the idlharness tests for system wake lock to wpt_internal/system-wake-lock to use wptserve. Relevant spec issue: https://github.com/w3c/screen-wake-lock/issues/257 Bug: 1064685 Change-Id: I77939065ca82257fc261dcdfd07c9e7608fc9c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147352 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#760380}
-
Anand K. Mistry authored
The updated credential needs to be remembered so that the share can be restored on suspend/resume. Bug: 1065271 Change-Id: Id47aaa5dd40ec61c979749760bf229f4dc661145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151498Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#760379}
-
Hiroki Sato authored
There is an invisible list in PlayStore app, and when the loading completed, a selection event is dispatched from the list. This made ChromeVox move the focus to the list when opening PlayStore. Before http://crrev/c/2129381, this was not observed because selection event handling was incomplete, but now observable. This CL prevents the behavior by dropping selection and focus events from invisible nodes. Bug: b:154293371 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open PlayStore, focus no longer moves to the invisible node. Change-Id: Icfe4c931bef53b573878c3a55223e9e553b47307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154358 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#760378}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: If9b4b0fdefd987a471c1a1a1ef52a6c2aaf8aed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155819Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760377}
-
Yue Zhang authored
http://crrev.com/c/2123991 exposes a problem in TabGridDialog by skipping a call which was used to setup the basic fade-in/fade-out animation. Instead of having it setup in a unrelevant call, this CL fixes this issue by adding a specific handle in TabGridDialogMediator# onReset to make sure that the basic animation is setup if needed. Some other things happened in this CL: * Add a e2e regression test for this bug. * Simplify the logic controlling the alpha of dummy views used for dialog zoom-in/zoom-out animation so that 1) the alpha is only set by animators related to zoom-in/zoom-out animation but not fade-in/fade-out animation. 2) The dummy views will always have alpha as 0 when animation ends. Bug: 1068928 Change-Id: I66ae49925727c65ceedc365a5ea27cc6d378d15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143671 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#760376}
-
Jing Wang authored
keep-typing feature: when the suggestion pops up and the user keeps typing, if what they type is a prefix of the suggestion, the popup will not disappear, and in the suggestion text the typed prefix will be displayed in black and bold. The popup will disappear anyway if the user has typed more than 10 characters. Test: tested with Linux emulator Bug: 1042084 Change-Id: I157cd92cf29bb308e09764109d2eb0333183af7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153181 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#760375}
-
Josh Simmons authored
Bug 1067499 requires the addition of individual browser tests to validate the MIME type detected and reported by Quick View for all file extensions known to Files.app. This CL adds a new test for files with extension 'jpeg' and more clearly names the existing test for files with extension 'jpg'. Bug: 1067499 Test: browser_tests --gtest_filter="*FilesApp*openQuickView*" Change-Id: I03d72d6d7daeffb2f14f5bf0083b07ca328b685d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153461 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Jie Jiang authored
Cleanup discovery sessions after the ARC Bluetooth service in Android shutdown. BUG=b:145257789 TEST=manually test: LE scan stops immediately after called BluetoothAdapter.disable() in an Android app, as expected. Change-Id: I9f1f7814eb935ceca3099c0d8124e313a9c2c065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051863 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#760373}
-
Sergei Datsenko authored
BUG=chromium:1037058,chromium:1037059,chromium:1037060 Change-Id: Ie0e9a26d0739f83502a422fc2ffb2d45cde43093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147519 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#760372}
-
