- 06 Apr, 2018 40 commits
- 
- 
https://chromium.googlesource.com/angle/angle.git/+log/c3755fc56611..b8e396609624 $ git log c3755fc56..b8e396609 --date=short --no-merges --format='%ad %ae %s' 2018-04-04 jmadill Vulkan: Remove Observer from LineLoopHandler. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Iba6ac177fe134d548f3d23118a785a9e85ff532e Reviewed-on: https://chromium-review.googlesource.com/998400Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548787} 
- 
tzik authoredThis is another run of base_bind_rewriter to //content and //storage that covers the users of newly migrated services, new rewriters that remove unneeded base::Passed and fix misused BindRepeating. Change-Id: I1e745d606de85a2843255e30ce7e0352a782aea9 Reviewed-on: https://chromium-review.googlesource.com/999077 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#548786} 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium d2ab45ba. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15385 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/compat jsbell@chromium.org: external/wpt/resources TBR=lukebjerring No-Export: true Change-Id: I4e69a43d8172c38fabb0cf400d31aa592638b15b Reviewed-on: https://chromium-review.googlesource.com/998543 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#548785} 
- 
Adam Rice authoredUpdate Blink's implementation of ReadableStream to https://streams.spec.whatwg.org/commit-snapshots/37ace3d5f16cbea7aec4a0c80532c95059994d51/ This also updates TransformStream to use CreateReadableStream() instead of calling the ReadableStream constructor. Several common operations have become unused and have been removed. The EXTERNALLY_CONTROLLED flag has been renamed to the slightly more specific name "BLINK_LOCK_NOTIFICATIONS". All external/wpt/streams/readable-streams tests now pass, and failing expectations have been removed. Most changes were already covered by the web-platform-tests. A new readable-streams/patched-global.js test verifies that ReadableStreamTee() does not use the global ReadableStream constructor or otherwise touch the global object. BUG=710728 Change-Id: I2b799045f47376adef305f5f88ad106161425b46 Reviewed-on: https://chromium-review.googlesource.com/992077 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#548784} 
- 
Vaclav Brozek authoredThis CL adds a function to generate FormData based on a given DataAccessor. The CL further uses this function to add a fuzzer for the code parsing FormData into PasswordForms (on iOS, for now). Bug: 827945 Change-Id: I910a19b8e54b6383f91476c5c0fd698521d11eb2 Reviewed-on: https://chromium-review.googlesource.com/992496 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548783} 
- 
Michael Thiessen authoredIt should be impossible for this toast to show up while in VR as we intentionally never send long presses for exactly this reason. However, the toast is still showing up whenever the icon is clicked or scrolled over, but only on Android N. I've gone through the support library code, and overridden the long-press handler that shows the toast and the toast still shows up. I have no idea what's creating the toast or how to even find that out. The simplest solution seems to be just clearing the title when we're in VR, as the toast will never show up then. Bug: 829151 Change-Id: I9353ffa41ee44e488cc79d44ad6869961e11561f Reviewed-on: https://chromium-review.googlesource.com/998658Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#548782} 
- 
Mikhail Pozdnyakov authoredOrigin must be extracted from the URL before it is passed to GetPermissionStatusForFrame(). Bug: 750018 Change-Id: Iffffbf4ec516cb1a798c3604333a71d3bdac5e9e Reviewed-on: https://chromium-review.googlesource.com/998160Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#548781} 
- 
Daniel Nicoara authoredThe video hole doesn't make practical use of the overlay API. Rather than pretend to show anything via overlays, just replace the video quad with a transparent quad. This also allows the video hole to work with Ozone platforms other than Cast since the Ozone platform is no longer expected to lie about supporting the video hole overlay. Bug: b/74998539 Test: Played video on device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia9b63f718d16ab8d933221a3ce551dbbf06b5748 Reviewed-on: https://chromium-review.googlesource.com/970910Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Sergey Volk <servolk@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#548780} 
- 
Nektarios Paisios authoredThis patch begins using the new AXPosition and AXRange classes in a relatively simple part of the codebase in order to avoid regressions. It also takes the opportunity to rename AXObject::AXRange to AXSelection in preparation of the use of the new AXSelection class in a subsequent patch. The C++ Style Guide allows the use of initializer lists {...} when returning from or when calling functions, hence this patch switches to the new style in all the selection related functions. This will make the switch to the new AXSelection class in a subsequent patch easier since a rename at the point of construction will not be needed. The patch makes some functions that are using the AXRange class not inline because the Style Guide dictates that virtual functions should not be inlined. R=dmazzoni@chromium.org Bug: 639340 Change-Id: I8e19986b0937fd6a954dfe1f5631064c5a9c42a2 Reviewed-on: https://chromium-review.googlesource.com/995976Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#548779} 
- 
Daniel Bratell authoredIn jumbo experiments (jumbo is not yet supported in chrome/browser/ui) several GetBubbleAnchorView and GetBubbleAnchorRect functions clashed. They were more or less identical but there is no obvious place to share them, and even though they are small, the code gets messier if you inline them. This patch gives the functions unique names as a preparation for jumbo support in chrome/browser/ui Bug: 803406 Change-Id: I104ae7cc961dd867e89e06fe8f18b401b39af549 Reviewed-on: https://chromium-review.googlesource.com/998158Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#548778} 
- 
Christos Froussios authoredThe aria labels for the 'More Actions' buttons will now also give context, mentioning whether the apply to all passwords or the specific user and domain. Bug: 828312 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If94daaa5b6a903b3e0887caea13a2446eef52bfd Reviewed-on: https://chromium-review.googlesource.com/964330Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#548777} 
- 
Christopher Grant authoredThis change puts the toast over content, near the bottom, in a position just above where a downloading snackbar appears. It also removes the linear layout that previously held more than one toast. BUG=828515 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iab15c457261e9887940c69140c9af607eb18f1cd Reviewed-on: https://chromium-review.googlesource.com/998404Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#548776} 
- 
Mounir Lamouri authoredInstead of the proper value that may have many digits and make no sense to a human. Bug: 829627 Change-Id: I467354edc416af46de0f1c625e6b890414f8ae6f Reviewed-on: https://chromium-review.googlesource.com/998915 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#548775} 
- 
Josh Horwich authoredChange the implementation of ArcBackupRestoreEnabled and ArcLocationServiceEnabled to disallow policy changes after the initial setup of ARC. BUG=b:74220823 TEST=Opt in to ARC, ensure settings still applied. Change-Id: I695cfaf0335faa6eefe96f63e5a5ce41ed9880a2 Reviewed-on: https://chromium-review.googlesource.com/959503 Commit-Queue: Josh Horwich <jhorwich@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#548774} 
- 
Nicolas Pena authoredPreviously, the |name| of a PerformanceNavigationTiming entry was the initial URL (the request URL). After this CL, it is the response URL, so for example a url of the form 'redirect?location=newLoc' will have 'newLoc' as the |name|. Bug: 797465 Change-Id: Icab53ad8027d066422562c82bcf0354c264fea40 Reviewed-on: https://chromium-review.googlesource.com/996579Reviewed-by: Yoav Weiss <yoav@yoav.ws> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#548773} 
- 
Vaclav Brozek authoredThis is part of the effort to introduce a fuzzer for code parsing FormData into PasswordForms. As described in the design linked from https://crbug.com/827945#c2, in order to create FormData from an arbitrary input string supplied by the fuzzer framework, a DataAccessor class should be created to wrap turning the input string into bits, numbers and strings. This CL adds DataAccessor, including tests (because the contained logic is not straightforward). Bug: 827945 Change-Id: Ib7b2fe54d74bc096afa7e8bc8ff72ab68a8c5977 Reviewed-on: https://chromium-review.googlesource.com/992312 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#548772} 
- 
Stephen McGruer authoredThis reverts commit 8fa7eced. Reason for revert: HistogramManager.HistogramBucketFields crashes consistently on Win7 Tests (dbg): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=cronet_unittests&tests=HistogramManager.HistogramBucketFields First failing run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/68309 Original change's description: > Enable Cronet tests on desktop platforms. > > - Only initialize global state (e.g. AtExitManager) in non-Debug builds, so that our component- > build Debug bots can run cronet_tests. > - Fix memory leaks in a number of unit-tests. > - Disable some StaleHostResolver tests under ASAN, since they have leaks > that need resolving. > > Bug: 812268, 816705, 829097 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5084dd578682b2a8c128487c62de12e437e646f3 > Reviewed-on: https://chromium-review.googlesource.com/981787 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Misha Efimov <mef@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548672} TBR=wez@chromium.org,mef@chromium.org,jbudorick@chromium.org Change-Id: Ic30729594ae2b1264702c7bb77c971d55e5e9ae9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812268, 816705, 829097 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/999334Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#548771} 
- 
Klaus Weidner authoredThis is a reland of f5bbb138 Original change's description: > Add SubmitFrameMissing mojo call for WebVR/WebXR > > Goal is that we get a clean lifecycle for a functioning WebVR/WebXR > presentation render loop. It's started by a presenting SendVSync, calls > GetVSync to schedule the next frame, and is ended by a SubmitFrame > call. If there was nothing drawn, it uses SubmitFrameMissing instead of the > usual SubmitFrame/SubmitFrameWithTextureHandle. > > In WebVR 1.1, submitFrame is a JS call, and the app can exit its animation > loop without calling it. WebXR had an analogous feature where SubmitFrame > was skipped if the framebuffer wasn't touched by drawing calls. This > made it hard to tell for the device side if a frame is done or not. > > WebVR 1.1 worked around this by deferring a GetVSync call until after > SubmitFrame, but this was complex: > > - // The logic here is a bit subtle. We get called from one of the following > - // four contexts: > - // > - // (a) from requestAnimationFrame if outside an animating context (i.e. the > - // first rAF call from inside a getVRDisplays() promise) > - // > - // (b) from requestAnimationFrame in an animating context if the JS code > - // calls rAF after submitFrame. > - // > - // (c) from submitFrame if that is called after rAF. > - // > - // (d) from ProcessScheduledAnimations if a rAF callback finishes without > - // submitting a frame. > - // > - // These cases are mutually exclusive which prevents duplicate GetVSync > - // calls. Case (a) only applies outside an animating context > - // (in_animation_frame_ is false), and (b,c,d) all require an animating > - // context. While in an animating context, submitFrame is called either > - // before rAF (b), after rAF (c), or not at all (d). If rAF isn't called at > - // all, there won't be future frames. > > This CL removes those special cases and just always calls RequestVSync from > requestAnimationFrame, collapsing cases (a) and (b) into an unconditional call. > Cases (c) and (d) are now no longer needed and removed. > > The layout tests now check the SubmitFrameMissing call count. > > Also added a check for a WebXR exclusive session ending in the middle of a > frame. (The layout tests revealed this since OnEndFrame no longer exits early > on a clean framebuffer.) > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I5722097d421ca9448760e696ea379895a1320199 > Reviewed-on: https://chromium-review.googlesource.com/996614 > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Commit-Queue: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548518} Change-Id: I14b7ac8fc661cfb91a8be2b959d27091007602ee Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/998079Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Martin Barbella <mbarbella@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#548770} 
- 
Leonard Grey authoredThis matches NSTextView's behavior by creating a CFString and asking what Cocoa thinks should happen. This also handles UTF-16 surrogate pairs, so this change splits that check to the non-Mac code path. Bug: 826794 Change-Id: I8fce5510e3cd483533699edd1ba33118ce55b44e Reviewed-on: https://chromium-review.googlesource.com/986475 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#548769} 
- 
Mustaq Ahmed authoredThe specs for both WebBlueTooth & WebUSB only require a user activation during a requestDevice call. So consuming the activation (vs just checking) is not a strong requirement. There was a concern that "not consuming" could possibly mean multiple choosers for a single user activation but our browser code already handles the situation gracefully. Multiple requests to browser is possible from different tabs anyway, even with (isolated) consumptions in individual tabs. Therefore it makes sense to remove the consumption behavior here, which is not spec-ed anyway. This would fit our goal of a simple user activation model ("UserActivationV2" project) which should be simple enough for cross-browser implementation and for a complete spec. Bug: 786407 Change-Id: I3c9dbf43df34d4cb4a2a33214a6c44847fa7435b Reviewed-on: https://chromium-review.googlesource.com/775866Reviewed-by:Reilly Grant <reillyg@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#548768} 
- 
vitaliii authoredPreviously, all user events were deleted when Sync was disabled. After this CL, user consent events are preserved in persistent store. This CL does *not* include their garbage collection and attempting to send them again. Bug: 781765 Change-Id: I6fdb7488da81324d782f28745299301b551a712c Reviewed-on: https://chromium-review.googlesource.com/986514 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548767} 
- 
Tatiana Gornak authoredThe AutofillAgent can be null in some cases. BUG=821502 Change-Id: Iada92ce5889643a3eda1d02cb499a16699e73015 Reviewed-on: https://chromium-review.googlesource.com/997797 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#548766} 
- 
Mikel Astiz authoredThis reverts commit 5e4c7d7b. Reason for revert: Speculative revert for failing base_unittests on Android, CFIBacktraceAndroidTest.TestUnwinding. See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/579 Original change's description: > Fix conditions for can_unwind_with_cfi_table with frame pointers > > CFI table unwinder is not appilcable for builds with frame pointer > enabled. Make sure can_unwind_with_cfi_table is set to false. > No need to check for use_thin_lto. > > BUG=469376 > > Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6 > Reviewed-on: https://chromium-review.googlesource.com/992890 > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548634} TBR=thakis@chromium.org,ssid@chromium.org,pcc@chromium.org Change-Id: I1bb99a9cde8fd501bd5abb7aa7fe798684454226 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 469376,826718 Reviewed-on: https://chromium-review.googlesource.com/999635Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548765} 
- 
Alexis Hetu authoredhttps://swiftshader.googlesource.com/SwiftShader.git/+log/f8cdc74..1119ce6 BUG=chromium:823096 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7606c5a8f2ade19639098c752e7f35e6b7f68330 Reviewed-on: https://chromium-review.googlesource.com/999128 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548764} 
- 
Gauthier Ambard authoredThis CL adds a metrics for the time elapsed between the time the user taps on a button and the popup menu is presented. Bug: 829343 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id978bd57ffa93adc0827a7810ca546c8272aded7 Reviewed-on: https://chromium-review.googlesource.com/999476 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#548763} 
- 
Maks Orlovich authoredCreation time is no longer unique (not that it ever was); (domain,path,key) is (as it's long been). Bug: 826322 Change-Id: I433fe3ceffd2b2cfeb5c27c7af0033d69e76301c Reviewed-on: https://chromium-review.googlesource.com/984514Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#548762} 
- 
Christopher Grant authoredThis makes the testapp rendering code more closely match vr_shell_gl, alleviating the annoying hover issue (a button may stay hovered even when the reticle had moved away). BUG= R=ymalik Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6b1bd7006c9ff319c177d721a309d82906a69153 Reviewed-on: https://chromium-review.googlesource.com/998740Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#548761} 
- 
Vaclav Brozek authoredCurrently, _CheckUniquePtr is run both on upload and on commit. This check emits errors, which means commit is blocked if it fires. At the same time, it has a history of false positives (one mentioned in https://crrev.com/c/933547, another in https://crbug.com/827961). Therefore this CL makes _CheckUniquePtr an upload-only check. Bug: 827961 Change-Id: I6d5a7f3dda33432ae1375359c2ae573e5ad3df34 Reviewed-on: https://chromium-review.googlesource.com/990133Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548760} 
- 
Mikel Astiz authoredThe test is timing out on Mac. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Flayout_ng_experimental%2Fprinting%2Fwebgl-oversized-printing.html&showFlaky=true TBR=junov@chromium.org NOTRY=true Bug: 829804 Change-Id: I0ee14c1e9235222e9690daed12cc489dd81e6a6e Reviewed-on: https://chromium-review.googlesource.com/999602Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548759} 
- 
erikchen authoredThis CL is a refactor with no intended behavior change. By moving the settings into components/services/heap_profiling, they will be usable by Android Webview, which does not compile chrome/ Bug: 827545 Change-Id: I8b217344fcbc259499b5f7622cbfc9b8d21e3e83 Reviewed-on: https://chromium-review.googlesource.com/998017 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548758} 
- 
Mugdha Lakhani authoredChange-Id: I0a05f243c3406f560fd2c88a0212ce73ad289586 Reviewed-on: https://chromium-review.googlesource.com/997833 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#548757} 
- 
erikchen authoredThis CL is a refactor with no intended behavior change. Bug: 827545 Change-Id: Id764a233ed364ec1d23f8540dfd1b1257fd7bb96 TBR: chrisha@chromium.org Reviewed-on: https://chromium-review.googlesource.com/998712 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#548756} 
- 
https://webrtc.googlesource.com/src.git/+log/83d676bd1505..3ab5c40f72ef $ git log 83d676bd1..3ab5c40f7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I96d9f10f9295b7a7b03fbc0a24e891b46f009f20 Reviewed-on: https://chromium-review.googlesource.com/998399Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548755} 
- 
kylechar authoredAdd a CHECK that XOpenDisplay() doesn't return null when initializing Ozone X11. There is no point going any further, we are going to crash somewhere else and the crash stack isn't going to be as obvious. Original change in https://crrev.com/c/980596. Reland change with call to XInitThreaded() first still to avoid crashes. Bug: 806508 Change-Id: I0ca480b140da702946b4b75cd93c63cd388fdfca Reviewed-on: https://chromium-review.googlesource.com/997894Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#548754} 
- 
Ken Rockot authoredThis is instead of having it reflect the allocation size, which may be larger than the requested size on some platforms. See bug for some elaboration. Also ensures that SharedMemoryMapping::size() reflects the requested size, and adds SharedMemoryMapping::mapped_size() to reflect the actual mapped size of the mapping. mapped_size() is used by SharedMemoryTracker. Bug: 829158 Change-Id: Ifde49f232548f865e8f8a6a1e5f948120f1b0ef0 Reviewed-on: https://chromium-review.googlesource.com/996811 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548753} 
- 
Boris Sazonov authoredThis CL changes the layout for account picker in signin_view.xml so it uses wrap_content for layout_height instead of explicit height in dps. This is a follow-up to https://crrev.com/c/986262 that has done the same for the account row in the account picker dialog. Using explicit height for TextViews is dangerous as it may cause clipping when font scaling is enabled, especially with tall scripts. This CL also fixes ordering of XMLs attributes in the chunk it changes. Bug: 814728 Change-Id: Ie7d1c7c9ccc8eb56bff3653c06aedff39cd50bc3 Reviewed-on: https://chromium-review.googlesource.com/999593Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#548752} 
- 
Ramin Halavati authoredTraffic annotation auditor's clang tool switches path is changed to absolute path, and data dependency on it is corrected. TBR=msramek@chromium.org Bug: 690323 Change-Id: If3dd10339745c601d6a4e4d077b5251defe37af6 Reviewed-on: https://chromium-review.googlesource.com/999612Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#548751} 
- 
Jinho Bang authoredThe related spec change: https://github.com/w3c/payment-handler/pull/276 Payment Handler feature is behind a flag: chrome://flags/#service-worker-payment-apps FYI, the original field type was `repeated string`, and the changed field type is `optional string`. So, if `enabledMethods` data is stored in a previous version, when reading the `method` field in a new version, the protobuf will read the first element of `enabledMethods`. Therefore, DB migration is not required. Bug: 828894 Change-Id: Ic5775768eaff9584517956f2984473e8b6a0a411 Reviewed-on: https://chromium-review.googlesource.com/986121Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#548750} 
- 
Elly Fong-Jones authoredThis entire dialog will be replaced soon, but for now, remove the flag on Mac and the wiring that hooks up the flag. It's not currently possible to remove the dialog code wholesale because the NTP code for examining an app always uses ShowAppInfoInNativeDialog(). Bug: 828270 Change-Id: Ieae022a5a8733819eadbb41e95c9ce67f5e9e73a Reviewed-on: https://chromium-review.googlesource.com/998013Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#548749} 
- 
Mounir Lamouri authoredThis is removing the kMediaOverlayPlayButton and resolves the issue of exposing only the play state to the accessibility tools with the new media controls. Bug: 829579 Change-Id: I4aa97ec6904933719bab02ef2451af0519230c03 Reviewed-on: https://chromium-review.googlesource.com/998553 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#548748} 
 
-