GitLab

Unit test for encoding advertisement on range requests.


Simple logic to change accepted encoding to identity in a range request

Bug: 849952
Change-Id: I436ac5e4db118faa4f362a0b8c1943b5fe7020ea
Reviewed-on: https://chromium-review.googlesource.com/c/1352672Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612816}

Change-Id: I8ef824ce088327dd1afe8ebdca5dbea845cf0642
Reviewed-on: https://chromium-review.googlesource.com/c/1357521Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#612815}

Article thumbnails are now fetched for suggestions from feed.
We fetch with the cached image fetcher, which is shared with feed.

Bug: 841522
Change-Id: I283fa2ea145341fb28dd337026a57abbd36aec77
Reviewed-on: https://chromium-review.googlesource.com/c/1344549
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612814}

Currently, if an extension is affected by runtime host permissions but
doesn't want to run on the current site, we still show the context menu
submenu entry for page access. The only item is the "Learn more" link.

Instead, remove the context menu submenu for these sites, and replace it
with a (disabled) menu item "Can't read or change site's data".

Bug: 909790
Change-Id: Id77efca23a96e8d5d8f683954946970b652612d4
Reviewed-on: https://chromium-review.googlesource.com/c/1351302
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612813}

* Fixes issue with an on-receive callback not being unbound, causing
  the incoming message buffer to be drained immediately.
* Add browser tests to verify buffering behavior.
* Add browser tests to verify proper origin enforcement for
  Frame::PostMessage.
* Make the AsyncValueReceiver interface a bit nicer to use.
* Minor cleanups for other FrameImpl browser tests.

Bug: 893236
Change-Id: I521e9316ccf9195133a940be670556a882cb1044
Reviewed-on: https://chromium-review.googlesource.com/c/1351777
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612812}

The dEQP test suites need to be run on specific dEQP buidlers
and testers. Trying to build dEQP on these configs was breaking
the ANGLE CQ when the testers were enabled. After this change
the configs can be re-added to the tools/build repo.

Bug: 822310
Change-Id: I7dae7799948819004640f14379839c425f8a8280
Reviewed-on: https://chromium-review.googlesource.com/c/1357002Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612811}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/010497f89102..b26f97ac1d28


Created with:
  gclient setdep -r src-internal@b26f97ac1d28

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=mmoss@chromium.org

Change-Id: I42411d33fb47167aae0ece852d5f2ba26a5a94ca
Reviewed-on: https://chromium-review.googlesource.com/c/1357422Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612810}

Hang reports show that there can be contention on the pool lock when
a thread is created in a scope where it is held. To avoid this
contention, this CL ensures that no lock is held when
SchedulerWorker::Start() is called.

Bug: 905288
Change-Id: I4158fb061e6c0ec0de820bd061c1cc5b2d309e6b
Reviewed-on: https://chromium-review.googlesource.com/c/1355427Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612809}

Removes use of testharness.js's async_test from all XR instrumentation
test files. testharness.js supports single-page tests, where not calling
test() or async_test() will allow asserts to work without having to be
wrapped in a step. This new approach is both cleaner and less confusing,
as it was not obvious to new users that asserts needed to be wrapped.

Bug: 909948
Change-Id: If945571ef414953c538596da08976483ab39b3f9
Reviewed-on: https://chromium-review.googlesource.com/c/1356021Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612808}

Most DownloadManager::DownloadUrl use cases don't use cache because
cache can result in download with a partial file, and it can block
video thumbnail generation when the partial file is too small.

Bug: 909605
Change-Id: I40c8dae00da677d969f1a3c398b758d4e1d230a4
Reviewed-on: https://chromium-review.googlesource.com/c/1357501Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612807}

This reverts commit 33264a73.

Reason for revert: Since dexdump version has been fixed, this should
now be okay.

Original change's description:
> Android: removing min-api from R8
>
> Bug: 910319
> Change-Id: I5fa81395b39d877e68eb8a49a3d4d1ffab016a39
> Reviewed-on: https://chromium-review.googlesource.com/c/1355855
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612398}

TBR=agrieve@chromium.org,smaier@chromium.org

Change-Id: Ie31442be0997e04bfcc65a852446e8935d6e2702
Bug: 910319
Reviewed-on: https://chromium-review.googlesource.com/c/1357379
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612806}

Create service that fetches middle-slot promo data from
/async/newtab_promos (created in cl/222286677) on NTP
load if kPromosOnLocalNtp is enabled.

Bug: 906278
Change-Id: I1ee859951acc06f8fae9354b80e41bf2a2ae2521
Reviewed-on: https://chromium-review.googlesource.com/c/1352321Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612805}

https://pdfium.googlesource.com/pdfium.git/+log/7b5740a89e63..390ce238ca28


git log 7b5740a89e63..390ce238ca28 --date=short --no-merges --format='%ad %ae %s'
2018-11-30 tsepez@chromium.org Use single-byte strings in more places in pdfium.


Created with:
  gclient setdep -r src/third_party/pdfium@390ce238ca28

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I804b05eccdefe3fec8ad7f24402a965909036595
Reviewed-on: https://chromium-review.googlesource.com/c/1357419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612804}

Bug: 907247
Change-Id: I6c6fd2c2c8fcc86f0b70a5e87640fc98ae530f63
Reviewed-on: https://chromium-review.googlesource.com/c/1354357
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612803}

This CL implements the retry functionality used in download home.

Currently interrupted download that can't resume can retry. Cancelled
download potentially can also be retried.

TBR=dtrainor@chromium.org

Bug: 883387
Change-Id: I13e9ad9511d8e15c1b3432184f1376cf3dcf9319
Reviewed-on: https://chromium-review.googlesource.com/c/1278267
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612802}

PDFium started exporting them in its public config, so these are now
redundant.

Change-Id: I2f7a476059a0aefd1e46b59463dbe9e90a64af32
Reviewed-on: https://chromium-review.googlesource.com/c/1357210Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612801}

I am not part or this team anymore and neither is John.
Replacing ourselves with the team TL.

Change-Id: I6ec7c488def2403806894a5dad462774ac2281c0
Reviewed-on: https://chromium-review.googlesource.com/c/1356227Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612800}

This CL breaks out the code that inspects an individual file within a
ZIP archive. This will be shared between the ZIP and RAR inspection,
when RAR files begin doing content inspection.

Bug: 909778
Change-Id: I7acf1cabd472f112f2ed7c31735688cae7a6d122
Reviewed-on: https://chromium-review.googlesource.com/c/1354103
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612799}

Windows generally doesn't seem to echo the HmacSecret extension in their
response to AuthenticatorMakeCredential. However, AuthenticatorImpl already
parses the hmacSecret response value out of the authenticator data, so we
should not fail the request over this.

Bug: 898718
Change-Id: I1e732ab189f240df2be09ec89135af143634238f
Reviewed-on: https://chromium-review.googlesource.com/c/1357460
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612798}

This is a reland of 1d979043

Original change's description:
> macOS Sandbox: Port fontloading test to V2 sandbox.
> 
> This removes all of the obsolete unit testing code from the V1 sandbox.
> 
> Bug: 902597
> Change-Id: I426e3b815e0bf23036815750aab350adbb22e068
> Reviewed-on: https://chromium-review.googlesource.com/c/1327527
> Commit-Queue: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612416}

Bug: 902597
Change-Id: I2088dd954956be6d704add7ee8e07bc629df8eb9
Reviewed-on: https://chromium-review.googlesource.com/c/1357217Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612797}

It will use static method globals which originally froze when
protobuf tool was run after compiling with CL.EXE. This allows
MSVC based builds to be re-enabled. The next official release
of protobuf should no longer need this patch as the code around
singletons has been rewritten to no longer have this issue
present in this release of protobuf.

https://bugs.chromium.org/p/webrtc/issues/detail?id=9695

Change-Id: I729bd66429774cf9845a7ae754173722f31a208a
Reviewed-on: https://chromium-review.googlesource.com/c/1297536Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612796}

This CL:
- Makes SplashActivity singleTask
- Introduces InitialSplashActivity to launch SplashActivity. Otherwise,
  whenever the user taps the WebAPK's app icon the WebAPK is relaunched
  and the ChromeActivity which is on top of SplashActivity is killed

BUG=907951
TEST=LaunchTest.*

Change-Id: Ibc06b1b3fc2aea49ad26bf1043aebec595fb68cf
Reviewed-on: https://chromium-review.googlesource.com/c/1340516
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612795}

Add labels for artist and title that are shown if
we have the metadata from the session.

BUG=893296

Change-Id: I9bab7dd6c31c711c3552dbac975477808ec9311a
Reviewed-on: https://chromium-review.googlesource.com/c/1321258
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612794}

The value of the autofill::prefs::kAutofillProfileValidity pref
name does not match the actual value being used to populate the
priority pref from the server.

Thie CL changes this constant from autofill.profile_validity to
autofill_profile_validity to match what's actually being synced.

Change-Id: I151874de8dde861dff280e1fc0e53e2ee1b60d84
Bug: 910596
Reviewed-on: https://chromium-review.googlesource.com/c/1356863
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612793}

The test legitimately fails when "prerender" value gets removed from
visibilityState as it is done in http://crrev.com/c/1356120

Unblock this change by removing the test. Traditional prerenders should
no longer happen, while nostate-prefetch should not ever look at
visibility state.

TBR=mattcary@chromium.org

Bug: 908582, 755921
Change-Id: I44da809f924b2730ac2b00fd85a1d1e484a3aacb
Reviewed-on: https://chromium-review.googlesource.com/c/1356939Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612792}

Except for sample_apk, which looks like it's a valid app on its own.

Motivation:
 * Trying to add a new JNI generator, and these targets were being
 difficult due to the tests having (unused) native methods that the
 under_test apk did not have.
 * The under_test apks didn't really make sense on their own anyways, so
 it's more efficent to just combine them.

Bug: 898261
Change-Id: I23571ea61230daefccb8e0e14689d3f872080136
Reviewed-on: https://chromium-review.googlesource.com/c/1352853Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612791}

This reverts commit b6e2cb9b.

Reason for revert: Causing WebKitLayout tests failure on linux:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76109
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76108

Original change's description:
> [EventTiming] Always buffer firstInput
> 
> Before, we'd buffer the firstInput entry only if it happened before
> onload. This CL forces firstInput to always be buffered. This means
> EventTiming code is called more in some tests, so the event hardware
> timestamp is no longer guaranteed to be nonzero, and a couple of xr
> tests require double RAF to avoid competing with the swap promises from
> Event Timing.
> 
> Bug: 841224, 843184
> 
> Change-Id: I942b934c387798c100da4ecfff52affb66ab94e8
> Reviewed-on: https://chromium-review.googlesource.com/c/1355880
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612703}

TBR=tdresser@chromium.org,npm@chromium.org

Change-Id: I4b2456f4b9f44798b3157bea960d84f72a50a8bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 841224, 843184
Reviewed-on: https://chromium-review.googlesource.com/c/1357404Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612790}

With Windows Japanese and Korean layouts, the OS returns
duplicate values so it appears that multiple keys return
the '\' char.

It should return the currency symbol (yen or won) instead
of the '\', but J and K codepage history means that
Windows will conveniently (or not) map these characters
to the backslash.

See:
https://web.archive.org/web/20131023080358/http://blogs.msdn.com:80/b/michkap/archive/2005/09/17/469941.aspx
for some history/background.

Bug: 910649
Change-Id: If27e4e46959fccd3da292365c521d7f3c4bb2a9b
Reviewed-on: https://chromium-review.googlesource.com/c/1356875Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612789}

Change-Id: Ic0f5e9a51da75f0e5f6e197a475b2920522c6336
Reviewed-on: https://chromium-review.googlesource.com/c/1357425Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612788}

This change fixes a UI bug where a hidden password was not correctly
updated when both the <password-list-item> and <password-edit-dialog>
were setting the same password at the same time.

Bug: 910081
Change-Id: If1ac5298ceebe1f12003083d87a85d1fa66a1f71
Reviewed-on: https://chromium-review.googlesource.com/c/1354275Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612787}

Previously when painting outlines we used LayoutObject::AddOutlineRects()
which adds outline rects in flipped blocks direction. The previous
flipping code in ObjectPainter::PaintOutline() was incomplete, and we
also missed the flipping in other places.

Add LayoutObject::PhysicalOutlineRects() which flips the outline rects
correctly.

Remove internals.outlineRects and internals.focusRingRects and convert
the layout tests using them into unit tests.

Bug: 910643

Change-Id: Ib8b3e0c7cd646e60378c09955ba26334f0f7f9e9
Reviewed-on: https://chromium-review.googlesource.com/c/1352503Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612786}

This converts Android WebView code to use the base-layer definition of
whether to enable developer-only features (in this case, the command
line). This also comments the BuildInfo method to mention Android's
definition of debuggability (IS_DEBUGGABLE), which could improve
discoverability.

Although this is a change in logic, this should not impact real
behavior, since "not equal to 'user'" should in practice be the same as
"equal to 'userdebug' or 'eng'," since these are the only three valid
values.

R=agrieve@google.com, tobiasjs@google.com

Bug: 908668
Test: N/A
Change-Id: I6007d564078a899567226a3777c02bfcffc16f75
Reviewed-on: https://chromium-review.googlesource.com/c/1351733
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612785}

This reverts commit b5edc37e.

Reason for revert: suspected to cause flaky failures in
SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames
While https://chromium-review.googlesource.com/1053907 enabled
the VizHitTestDrawQuad feature in fieldtrial_testing_config.json,
it doesn't seem to be applied to content_browsertests,
so this CL actually enabled that feature in this test and
possibly caused the flakiness. See crbug/910586.

Original change's description:
> Enable VizHitTestDrawQuad feature by default on TOT for cros.
>
> The OOPIF bug on cros was fixed
> https://bugs.chromium.org/p/chromium/issues/detail?id=877762,
> re-enabling VizHitTestDrawQuad by default for cros platforms.
>
> Bug: 804888
> Change-Id: I93cd237bc0631b6e1f77ae59232937697ce45ef2
> Reviewed-on: https://chromium-review.googlesource.com/c/1337644
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Ria Jiang <riajiang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608637}

TBR=sadrul@chromium.org,riajiang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 804888, 910586
Change-Id: Ic42c16a2b0547878e1e794069f2057f18a74b337
Reviewed-on: https://chromium-review.googlesource.com/c/1356887
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612784}

The tests sometimes use the personal data manager factory,
as in ChromeBrowsingDataRemoverDelegateUnittest.
The factory should distinguish between the two.

For the tests we should use the fake test source of autofill
profile validation, and not the real one.

Change-Id: I694bf487fc42176cfa874567908774f0f971094a
Reviewed-on: https://chromium-review.googlesource.com/c/1351771Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#612783}

To test it locally make sure that threaded scrolling is disabled and
use --enable-blink-features=OverscrollCustomization.
For further details please check the design doc:
https://docs.google.com/document/d/1CJgCg7Y31v5MbO14RDHyBAa5Sf0ZnPVtZMiOFCNbgWc/edit?usp=sharing

Bug: 907601
Change-Id: If3269ee73ac6c8d986b82ec451d8c50ad5fcc226
Reviewed-on: https://chromium-review.googlesource.com/c/1348850Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612782}

Updates the name to be consistent with the terminology used in the
corresponding protocol buffer and design docs. Also updates the comment.

Bug: 851163
Change-Id: I4f20f1e53d8db50301e0a23a34a03099968692b6
Reviewed-on: https://chromium-review.googlesource.com/c/1357301Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612781}

Upon entering an incremental step without stack such objects can be
flushed to a worklist that is processed in the regular marking loop as
the objects are definitely constructed at this point.

Bug: 843903
Change-Id: Ie4acbb7a58e7bedaee3b7806bdd18ca306ff14d7
Reviewed-on: https://chromium-review.googlesource.com/c/1350751
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612780}

Also moved xml.dict to //third_party/libxml/fuzz/.

Bug: 584819
Change-Id: Ie4bd02f3ae2559ce11676297ee1ed078901aa5e8
Reviewed-on: https://chromium-review.googlesource.com/c/1355853Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612779}

Updates the VR UI model to allow an array of controllers, each of which
will be rendered as part of the UI. This update introduces a concept of
a "primary controller" (largely for porting convenience) that is
currently always the controller at index 0 of the array. We may want to
improve the logic around that in future CLs.

Bug: 873274
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1a91f6550f4d051d35d872118c822f1b6716c614
Reviewed-on: https://chromium-review.googlesource.com/c/1171519
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612778}

Update the relevant failing ClientOnReceivedError2Test tests
(listed below) to not check for empty headers. Request headers
in onReceivedError callback may or may not be empty, this is
an implementation detail. In the network service code path
they may e.g. contain user agent, see https://crbug.com/893573.

Also add a comment in tests explaining this.

Fixed tests:
-ClientOnReceivedError2Test.testIframeSubresource
-ClientOnReceivedError2Test.testImageSubresource
-ClientOnReceivedError2Test.testMainFrame
-ClientOnReceivedError2Test.testUserGesture
-ClientOnReceivedError2Test.testUserGestureForIframeSubresource

BUG=893573,841556

Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ic6322c7d9720b62709c2b506639108ed2a36a188
Reviewed-on: https://chromium-review.googlesource.com/c/1356801Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612777}