GitLab

The legacy implementation of FETurbulence actually never generated
tile-able noise. The algorithmic problem was fixed in Skia
(https://codereview.chromium.org/332523006/), but Blink was also not
passing the tile size (filter primitive subregion) to the turbulence
shader. This change fixes the latter (small) problem.

BUG=383495
R=fmalita

Review URL: https://codereview.chromium.org/333783002

git-svn-id: svn://svn.chromium.org/blink/trunk@176121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ASSERT_ENABLED doens't have more not double negatives.

Note the #ifndef ASSERT_DISABLED in DatabaseThread.cpp was always compiled out
because ASSERT_DISABLED was always defined to be either 0 or 1.

Review URL: https://codereview.chromium.org/331793004

git-svn-id: svn://svn.chromium.org/blink/trunk@176120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function is iterating the stacking tree. It needs to ensure that the
stacking tree is up-to-date.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/331923002

git-svn-id: svn://svn.chromium.org/blink/trunk@176119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Styles are un-applied when an import with the style is removed.
The style however should be re-applied when the import is inserted back to the tree.

BUG=381052
R=dglazkov@chromium.org
TEST=import-readd*

Review URL: https://codereview.chromium.org/331763002

git-svn-id: svn://svn.chromium.org/blink/trunk@176117 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update SelectorQuery constructor to adopt CSSSelectorList object instead of
copying it. This CL adds a adopt(CSSSelectorList&) factory function to
SelectorQuery class to make this behavior obvious.

Copying a CSSSelectorList is relatively expensive and it should therefore be
avoided when possible.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/330713003

git-svn-id: svn://svn.chromium.org/blink/trunk@176116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently WebSocketChannel has methods subprotocol and extensions.
But they can be available only after the connection is established and
they don't change once set. Futhermore, there is didConnect notification
in WebSocketChannelClient.
This CL removes subprotocol and extensions from WebSocketChannel and
add them as WebSocketChannelClient::didConnect parameters.

BUG=384238
R=tyoshino

Review URL: https://codereview.chromium.org/334873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* TreeScopeEventContext
 Move to Oilpan heap.
* WindowEvnetContext
 Declare as STACK_ALLOCATED(), and remove Persistent<>s.
* EventPath
 Eliminate raw pointers.

BUG=

Review URL: https://codereview.chromium.org/336463002

git-svn-id: svn://svn.chromium.org/blink/trunk@176114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Strongly keep track of the current target.

For tidiness, also trace the 'parent' back reference on the XHR progress
event throttling part object.

R=zerny@chromium.org,ager@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/330273002

git-svn-id: svn://svn.chromium.org/blink/trunk@176112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cause of a flaky ASAN use-after-poison in media/video-frame-accurate-seek.html

R=ager@chromium.org, haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/333813004

git-svn-id: svn://svn.chromium.org/blink/trunk@176111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When conservatively tracing ListHashSets we can end up tracing the
ListHashSet itself where the ListHashSet backing has been marked
and is on the marking stack for later tracing. Therefore, the
asserts that the backing has already been fully traced if the
backing is marked when we trace the ListHashSet is invalid.

R=erik.corry@gmail.com, oilpan-reviews@chromium.org
BUG=375669

Review URL: https://codereview.chromium.org/336693007

git-svn-id: svn://svn.chromium.org/blink/trunk@176110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since this field is always set to true before being used only in WebURLLoaderImpl, this CL removes it entirely.

BUG=376025

Review URL: https://codereview.chromium.org/316353004

git-svn-id: svn://svn.chromium.org/blink/trunk@176109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176090

BUG=382872
TBR=ed@opera.com

Review URL: https://codereview.chromium.org/333873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTML spec update:
http://html5.org/tools/web-apps-tracker?from=8674&to=8675

BUG=332066

Review URL: https://codereview.chromium.org/329103003

git-svn-id: svn://svn.chromium.org/blink/trunk@176107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In GraphicsContextState::copy we use placement-new to overwrite the current
object. We need to first call the object's destructor though to not leak any
memory.

BUG=383548

Review URL: https://codereview.chromium.org/335613002

git-svn-id: svn://svn.chromium.org/blink/trunk@176106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Modules tests have been placed in top of LayoutTests. So, this cl moves navigatorcontentutils
to top of LayoutTests.

BUG=none

Review URL: https://codereview.chromium.org/335783003

git-svn-id: svn://svn.chromium.org/blink/trunk@176105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383749
TEST=none

Review URL: https://codereview.chromium.org/330763002

git-svn-id: svn://svn.chromium.org/blink/trunk@176103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes the flaky crash in screen_orientation/page-visibility.html

The willBeDestroyed callback of GeolocationController has not been called in either build since r175404.

In addition LocalFrame supplements receive an explicit callback when the LocalHost is torn down in order to perform coordinated cleanup. This callback can be removed again once LocalFrame is moved to the heap and it again dies together with its supplements.

R=ager@chromium.org, tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/335573004

git-svn-id: svn://svn.chromium.org/blink/trunk@176102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. Open page with javascript
2. Add breakpoint
3. Stop on breakpoint
4. Use live edit and save script
The test worked for Chromium revision until May 30.

Review URL: https://codereview.chromium.org/329533002

git-svn-id: svn://svn.chromium.org/blink/trunk@176101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/336693006

git-svn-id: svn://svn.chromium.org/blink/trunk@176100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://src.chromium.org/viewvc/blink?view=rev&revision=174436

r174436 was introduced to improve the performance, but
introduced some regressions for shadow styling.

Added a layout test based on the report in issue 383366
to prevent the same regression again.

BUG=383366, 372083
TEST=pass all layout tests.

Review URL: https://codereview.chromium.org/323423008

git-svn-id: svn://svn.chromium.org/blink/trunk@176099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

wrap() is called only when we fail to get a wrapper from DOMDataStore. In other words, wrap() is called only when a wrapper is created. This is a slow path, so we don't need to inline the function.

This reduces the binary size of Linux Release from 135279744 byte to 135230832 byte (saving 50 KB).

Review URL: https://codereview.chromium.org/331593006

git-svn-id: svn://svn.chromium.org/blink/trunk@176098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes binary size by 43 KB (Linux Release). I don't see any regression with this CL in Dromaeo.

Review URL: https://codereview.chromium.org/332973002

git-svn-id: svn://svn.chromium.org/blink/trunk@176097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves off the contents of V8XXX::domTemplate from V8XXX.cpp to V8DOMConfiguration.cpp. By doing this, we can decrease the binary size by 60 KB.

Review URL: https://codereview.chromium.org/336653004

git-svn-id: svn://svn.chromium.org/blink/trunk@176096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383985

Review URL: https://codereview.chromium.org/336653003

git-svn-id: svn://svn.chromium.org/blink/trunk@176095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Most of ColorMac.h is unused (except for one function, which is only
used in one file, but seems general enough to remain).

EmptyProtocolDefinitions.h is included only in one source file, which
does not refer to either of the protocol definitions it provides.

Review URL: https://codereview.chromium.org/336523003

git-svn-id: svn://svn.chromium.org/blink/trunk@176094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383749
TEST=none
R=yutak@chromium.org

Review URL: https://codereview.chromium.org/334833003

git-svn-id: svn://svn.chromium.org/blink/trunk@176093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Aggregate bindings are supposed to wrap the include of
interfaces that have [Conditional] on their definition with
ifdef, so these are not compiled if these are turned off.

However, this was broken so it didn't work,
and we couldn't turn it on, due to linking failure in SVG.
(I noticed this during a cleanup.)

This now can be turned back on, perhaps thanks to Kouhei's
fix-up of SVG bindings (or something Mahesh has been doing?).
Turning it on thus speeds up and simplifies compilation
somewhat.

(The only [Conditional] compilation flags on interfaces
are SVG_FONTS and WEB_AUDIO.)

I looked into this because of Mahesh's other Conditional fixes in:
Add support in generate scripts to handle Conditional
https://codereview.chromium.org/330093002/

R=haraken

Review URL: https://codereview.chromium.org/333803003

git-svn-id: svn://svn.chromium.org/blink/trunk@176092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Followup to:
IDL build: factor out global constructors action into a GYP template
https://codereview.chromium.org/319933002/

R=haraken

Review URL: https://codereview.chromium.org/328643002

git-svn-id: svn://svn.chromium.org/blink/trunk@176091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec:
https://svgwg.org/svg2-draft/struct.html#UseElement

BUG=382872, 313438

Review URL: https://codereview.chromium.org/323343004

git-svn-id: svn://svn.chromium.org/blink/trunk@176090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://whatwg.org/html#texttracklist

The test has also been submitted to web-platform-tests:
https://github.com/w3c/web-platform-tests/pull/1058

Review URL: https://codereview.chromium.org/336523002

git-svn-id: svn://svn.chromium.org/blink/trunk@176089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This removes some cruft added in:
Bindings for CSSOM View smooth scroll API
https://codereview.chromium.org/146003002
...which was done b/c [RuntimeEnabled] didn't work properly on
overloaded methods.

This has been fixed (thanks Jens!) and thus the cruft can be removed.

R=haraken
BUG=339000

Review URL: https://codereview.chromium.org/329303009

git-svn-id: svn://svn.chromium.org/blink/trunk@176088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is necessary because the coordinate system of the squashing layer may change
w.r.t. a squashed layer, even if the squashed layer's layout position did not change.
For example, a new layer may be added to a squashing layer that expands its bouds to the top
or left.

BUG=383779

Review URL: https://codereview.chromium.org/331693004

git-svn-id: svn://svn.chromium.org/blink/trunk@176087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This removes some cruft added in:
Add versions of stroke, fill, and clip that take a Path parameter.
https://codereview.chromium.org/137353004/
...which was done b/c [RuntimeEnabled] didn't work properly on
overloaded methods.

This has been fixed (thanks Jens!) and thus the cruft can be removed.

R=haraken
BUG=339000

Review URL: https://codereview.chromium.org/334803002

git-svn-id: svn://svn.chromium.org/blink/trunk@176086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently filename suggestions specified via a[download] are only honored if
the interface origin is allowed to read content retrieved from the target
resource origin. An embedder may enforce additional restrictions such as only
honoring the suggested name if there are no cross-origin redirects encountered
while fetching the resource.

The suggested filename determination algorithm at
http://www.w3.org/TR/html5/links.html#downloading-resources allows an exception
for data URIs. They should be considered same-origin as the interface. This
isn't currently the case since the origin of a data URI is considerd to be
unique and is not same-origin with anything since they lack a server-based
naming authority.

This CL implements the exception for data URIs so that they are considered
same-origin as their containing document for the purpose of handling the
suggested filename for a[download].

BUG=373182

Review URL: https://codereview.chromium.org/300543002

git-svn-id: svn://svn.chromium.org/blink/trunk@176085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVG images have unique security rules that prevent them from loading
any external resources. This patch enforces these rules in
ResourceFetcher::canRequest for all non-data-uri resources. This locks
down our SVG resource handling and fixes two security bugs.

In the case of SVG images that reference other images, we had a bug
where a cached subresource would be used directly from the cache.
This has been fixed because the canRequest check occurs before we use
cached resources.

In the case of SVG images that use CSS imports, we had a bug where
imports were blindly requested. This has been fixed by stopping all
non-data-uri requests in SVG images.

With this patch we now match Gecko's behavior on both testcases.

BUG=380885, 382296

Review URL: https://codereview.chromium.org/320763002

git-svn-id: svn://svn.chromium.org/blink/trunk@176084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176024

BUG=382884
TBR=jinho.bang@samsung.com

Review URL: https://codereview.chromium.org/328383005

git-svn-id: svn://svn.chromium.org/blink/trunk@176083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176060

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/336623005

git-svn-id: svn://svn.chromium.org/blink/trunk@176082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176047

BUG=371611
TBR=skobes@chromium.org

Review URL: https://codereview.chromium.org/330193004

git-svn-id: svn://svn.chromium.org/blink/trunk@176081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175857

BUG=267206
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/330513009

git-svn-id: svn://svn.chromium.org/blink/trunk@176080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175961

BUG=378610
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/327323012

git-svn-id: svn://svn.chromium.org/blink/trunk@176079 bbb929c8-8fbe-4397-9dbb-9b2b20218538