GitLab

The PopulatePrinterList() interface is not used anywhere, and can be
deleted.

The method to provide meaningful data back to tests which use this class
should be improved to be consistent by other changes to
TestPrintBackend, so that tests which use
PrintBackend::EnumeratePrinters() can get something meaningful.

Bug: 809738
Change-Id: I9da77434456ca9af4c75928b8465966f23cbed1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469230
Commit-Queue: Alan Screen <awscreen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817166}

https://dawn.googlesource.com/tint.git/+log/f2b8b6e87396..5afb002aa423

2020-10-14 dsinclair@chromium.org Add comments

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-chromium-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: enga@google.com
Change-Id: I4ecfb8b8526459aae20e27a1fd77a7f5f86804f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472578Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817165}

With SkiaRenderer on Windows overlay textures weren't kept alive after
the client destroys them if still in use. Implement something in
SkiaOutputDeviceGL that is similar SkiaOutputDeviceBufferQueue where we
keep a map of mailboxes to textures to keep alive. Instead of using
SharedImageRepresentationOverlay we have to use GLImage still as not all
Windows video paths are using shared image.

Bug: 1136194
Change-Id: Ibeb5726b914058c0868a90dcc9bca74a8499c660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462038Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817164}

Enforces that all GPU expectation files have the same tags defined as
a source of truth, and provides an easy way of applying that source of
truth to all files.

This is a step towards ensuring that all tags that get generated are
listed in the expectation files so that we can have stronger tag
validation in typ and get rid of the warning spam from generating tags
that aren't listed in the expectation file.

Bug: 1011107, 1111876
Change-Id: Ie11bbec08cb14baaccf99fd08eea45a751316014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459386
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817163}

Pressing F7 to toggle caret browsing was interfering with a Japanese
IME on Mac, but only when the omnibox has focus. There were no
conflicts when focus is in a web page. So to work around this issue,
ignore the F7 shortcut when focus is

It turns out Firefox has the same behavior: it ignores the F7 toggle
when focus is in its address bar. So that's good motivation that this
is the right fix.

There hasn't been any feedback about a similar issue on other
platforms, so scoping the fix to just Mac.

Bug: 1138475
Change-Id: I19b5ccaf9aec0b46c76e241887af60b0180a7338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472897Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817162}

This change uses the native_theme_aura.cc to set
correct dark mode styling for scrollbar corners.

Bug: 1096729
Change-Id: Ib79c3fc638edc4915943bada267e897763503ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469662Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Yu Han <yuzhehan@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#817161}

Componentize the remaining files for the renderer-side
phishing classifier located in chrome/renderer/safe_browsing/.

In this patch:
 - move files and unit tests to components/safe_browsing/
   content/renderer/phishing_classifier,
 - update build config files, deps and includes,
 - add DEPS,
 - add and initialize TestDiscardableMemoryAllocator to
   scorer_unittest, to make the test pass on bots.

Note:
browser tests remain in chrome/, because they depend on
chrome specific code.

BUG=1115700,1136950

Change-Id: I1df1cb0a858dc95c85b51b19a0af33ff9a246603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463569
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817160}

https://screenshot.googleplex.com/5AmhSc583y5es9f

Bug: 1125150
Change-Id: I56e8c087494527a8e8518d27f43c7a9148aae1ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466736
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817159}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea954d80edb7..08cdb1c17f2e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC msw@google.com,ftirelo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1126301
Tbr: msw@google.com,ftirelo@google.com
Change-Id: I27f786c98e2803d992c7ee022523c844de319b84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472617Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817158}

Updates text in script.
Changes gn args to provide more debugging information.
Updates version used for 85.

BUG=none
TEST=test only changes

Change-Id: Ibf18a9c829a3e1f7c4463ebfa68ba7d889a1614a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472438Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817157}

Originally the observer was only listening on DisplayMetricsChanged, but
in testing I noticed that was not sufficient as it didn't cover the case
of display removal. I've also added handling display added/removed so it
should catch all cases of display change now.

BUG=b:170780507,b:153111783
TEST=Display plug/unplug repeatedly is now handled for HDCP

Change-Id: Ie2ecbe2d494908dc51b4efd7bf4acf93555c09ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472020
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817156}

This fixes the way callbacks are run when OS hooks
are suppressed to post task in the same fashion as
actual OS hooks deployments. It also adds NotifyWebAppInstallWithOsHooks
to fix tests that were meant to depend on full completion
of web app install including OS deployments.

Bug: 1124383
Change-Id: I5fa170251acccbf6c0c8a085d85b2612ed2c01c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438892Reviewed-by: Phillis Tang <phillis@chromium.org>
Reviewed-by: Anqing Zhao <anqing@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817155}

These were added so chromevox properly updates the highlight
location when transform animations complete. Previously, the view
location was updated only when view bounds changed. This has since
been addressed in the views code, so app list specific workarounds are
no longer needed.

TEST=Enable chromevox, show the partial launcher with the highlight on
the search box. Expand the app list to fullscreen. Verify that the
highlight stays with the search box.

Change-Id: Iee6be1a1ec2173282a39e2af31e2df1204ab081b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472877Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817154}

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and a follow up will remove warning
  exemption.

Bug: 999886
Test: no errors building
Change-Id: I6d861d9e63cf93670087e56c80a624d5b69d038c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468789
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817153}

To ensure we are cleaning up native memory promptly this CL invokes
recycle on all bitmaps prior to ceasing to use them.

Change-Id: If76397cdd8f232eff9992763d2b1cf07ecaed07c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471598Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817152}

This method forwards to MediaStreamManager::OpenDevice(), which
DCHECKs for the stream type to be device video or audio capture
(i.e., webcam or mic). However, MSDH admits other stream types,
which cause MSM::OpenDevice to hit this DCHECK.

This CL ensures that a message containing an incorrect stream type,
which could be sent by a malicious renderer, results in killing the
renderer process.

Bug: 1135018
Change-Id: I3884dde95d92c41f44966a8ab1dd7bdfd4b23b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472397
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817151}

Bug: internal b/169779668
Test: CQ
Change-Id: If435dd5870d08d1fd2031588d3a0fae1c46e46f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469366Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817150}

When `OnViewIsDeleting` is called, the holding space item view is
already well into its destruction sequence. We shouldn't attempt to cast
from `views::View` back to `HoldingSpaceItemView` at this time and we
have no need to.

Bug: 1137461
Change-Id: I3c431af03b692d15b4e83de25d9ffcaa2b35d148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472584Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#817149}

Capture bar appears on the display with the mouse cursor. The other
displays are dimmed out. In fullscreen capture mode, users can move the
mouse to the other display to focus that display. In region capture
mode, moving the mouse to the other display does nothing, but pressing
the mouse on the display will focus that display.

Focusing a display will move the widgets and the layer owned by the
session to the display.

See videos in linked bug for demos.

Test: added test
Bug: 1133454
Change-Id: If237ca653736e94549d7005f09ecc9c8e94dc8c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440874
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817148}

The run time estimate is hardcoded for each gtest regardless of the platforms. This is inaccurate and will cause uneven sharding. Update to allow different estimate on different platforms.

Also removing some unused gtests.

Bug: chromium:1130157
Change-Id: I467f851e95f4aa2c4a7ad089a21862195eca42bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470117Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#817147}

Bug: None
Change-Id: Id27c9db1a9803149229ebf138ba6a8e729da2833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450727Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817146}

APP_INSTALL_EVENT will roll into UPLOAD_EVENT. No need for the division.

Bug: chromium:1078512
Change-Id: I2ce795e59dbf3a255b89dd4a4b3ae5172f78ede5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436328
Commit-Queue: Zach Trudo <zatrudo@google.com>
Reviewed-by: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817145}

https://chromium.googlesource.com/catapult.git/+log/f654dd2f225c..fb3d4294864a

2020-10-14 jleconte@google.com Fix 'Unknown git hash' when repository is not chromium.
2020-10-14 jleconte@google.com Fix DescribeHandler request for test_suite=='webrtc_perf_tests'.
2020-10-14 jleconte@google.com [pinpoint] Support Monorail projects in UI
2020-10-14 dberris@chromium.org pinpoint: Isolate Pinpoint-Multiple-MissingValues

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1119962,chromium:1133649
Tbr: wenbinzhang@google.com
Change-Id: Icf9705f548846c0fbfa773ce3ebf0055847c91d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817144}

Initiating a CopyOutputRequest for HDR content (e.g. cros overview
mode while an HDR video is playing) results in invalid output (and a
DCHECK failure [1]) because we can't convert a PIECEWISE_HDR
gfx::ColorSpace to a skcms_TransferFunction [2].

This CL remedies this issue by transforming unsupported color spaces
like PIECEWISE_HDR into sRGB inside GLRendererCopier and then
returning a transformed sRGB CopyOutputResult instead.

[1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/common/frame_sinks/copy_output_result.cc;l=118;drc=7a942548e0af7397f79bf07b4ca03ade10d04019
[2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/gl_renderer_copier.cc;l=549;drc=3e77a4cd58bab1daff8572b17af776ead811c8b8

Bug: 1136876
Change-Id: I796025f0dc3575849631fb37b66547172d47bc1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464100
Commit-Queue: Brian Ho <hob@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817143}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ib8c3d1a82847d27e04fa61b3825717136a778f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472697Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817142}

Change-Id: I1da7035e84173f5e9d8021ec3d2639f2ba96bf89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469261Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Cr-Commit-Position: refs/heads/master@{#817141}

When fulfulling RGBA_BITMAP copy requests, SkiaRenderer does not
pass a color space to asyncRescaleAndReadPixels which according to
the Skia documentation [1], means that Skia will default to a sRGB
conversion. However, when the color space isn't sRGB (e.g.
HDR videos), the non-sRGB color space is still passed via
ReadPixelsContext to initialize the SkBitmap [2]. Thus, even though
the image was converted to sRGB in the read, the SkBitmap reports
that it is in a non-sRGB color space.

This CL fixes this issue by explicitly providing a SkColorSpace to
asyncRescaleAndReadPixels via a conversion from gfx::ColorSpace.
Additionally, if the gfx::ColorSpace cannot be converted to an
SkColorSpace (e.g. PIECEWISE_HDR), fallback to sRGB. This fallback
fixes a null pointer dereference in Chrome OS [3], and for more
context, see the CL for a similar fix in GLRenderer [4].

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/skia/include/core/SkImageInfo.h;l=296;drc=a450ab794839b63f9c2ba982f738945f90e9fee2
[2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc;l=214;drc=a450ab794839b63f9c2ba982f738945f90e9fee2
[3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc;l=753;drc=e0789c0a2326279a3bac70012ca3edd3e46b5aa1
[4] https://chromium-review.googlesource.com/c/chromium/src/+/2464100

Bug: 1138518
Change-Id: I4ccd5b6e9af75caff917fa851281eae7ee8f10cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472437Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Brian Ho <hob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817140}

style preferences and Live Caption, on one settings subpage.

This CL makes some adjustments to the captions subpage in settings
according to the latest UX spec (https://docs.google.com/presentation/d/1YO10r3-ybP-L9uTNCClAQO9Er0gjwWMOLVKY98u59qU/edit#slide=id.g8ea378aef4_0_0):
 - Rename some strings
 - Change some indentations and spacing
 - Add the Live Caption toggle

The Live Caption toggle is removed from the a11y page for operating
systems that show the captions subpage (ChromeOS, Linux, some versions
of Windows). For operating systems that do not show the captions subpage
(MacOS, some versions of Windows) the Live Caption toggle is still shown
on the a11y page.

Bug: 1055150, 1111002
Change-Id: If4cb2b236ef0561a9cb75d7d921ede9fccf401af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468756Reviewed-by: Evan Liu <evliu@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#817139}

Implemented generic-hand-select using the MSFT hand interaction
extension.

Change-Id: I25595dfcf05fd0e23fb7ee9484c333321746fa0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469836Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Lachlan Ford <laford@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#817138}

Bug: 1106937
Change-Id: I2f660e20ecc0490ed4fb87acaf3b047b03e72fe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462225Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817137}

The ActivityServiceCoordinator used to get the popover's sourceRect from
the sourceView's bounds. Since Shared Highlight requires placing the
popover at some location inside a given UIView, we had to decouple the
two properties.

Bug: 1136043
Change-Id: Ica3294313f39c32c0edef0bd4bb2aa9443c0e1fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462244
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817136}

Cannot repro the ASAN crash on linux, this CL re-enable this test.

Bug: 838403
Change-Id: Id936de540668cc230d5ccf2fdba3f61bdcbf0ec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463456Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817135}

Hook-up the |shareLinkToText| method in LinkToTextMediator to a new
command which will be handled in the BrowserCoordinator. The latter
will make use of its SharingCoordinator to handle presenting the right
sharing scenario.

Bug: 1136043
Change-Id: I95ae7bdf5d5cee9c1538d43698753631f505c59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456288
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817134}

See https://crbug.com/1138540

TBR=lukasza@chromium.org

Bug: 1138540
Change-Id: I9c4aed146fce8642bb98e63aa8dd4b7c55b668cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472580Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817133}

Bug: 1136706
Change-Id: I3e713ae638d14b9d0d3a9af2357bd7147217d326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467580
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817132}

Skew tests are being added for the following versions:
1, 86.0.4240.75

TBR=estaab@chromium.org

Bug: 1041619
Change-Id: I8da60dd2875d416da905cb7f8c64546c0c2f384c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472259
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#817131}

No change to logic. This moves WebView's variations code into separate
folders with distinct OWNERS files, updates BUILD rules, and applies
automatic code formatting from git-cl format.

Test: autoninja -C out/Default system_webview_apk
Test: run_webview_instrumentation_test_apk -f *Variations*
Test: gn check out/Default android_webview/browser/variations:variations
Test: gn check out/Default android_webview/browser:browser
Change-Id: If405f2f840d37861d38f8d5b221ed5f2bc36de69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469356Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817130}

Starting with the crashers, which are more straightforward as obvious
defects. I haven't had a chance to look at all of these yet, but there
are a few different bugs causing issues.

This is the first in a series of CLs to get the bot green, at which
point we'll start whittling away at the failures.

Bug: 1138028
Change-Id: I4b10e3764fde283d548a840b99e045cd44e6ad4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469447Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#817129}

https://android.googlesource.com/platform/external/perfetto.git/+log/1410c33130bc..ca4153fa8b09

2020-10-14 taylori@google.com Roll trace processor
2020-10-14 treehugger-gerrit@google.com Merge "Add a new proto for ChromeRendererSchedulerState"
2020-10-14 simonmacm@google.com Merge "Update ugly suspend-resume heuristic for newer kernels."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I444e2f2a5bf2eb201acff7546060db8760cfcbd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471777Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817128}

Some tests failed due to changed expecation tags. no-use-skia-dawn means
no-skia-renderer or gl-skia-renderer or vulkan-skia-renderer.

Referring to crrev.com/c/2462222

Bug: 1138478
Change-Id: I3cfcc4385695e69252f521393f5407a8c0c84fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471818Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817127}