- 10 Mar, 2020 40 commits
-
-
Jesse Schettler authored
Bug: 1059779 Change-Id: Ib345da98f093452a21d575071fdc3872cd52619a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088403Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#748745}
-
Shouqun Liu authored
Bug: none Change-Id: I4d4059891719368e04f1fa4391dbe07fdda4e846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094067Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#748744}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I5a3ce15915d122ee6c12d2f5aaf9bc559758c4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095200Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748743}
-
Alex Ilin authored
At the end of the remote consent flow, the browser makes the second issueToken request. This request must use a login token of an account that the user has chosen in the consent UI. Gaia returns an id of this account in a consent result. This CL updates IdentityGetAuthTokenFunction to use the id returned in a consent result instead of the one that was originally chosen by Chrome. This CL also moves IdentityTokenCacheValue to use static factory methods instead of multiple constructor overloads. This makes obvious what type of a cache value is created instead of relying on argument types. Bug: 1026237 Change-Id: I59d5eefa7bbca91b59bb3d8cd69deca600580150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095302 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#748742}
-
Ehimare Okoyomon authored
Add strings for four-state radio buttons that will be used in cookie settings. Designs can be found in the bug. Bug: 1060118 Change-Id: I11ca66811510d93b3f00e730fcac639afaa7fa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096637 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#748741}
-
Rouslan Solomakhin authored
Before this patch, the RespondWithCallbacks class in payment_app_provider_impl.cc contained a number of public methods that were either not used outside of this class or not used at all. This patch moves a number of RespondWithCallbacks methods from public to private and removes one method that was never used. After this patch, it is more clear which part of RespondWithCallbacks is used outside of the class. Bug: 1005076 Change-Id: I1058137899177454cb786a91e16fe7f88dc8eaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089409 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#748740}
-
Jerome Jiang authored
BUG=1055917 Change-Id: I1d8e26b33528b3edb38723a6fd3282401a12b49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095400Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#748739}
-
Hesen Zhang authored
- fix the crash before loading native This is a reland of 4d4e25dd Original change's description: > [Prefetch notification service]: Java side and glue setup, feature flag. > > - Added a feature flag for the migration. > > - Added and hid new code path in OfflineNotificationBackgroundTask. > > - Created JNI bridge for gluing prefetch notification service in native. > > Bug: 1047037 > Change-Id: If7b728609f86665cfe6b4c61f521f7362000b292 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082087 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747323} Bug: 1047037 Change-Id: Ifb2d2b97a190c98b00ff2244c2f4d4ae879bdac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095875Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748738}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibac6eebb9f5c1b4b20d90fa61075c92a45089c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096322Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#748737}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf9df5292254..eaadca132fce git log bf9df5292254..eaadca132fce --date=short --first-parent --format='%ad %ae %s' 2020-03-10 sigurds@chromium.org [COEP] Add links to future COEP/COOP article Created with: gclient setdep -r src/third_party/devtools-frontend/src@eaadca132fce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051473 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I76ddf0000291b43671f3976e04a16447a7fb3edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096544Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748736}
-
Ken Rockot authored
This is a reland of 1b21e379 Unmodified from the original, which was reverted to revert a preceding change. Original change's description: > Migrate URL and Origin typemaps to GN definitions > > Also moves some longer bits of code out-of-line. > > Bug: 1059389 > Change-Id: Idd1b3606e26504ab92e9aefebc933823919a2431 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092695 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748058} Bug: 1059389 Change-Id: Ifd8edc62b361cd5947e6161758ce310c2c912556 Tbr: dcheng@chromium.org Tbr: dtapuska@chromium.org Nopresubmit: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095943 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#748735}
-
Jonathan Ross authored
This test has begun flaking regularly on Windows. Marking as RetryOnFailure so that we can hopefully handle the flakes. TBR=ynovikov@chromium.org TEST= webgl2_conformance_gl_passthrough_tests deqp/functional/gles3/shaderloop_do_while.html Bug: 1060024 Change-Id: I5fb22fcf429699839d972dd8a6b512f5dbab48d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096089Reviewed-by:Jonathan Ross <jonross@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748734}
-
Rouslan Solomakhin authored
Before this patch, the classes in payment_app_provider_impl.h/cc used a combination of the deprecated DISALLOW_COPY_AND_ASSIGN and not specifying copying behavior. This patch removes DISALLOW_COPY_AND_ASSIGN and instead explicitly deletes the copy constructor and assign operator in payment_app_provider_impl.h/cc. After this patch, the classes in payment_app_provider_impl.h/cc use the current style of explicitly deleting their copy constructor and assign operator. Bug: 1005076 Change-Id: Ibae5b145927e2fd8e1e751605caf4aaa49b41ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090491 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
Sam Bowen authored
Support repeated property values of different types. The mojo file change from union to struct isn't compatible with Android so fork this file as well to avoid temporary build breakages in Clank. Also had to change module name to avoid duplicate build definitions. Open to better suggestions on this and the file name. Bug: 1055887 Change-Id: Iad691c45c25a404a4b560b604c63541f7feab89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073337 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#748732}
-
Corentin Wallez authored
Previously it didn't take a device client id, which meant the map associating shared images to texture reservations in the wire was global to the WebGPUDecoderImpl. This is incorrect because there is one wire per device. This CL adds the missing argument to DissociateMailbox and makes the associated shared image map a per-device thing. It also adds a regression test. Bug: chromium:1059777 Change-Id: Id4db2556dc19f90a13e1af6381f855f7d633e113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095123 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
-
Oriol Brufau authored
This patch adds LayoutInsideListMarker and LayoutOutsideListMarker classes for ::marker. The logic remains in LayoutListMarker for now, but this is a first step to implementing inside markers with LayoutInline and outside markers with LayoutBlockFlow, which will be necessary in order to support the 'content' property in legacy layout. TEST=blink/web_tests/editing/execCommand/create-list-1.html TEST=editing/pasteboard/drag-selected-image-to-contenteditable.html TEST=editing/pasteboard/input-field-1.html TEST=editing/selection/drag-to-contenteditable-iframe.html TEST=editing/selection/move-by-line-002.html TEST=editing/selection/selectNode.html TEST=editing/selection/selectNodeContents.html TEST=editing/unsupported-content/list-delete-001.html TEST=editing/unsupported-content/list-type-after.html TEST=editing/unsupported-content/list-type-before.html TEST=paint/invalidation/list-marker-2.html BUG=457718 Change-Id: I1eda402ac6e9b137031992257a0542fffa103639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094991 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#748730}
-
Yann Dago authored
Screenshot: http://screen/h5v2MCq2nzc Bug: 1050721 Change-Id: If946fd0077aa1db012f44359753f7a01fc6ecb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085753 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748729}
-
Friedrich Horschig authored
With this CL, the title and subtitle will change based on the progress and the status of the password check. Screenshots at the linked https://crbug.com/1047726#c31 Translation screenshots: IDS_SETTINGS_CHECK_PASSWORDS_ERROR_GENERIC.png: IDS_SETTINGS_CHECK_PASSWORDS_ERROR_NO_PASSWORDS.png: IDS_SETTINGS_CHECK_PASSWORDS_ERROR_OFFLINE.png: IDS_SETTINGS_CHECK_PASSWORDS_ERROR_QUOTA_LIMIT.png: IDS_SETTINGS_CHECK_PASSWORDS_ERROR_SIGNED_OUT.png: IDS_SETTINGS_CHECK_PASSWORDS_ERROR_TOO_MANY_PASSWORDS.png: IDS_SETTINGS_CHECK_PASSWORDS_PROGRESS.png: IDS_SETTINGS_CHECK_PASSWORDS_CANCELED.png: https: //storage.cloud.google.com/chromium-translation-screenshots/4de6e19b4772e8e130b87952ad8fcc10b79054e7 https: //storage.cloud.google.com/chromium-translation-screenshots/ce276f9b31384860c1369b11dd2844ed01d988d6 https: //storage.cloud.google.com/chromium-translation-screenshots/014f118ca023ad004523e7860746aae0a96f981d https: //storage.cloud.google.com/chromium-translation-screenshots/7685361448310ce06f9b704483d1ddd16721ee62 https: //storage.cloud.google.com/chromium-translation-screenshots/25b0c6ed74bd2313c5b7f954a7d34a0ec46cf2d7 https: //storage.cloud.google.com/chromium-translation-screenshots/31e9ccf14e6882a56ffffac5d6ee583e756b7136 https: //storage.cloud.google.com/chromium-translation-screenshots/d5a0c340e5f407e3347eb3323bd9c08b85c09f95 https: //storage.cloud.google.com/chromium-translation-screenshots/1b9d821e5ff2b0fcbf93c120f7e604f61eb6cb63 Bug: 1047726 Change-Id: I265376b6879427c3cbbc318d1d50bc1a0b89d969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087679 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748728}
-
Fergal Daly authored
The current behaviour is not consistent with the name and the two places that call CreateRenderFrameHost already have a call to GetRenderViewHost in their logic. This is a pre-factor for https://crrev.com/c/2084038/. Change-Id: Ib9a16101373f0027cb712c955501360425056a97 Bug: 1059678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089569 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Rodney Ding authored
See the crbug for more details on the related spec in v15. Bug: 1049698 Change-Id: Iaad730e14630e528a6041ac3a54cec23ded5ee27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085696 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#748726}
-
Joshua Pawlicki authored
TBR=andypaicu@chromium.org Bug: 1060175 Change-Id: I524dba2e7ebb9ed1bf1de3060912dfe7d4a66222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095968Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#748725}
-
Fergal Daly authored
Currently the ID is used only to signal that a widget exists, however this can be deduced by looking at the frame's parent (or lack of) and site instances. Previously the ID for this case was being generated in RenderFrameHostManager::CreateRenderFrame and passed all the way down. It's simpler to just generate one at the latest point possible. This is a pre-factor for https://crrev.com/c/2084038/. Change-Id: I5627e204c7afeab8b05bcb8a5f09a162e051c1c6 Bug: 1059678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089546 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The APIs haven't been used in a long while, presumably after https://crrev.com/1454983004. Change-Id: I1bfbc537663348e0e6c74f0a82e3df77911037d6 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095576Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748723}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/40d81599..c98aec6a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad5f5a4e331c5e4fd04a3ffb3b6b51bc1f8b17d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094665Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748722}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ib08e9e9d53de98bf9ed11a048cd8a853294b1f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096779Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#748721}
-
Tim van der Lippe authored
This target depends on the DevTools `all_devtools_files` target. We are in the progress of marking that target as testonly. `blink_devtools_frontend_resources_files` can be testonly itself, as `blink_web_tests` (which is the only target that depends on it) is marked as testonly itself. Bug: 1011811 Change-Id: Ic128457f5dba06992401e6c6d43550df1fa8c12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095063 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#748720}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c782263e5f19..b2678cfefedd git log c782263e5f19..b2678cfefedd --date=short --first-parent --format='%ad %ae %s' 2020-03-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5a78076c..29afd4ae (748288:748637) 2020-03-10 srte@webrtc.org Cleanup: Removes unused AimdRateControl field trials. 2020-03-10 ilnik@webrtc.org Reland "Wire up internal libvpx VP9 scaler to statistics proxy" 2020-03-10 phoglund@webrtc.org Hand protos directly to histograms and fix summary. Created with: gclient setdep -r src/third_party/webrtc@b2678cfefedd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I611e65e64cfce1d9db1be6d96fce09e86c0dbe06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096090Reviewed-by:
-
Clemens Arbesser authored
This adds a new interaction to the framework, which shows a calendar popup and lets the user set or clear a date from the specified range. Bug: b/145043394 Change-Id: I739e6b5ccb5821352b1ce63e63d8573bdde74f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093224 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#748718}
-
Lily Chen authored
This change extends expiry for a number of histograms emitted from the Cookie and Reporting/NEL databases in //net/extras/sqlite, and also removes a couple of them. They are useful as a debugging aid for users reporting problems loading/saving cookies. The one that is removed is {Cookie,ReportingAndNEL}.DBSizeInKB. Fixed: 1053115, 1052954, 1037004 Change-Id: I6eb0229758d7791e97dbff1e9b69195e14e760dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095438Reviewed-by:Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#748717}
-
Fredrik Söderquist authored
This cuts out one of the middle steps as well as the additional clip to |bounds|. We will be clipping the results of the filter anyway, so hopefully this extra clip step doesn't matter too much. When the full 'filter' syntax is supported on SVG content we won't be able to use the filter region clip in this way anyway. Bug: 109224 Change-Id: I8cf8799c8c0992b763291f57759ad7d83f98d258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096448Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#748716}
-
Greg Thompson authored
browser_policy_connector_ must outlive local_state_ in early shutdown cases where ownership isn't transferred away to the BrowserProcess. BUG=948265 R=rkaplow@chromium.org Change-Id: I1b79131b0668352743e8a4620910dbed3fbdc96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096577 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#748715}
-
Joshua Pawlicki authored
Bug: 1056621 Change-Id: I5bf7da8366018d9cff7c581d78ac1e2c8f8e962b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078411Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#748714}
-
Andrey Zaytsev authored
Safety check: renamed displayedString to displayString for consistency with the rest of the codebase Bug: 1015841 Change-Id: I65edf49f7224ab118ba164f9039fa1c717e578b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096696Reviewed-by:
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I87a7166d964b3229661b125e71288e9bf0eec6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095397Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748712}
-
Bruce Dawson authored
When building the 'chrome' target Mojo generates about 680 .cc files that contain no actual code. Due to the includes that are stamped out these files collectively take a non-trivial amount of time to compile. Detecting these files and deleting the #includes saves about ~1,200 to ~2,100 CPU seconds. The no-code detection doesn't work generically, but it handles the code which mojo generates. Bug: 1054626 Change-Id: Icb2feaa0021332e0a6d4c9e5cac314824578cd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093881Reviewed-by:
-
Maggie Chen authored
Bug:949839 Change-Id: Id84825c9b13a800c80a22ed3bf42b4056bc16343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084718 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748710}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I426f0455d698715bfdc9b256f3de6cb5492f640e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095198Reviewed-by:
-
Bo Liu authored
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1960465 With change above and with virtual context enabled, it is fairly likely that when a context is lost, the new context is created before the old context is destroyed. Since GpuChannelManager keeps using the same GLShareGroup, the new context will end up in the same share group as the old context. Avoid this by creating a new GLShareGroup in LoseAllContexts. Bug: 1059286,1052485 Change-Id: I1d60578fa6359329406d634fe04c7f242314839a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090137 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#748708}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ For these flags, ownership was claimed, but no expiration milestone was given. This CL attempts to act as a forcing function for owners to choose an expiration milestone. This CL sets M85 as the default expiry milestone for every flag in this CL. All owners have been responded with an LGTM or with a comment to change the expiry. Bug: 1058614 Change-Id: I40b40103f6a74aab185e8c7cebeceeb183476bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094238Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748707}
-
Andy Paicu authored
TBR=olka@chromium.org Bug: 1060165 Change-Id: I0f96c85b400ea05dd0bfbd9852d99b029cfdec02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096758Reviewed-by:
-
