GitLab

We currently send a request to ItemSuggest on login if the suggested
files experiment is enabled. This generates too much peak QPS, so we
would like to only issue this 'warmup' request if the user has ever used
the launcher before.

This CL:

1. Adds a synced pref to track whether a search result has ever been
   launched from the launcher.

2. Gates the warmup query behind that pref, so long as the gating itself
   hasn't been disabled via Finch (in case we want to reverse this
   decision later).

Bug: 1034842
Change-Id: Id226f94274fd0fb4fb89680eb90056894587c74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485995Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Rachel Wong <wrong@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819556}

This reverts commit de6e338e.

Reason for revert: Should be fixed by https://crrev.com/819550

Original change's description:
> Set use_vaapi=false in fuzzer builds.
>
> Bug: 1140770
> Change-Id: I0c9877f5cb24bb66c86df3577caee71a9fdca102
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487742
> Commit-Queue: Oliver Chang <ochang@chromium.org>
> Auto-Submit: Oliver Chang <ochang@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819249}

TBR=ochang@chromium.org,tikuta@chromium.org

Change-Id: If383a43d03d61b581df2451f133b2d5bfe4b09ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1140770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491220Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819555}

Move connectivity detector to a common directory. This CL does
not make any functional changes, but it allows for reuse
of connectivity detector by other features.

Change-Id: Ic3ac9693301eba47d4d44134fd609d1d6644416b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460831Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819554}

Make NQE signal strength unit test more robust by
approximately checking for the histogram count.

Bug: 1130720
Change-Id: Ic535966d94ec0a5b312f51c20b71dfceaf0be0e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484302
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819553}

https://android.googlesource.com/platform/external/perfetto.git/+log/d139f2661939..9606cffa66d0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ib1d0cc6496286387d8ce555068d9e746957efbe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489672Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#819552}

This will not have a speed up but will allow ANGLE to complete
the transition to the standalone test runner. Also increase the
sharding parameter for these tests. Right now they only run on
Android.

Bug: angleproject:5124
Bug: 1140626
Change-Id: I61847aa30e0b00226e5961b78bc29cac52c659e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489723
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819551}

Add libvpx as deps to libvp9rc instead to avoid duplication.

Bug: 1140770
Change-Id: I2bdeb2985008cc31eb24abff50a1da290192f50b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490506Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#819550}

This is a reland of 0397ac4e

The original CL was reverted because it caused two tests failures on
the win7 platform [1]. I think what happened I manually corrected the
rebaseline tool's merging of some of the expected files. These led to
not removing the expected files for these two tests on win7 platform.
And since CQ's win7 builder doesn't auto run, it CL passed where it
should have failed.

I've since removed these two invalid expected files from win7 platform.
In addition, I removed fuchsia/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-picker-appearance-expected.png
because its incorrect and I don't see the virtual suite tested on
fuchsia. Ran CQ on all platforms and they passed.

[1] https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/b8866243899672370144

Original change's description:
> [Controls Refresh] Update controls styles for dark mode
>
> This CL updates the dark mode styles for the following controls:
> 1. <meter> -  border color.
> 2. multi-select - foreground text color.
> 3. Button: Dark mode button design has no border and has unique fill
>    color. Thus, a specific set of color enums is created for only
>    buttons. Button's border color is styled to match its fill color
>    in order to give the appearance of no borders and keep its
>    dimensions unchanged. This impacts: button, file, and color
>    controls.
>
>
> Bug: 1107290, 1099624
> Change-Id: I141c199f93acac2b950b8af7195e863f811c2f4c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469357
> Commit-Queue: Yu Han <yuzhehan@google.com>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#818119}

Bug: 1107290
Bug: 1099624
Change-Id: I3097043a036da08dc201e0ce78ecc2ed1c94a1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485039Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819549}

This reverts commit 9d5ab21c.

Reason for revert: suspected to be causing Unknown function unpak("unpak_v3") errors
eg:
https://ci.chromium.org/p/chromium/builders/try/chromeos-arm-generic-rel/403265?
https://ci.chromium.org/p/chromium/builders/try/chromeos-arm-generic-rel
 
Original change's description:
> WebUI: Delete unpack_pak
>
> Remove unpack_pak.py script and associated rule and tests. grit + unpack
> rules are no longer needed to generate inputs for optimize_webui since
> the introduction of the new preprocess_grit rule.
>
> Bug: 1132403
> Change-Id: I52fed86461108904abe8e319f3a015e8daa21aa0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490332
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819539}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Ib27403a02332ca2bbae464930fa23882657d29f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1132403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490670Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819548}

CalculateAvailableWidthForTabs takes into account the fixed tabstrip
width for closing mode |override_available_width_for_tabs_|.

Bug: 1140423

Change-Id: I5bec3dde8f4b14990d4556a6c424d42b75acd89e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488881
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819547}

Switch kFailedToResolveAllHosts to the clearer kHostResolutionFailure to
denote when one or more hosts failed DNS resolution.

BUG=chromium:956783
TEST=unit_tests --gtest_filter=DnsLatencyRoutineTest.*

Change-Id: I0392df692919a55896e439edc5f53801d756873d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490069Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819546}

This change removes CrostiniAppRestartView, replacing it with:
* Construction and configuration of a bare View + DialogDelegate pair
* A pair of public functions that create and show this dialog

This change also adds some unit test coverage for this dialog to
ensure that I didn't break it when doing this refactor.

Bug: 1075649
Change-Id: I7de0e2386de14aa6aec8917c630f64a69df26832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490345
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819545}

https://dawn.googlesource.com/tint.git/+log/4f79c8405028..0ce070474164

2020-10-21 dsinclair@chromium.org Remove type alias struct variant.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-chromium-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I35688907dd5f9a260909610f875a4efaae580843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490164Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#819544}

Test runner will copy attachments from xcresult to output folder
(isolated output in infra) for all failed tests in each attempt.
Screenshots will be collected only from failing steps to avoid noise.
Other attachments will be collected from every step.
- Put the copy logic in private methods and called these in public
collect_test_results.
- Improved and unified variable naming where touched.
- Removed unused plist check where touched.
- Fixed and added tests for xcode_log_parser.

Bug: 1047704
Change-Id: I448c785a256702d93698e5c73ef89b7477efbc87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473499Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819543}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/553115ec991c..726aef930d80

2020-10-21 jalyn@microsoft.com Partial reland: Remove dependencies on ShortcutsScreen

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1140386,chromium:174309
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5c045c6ffe5bf6e73de481816c8c0dd603325bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490163Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#819542}

kOccludingDamageOnly in Viz.DisplayCompositor.RootDamageRect.Underlay is
no longer used.

Bug: 1117235
Change-Id: I7ed3b9572c4358eef9d6474d7988a95af8e0f46e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488986Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819541}

ComputedStyle::Animations() are null if all values are initial. If we
apply initial we don't need to create the object.

The same applies to CSSTransitionData.

Change-Id: I4c529a9df1764ba04560554892a46c452734d26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489621Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819540}

Remove unpack_pak.py script and associated rule and tests. grit + unpack
rules are no longer needed to generate inputs for optimize_webui since
the introduction of the new preprocess_grit rule.

Bug: 1132403
Change-Id: I52fed86461108904abe8e319f3a015e8daa21aa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490332Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819539}

x11::Input::Fp1616 should be treated as a signed integer, otherwise
-1 will underflow to 65535.  When dragging a scrollbar, this would
cause the scrollbar to snap to the bottom when the cursor is dragged
above the window's y=0 coordinate.  Verified that the issue is fixed
after this CL.

BUG=1139623,1136352
R=sky

Change-Id: Ie318006ceadde9b9ce3e267fb453ddeba0e81da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485620
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819538}

Once upon a time, mini_installer.exe created a directory in %TMP% in
which to place files while it performed its work. Since it may fail to
delete these files (e.g., due to crashes or interference by A/V
software), it was given the power to delete files left behind by
previous executions. This is all well and good, except that organic
system-level installs did this work in a user's %TMP% directory rather
than in the system's. Starting in r798844, mini_installer now puts its
work directory next to itself. For installs driven by Google Update, GU
will take care of (eventually) deleting anything left behind. Since this
appears to be working reliably, we no longer need the %TMP% cleanup
code.

One caveat to this change is that files/dirs may once again accumulate
in %TMP% if mini_installer is run from a directory in which it does not
have write access. This will never be the case for proper Google Chrome
installs.

BUG=1125018
R=forshaw@chromium.org

Change-Id: I50a768585d25ebdd508fc88f8036580a01bd8727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484651Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819537}

This fixes errors while building universal binary diff tools on official
builders. This didn't surface in https://crrev.com/c/2462242 because the
trybots don't build with official settings, so don't run dsymutil.

BUG=1119472

Change-Id: Ic6a29205cff50746ad25a0944bf961907af910a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488710Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Auto-Submit: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819536}

Roll Chrome Win32 PGO profile from chrome-win32-master-1603031994-5f3b6fcba7bce636145481c18ca09ca6363425d3.profdata to chrome-win32-master-1603227551-27f8a1799a335df211e237de1f87f7621bc18d2f.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I8be197cd3ca9c9aca1587c955c7a17c3660141e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488926Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#819535}

Currently it does the same thing as ExecutionContextCSPDelegate would,
but does so directly. It should flow through the same path, so that
the delegate is informed when policies are added whether from
accumulated headers or not.

This addresses a minor metrics issue whereby a use counter is bypassed.

Bug: 1110010
Change-Id: Ic06a426f172791c2225efec875bbbd041feeb4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487847
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819534}

This can happen if peer connections are created or garbage collected
inside of JavaScript event listeners triggered by OnSuspend which
closes peer connections.

Bug: chromium:1139153
Change-Id: I3d36c418f2f1a1e41886ff22901feeaaaee28029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489302Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819533}

WidgetMsg_Close was only sent for popups and was used to indicate the
browser destroyed the widget (possibly due to a focus change). To do
this without an actual message we add a PopupWidgetHost channel. If
the browser disconnects the channel then the popup widget is
closed.

BUG=1097816

Change-Id: I606dc2ef57b9b42eb45e3b638d88f2a8dc687a01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472424Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819532}

This patch inlines |NGLineBreaker::HandleText|.

This is a very small function with "inline", but while
investigating disassembly for an issue, it turns out that this
function is not inlined, and has |__security_check_cookie|.
This patch inlines it to avoid the cost.

This patch has no behavior changes.

Change-Id: I8d796a31fb952afc99c0caab427b96b4c503a9ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490336
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819531}

Add UserFeedbackProvider::CreateViewController method which takes
UserFeedbackSender as an argument. Downstream code will convert this
sender to Feedback category tag. This will allow to distinguish user
feedback sent from Tools Menu vs. SadTab.

Bug: 1138523
Change-Id: Ibd768abb170e447c9ee06f1d2a3384721318d920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485877
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819530}

Bug: None
Change-Id: If25e328730ca156187f164e12aa57df08fad2e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490881Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819529}

This reverts commit 0dcebcdd.

Reason for revert: Looks like component build is not quite fixed:
https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-dbg/1963?

Original change's description:
> Reland "Enable isolated splits in canary"
>
> This is a reland of b9d174e5
>
> This was reverted because it broke component builds, should be fixed by
> http://crrev.com/c/2490330
>
> Original change's description:
> > Enable isolated splits in canary
> >
> > All known issues have been fixed so enabling this in canary to see if
> > there are any major problems.
> >
> > Bug: 1126301
> > Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#819200}
>
> TBR=agrieve@chromium.org
>
> Bug: 1126301
> Change-Id: I343572b03f99ec201df4fb021c56d13233db623e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490682
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819512}

TBR=agrieve@chromium.org,cduvall@chromium.org

Change-Id: I0ff64b2047d25fab0b4fd5feb83f3568ceecf828
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1126301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490862Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819528}

Adds counterfactual param to ButtonRowWithPedals experiment. Also adds
entry for ButtonRowWithPedalsAndKeywordButton to match server-side
changes.

Browser tests are updated to reflect the keyword-mode-by-space being
disabled when the keyword search button is enabled.

Bug: 893183
Change-Id: I11aa0223d01436e065eb63e2baa57fc0118dedc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472434Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Angela Yoeurng <yoangela@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819527}

This lets us re-hide the implementing class and wire dependencies to its
constructor.

Bug: 1140188
Change-Id: Idbe3c9c9b061cb657a3a04fa60cb6fc2dece260f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486079Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819526}

Bug: 1117081
Change-Id: I655468fd6748b6e948edc0add545d6fbb7b3272a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489111Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819525}

This reverts commit f454440c.

Reason for revert: chromeos compile failed with a dirty tree. Ninja pointing to OS Settings as likely culprit:

"ninja explain: output gen/chrome/browser/resources/settings/chromeos/preprocess_v3/chromeos/os_settings.html of phony edge with no inputs doesn't exist"

https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/47276?

Original change's description:
> OS Settings: Update to use preprocess_grit
>
> OS settings is the last remaining user of unpack_pak. By migrating it to
> use preprocess_grit, unpack_pak can be deleted, preventing any new UIs
> from adding more usage. All UIs should instead use preprocess_grit
> (and, eventually, autogenerate grd files with generate_grd).
>
> Planning to update OS settings to autogenerate grd files in a followup.
>
> Bug: 1132403
> Change-Id: I5378836543befb224a82e58b0211bafba9aead64
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487885
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819485}

TBR=khorimoto@chromium.org,dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Ibaed7c55cc29a22bde6272d6a29f2ee201e79111
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1132403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490511Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819524}

On testdriver virtual authenticator tests, binary values were being
encoded as base64 instead of base64url. This didn't blow anything up
because the test values happened to have the same representation in
both, but is still a bug.

Bug: 1141104
Change-Id: I6edd7fdfd4ab0f9ae1d196d8f2e14ed2bd9e334d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490230
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819523}

This way we make sure to stop/start observing whenever a new FeedView
has been set, making sure the calls are balanced for all FeedViews.

Bug: 1122031
Change-Id: If6392e5b3e9692141b441162665aebd95ddd4b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490024Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819522}

https://chromium.googlesource.com/catapult.git/+log/2d615e49c1cb..982bf51c4052

2020-10-21 robdclark@chromium.org Add way to have a hidden container slice

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: skyostil@google.com
Change-Id: I0bbca1dafcd58dc472f4be83daf091d7f5fad829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489669Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#819521}

It is important to unsubscribe WebOTPService from SMS fetcher when
it gets destructed to avoid use-after-free bugs.

This currently happens in CompleteRequest() but we only call it if there
is a callback. At the moment using the existence of a callback as a
proxy for the existence of a subscription is safe because we only
subscribe when there is a callback. But it is more robust and safer to
unsubscribe unconditionally and not rely on the existence of callback_
as an indicator for a subscription.

R=kenrb@chromium.org

BUG: 1138161
Change-Id: Ic69191fa7d895b211508b84f1b90c973f0c386a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490260Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819520}

Two Texture Copying tests have begun failing consistently on the
ARM-based Apple DTK machines.

This change suppresses the tests while the root cause can be identified.

TEST=conformance/textures/misc/texture-copying-and-deletion.html
conformance/textures/misc/texture-copying-feedback-loops.html

Bug: 1141066
Change-Id: I63c40ccd01f4a8304b027738952ca862996181cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490482Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819519}

Bug: 1140588
Change-Id: Ib4429dd024d2571d574dcbd63d84dca6ec90e10a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488082Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819518}

This patch makes sure that cursor bitmap received via
wl_pointer_set_cursor is scaled correctly before creating the
corresponding PlatformCursor.

The previous approach had two issues:
1. The cursor size was incorrect for scale less than 200% since we used
default DSF (ManagedDisplayInfo::GetDensityRatio()) instead of the
effective one (Display::device_scale_factor()). This led to cursor
always being upscaled to 200%.
2. We didn't use the same logic that ash uses for scaling cursors:
ui::GetScaleForScaleFactor() + ui::GetSupportedScaleFactor(). So the
cursor size was different from ash when using fractional scale.

Bug: 1140175
Change-Id: Id034cb6d92718a01e3ac0a70047b1e4224b9cf96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485157Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Zakhar Voit <zvoit@igalia.com>
Cr-Commit-Position: refs/heads/master@{#819517}