- 06 Apr, 2018 40 commits
-
-
Tatiana Gornak authored
The AutofillAgent can be null in some cases. BUG=821502 Change-Id: Iada92ce5889643a3eda1d02cb499a16699e73015 Reviewed-on: https://chromium-review.googlesource.com/997797 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#548766}
-
Mikel Astiz authored
This reverts commit 5e4c7d7b. Reason for revert: Speculative revert for failing base_unittests on Android, CFIBacktraceAndroidTest.TestUnwinding. See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/579 Original change's description: > Fix conditions for can_unwind_with_cfi_table with frame pointers > > CFI table unwinder is not appilcable for builds with frame pointer > enabled. Make sure can_unwind_with_cfi_table is set to false. > No need to check for use_thin_lto. > > BUG=469376 > > Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6 > Reviewed-on: https://chromium-review.googlesource.com/992890 > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548634} TBR=thakis@chromium.org,ssid@chromium.org,pcc@chromium.org Change-Id: I1bb99a9cde8fd501bd5abb7aa7fe798684454226 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 469376,826718 Reviewed-on: https://chromium-review.googlesource.com/999635Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548765}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f8cdc74..1119ce6 BUG=chromium:823096 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7606c5a8f2ade19639098c752e7f35e6b7f68330 Reviewed-on: https://chromium-review.googlesource.com/999128 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548764}
-
Gauthier Ambard authored
This CL adds a metrics for the time elapsed between the time the user taps on a button and the popup menu is presented. Bug: 829343 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id978bd57ffa93adc0827a7810ca546c8272aded7 Reviewed-on: https://chromium-review.googlesource.com/999476 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#548763}
-
Maks Orlovich authored
Creation time is no longer unique (not that it ever was); (domain,path,key) is (as it's long been). Bug: 826322 Change-Id: I433fe3ceffd2b2cfeb5c27c7af0033d69e76301c Reviewed-on: https://chromium-review.googlesource.com/984514Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#548762}
-
Christopher Grant authored
This makes the testapp rendering code more closely match vr_shell_gl, alleviating the annoying hover issue (a button may stay hovered even when the reticle had moved away). BUG= R=ymalik Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6b1bd7006c9ff319c177d721a309d82906a69153 Reviewed-on: https://chromium-review.googlesource.com/998740Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#548761}
-
Vaclav Brozek authored
Currently, _CheckUniquePtr is run both on upload and on commit. This check emits errors, which means commit is blocked if it fires. At the same time, it has a history of false positives (one mentioned in https://crrev.com/c/933547, another in https://crbug.com/827961). Therefore this CL makes _CheckUniquePtr an upload-only check. Bug: 827961 Change-Id: I6d5a7f3dda33432ae1375359c2ae573e5ad3df34 Reviewed-on: https://chromium-review.googlesource.com/990133Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548760}
-
Mikel Astiz authored
The test is timing out on Mac. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Flayout_ng_experimental%2Fprinting%2Fwebgl-oversized-printing.html&showFlaky=true TBR=junov@chromium.org NOTRY=true Bug: 829804 Change-Id: I0ee14c1e9235222e9690daed12cc489dd81e6a6e Reviewed-on: https://chromium-review.googlesource.com/999602Reviewed-by:
-
erikchen authored
This CL is a refactor with no intended behavior change. By moving the settings into components/services/heap_profiling, they will be usable by Android Webview, which does not compile chrome/ Bug: 827545 Change-Id: I8b217344fcbc259499b5f7622cbfc9b8d21e3e83 Reviewed-on: https://chromium-review.googlesource.com/998017 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548758}
-
Mugdha Lakhani authored
Change-Id: I0a05f243c3406f560fd2c88a0212ce73ad289586 Reviewed-on: https://chromium-review.googlesource.com/997833 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#548757}
-
erikchen authored
This CL is a refactor with no intended behavior change. Bug: 827545 Change-Id: Id764a233ed364ec1d23f8540dfd1b1257fd7bb96 TBR: chrisha@chromium.org Reviewed-on: https://chromium-review.googlesource.com/998712 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#548756}
-
https://webrtc.googlesource.com/src.git/+log/83d676bd1505..3ab5c40f72ef $ git log 83d676bd1..3ab5c40f7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I96d9f10f9295b7a7b03fbc0a24e891b46f009f20 Reviewed-on: https://chromium-review.googlesource.com/998399Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548755}
-
kylechar authored
Add a CHECK that XOpenDisplay() doesn't return null when initializing Ozone X11. There is no point going any further, we are going to crash somewhere else and the crash stack isn't going to be as obvious. Original change in https://crrev.com/c/980596. Reland change with call to XInitThreaded() first still to avoid crashes. Bug: 806508 Change-Id: I0ca480b140da702946b4b75cd93c63cd388fdfca Reviewed-on: https://chromium-review.googlesource.com/997894Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#548754}
-
Ken Rockot authored
This is instead of having it reflect the allocation size, which may be larger than the requested size on some platforms. See bug for some elaboration. Also ensures that SharedMemoryMapping::size() reflects the requested size, and adds SharedMemoryMapping::mapped_size() to reflect the actual mapped size of the mapping. mapped_size() is used by SharedMemoryTracker. Bug: 829158 Change-Id: Ifde49f232548f865e8f8a6a1e5f948120f1b0ef0 Reviewed-on: https://chromium-review.googlesource.com/996811 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548753}
-
Boris Sazonov authored
This CL changes the layout for account picker in signin_view.xml so it uses wrap_content for layout_height instead of explicit height in dps. This is a follow-up to https://crrev.com/c/986262 that has done the same for the account row in the account picker dialog. Using explicit height for TextViews is dangerous as it may cause clipping when font scaling is enabled, especially with tall scripts. This CL also fixes ordering of XMLs attributes in the chunk it changes. Bug: 814728 Change-Id: Ie7d1c7c9ccc8eb56bff3653c06aedff39cd50bc3 Reviewed-on: https://chromium-review.googlesource.com/999593Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#548752}
-
Ramin Halavati authored
Traffic annotation auditor's clang tool switches path is changed to absolute path, and data dependency on it is corrected. TBR=msramek@chromium.org Bug: 690323 Change-Id: If3dd10339745c601d6a4e4d077b5251defe37af6 Reviewed-on: https://chromium-review.googlesource.com/999612Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#548751}
-
Jinho Bang authored
The related spec change: https://github.com/w3c/payment-handler/pull/276 Payment Handler feature is behind a flag: chrome://flags/#service-worker-payment-apps FYI, the original field type was `repeated string`, and the changed field type is `optional string`. So, if `enabledMethods` data is stored in a previous version, when reading the `method` field in a new version, the protobuf will read the first element of `enabledMethods`. Therefore, DB migration is not required. Bug: 828894 Change-Id: Ic5775768eaff9584517956f2984473e8b6a0a411 Reviewed-on: https://chromium-review.googlesource.com/986121Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#548750}
-
Elly Fong-Jones authored
This entire dialog will be replaced soon, but for now, remove the flag on Mac and the wiring that hooks up the flag. It's not currently possible to remove the dialog code wholesale because the NTP code for examining an app always uses ShowAppInfoInNativeDialog(). Bug: 828270 Change-Id: Ieae022a5a8733819eadbb41e95c9ce67f5e9e73a Reviewed-on: https://chromium-review.googlesource.com/998013Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#548749}
-
Mounir Lamouri authored
This is removing the kMediaOverlayPlayButton and resolves the issue of exposing only the play state to the accessibility tools with the new media controls. Bug: 829579 Change-Id: I4aa97ec6904933719bab02ef2451af0519230c03 Reviewed-on: https://chromium-review.googlesource.com/998553 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#548748}
-
Friedrich Horschig authored
By moving the keyboard accessory to chrome/browser, the following work for the new manual UI will be simplified by a large margin: - The entry point for the fallback sheet can be added directly - Buttons as needed for password generation can be added - styles can be unified by using default resources This CL mainly moves the files and modifies BUILD files accordingly. Only colors have changed to similar-looking colors that are already defined in Chromium (which is unproblematic this component is not user-facing yet and its final visuals are far from done). Bug: 828832 Change-Id: I6e9b9c9902468c010f72b717fd24de0bd81953af Reviewed-on: https://chromium-review.googlesource.com/995415Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Mikel Astiz authored
It's flaky on Win7 Tests (dbg): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=fast%2Fhistory%2Fhistory-back-twice-with-subframes-assert.html&showFlaky=true TBR=smcgruer@chromium.org NOTRY=true Bug: 829740 Change-Id: Icbe3428b6652e1bf2d701355a661acbd5d9b3cb9 Reviewed-on: https://chromium-review.googlesource.com/999483 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Martin Sramek authored
This was added in M66 as it was needed by ConsentAuditor. After an in-memory queue was added to UserEventService in https://chromium-review.googlesource.com/c/chromium/src/+/980975, it can handle events before the initialization of the persistent storage is finished, thus obsoleting the early initialization. Bug: 819296 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieca1cf50cb02ebf9e9336c0be755eb89b5b1de16 Reviewed-on: https://chromium-review.googlesource.com/999052Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#548745}
-
Jinho Bang authored
Until now, we had to use IsSecureContext() to check whether an execution context is a secure context manually. But we can use [SecureContext] instead of the manual check now. Related spec change: https://github.com/w3c/web-nfc/pull/143 https://github.com/w3c/web-nfc/pull/144 Bug: none Change-Id: I1396470cc57aeba137ddba65d1f29eb58cf9cf9b Reviewed-on: https://chromium-review.googlesource.com/989537Reviewed-by:
Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#548744}
-
jdoerrie authored
This change introduces a CHECK that the ranges passed to u2f_parsing_utils::Append do not overlap. Calling it with overlapping ranges results in undefined behavior if a reallocation is necessary during the Append operation. Bug: 780078 Change-Id: Ibc83c054bdf8dee81f293c54f980c6735fcc358a Reviewed-on: https://chromium-review.googlesource.com/999481 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548743}
-
Takashi Toyoshima authored
Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Idf30c00040eb3196902a4a611e2b51b00e995ca9 Reviewed-on: https://chromium-review.googlesource.com/996735 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#548742}
-
Fredrik Söderquist authored
Update FontDescription::BolderWeight and LighterWeight to match the table in https://drafts.csswg.org/css-fonts-4/#font-weight-prop . Bug: 809956 Change-Id: I18cb9a10ef3d86f68113bb0663e5364d0120a739 Reviewed-on: https://chromium-review.googlesource.com/997592 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#548741}
-
Vaclav Brozek authored
IOSFormParser is a class used on iOS to turn a HTML description of password forms into an internal PasswordForm structure. The class has no data members and the only method, Parse(), is thus effectively static. It was created as a class for two reasons: (1) to allow mocking, and (2) to enable holding some server-supplied state. I chatted with dvadym@ and we agreed that once this actually needs being mocked, we can assess the concrete needs, and perhaps change some alternative (e.g., providing a fake result for testing) to mocking which would still require adding a virtual interface and other boilerplate. Holding the server-supplied state might also likely end up in PasswordFormManager. Because it is confusing to create IOSFormParser instances in the current code and the two concerns above seem addressed, this CL turns IOSFormParser into a single static function, ParseFormData(), following the existing pattern found in components/password_manager/core/browser/import/csv_reader.h. Bug: 827945 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idbbd5087f301bb07974364f7b8bd324ed42a0fa5 Reviewed-on: https://chromium-review.googlesource.com/990333 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This adds support for: * Service worker intercepting the main script request for a shared worker. * Service worker intercepting subresource requests from a shared worker (i.e., importScripts, fetch/xhr). These tests now pass: external/wpt/service-workers/service-worker/claim-shared-worker-fetch.https.html external/wpt/service-workers/service-worker/shared-worker-controlled.https.html Here is the basic flow: 1) Renderer (Main): calls new SharedWorker() 2) Browser (UI): SharedWorkerServiceImpl starts preparing the shared worker. 3) Browser (IO): With this patch, here we create the ServiceWorkerProviderHost for the shared worker, and SharedWorkerScriptLoaderFactory (a URLLoaderFactory subclass) for loading the main script. 4) Renderer (Main): SharedWorkerFactory::Start is called by the browser. The URLLoaderFactory and provider host info are passed into it. It starts the shared worker, creating the shadow page and ServiceWorkerNetworkProvider. The network provider uses the browser-assigned provider_id. The shared worker uses the URLLoaderFactory to load the main script, via WebServiceWorkerNetworkProviderForSharedWorker::CreateURLLoader. 5) Browser (IO): SharedWorkerScriptLoaderFactory creates a SharedWorkerScriptLoader for the request. This loader behaves like NavigationURLLoaderNetworkService: it allows ServiceWorkerControlleeRequestHandler to interept the request (setting the controller and dispatching a fetch event), or goes to network. On redirects, it repeats for the new URL. 6) Renderer (Worker): After the worker starts up, it can make requests using importScripts() or fetch/xhr. importScripts() go to the main thread's WebServiceWorkerNetworkProviderForSharedWorker::CreateURLLoader like before, which forwards the request to the controller. fetch/xhr go through off-main-thread fetch, which also forwards the request to the controller. Unlike navigations, this doesn't pass SubresourceLoaderParams along with the response. This means the controller info (sent via the SetController IPC) can be received after the script response. To guarantee the controller info is received before starting the worker, a ping/pong to the ServiceWorkerContainerHost interface is performed after the script is received. Once the pong is received, we know the SetController IPC must have been received, so we can continue starting the worker. Design doc: https://docs.google.com/document/d/1KuzxwHMSgj4w-QH6f_Ks1QFcGjM36mEomGp6X-T3tqc/edit?usp=sharing Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia064cd694a41491cf4023202e44e96dba759e969 Bug: 796819 Reviewed-on: https://chromium-review.googlesource.com/981845 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Max Morin authored
Bug: None No-Try: true Change-Id: Id77f44682a682c7edbf0df365392737870ecfb5b Reviewed-on: https://chromium-review.googlesource.com/997744 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#548738}
-
Ramin Halavati authored
Change-Id: I57a7aab0e1dead805863f974aca238d09aa3162d Reviewed-on: https://chromium-review.googlesource.com/999487Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#548737}
-
arthursonzogni authored
Add a new Chrome Apps test. It tries to open a new window using chrome.app.window.create() with a file that does not exist. The callback must be called with createdWindow == undefined. Bug: 820995 Change-Id: Iaffe9373e2f19f30d473f3bd165c1a2822f85073 Reviewed-on: https://chromium-review.googlesource.com/986437 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#548736}
-
Marina Ciocea authored
Add implementation of media::mojom::AudioInputStream to audio service. This implementation is not used yet, it will be used in a future CL introducing input stream factory. UserInputMonitor is also not used, and will be moved to audio service in a future CL. Also removed AIC::Create branch that returns null if params are invalid, as params are verified many times along the way to AIC and should be valid. Bug: 803102 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib0b3c381bb9d5493e22047f13d093a87c252229c Reviewed-on: https://chromium-review.googlesource.com/975642 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548735}
-
Yuta Kitamura authored
This class is Blink's public interface, so its name should start with "Web". This is a follow-up of crrev.com/c/986112. Bug: 826203 Change-Id: I88933aa86fbe64c695cc10a76ce36edc1b981f7a Reviewed-on: https://chromium-review.googlesource.com/989386Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#548734}
-
Michael van Ouwerkerk authored
This reverts commit 023aea51. Reason for revert: Causing downstream compile failure. Bug:755921,710720,828968,829765 Original change's description: > Custom Tabs: permanently disable prerender from custom tabs. > > Removes the ability to set a prerender speculation mode for custom tabs, > making the background (hidden) tab the only option. Where appropriate, > method names mentioning "prerender" have been changed to > generically refer to "speculation". In one case shims for > shouldPrerenderOnCellularForSession, etc, have been left in so that > downstream code can be changed in a future CL. > > Bug: 755921,710720, 828968 > Change-Id: I7234fad18a9616ae65f20af39da4a0261cf75935 > Reviewed-on: https://chromium-review.googlesource.com/979992 > Commit-Queue: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548717} TBR=pasko@chromium.org,bauerb@chromium.org,gayane@chromium.org,lizeb@chromium.org,mattcary@chromium.org Change-Id: Ib6105a4f7f5d1721374e2b27ba818a86640b7903 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755921, 710720, 828968 Reviewed-on: https://chromium-review.googlesource.com/998895Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#548733}
-
Elad Alon authored
RunFunction() was verifying whether a value was returned, then the test bodies were also verifying the same thing. This CL fixes. Bug: 814402 Change-Id: I177053ee53d1f651ad0cda986b78148759ddcea9 Reviewed-on: https://chromium-review.googlesource.com/986266Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548732}
-
Erik Chen authored
The out of process heap profiler only requires modules to be dumped, not every single virtual memory region. This CL modifies the interface to support this, and updates the macOS implementation to be much faster. The other OSes currently still perform full address space dumps - this can be changed in the future if it proves to be a performance issue. Bug: 826913 Change-Id: Ibaa03d3dfae71a2b6d090aed0ab2ffdc4bb090a9 Reviewed-on: https://chromium-review.googlesource.com/986680 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Earlier this year, all kSha2Hash got longer names but two kSha256Hash must have remained, and now they ended up in the same translation unit and jumbo on Windows stopped compiling. This renaming follows the pattern of earlier renames. TBR=thestig@chromium.org Change-Id: I95b7d6b7e5f43f25bee8e98aa3eeeb4de9d7e55f Reviewed-on: https://chromium-review.googlesource.com/999415Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#548730}
-
Philip Jägenstedt authored
Bug: 829761 Change-Id: I1b7b0f849b9d28fa7b46a7fe789459ada7f94fe3 No-Try: true TBR: jsbell@chromium.org, pwnall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/998097Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#548729}
-
Farah Charab authored
normal priority queues. Modify the task queue selection and starvation logic, and add the relevent unit tests. Rename kHighPriority to kHighestPriority, and modify the affected code. The introduced priority is kHighPriority. Change-Id: If6d928180e8848f5492a64ce6a3d504219658376 Reviewed-on: https://chromium-review.googlesource.com/978011 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5418891.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "5418891.html" to "break_blockquote_at_end_of_content.html". Bug: 679977 Change-Id: I753287bf7be767e48f3547a2ecc319930a57a9a0 Reviewed-on: https://chromium-review.googlesource.com/999223Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548727}
-
