- 27 Apr, 2020 40 commits
-
-
Morten Stenshorne authored
As part of the descendants walk that we perform when adding a box fragment that establishes an inline formatting context, update the first/last-for-node bits directly. Many thanks to kojii@ for suggesting and helping out with this solution! Once we add the last box fragment for a node, finalize the inline items. In addition to associating with the LayoutObjects, also set the first/last-for-node bits, if fragment traversal is enabled. Since we now require the layout results to be available for anything that establishes an inline formatting context (to set the first/last bits), we also need to store the layout results for the column fragments. Columns are not really associated with a LayoutObject, but we'll use the legacy LayoutFlowThread for this. Another option would be to create an anonymous block child of a multicol container that establishes an inline formatting context, but I decided against that for now. Expanded some NGFragmentItemTest unit tests, and added a new one, to make sure that we behave in RTL situations. This allows for supporting these bits in culled inlines as well. Enabled fragment traversal in NGFragmentItemTest, so that we can test it, and removed DCHECKs in IsFirstForNode() and IsLastForNode(). The culled inlines test there also expects FragmentsVisualRectBoundingBox() to return something sensible, so remove the skipping we had in PrePaint for culled inlines, to just make this work. Will follow-up with cleaning up the first/last for node stuff added as part of CL:2111158. This will no longer be needed, but doing it in a separate CL is probably cleaner. Bug: 1043787 Change-Id: Id9873300e9ac5ec01d68aafd059a4aa3d830528b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152824Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#762758}
-
sandromaggi authored
Original failure: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/25109 Fixed test such that it's more robust towards smaller screens. [Autofill Assistant] Fixate bottomsheet in Talkback mode This CL fixates the height of the bottomsheet when Talkback is enabled. It also forces VisualViewport resizing. This is done, such that no element is highlighted under the bottomsheet. Bug: b/143944870 Change-Id: Ib2906b2c7955b7e57874084f2be325c761804798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167436Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#762757}
-
Alexander Hendrich authored
This reverts commit d1173dbd. Reason for revert: DomDistillerViewerSourceBrowserTest.UISetsPrefs flaky Original change's description: > Reland "Persist Reader Mode theme and font family settings on desktop." > > This reverts commit 23979013, which > reverted an earlier implementation of this CL in commit > a18fd063 due to > https://crbug.com/1065341. > > The main functional difference between this and the original version is > where the JavaScript code calls the pref-storing functions. They were > previously called inside useTheme() and useFontFamily() instead of the > UI callbacks. Changes to the synced prefs result in a series of > observers being notified, which ultimately led to the useTheme() and > useFontFamily() methods being called again, potentially leading to an > infinite loop and the behavior seen in the bug. > > The updateThemeSelection() method from the original CL was excluded in > this reimplementation because it was unintentionally never called in the > original CL. Omitting it helps reduce the scope of the CL and highlight > the important changes. > > Bug: 1016615, 1065341 > Change-Id: Ifd0e71027afd196267419ed81f7bdc0d78978a98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152901 > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Aran Gilman <gilmanmh@google.com> > Cr-Commit-Position: refs/heads/master@{#762524} TBR=dmazzoni@chromium.org,estark@chromium.org,wychen@chromium.org,gilmanmh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1016615, 1065341, 1075439 Change-Id: I222e95940848b68fa8158fd64aaca76048ed96db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167751Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#762756}
-
Piotr Tworek authored
The two affected files use memcpy and memset. Both functions are supposed to be defined in string.h / cstring. Unfortunately the affected files do not pull in this header. On Linux this works fine up until glibc 2.29. Starting with 2.30 the code fails to build. Most probably string.h was being pulled indirectly in glibc 2.29 and older. Bug: 1074286 Change-Id: Ia79cb76bb3cfb0d4062aec1a7688cc6e516b5bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164885Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#762755}
-
Piotr Tworek authored
There is a lot of code in the tree that uses various functions defined in string.h (memcpy, strlen, strnlen, memmove, etc), but never includes the necessary header file. At least on Linux it still works fine with bundled sysroots, or when using system headers based on glibc 2.29. Starting with glibc 2.30 this is no longer the case. There are quite a few files which fail to compile because the compiler can't see the definitions of some functions normally defined in string.h. Bug: 1074286 Change-Id: I24541cea1c1b43ec1d7bccdce1c504aebdf33f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164607 Commit-Queue: Piotr Tworek <ptworek@vewd.com> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#762754}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fb23afc21f05..65301cad4d44 git log fb23afc21f05..65301cad4d44 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 dberris@chromium.org Pinpoint: Introduce Job Priority Created with: gclient setdep -r src/third_party/catapult@65301cad4d44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064955 Tbr: wenbinzhang@google.com Change-Id: I1d5f51fd1f5999acf0c73b4e7a8af5eb359cdf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762753}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/981d590e8eba..78debd6f6d83 git log 981d590e8eba..78debd6f6d83 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 johnstiles@google.com Reland "Add Abseil to third_party." 2020-04-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 21c5af3151fb..3cb9c4bee9b3 (7 commits) 2020-04-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 132edc1c..9781ff27 (476 commits) 2020-04-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 91525d85792f..60aa34a990fa (5 commits) Created with: gclient setdep -r src/third_party/skia@78debd6f6d83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I44d318fb25608f8d724f54b80c89b1848c604f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167568Reviewed-by:
-
Kenichi Ishibashi authored
Before this CL ServiceWorkerNewScriptLoader and ServiceWorkerSingleScriptUpdateChecker converted URLResponseHead to HttpResponseInfo. This conversion is going to be done in the storage service (see [1] for the plan). This CL changes the signature of MaybeWriteHeaders() so that these two classes don't have to do the conversion. [1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/edit#heading=h.z6754cqqpv4k Bug: 1060076 Change-Id: I56bda5ce166d2fb08f825cbffa24bf5e04942e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160648 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762751}
-
Yuki Shiino authored
This reverts commit ad63cae8. Reason for revert: Suspicious causing test failures. https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18835 SyntheticGestureControllerTest.MultiScrollGestureMouse SyntheticGestureControllerTest.MultiScrollGestureMouseHorizontal SyntheticGestureControllerTest.SingleScrollGestureMouseDiagonal SyntheticGestureControllerTest.SingleScrollGestureMouseHorizontal SyntheticGestureControllerTest.SingleScrollGestureMousePreciseScroll SyntheticGestureControllerTest.SingleScrollGestureMouseScrollByPage SyntheticGestureControllerTest.SingleScrollGestureMouseVertical SyntheticGestureControllerTest.SingleScrollGestureTouchpadSwipe Original change's description: > Add key modifiers to gpuBenchmarking.smoothScrollBy to support page zoom > > In order to do a page zoom, we can press the Ctrl key and do a mouse > wheel scroll. therefore we should pass a key modifier to the > gpuBenchmarking.smoothScrollBy function to set the modifier of the mouse > wheel events. > > In addition, when I rewrite the layout test "wheel/wheelevent-ctrl.html" > that tests mouse wheel scroll with Ctrl key pressed, I found there is a > variable "sendGesture" in the eventSender.mouseScrollBy function, which > will not send any gesture scroll events when it is set to be false. It > is very strange to have this variable, because it does not nothing. I > think we should delete it. > > Bug: 1047176 > Change-Id: I1bc1f6f4e4c4e9774754bcba54a5aed00ee371ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131359 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762459} TBR=dcheng@chromium.org,bokan@chromium.org,lanwei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047176 Change-Id: I7522fcf742b6cceecad0d502f539e928e265a84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167639Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#762750}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-3608430-fix.html" to utilize |selection_test()| for ease of maintenance. This patch also makes the test independent from trailing space handling for preparation of migrating to EditingNG. Note: legacy layout keep trailing spaces in |InlineTextBox| but LayoutNG not. Bug: 707656, 679977 Change-Id: I8a54875576f9cc76d9a5873ee995a93a77fd1f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166241 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762749}
-
Piotr Tworek authored
The code uses memset and memcpy provided by string.h. It does not include this file however. On Linux this fails to build starting with glibc 2.30. Bug: 1074286 Change-Id: I549b02aad39ba0f022a2c84bfc2bb36c2ff31f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164508Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#762748}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37e4d79ae4da..f2c41c66492c git log 37e4d79ae4da..f2c41c66492c --date=short --first-parent --format='%ad %ae %s' 2020-04-27 szuend@chromium.org Restore old behavior in ResourceTreeModel Created with: gclient setdep -r src/third_party/devtools-frontend/src@f2c41c66492c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063012 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4785256d30309094b36bab75415d103580ac4c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167567Reviewed-by:
-
Timothy Loh authored
Instead of having 'Plugin VM' explicitly written out in the various strings, we should use a placeholder and have the name in a single place. This ensures the translations of this name will be identical. Bug: 1073795 Change-Id: I76f1ef2d81fc7baa69e2becc3af8381071315eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162386 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#762746}
-
Alexander Hendrich authored
TBR=dougarnett@chromium.org Bug: 1075446, 797328 Change-Id: If68a0f22b50a6dd848db6cce5b2442e4639f8a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166105Reviewed-by:
-
Armando Miraglia authored
Extended to November for re-evaluation. Fixed: 1055396 Change-Id: I7e6bab29967a23f73169515ae4736e81827211a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149651 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#762744}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: Id07722e5d42d9e4f1b855efcf5f2182c17cb9a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164831 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762743}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |CollapseTrailingSpace()| in |TextIteratorBehavior| and related things for improving code health. Note: This patch doesn't change behaviors. Note: This patch exposes differences between legacy and LayoutNG about trailing space to help implementing EditingNG. The legacy layout tree holds trailing spaces, e.g. "ab <br>cd", but LayoutNG doesn't. Bug: 707656 Change-Id: Ib7c5c4a1be39bb7f50d0aa9378e8d1148e682d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167633 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 84-4103.6-1586771664-benchmark-84.0.4114.0-r1 to 84-4103.6-1587378376-benchmark-84.0.4118.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifc8558158c25e59153797ff18d7944b235cd50cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167570Reviewed-by:
-
Rachel Carpenter authored
Bug: b/153377178 Change-Id: I64beda05358e880c49d52194bd90c435dd903689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166229Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#762740}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie3eff3c44f8f8e650ed7e2a508485542bd801497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167566Reviewed-by:
-
Armando Miraglia authored
This CL adds error reporting on the audio media element when playing a local track or a WebRTC track. The reported error can be caught via the onerror event handling and is of type Abort. The change was tested on both local track and pc track using WebRTC samples. Fixed: 1003751 Change-Id: I20a2a194f07417048d39b520d85e68e585821699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153033Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#762738}
-
Johann authored
Use the HeapMojoRemote wrapper so that Oilpan will GC the object. BUG=chromium:1049056 Change-Id: I387365fe5a52180547aa8c1728bc3b6c31cffcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147975 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#762737}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1ae3e75a0b4c..981d590e8eba git log 1ae3e75a0b4c..981d590e8eba --date=short --first-parent --format='%ad %ae %s' 2020-04-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 635239faf8ef..00b90ea83262 (4 commits) Created with: gclient setdep -r src/third_party/skia@981d590e8eba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I4388e7116ade65ff55fe127abc4e2c7f772c3ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167565Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1593580f3521..37e4d79ae4da git log 1593580f3521..37e4d79ae4da --date=short --first-parent --format='%ad %ae %s' 2020-04-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@37e4d79ae4da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I08405346d1a33c4271f9167063db38e4e8be9ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167563Reviewed-by:
-
Yuki Shiino authored
This reverts commit 0823e911. Reason for revert: Suspicious to have caused crashes on Win7 Tests Dbg. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/82323 A lot of NaCl / PPAPI related tests crash. Original change's description: > Exchange SandboxType::kInvalid for a CHECK. > > No processes should be launched with an invalid combination of flags for > sandboxing. This eliminates SandboxType::kInvalid and adds a CHECK at > the point where the command line is parsed when child processes start. > > Unit tests exist for this code and continue to pass. Tests that > verified that bad command lines were recognized are now removed as > Chrome will safely CHECK in these cases. > > The following changes in default or behavior:- > > * cloud print service (--type=service) now reports kNoSandbox > * NaCl loader process on non-Mac now reports kUtility > - The NaCl loader defines its own sandbox but its command line > is processed in some tests and needs a valid value. > * Fuchsia: sandbox types are now enumerated and the type must be > specified when the low level sandbox policy is constructed. > * Linux: type added for Zygote to have before it grows up to get a > real sandbox > > Bug: 1065087 > Change-Id: Ibe277153fa58771d12bae7e3c2f9c6b92b9370a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120049 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762525} TBR=wez@chromium.org,jam@chromium.org,rsesek@chromium.org,ajgo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1065087 Change-Id: Ic2384481d0832b6513434102b7da96512678d744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167636Reviewed-by:
-
Koji Ishii authored
This patch moves all functions that: a. Do not need text, and b. Do not need root/range. to |NGInlineCursorPosition|. This patch has no behavior changes. Bug: 982194 Change-Id: If6fdb5984ad6f96557cca4bef9ae21aa2932c08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167640Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#762733}
-
John Z Wu authored
Translation are normally offered automatically if the translate internals thinks translation is necessary according to page language and the user's settings. But in cases where the user still wants to translate, this method can be used to manually trigger translation offers. Change-Id: I4f71ed0142a3fec6438b883c87b514c0749a8acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163036 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#762732}
-
Yoshifumi Inoue authored
This patch gets rid of unused enum member |NGOffsetMappingUnitType::kExpanded| for improving code health. Change-Id: I13331a6974e30e6b7b583be2cee1d1989b003ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167637 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Fergal Daly authored
Change-Id: I9e31d6465e4f4cd710611ffea990ded46ee6bb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154625Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#762730}
-
Christopher Lam authored
This CL plugs cros_colors.json5 into the AshColorProvider by generating a C++ header that maps color names to their final values at compile time. Bug: 1018654 Change-Id: I52f21e859be704504ce430b5d558c96b60b1fb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154350 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#762729}
-
Eric Willigers authored
In unit tests, WebApps::Connect() would previously never lead to never signaled it was ready. WebApps: :StartPublishingWebApps() being called as the web app provider Change-Id: Iadc02947ecca2dd29d74fef91a83279733537bea Bug: 1074111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162433 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#762728}
-
Kramer Ge authored
video_encode_accelerator_unittest failed under OzoneDrmMojo. ui/ozone/public/ozone_gpu_test_helper needs to be changed to binding mojo endpoints instead of forwarding IPC messages. Bug: 620927,806092 Change-Id: I9399eff2f1a681f82feb5e027af76a8fb8712d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163408 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#762727}
-
Sasidhar Sanapala authored
https://screenshot.googleplex.com/hGiyMOp7FLA R=wrlewis@google.com Change-Id: I29c8907d760be6e0332638c29917624c41df5a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147633Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Sasidhar Sanapala <ssanapala@google.com> Cr-Commit-Position: refs/heads/master@{#762726}
-
Johann authored
Pass EC in instead of the task runner. Puts the task type in the dispatcher class instead of the calling class. Dropped std::move: error: moving a temporary object prevents copy elision Also paves the way for some new objects which will need the execution context. Change-Id: Id0608ccf129443532091e7bdfe0afccb146172ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152134Reviewed-by:
-
Ramin Halavati authored
Extra IsSameProfile is removed from ChromeExtensionsBrowserClient and a browser test is added to ensure it's working as expected. Bug: 1033903, 727487 Change-Id: I7245f8b9491582674a1428d0f09500e4e443ba39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164627Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#762724}
-
Koji Ishii authored
This is a left over from r762697 <crrev.com/c/2166202>. This patch has no behavior changes. 982194, 1035773 Change-Id: I3b094e02b840c0f7bf36abaeb2ac38c8748abb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167635 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Implement WebAppInstallObserver::SetWebAppInstalledDelegate. It will be used with lambdas in sync tests. Bug: 1020037 Change-Id: I01f5a60bd24f3b74dd52d62f3d7d61bdf477d929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162401 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#762722}
-
Yutaka Hirano authored
On Windows the function requires system fonts to be "Segoe UI", which is overly restrictive when we are not interested in layout. Bug: 1074776 Change-Id: I8ac77928c0049eec67b7f0944872f3b5cc2b96b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166232Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#762721}
-
Yuki Shiino authored
This reverts commit 7de90169. Reason for revert: Suspicious to have broken DomDistillerViewerSourceBrowserTest.UISetsPrefs in browser_tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37476 Original change's description: > Refactor Reader Mode's JavaScript tests to use Mocha. > > The tests did not previously use an established test framework, making > tasks like executing certain code before or after every test and testing > asynchronous code more difficult. It should also be easier for > developers familiar with JavaScript testing in general and WebUI testing > in particular to read and write JavaScript tests for DOM Distiller and > Reader Mode. > > Follow-up work includes replacing the custom assert methods with Chai, > as well as writing more tests to cover existing functionality. > > Bug: 1027612 > Change-Id: I39acc923a0424881d2694281d9aa0323c8f9a913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992504 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Aran Gilman <gilmanmh@google.com> > Cr-Commit-Position: refs/heads/master@{#762551} TBR=wychen@chromium.org,gilmanmh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027612 Change-Id: I78b6b82e98c8f47951ab88e2056595de878f1ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166219Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Id199e13d0bff53e3fb4836d92fb72e61e7097091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167419Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762719}
-
