Commits · 7d4328f4fa95550f23f70f8246cab834fe109c55 · eriksson monteiro / tangled

28 Oct, 2014 33 commits

Standardize usage of virtual/override/final specifiers. · 7d4328f4

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=derat@chromium.org

Review URL: https://codereview.chromium.org/685543003

Cr-Commit-Position: refs/heads/master@{#301523}

7d4328f4

Standardize usage of virtual/override/final specifiers. · c71b15e5

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/676403006

Cr-Commit-Position: refs/heads/master@{#301522}

c71b15e5

[Password Generation] Always query password forms via Autofill · c57dd560

gcasto authored Oct 27, 2014

For other fields, we assume that if the author has specified autocomplete
attributes we should respect all their choices, including not trying to
determine field autocomplete values for fields that the author didn't specify.

This doesn't apply for password fields for two reasons. First, there is no way
for an author to specify generation for a particular field. Second, since
generation isn't a specced autocomplete value, the password field can reasonably
be set (e.g. "autocomplete=new-password") and also have generation enabled.

BUG=424793

Review URL: https://codereview.chromium.org/659793005

Cr-Commit-Position: refs/heads/master@{#301521}

c57dd560

telemetry: Remove obsolete benchmark aliases. · 0823191b

ernstm authored Oct 27, 2014

R=tonyg@chromium.org,dtu@chromium.org
BUG=426649

Review URL: https://codereview.chromium.org/684673002

Cr-Commit-Position: refs/heads/master@{#301520}

0823191b

cc: Full solid layers not at origin painted incorrectly · efe523e2

hendrikw authored Oct 27, 2014

Old code used a size, we now use a rect, and I didn't update the
quad clipping to use the origin offset.

We now correctly clip the quads, and I've updated the unit test
to use a visible rect that doesn't sit on (0,0), and will fail
without this change.

Though I wasn't able to reproduce it, it may also fix:
https://code.google.com/p/chromium/issues/detail?id=427467

BUG=18132446 (internal)

Review URL: https://codereview.chromium.org/678193002

Cr-Commit-Position: refs/heads/master@{#301519}

efe523e2

Standardize usage of virtual/override/final specifiers. · 34688b71

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/657923005

Cr-Commit-Position: refs/heads/master@{#301518}

34688b71

Roll src/third_party/WebKit bdffb34:33edc61 (svn 184473:184478) · bcfd1f3a

blink-deps-roller authored Oct 27, 2014

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bdffb34..33edc61

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/681913003

Cr-Commit-Position: refs/heads/master@{#301517}

bcfd1f3a

[webcrypto] Properly fail-fast when importing RSA key as JWK with bad usages. · 390613d6
eroman authored Oct 27, 2014
```
BUG=395904

Review URL: https://codereview.chromium.org/413523003

Cr-Commit-Position: refs/heads/master@{#301516}
```
390613d6

Remove stub ScrollEndEffectController · 9d751807

pkotwicz authored Oct 27, 2014

BUG=426561
TEST=None

Review URL: https://codereview.chromium.org/674303002

Cr-Commit-Position: refs/heads/master@{#301515}

9d751807

Standardize usage of virtual/override/final specifiers. · 9b1bc207

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=derat@chromium.org

Review URL: https://codereview.chromium.org/686553002

Cr-Commit-Position: refs/heads/master@{#301514}

9b1bc207

SyscallSet: add ValidOnly · 8340278f

mdempsky authored Oct 27, 2014

BUG=414363
TBR=jln@chromium.org

Review URL: https://codereview.chromium.org/657893006

Cr-Commit-Position: refs/heads/master@{#301513}

8340278f

Make browser GPU channel creation async. · 1a7a5129

jbauman authored Oct 27, 2014

This may help startup time.

Review URL: https://codereview.chromium.org/648413004

Cr-Commit-Position: refs/heads/master@{#301512}

1a7a5129

Standardize usage of virtual/override/final specifiers. · 0b8c9d7f

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sky@chromium.org

Review URL: https://codereview.chromium.org/683623002

Cr-Commit-Position: refs/heads/master@{#301511}

0b8c9d7f

Removes hard-coded 10K limit on file-size. · 8cd06158

anandc authored Oct 27, 2014

BUG=

Review URL: https://codereview.chromium.org/680643003

Cr-Commit-Position: refs/heads/master@{#301510}

8cd06158

Standardize usage of virtual/override/final specifiers. · 0c1f5ce4

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/686543002

Cr-Commit-Position: refs/heads/master@{#301509}

0c1f5ce4

Autofill - improve Macy's and Best Buy checkout by parsing input type="tel" · 1dbde9ea

estade authored Oct 27, 2014

for CVC and PAN fields.

BUG=427103,427012

Review URL: https://codereview.chromium.org/681843002

Cr-Commit-Position: refs/heads/master@{#301508}

1dbde9ea

Standardize usage of virtual/override/final specifiers. · 5b68c67d

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mdm@chromium.org

Review URL: https://codereview.chromium.org/682613003

Cr-Commit-Position: refs/heads/master@{#301507}

5b68c67d

Standardize usage of virtual/override/final specifiers. · 131bb7e6

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/681823004

Cr-Commit-Position: refs/heads/master@{#301506}

131bb7e6

Cleanup: Sync up ifdefs in pref_names.cc and pref_names.h. · ea0e4af3

thestig authored Oct 27, 2014

Review URL: https://codereview.chromium.org/673343003

Cr-Commit-Position: refs/heads/master@{#301505}

ea0e4af3

Adding instrumentation to locate the source of jankiness. · 535be343

vadimt authored Oct 27, 2014

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL instruments code invoked from HttpStreamParser::OnIOComplete's callback, which is responsible for 16.2 jph

BUG=424359
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/675273004

Cr-Commit-Position: refs/heads/master@{#301504}

535be343

Use cpuused=6 for lossy VP9 mode · b17047cc

wez authored Oct 27, 2014

BUG=260879

Review URL: https://codereview.chromium.org/678073007

Cr-Commit-Position: refs/heads/master@{#301503}

b17047cc

Log SSL_READ_ERROR and SSL_WRITE_ERROR in SSLClientSocketOpenSSL. · b8c23215

davidben authored Oct 27, 2014

The equivalent logs in SSLClientSocketNSS were never implemented here. This
will help in debugging problems which occur after the handshake.

BUG=425834

Review URL: https://codereview.chromium.org/651183004

Cr-Commit-Position: refs/heads/master@{#301502}

b8c23215

Standardize usage of virtual/override/final specifiers. · 2dec45fb

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/681913002

Cr-Commit-Position: refs/heads/master@{#301501}

2dec45fb

Standardize usage of virtual/override/final specifiers. · 3f5cbabd

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/681883002

Cr-Commit-Position: refs/heads/master@{#301500}

3f5cbabd

Standardize usage of virtual/override/final specifiers. · b1c24b60

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/683553002

Cr-Commit-Position: refs/heads/master@{#301499}

b1c24b60

Standardize usage of virtual/override/final specifiers. · d002275e

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/679273002

Cr-Commit-Position: refs/heads/master@{#301498}

d002275e

Standardize usage of virtual/override/final specifiers. · 5e6a48d3

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/685483004

Cr-Commit-Position: refs/heads/master@{#301497}

5e6a48d3

Standardize usage of virtual/override/final specifiers. · fbf9696f

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/686593002

Cr-Commit-Position: refs/heads/master@{#301496}

fbf9696f

Revert unintended prevention of seeks on infinite duration media. · 56359cbf

dalecurtis authored Oct 27, 2014

Preserves the looping behavior for 200-type sources, while reverting
the disabling of seeks for "non-streaming" type sources which report
an infinite duration. This reverts the unintended behavior change
from http://crrev.com/298565

BUG=412562,427412
TEST=live player works again. LayoutTest forthcoming.

Review URL: https://codereview.chromium.org/684473002

Cr-Commit-Position: refs/heads/master@{#301495}

56359cbf

Temporarily excluding failing test on valgrind/drmemory bots · d68b1649

Mitsuru Oshima authored Oct 27, 2014

BUG=427729
TBR=lanwei@chromium.org

Review URL: https://codereview.chromium.org/680183003

Cr-Commit-Position: refs/heads/master@{#301494}

d68b1649

Update a bunch of OWNERS files. · 0ee290d0

ben authored Oct 27, 2014

Remove v2.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/682713003

Cr-Commit-Position: refs/heads/master@{#301493}

0ee290d0

Move app_installer into chromium. · 511a873f

jackhou authored Oct 27, 2014

This code was previously in
https://chrome-internal.googlesource.com/chrome-app-installer.git

We're moving it to chromium with the goal of having it
eventually built as part of Chrome releases.

The third_party code is used to extract the tags added
by dl.google.com. Omaha uses this mechanism to tag their
meta-installers.

BUG=341353

Review URL: https://codereview.chromium.org/423293004

Cr-Commit-Position: refs/heads/master@{#301492}

511a873f

Standardize usage of virtual/override/final specifiers. · 4c112747

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/679243002

Cr-Commit-Position: refs/heads/master@{#301491}

4c112747

27 Oct, 2014 7 commits

Standardize usage of virtual/override/final specifiers. · 1f4538e0

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=derat@chromium.org

Review URL: https://codereview.chromium.org/680153002

Cr-Commit-Position: refs/heads/master@{#301490}

1f4538e0

· e19d49ab

Adam Langley authored Oct 27, 2014

net: add a batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#301489}

e19d49ab

MenuButtons enter Hover state upon Tap Down · c22434d2

jonross authored Oct 27, 2014

MenuButton will now respond to TAP_DOWN gestures, entering the Hover state. It will return to a normal state if the gesture is cancelled. Tap gestures that activate the menu will still cause it to enter a Pressed state.

This experiment is behind the flag switches::kEnableTouchFeedback

TEST=MenuButtonTest.TouchFeedbackDuringTap, MenuButtonTest.TouchFeedbackDuringTapCancel
BUG=398404

Review URL: https://codereview.chromium.org/674163003

Cr-Commit-Position: refs/heads/master@{#301488}

c22434d2

Refactor top_25 so only page class with custom Run.. logic is defined · 26757de9

nednguyen authored Oct 27, 2014

BUG=418375

Review URL: https://codereview.chromium.org/650293007

Cr-Commit-Position: refs/heads/master@{#301487}

26757de9

Cleanup: Remove unneeded chrome/common/pref_names.h includes. · 7e3b19da
thestig authored Oct 27, 2014
```
Review URL: https://codereview.chromium.org/674273002

Cr-Commit-Position: refs/heads/master@{#301486}
```
7e3b19da

net: add domain ID for Facebook. · fc62f189

Adam Langley authored Oct 27, 2014

Facebook domains were added with pinning in
https://codereview.chromium.org/673313002/. However, I omitted to add a new
domain ID for it. This resulted in it having an ID of zero.

The generation script has been updated to catch this in the future[1].

[1] https://github.com/agl/transport-security-state-generate/commit/641c7af7cac98a96386cd3fb3c4444316f8ea967

BUG=none
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/673843003

Cr-Commit-Position: refs/heads/master@{#301485}

fc62f189

mac: Update metrics for Fullscreen styles. · b4159bc3

erikchen authored Oct 27, 2014

I removed the metric "OSX.Fullscreen.Enter" because the confusion it was
causing outweighted the additional information it provided.

It has been replaced by 3 metrics:
  - OSX.Fullscreen.Enter.Style
  - OSX.Fullscreen.Enter.WindowLocation
  - OSX.Settings.ScreensHaveSeparateSpaces

BUG=414527

Review URL: https://codereview.chromium.org/640053007

Cr-Commit-Position: refs/heads/master@{#301484}

b4159bc3