- 03 Apr, 2020 40 commits
-
-
Peng Huang authored
Bug: None Change-Id: I722c93d7c69d23f343eee025ee06764dd068c01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135811 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756323}
-
Garrett Beaty authored
Change-Id: I33f82f7b93f9815c625cf6223492d2ebc66ea254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134193Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#756322}
-
Lei Zhang authored
They were added in https://crrev.com/569750 but never used. Bug: 809982 Change-Id: Idbc94dd315b487f19d4b2634c8c1936a94b38f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134912Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756321}
-
Peter Kotwicz authored
This CL: - Removes the remaining methods in WebApkActivity. - Introduces BrowserServicesIntentDataProvider#getActivityType() BUG=1059580 Change-Id: Ic54d36b27bc6ca8ee3f4f83419b41f53ff6ab3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121444 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#756320}
-
Joe DeBlasio authored
This CL adds the new target embedding parameter for Safety Tips to the field trial testing config. This is a new feature that is only ever disabled by variations right now, so nothing user-visible is changing. The parameter was added in crrev.com/c/2119374 . Change-Id: Ie233c128d814a4048d5b89aca73fb637fda492ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134951 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#756319}
-
Salvador Guerrero authored
This CL adds DownloadService, StrikeService, TabStateDatabase and VideoDecodeStatsDB to the LevelDBClients suffix list so they can report histograms on their operations. Change-Id: Iaa10c4137fc7484019217bb9507e1d5f22cbb63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135168Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#756318}
-
Garrett Beaty authored
The CI builders that some of the waterfall try builders mirror were not correctly set up to be branched and have been moved from //buckets/ci.star to //versioned/trunk/buckets/ci.star. The CI builders that some of the waterfall try builders mirror were not included in the main console and have been added. The main console included a number of builders that are not mirrors of any waterfall try builders, presumably due to the now-removed requirement that the subwaterfall categories in the main console match the subwaterfall console. Change-Id: I2185fb00756c85d93ee64ed3f9926f2fcfec21ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134696 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#756317}
-
Finnur Thorarinsson authored
This changelist also refactors the FileEnumWorkerTask to facilitate easier testing. Functions createImageCursor and shouldShowCameraTile were added so that that behavior could be overridden during testing. Also, onCancelled was added so that the test would get notified when the thread has to be shut down due to an Exception being thrown (otherwise the Roboelectric test just hangs). Bug: 656015 Change-Id: Ie601a84c6e8028a57720ddaf9802eecd194c4f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127708 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#756316}
-
Daniel Libby authored
These three locations in code all have a DisableCompositingQueryAsserts disabler in order to query some compositing state. However, none of these operations are necessary in CompositeAfterPaint. In PaintLayer destructor, we won't have a composited layer mapping to clear in CAP. Enforce callers of ClearCompositedLayerMapping to have ensured that HasCompositedLayerMapping is true, clean up an unnecessary CAP check and more tightly scope the DisableCompositingQueryAssert to this function. PaintLayer::StyleDidChange queries compositing state to determine whether or not to call SetNeedsCompositingInputsUpdate. That method is a no-op in CAP. PaintLayer::DirtyStackingContextZOrderLists queries compositing state in order to mark the AncestorStackingContext's CompositedLayerMapping as needing a graphics layer update, which also is not needed in CAP. Bug: 1007989 Change-Id: I552b348a3bc4d6da196eaad90b05e25a6b470c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129090 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756315}
-
Ian Wells authored
This is a reland of b84a396f Original change's description: > Add InterestFeedV2 feature flag > > If enabled, the v2 feed stream loading task is kicked off when the NTP > or start surface is created. Not currently user-visible; this is > happening silently while the existing feed is created and shown. > > The binary size increase is mainly due to generated proto code that was > added previously but has not been linked until now. We are generating > the sources with "option optimize_for = LITE_RUNTIME;" which matches the > existing feed library and provides an acceptable speed/size tradeoff. > > Once the v2 feed component is fully launched, we can begin removing the > existing feed library. For a recent measurement of the binary size we > would eliminate by removing the existing feed library, see this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1829821. > > Binary-Size: The increase is temporary (see above). > Bug: 1044139 > Change-Id: Ic596d28e03300ad617f98f0b725cdf5ed1b0b986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132648 > Reviewed-by: Dan H <harringtond@chromium.org> > Commit-Queue: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756004} Binary-Size: Temporary. See the original CL description. Bug: 1044139 Change-Id: I820a43891b7db4e0b335a51e51fe452fe325f44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134936 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#756314}
-
Leszek Swirski authored
Adds a feature flag for enabling off-thread finalization of V8 streaming compilation tasks. This feature should reduce main-thread script compilation time. Bug: 1011762 Change-Id: I64bb986e07dae8d68dc61269e69096c368b1aac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135629 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756313}
-
Ahmed authored
DeskMiniView was changed from a Button to a generic View, but the actual button now is DeskPreviewView. The a11y node data should be initialized first by the button, before we add the extra attributes. Also announce the desk name if the miniview is selected. BUG=1067392c TEST=Manually Change-Id: I1646e0aeff95f089a9f2252532b09f2c7acdcb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134920Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#756312}
-
Peter Kasting authored
* Replace WidgetDelegate inheritance with composition. * Make window_ private. * Null |window_| automatically (via the WidgetDelegate) when it closes. * Replace manual Layout() override with FillLayout. * Slightly less random declaration order. Bug: none Change-Id: I9179f6d581d6b90d50c324aa81fccdbf200570fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135533Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756311}
-
Peter Kasting authored
A service factory may check the guest/incognito bits to determine which context to use. If these bits aren't set correctly before the various context-keyed services are created, the result could be the wrong service, no service, etc. Without this, apps::LaunchServiceFactory cannot be registered properly on startup. (Fixing that will happen separately.) Bug: none Change-Id: I75d545066e382a10ff3b5f7aff2db59fa7a6e4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135204 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756310}
-
Connor Clark authored
Change-Id: Ie9559c780d2b87365bb2b69c2111507e2da87bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134503Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@chromium.org> Cr-Commit-Position: refs/heads/master@{#756309}
-
Wenbin Zhang authored
Stop uploading perf data to perf dashboard on linux fyi. This is part of moving the upload workflow to the new VM. Bug: chromium:1045256 Change-Id: Ifb09b5ff12a56254c18edf41038f3952f03518ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132961 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#756308}
-
Lei Zhang authored
They are unreferenced after https://crrev.com/577514. Change-Id: Ie7173373d3f22a2f79302445cc2356e6b9ffb5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135147Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756307}
-
Sam Bowen authored
* Generate new code in entity_names to check whether an entity type is descended from another (including itself). * Use generated code in validator to validate nested entity types. They should match or be descended from one of the thing_types in the property config. Bug: 1065513 Change-Id: I0e2cfecf29e7b85a3f5f89c98b00ff708fb4ee19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134932Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#756306}
-
Egor Pasko authored
Since October 2019 the name of the autoroller bot name changed, stop checking for commit author name. Bug: 1066739 Change-Id: I192896ac3a2b4081352cccf148d5d6492ad45710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134302 Auto-Submit: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756305}
-
wutao authored
This patch will make the Chrome OS Settings ambient mode page in sync with the server. 1. Topic source radio button will be selected after the settings has been fetched from the server. 2. Changes of the selected topic source will update it to the server. Bug: b/148483925 Test: Modify the unittests. Change-Id: I9313b74bfb8d489da94923baab1207a4dcc6a834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125686Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#756304}
-
Wez authored
GetAmberRepo() may fail with an exception, in which case it is important both that system logs are available for diagnosis, and that the finally clause has access to the related variables that it expects. Bug: 1067446 Change-Id: Ieed6f957d458b360c867d68ffd104fb8b830111f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133977 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756303}
-
Hirokazu Honda authored
RtcVideoEncoder doesn't propagate the spatial layer configuration from werbct to VEA. crrev.com/c/2131444 adds the configuration for spatial layer to VideoEncodeAccelerator::Config. This delegates VEA the configuration from webrtc with SpatialLayer. Bug: 1030199 Test: None Change-Id: Ie7275abc31b2842f62ec50e2224ca140b5f8da3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131811 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756302}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 04f8669a. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 2fb88bb8 "Use integer coordinates for Actions.pointerMove." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Id1f29fed5caeb5027f1c5c39da757346bacbd95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135708Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756301}
-
Hirokazu Honda authored
This CL adds SpatialLayer to VideoEncodeAccelerator::Config so that a VEA client is able to configure a spatial layer encoding. The configuration is useful to configure temporal layer encoding too. Supporting temporal layer with vp9 hw encoder is a short term goal today. Design doc: https://docs.google.com/document/d/1yeCV36yhk9zna4qwngPiJGhSUkDyJHRlfEpziFgJfHo#heading=h.aeh6kjktcuzy Bug: 1030199 Test: media_unittests Change-Id: I1e0524a71b043ccfa0e41d08e8de4b86e9c17c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131444 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756300}
-
Katie D authored
The autoclick ring animation was spending 0ms in the GROWING state and then immediately entering the SHRINKING state, where both states were exactly the same. Removes the SHRINKING state and switches to spend the correct amount of time animating in GROWING. The extra state was a holdover from an earlier version of Autoclick which did have two animation states. This will also increase test coverage as SHRINKING was not covered. TEST: manual Relnotes: N/A Bug: 1067399 Change-Id: I2e349ee4cca8c10c7753b8b37ac8cf3ab2696fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134393Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#756299}
-
Eugene But authored
Bug: 620438 Change-Id: Iba4ec203858d779a2e91b45843b473349fd52e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134567Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#756298}
-
Jeff Yoon authored
wrong method call for aborted/timed-out tests in xcode runner when preparing std json format. Bug: 1067453 Change-Id: I8b1bb64adad7bfec760b63247c5b82dea9cfe2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134501 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#756297}
-
Boris Sazonov authored
This test has been flaky, so this CL adds waitForIdleSync to wait for UI to settle. It also adds an assert to verify that "Sync everything" toggle is turned off. Bug: 1059116 Change-Id: I3955eaa187c5ce9f57ac715fc416e9b88a5ac461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108555Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756296}
-
Raul Tambre authored
In Python 3 only bytes objects can be hashed. This means we need to encode() beforehand. Python 2 doesn't care, so this way it works on both. Traceback (most recent call last): File "../../tools/metrics/ukm/gen_builders.py", line 35, in <module> sys.exit(main(sys.argv)) File "../../tools/metrics/ukm/gen_builders.py", line 29, in main builders_template.WriteFiles(args.output, relpath, data) File "C:\Google\chromium\src\tools\metrics\ukm\builders_template.py", line 93, in WriteFiles HEADER.WriteFile(outdir, relpath, data) File "C:\Google\chromium\src\tools\metrics\ukm\codegen.py", line 89, in WriteFile output.write(self._StampFileCode(relpath, data)) File "C:\Google\chromium\src\tools\metrics\ukm\codegen.py", line 73, in _StampFileCode event_code = "".join( File "C:\Google\chromium\src\tools\metrics\ukm\codegen.py", line 74, in <genexpr> self._StampEventCode(file_info, event) File "C:\Google\chromium\src\tools\metrics\ukm\codegen.py", line 62, in _StampEventCode event_info = EventInfo(event) File "C:\Google\chromium\src\tools\metrics\ukm\codegen.py", line 36, in __init__ self.hash = HashName(json_obj['name']) File "C:\Google\chromium\src\tools\metrics\ukm\codegen.py", line 23, in HashName return struct.unpack('>Q', hashlib.md5(name).digest()[:8])[0] TypeError: Unicode-objects must be encoded before hashing Bug: 941669 Change-Id: I063ed268a8326b5acedbddc2628af7b015edb7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082551Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#756295}
-
Natalie Chouinard authored
Test succeeded 10/10 times locally on an emulator M tablet, so re-enabling to see if it's still flaky on bots. Increasing timeout to MediumTest either way since this is more than a simple unit test. Bug: 945293 Change-Id: I3d82eac071af9de75dae88dc2e60b3fe40892a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134612 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756294}
-
Rainhard Findling authored
* Safety check password check reuses the newly introducted strings for password check, instead of introducing separate strings. Bug: 1015841 Change-Id: I7ad111f1ef7b57b8e5df1073e8c84221e60f5be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132455Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#756293}
-
Antonio Gomes authored
... back to chromium web_test. The way how 'overflow:auto' elements contribute their scrollbar thickness to their intrinsic size is UA-specific [1]. This CL factors such checks out of css/css-flexbox/overflow-auto-006.html, back into blink specific web_test directory. The new test is t_p/blink/web_tests/css3/flexbox/overflow-auto-intrinsic-size.html Note: The test originated from web_tests/css3/flexbox/flexbox-height-with-overflow-auto.html, and was moved to wpt/css/css-flexbox/flexbox-overflow-auto-002.html in https://crrev.com/c/2120544 and then renamed to overflow-auto-006.html. [1] https://www.w3.org/TR/CSS22/visufx.html#overflow Issue=22580 BUG=1063749 R=robertma@chromium.org Change-Id: Ief1c2861e39a7eb66de3786e399774f647527a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135707Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#756292}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ide9135764534d061d777e3e7f88936a8b768dc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132201 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756291}
-
Natalie Chouinard authored
This reverts commit 4e6c1d9e. Reason for revert: Test still very flaky (see bug) Original change's description: > Re-enable testPaymentsIntegrationCheckboxClearsServerAutofillCreditCards > > Test succeeded 10/10 times locally, and no log data available on the bug > or flakiness dashboard (disabled >6 months ago). Re-enabling to monitor > whether flakiness still exists. > > Pre-emptively increasing timeout to MediumTest either way since this > test is more than a simple unit test. > > Bug: 994726 > Change-Id: Iaa645356906b17ff17c44cc49c4c76c7b9dac4d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134204 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Natalie Chouinard <chouinard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755973} TBR=nyquist@chromium.org,chouinard@chromium.org Change-Id: I82b8a2877bda92fc6d864d58f97b553130e820b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 994726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135327Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#756290}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Since there was already a similar test in WPT, this CL also renames that test to adding the -001 suffix to it, so that we can consistently add this new one as a -002 one. Additionally, this CL also adapts a bit the content of that previously existing test in order to contain as much metadata as the one being added now, that is, a link to the original chromium bug, a meta description, links to the same specs pointed also from the newly-added -002 test, and a consistent title. Bug: 1063749 Change-Id: I96781e53d1fa272d094937ff1582baac5b82c1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132161Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#756289}
-
Jonathan Freed authored
Change-Id: I6e00f1453a423ed9069e1870a0fa6c21230810ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135049Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#756288}
-
Corentin Wallez authored
This reverts commit 9dce00d2. Reason for revert: Causes crashes in the webgl_conformance_tests on Android. Original change's description: > Add DCHECKs to match deserialization errors > > Two checks about the DrawQuad rects were added as deserialization > errors. Add equivalent DCHECKs during serialization so the errors are > caught closer to the source in debug builds. > > Bug: 1066139 > Change-Id: I69665dd200d7ee2028fac6e55bd0264967ed9216 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134609 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756252} TBR=rsesek@chromium.org,kylechar@chromium.org Change-Id: I6a045401c94aedcaa200e4bb9bbb6ae52f72ad73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134238Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756287}
-
Javier Ernesto Flores Robles authored
This adds an skeleton for the credential provider service, which will be in charge of listening to the changes in the password store and keep Credential Provider data in sync. Bug: 1066803 Change-Id: Iedec647ff9a18f5aae013bd318d095019af65be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133928 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#756286}
-
Arthur Eubanks authored
Now that https://crbug.com/965937 is fixed. Partial revert of https://crrev.com/c/1624331. Change-Id: I9e73fdff99984601182ec142723a9d3521a9eb6e Bug: 897796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134702 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Auto-Submit: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#756285}
-
Peng Huang authored
Bug: 1066854 Change-Id: Ic0ef799e374b90a81504f9655913fb52a68f459e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135868 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756284}
-