- 30 Nov, 2018 40 commits
-
-
Xianzhu Wang authored
Previously when painting outlines we used LayoutObject::AddOutlineRects() which adds outline rects in flipped blocks direction. The previous flipping code in ObjectPainter::PaintOutline() was incomplete, and we also missed the flipping in other places. Add LayoutObject::PhysicalOutlineRects() which flips the outline rects correctly. Remove internals.outlineRects and internals.focusRingRects and convert the layout tests using them into unit tests. Bug: 910643 Change-Id: Ib8b3e0c7cd646e60378c09955ba26334f0f7f9e9 Reviewed-on: https://chromium-review.googlesource.com/c/1352503Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612786}
-
Nate Fischer authored
This converts Android WebView code to use the base-layer definition of whether to enable developer-only features (in this case, the command line). This also comments the BuildInfo method to mention Android's definition of debuggability (IS_DEBUGGABLE), which could improve discoverability. Although this is a change in logic, this should not impact real behavior, since "not equal to 'user'" should in practice be the same as "equal to 'userdebug' or 'eng'," since these are the only three valid values. R=agrieve@google.com, tobiasjs@google.com Bug: 908668 Test: N/A Change-Id: I6007d564078a899567226a3777c02bfcffc16f75 Reviewed-on: https://chromium-review.googlesource.com/c/1351733 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#612785}
-
Hiroshige Hayashizaki authored
This reverts commit b5edc37e. Reason for revert: suspected to cause flaky failures in SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames While https://chromium-review.googlesource.com/1053907 enabled the VizHitTestDrawQuad feature in fieldtrial_testing_config.json, it doesn't seem to be applied to content_browsertests, so this CL actually enabled that feature in this test and possibly caused the flakiness. See crbug/910586. Original change's description: > Enable VizHitTestDrawQuad feature by default on TOT for cros. > > The OOPIF bug on cros was fixed > https://bugs.chromium.org/p/chromium/issues/detail?id=877762, > re-enabling VizHitTestDrawQuad by default for cros platforms. > > Bug: 804888 > Change-Id: I93cd237bc0631b6e1f77ae59232937697ce45ef2 > Reviewed-on: https://chromium-review.googlesource.com/c/1337644 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Ria Jiang <riajiang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608637} TBR=sadrul@chromium.org,riajiang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 804888, 910586 Change-Id: Ic42c16a2b0547878e1e794069f2057f18a74b337 Reviewed-on: https://chromium-review.googlesource.com/c/1356887 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#612784}
-
Parastoo Geranmayeh authored
The tests sometimes use the personal data manager factory, as in ChromeBrowsingDataRemoverDelegateUnittest. The factory should distinguish between the two. For the tests we should use the fake test source of autofill profile validation, and not the real one. Change-Id: I694bf487fc42176cfa874567908774f0f971094a Reviewed-on: https://chromium-review.googlesource.com/c/1351771Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#612783}
-
Sahel Sharify authored
To test it locally make sure that threaded scrolling is disabled and use --enable-blink-features=OverscrollCustomization. For further details please check the design doc: https://docs.google.com/document/d/1CJgCg7Y31v5MbO14RDHyBAa5Sf0ZnPVtZMiOFCNbgWc/edit?usp=sharing Bug: 907601 Change-Id: If3269ee73ac6c8d986b82ec451d8c50ad5fcc226 Reviewed-on: https://chromium-review.googlesource.com/c/1348850Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612782}
-
Mike Wittman authored
Updates the name to be consistent with the terminology used in the corresponding protocol buffer and design docs. Also updates the comment. Bug: 851163 Change-Id: I4f20f1e53d8db50301e0a23a34a03099968692b6 Reviewed-on: https://chromium-review.googlesource.com/c/1357301Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612781}
-
Michael Lippautz authored
Upon entering an incremental step without stack such objects can be flushed to a worklist that is processed in the regular marking loop as the objects are definitely constructed at this point. Bug: 843903 Change-Id: Ie4acbb7a58e7bedaee3b7806bdd18ca306ff14d7 Reviewed-on: https://chromium-review.googlesource.com/c/1350751 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#612780}
-
Max Moroz authored
Also moved xml.dict to //third_party/libxml/fuzz/. Bug: 584819 Change-Id: Ie4bd02f3ae2559ce11676297ee1ed078901aa5e8 Reviewed-on: https://chromium-review.googlesource.com/c/1355853Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612779}
-
Brandon Jones authored
Updates the VR UI model to allow an array of controllers, each of which will be rendered as part of the UI. This update introduces a concept of a "primary controller" (largely for porting convenience) that is currently always the controller at index 0 of the array. We may want to improve the logic around that in future CLs. Bug: 873274 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1a91f6550f4d051d35d872118c822f1b6716c614 Reviewed-on: https://chromium-review.googlesource.com/c/1171519 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#612778}
-
Tim Volodine authored
Update the relevant failing ClientOnReceivedError2Test tests (listed below) to not check for empty headers. Request headers in onReceivedError callback may or may not be empty, this is an implementation detail. In the network service code path they may e.g. contain user agent, see https://crbug.com/893573. Also add a comment in tests explaining this. Fixed tests: -ClientOnReceivedError2Test.testIframeSubresource -ClientOnReceivedError2Test.testImageSubresource -ClientOnReceivedError2Test.testMainFrame -ClientOnReceivedError2Test.testUserGesture -ClientOnReceivedError2Test.testUserGestureForIframeSubresource BUG=893573,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ic6322c7d9720b62709c2b506639108ed2a36a188 Reviewed-on: https://chromium-review.googlesource.com/c/1356801Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612777}
-
oysteine authored
This reverts commit 53e8b2a2. Reason for revert: crbug.com/910704 Original change's description: > Perfetto: Stop splitting _COMPLETE events > > The current Perfetto backend splits _COMPLETE trace events into > separate _BEGIN and _END pairs, as it's not very feasible to modify > existing events after they're written into the Shared Memory Buffers. > > This is causing some issues with the trace-viewer which has some > assumptions about the ordering of begin/end events vs. async events, > and is also bloating the sizes of traces and adding extra > overhead for the perf infra. > > Instead, we now keep the _COMPLETE events in an internal stack in > TLS and only emit them when we have their duration. > > R=eseckler@chromium.org,skyostil@chromium.org > > Bug: 909728,888558 > Change-Id: I80e37264de66d8bbcb6c9095d21047957fd6eb9f > Reviewed-on: https://chromium-review.googlesource.com/c/1354503 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612360} TBR=oysteine@chromium.org,skyostil@chromium.org,eseckler@chromium.org Change-Id: I0cda9ab36248042c3889d810bfd07a6d03a6d58e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 909728, 888558 Reviewed-on: https://chromium-review.googlesource.com/c/1357500Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612776}
-
Christopher Thompson authored
This CL changes the print preview handler to set kSettingHeaderFooterURL using url_formatter::FormatUrl rather than extracting the GURL::spec() directly. In particular, this allows safe IDNs to be displayed as unicode rather than punycode in the header/footer (matching how they are displayed in the omnibox). Bug: 910344 Change-Id: Iabed0e1821df29e5c2a5b6fc9953fa6d8cb3e10d Reviewed-on: https://chromium-review.googlesource.com/c/1356235Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/625db3890df8..6af3c5cbe4c7 git log 625db3890df8..6af3c5cbe4c7 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 33432579+alan-baker@users.noreply.github.com Clean uses of EvalInt32IfConst (#2145) 2018-11-30 ale64bit@users.noreply.github.com Validate PushConstants annotation and type (#2140) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6af3c5cbe4c7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I44eee178e652ecc7220ab0f3fde123235a214e34 Reviewed-on: https://chromium-review.googlesource.com/c/1357345Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612774}
-
Xiyuan Xia authored
- Add a kClientWindowHasContent property to pass the info from client to Window Service; - DesktopWindowTreeHostMus sets the property based on layer type and opacity of Widget::InitParams; - Check kClientWindowHasContent property as part of the remote window has-content check for occlusion tracking; Bug: 908629 Change-Id: I23c582d7135d50b70ba0776cb0368da59fe5d8c7 Reviewed-on: https://chromium-review.googlesource.com/c/1354439Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612773}
-
Aiden Benner authored
MASS REFACTOR - please consider fixing rather than reverting. The jclass parameter is never used in static JNI functions because we generate bindings ourselves for functions that are called by native. This CL removes the jclass parameter from all JNI methods by refactoring all current JNI method declarations that contain a jclass and stops the JNI generator from generating stubs that pass jclass to our implementation. This change is also being done to support the conversion of all non-static native methods to static native methods and then all static natives to the new JNI interface. When this is done proguard will be able to obfuscate classes that contain native methods. And native methods that don't rely on native TBR=agrieve # wide-reaching mechanical refactor Bug: 898660 Change-Id: Ie2932564d58933a2f4bcd23fe47723e147cf87d8 Reviewed-on: https://chromium-review.googlesource.com/c/1352518 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Joel Einbinder authored
This code was not used Change-Id: I57c742e34811807e091d8a833fa89ac0487e64bf Reviewed-on: https://chromium-review.googlesource.com/c/1356128Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#612771}
-
Martin Robinson authored
In the accessibility tree, each popup menu and its submenus have a native window. When using popup menus, the AtkWindow for the native window of the active menu should always have the ATK 'active' property. We listen to events associated with the lifetime active popup menus and use them to properly manage the 'active' property on this constellation of AtkWindows. Bug: 895921 Bug: 896392 Change-Id: I7a5e148feb8486bab7984f19c7ee2532b1fd16f0 Reviewed-on: https://chromium-review.googlesource.com/c/1335586 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
sebsg authored
Bug: 907929 Change-Id: I6cc9d7a908010c204fc8060802c7ee453363ffa3 Reviewed-on: https://chromium-review.googlesource.com/c/1349455 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612769}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 11e0d834. With Chromium commits locally applied on WPT: b6e2cb9b "[EventTiming] Always buffer firstInput" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-break NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I8e830b280b458cdd488856f7289319f5beaaf14e Reviewed-on: https://chromium-review.googlesource.com/c/1357310 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612768}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/199f50b66cb0..010497f89102 Created with: gclient setdep -r src-internal@010497f89102 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4324a32bb363bbe01b5b9e31874b2a9f12f6050f Reviewed-on: https://chromium-review.googlesource.com/c/1357347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612767}
-
Ryan Meier authored
Bug: 725197 Change-Id: I24e0f3ff08ebd26f0621c2e16154f34a3dfd5467 Reviewed-on: https://chromium-review.googlesource.com/c/1355771 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#612766}
-
Xing Liu authored
This CL polishes the comment for transient flag in DownloadUrlParameters. Change-Id: I06732268dc08889cc195b61d3140560acc9e5242 Reviewed-on: https://chromium-review.googlesource.com/c/1357380Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612765}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/35457f076227..559cacb8fdf1 git log 35457f076227..559cacb8fdf1 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 benjhayden@chromium.org Move Catapult Android Tryserver to LUCI. Created with: gclient setdep -r src/third_party/catapult@559cacb8fdf1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:825432 TBR=sullivan@chromium.org Change-Id: I45252f26469927cd0ebc9f70724b1d04ce2a7178 Reviewed-on: https://chromium-review.googlesource.com/c/1357346Reviewed-by:
-
Philip Rogers authored
The name "SlimmingPaintV2" has led to confusion about what exactly is in "v2". This renames the in-development feature to "CompositeAfterPaint". Tasks left to do: 1) Remove the --enable-slimming-paint-v2 flag 2) Remove the SlimmingPaintV2 runtime enabled feature 3) Move the virtual tests from virtual/spv2 to virtual/composite-after-paint 4) Move the flag-specific expectations to enable-features=CompositeAfterPaint This patch has been generated from the following commands: cd third_party/blink git grep -l SlimmingPaintV2 | xargs sed -i "" 's/SlimmingPaintV2/CompositeAfterPaint/' git grep -l "slimming paint v2" | xargs sed -i "" 's/slimming paint v2/composite after paint/' git grep -l "slimming paint V2" | xargs sed -i "" 's/slimming paint V2/composite after paint/' git grep -l "Slimming Paint v2" | xargs sed -i "" 's/Slimming Paint v2/Composite After Paint/' git grep -l "Slimming Paint V2" | xargs sed -i "" 's/Slimming Paint V2/Composite After Paint/' git grep -l "Slimming paint v2" | xargs sed -i "" 's/Slimming paint v2/Composite after paint/' git grep -l "Slimming paint V2" | xargs sed -i "" 's/Slimming paint V2/Composite after paint/' git grep -l "enable-slimming-paint-v2" | xargs sed -i "" 's/enable-slimming-paint-v2/enable-composite-after-paint/' git grep -l "spv2" | xargs sed -i "" 's/spv2/cap/' git grep -l "SPv2" | xargs sed -i "" 's/SPv2/CAP/' git grep -l "SPV2" | xargs sed -i "" 's/SPV2/CAP/' git grep -l "enable_s_pv2" | xargs sed -i "" 's/enable_s_pv2/enable_cap/' git grep -l "kSlimmingPaintV2" | xargs sed -i "" 's/kSlimmingPaintV2/kCompositeAfterPaint/' git mv third_party/blink/renderer/core/paint/stub_chrome_client_for_spv2.h third_party/blink/renderer/core/paint/stub_chrome_client_for_cap.h git checkout -- perf_tests/bindings/resources/data/blink-dev.json git checkout -- perf_tests/svg/resources/CrawFishGanson.svg git checkout -- renderer/build/scripts/blinkbuild/name_style_converter.py git checkout -- renderer/build/scripts/blinkbuild/name_style_converter_test.py git checkout -- web_tests/VirtualTestSuites git checkout -- renderer/platform/exported/web_runtime_features.cc git checkout -- public/platform/web_runtime_features.h git checkout -- web_tests/FlagExpectations/enable-blink-features=LayoutNG git checkout -- web_tests/FlagExpectations/enable-blink-gen-property-trees git checkout -- web_tests/FlagExpectations/enable-slimming-paint-v2 git checkout -- web_tests/SlowTests git checkout -- web_tests/TestExpectations git checkout -- web_tests/animations/resources/composited-animation-test.js git checkout -- web_tests/virtual/spv2/compositing/README.txt git checkout -- web_tests/virtual/spv2/fast/block/README.txt git checkout -- web_tests/virtual/spv2/fast/borders/README.txt git checkout -- web_tests/virtual/spv2/fast/clip/README.txt git checkout -- web_tests/virtual/spv2/fast/css/README.txt git checkout -- web_tests/virtual/spv2/fast/overflow/README.txt git checkout -- web_tests/virtual/spv2/fast/repaint/README.txt git checkout -- web_tests/virtual/spv2/paint/README.txt git checkout -- web_tests/virtual/spv2/paint/subpixel/README.txt git checkout -- web_tests/virtual/spv2/svg/README.txt git checkout -- web_tests/virtual/threaded/animations/composited-animation-independent-transform-cancel.html git checkout -- web_tests/virtual/threaded/animations/compositor-independent-transform-properties.html git checkout -- renderer/platform/runtime_enabled_features.json5 { name: "CompositeAfterPaint", implied_by: ["SlimmingPaintV2"], }, git cl format I then manually cleaned up some instances of "composite after paint" being "CompositeAfterPaint" as well as some grammar. Bug: 909899 Change-Id: Iec0a803b997ada7c58c9c0446bbca23451de08dd Reviewed-on: https://chromium-review.googlesource.com/c/1355247Reviewed-by:Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612763}
-
Ella Ge authored
Bug: None Change-Id: I3df4dd15394d61b4334c5e8794c6e382535417d5 Reviewed-on: https://chromium-review.googlesource.com/c/1355761Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Joey Arhar authored
Bug: 802182 Change-Id: I01b45373ab5fe21bf2513cd1ea9e7f2e90d9820f Reviewed-on: https://chromium-review.googlesource.com/c/1356135Reviewed-by:
-
Ryan Meier authored
Bug: 802374 Change-Id: I89e01e755d4a5bf4dabda8f93b75eafc7418fc34 Reviewed-on: https://chromium-review.googlesource.com/c/1355613 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Dave Tapuska authored
BUG=879657 Change-Id: I522fa35be26873436ed090990cbae1897acef6f7 Reviewed-on: https://chromium-review.googlesource.com/c/1355841Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#612759}
-
Pavel Feldman authored
Change-Id: I43c98ef335c76b0bbc5276742fdfe791c40f3a7d Reviewed-on: https://chromium-review.googlesource.com/c/1357009Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
chrome://flagsdpapad authored
Bug: 907791 Change-Id: I18f62b564509ac97d54aa6fec33d213ebf16e575 Reviewed-on: https://chromium-review.googlesource.com/c/1357018Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612757}
-
Stephen Martinis authored
This CL adds a check to //infra/config/branch/cq_cfg_presubmit.py to check the path regexps in cq.cfg to make sure there is at least one file that they could match with. This CL also fixes a few typos which already exist in cq.cfg, as a result of this missing checking. Bug: 902507 Change-Id: I535d6671e4598eda27a0919ef14404a228398ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1334940 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612756}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/58017e91adbf..179db44c2586 git log 58017e91adbf..179db44c2586 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 brandon1.jones@intel.com Refactor Internal Command Buffer Copy APIs 2018-11-30 cwallez@chromium.org Revert "Run linux-dawn-rel on the CQ" Created with: gclient setdep -r src/third_party/dawn@179db44c2586 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:901830 TBR=cwallez@chromium.org Change-Id: I0589a99d1cab6762ddf577d2fd7997fb32881007 Reviewed-on: https://chromium-review.googlesource.com/c/1357341Reviewed-by:
-
Anne Lim authored
Added GetExpiryTime() to StrikeDatabase interface and removes expired striked on StrikeDB init. Bug: 884817 Change-Id: Ie99173b631f668f3be848f1afa925d7feec801ef Reviewed-on: https://chromium-review.googlesource.com/c/1351887Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#612754}
-
Martin Kreichgauer authored
In http://crrev.com/c/1354559, the thread waiting for the blocking Windows WebAuthn API calls to return was moved into the WinWebAuthnApi singleton. Unfortunately, this introduced a potential use-after-free, because arguments to the blocking API calls get passed via pointer and the owner of those arguments, WinHelloApiAuthenticator, wasn't generally guaranteed to outlive the duration of the request. This change fixes the issue by moving all data passed to the Windows API calls into WinWebAuthnApi by value. Bug: 898718 Change-Id: Ib4f2e86f4ef04cbac712682d4cff386709e735eb Reviewed-on: https://chromium-review.googlesource.com/c/1356334 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612753}
-
Xing Liu authored
This CL enable a flaky test: NotificationIntentInterceptorTest#testContentIntentInterception Bug: 906843 Change-Id: Icf92bbd5fae556b0faf1c1a6c5b2bf65c0016449 Reviewed-on: https://chromium-review.googlesource.com/c/1353949Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612752}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dae4dfd2c5df..7b5740a89e63 git log dae4dfd2c5df..7b5740a89e63 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 thestig@chromium.org Move pdf_enable_xfa build rules inside pdf_enable_v8 blocks. Created with: gclient setdep -r src/third_party/pdfium@7b5740a89e63 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8156992c15102ad2b8fff22a6fc8e4c9fa0f678a Reviewed-on: https://chromium-review.googlesource.com/c/1357343Reviewed-by:
-
Becca Hughes authored
This CL deletes the old content::MediaMetadata types. BUG=875004 Change-Id: Ia6c5fa76090d2e848261207d6a0dc28e782a4db3 Reviewed-on: https://chromium-review.googlesource.com/c/1241554 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#612750}
-
Becca Hughes authored
Add the MediaSessionMetadataChanged event to the observer that will be fired if the metadata associated with the media session changes. This will be used for the notification to display metadata of the currently playing media. BUG=875004 Change-Id: I17d4e2af8b1d3b5b6213ec2eaaf0c29eb58c5937 Reviewed-on: https://chromium-review.googlesource.com/c/1316659 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#612749}
-
Lily Chen authored
New unit test checks that setting the priority of a request to an SSLClientSocketPool layered on top of a HttpProxyClientSocketPool passes the priority change all the way down to the transport socket pool. Bug: 166689 Change-Id: I4a4b00106659a65ea75689c5cea1c4e44266bb13 Reviewed-on: https://chromium-review.googlesource.com/c/1356865Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#612748}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7ae5d7a9b12c..020b59722ab0 git log 7ae5d7a9b12c..020b59722ab0 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 ehmaldonado@chromium.org presubmit: Remove EnsureCQIncludeTrybotsAreAdded Created with: gclient setdep -r src/third_party/depot_tools@020b59722ab0 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:845642 TBR=agable@chromium.org Change-Id: I32ac7a57384716d8c246a50a4a62cab231b53b91 Reviewed-on: https://chromium-review.googlesource.com/c/1357344Reviewed-by:
-
