GitLab

We are implementing "Navigation to Bundled Exchanges".
Design doc:
https://docs.google.com/document/d/1Bulrd7E1lFZyPfRFIXP3vNMOM9FX-kWJOCxMOeR8pAQ/view#
Demo movie: https://www.youtube.com/watch?v=rs-3R0ji6dA

To open the Bundled Exchanges files on Android from other applications, we need
to add intent-filters in AndroidManifest.xml.

The first intent-filter is for the applications which can't detect the
"application/webbundle" mime type. (eg: Open .wbn file from "Internal Storage"
in Files app.) We use pathPattern to capture the ".wbn" file extension. But due
to the strange behavior of intent filter's pathPattern [1], we need to have
multiple patters to load the .wbn files under folders which name contains ".".
[1] https://stackoverflow.com/questions/51912180/strange-intent-filter-pathpattern-behaviour

The second intent-filter is for the applications which can detect the
"application/webbundle" mime type. (eg: Download the Bundled Exchanges file with
"content-type: application/webbundle" header, and open the file from "Download"
category in Files app.)

We don't have plan to ship this feature in Beta and Stable yet.
So this CL uses "{% if channel in ['dev', 'canary', 'default'] %}" not to change
the AndroidManifest.xml for Beta and Stable.

Bug: 995177
Change-Id: I754ca1c74f5bc56d17462cde9d5bd764671c849b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811405Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701296}

* Expose two more observer calls of TabGroupModelFilter.Observer.
* Introduce TabGroupTitleEditor as an abstract class and specify the
  logic about when to delete stored titles.

Bug: 1001738
Change-Id: I0e915582c50bb7a900d2464f3fbd03d1a173a47f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825459
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701295}

Add them to OSSettingsPageTest.AllJsTests.

Rework the existing test slightly to directly query for sections with
the specified name using CSS selectors, rather than using JS code to
look things up.

Bug: 967896
Test: browser_tests
Change-Id: Iac51bae17cfa2e8d2ccb9d4d3cc449a59dee8e07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831949Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701294}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7d6c98f10423..9ee7f7856b07

git log 7d6c98f10423..9ee7f7856b07 --date=short --no-merges --format='%ad %ae %s'
2019-09-30 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@9ee7f7856b07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I114dab75995e10621f5348680c2d90933b7ccfa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832050Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#701293}

This should reduce the page loads that have blacklist unavailable
eligibility reasons for commit-time previews.

Bug: 905088
Change-Id: I2350706637e2d0b37cc07d3ac9325137143164a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831276Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701292}

Fixed errors:
Traceback (most recent call last):
  File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 293, in <module>
    sys.exit(main())
  File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 289, in main
    _GenerateFile(arguments)
  File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 241, in _GenerateFile
    header_file_content = _GenerateFileContent(
  File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 217, in _GenerateFileContent
    expired_histograms_map = _GetHashToNameMap(expired_histograms_names)
  File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 158, in _GetHashToNameMap
    hash_to_name_map[_HashName(name)] = name
  File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 151, in _HashName
    return "0x" + hashlib.md5(name).hexdigest()[:16]
TypeError: Unicode-objects must be encoded before hashing
C:\Google\chromium\src [expired_histograms]> .\tools\metrics\histograms\generate_expired_histograms_array_unittest.py
  File "C:\Google\chromium\src\tools\metrics\histograms\generate_expired_histograms_array_unittest.py", line 96
    base_date = datetime.date(2000, 10, 01)
                                         ^
SyntaxError: leading zeros in decimal integer literals are not permitted; use an 0o prefix for octal integers
C:\Google\chromium\src [expired_histograms]> .\tools\metrics\histograms\generate_expired_histograms_array_unittest.py
  File "C:\Google\chromium\src\tools\metrics\histograms\generate_expired_histograms_array_unittest.py", line 132
    self.assertEqual(base_date, datetime.date(2010, 01, 01))
                                                     ^
SyntaxError: leading zeros in decimal integer literals are not permitted; use an 0o prefix for octal integers

The changes are backwards compatible with Python 2.

Bug: 941669
Change-Id: I1f1dbedd8f55737fec20f7ae82e97bd140637ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829204
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701291}

We will add ~45 DevUI pages to the DevUI DFM. Each of these has an
"atomic" PAK file, and an entry in the main resource_ids file. This CL
rearranges existing items in the main resource_ids file in preparation:
* Move bluetooth_internals and usb_internals resources to a new
  section: "/chrome WebUI section".
* Extract ios/web/ section from ios/ section, since there's a
  restriction for ios/web/ to start from same IDs as content/.
* Move content/ section between ios/ and ios/web/. This order makes it
  easier for semi-automated tools to extract structure.

Bug: 927131
Change-Id: I35b32a88f56cfd4437a9bd66fda08e1156fc7d97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832443Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701290}

https://chromium.googlesource.com/angle/angle.git/+log/2e80cf9d91ab..087f1384f233

git log 2e80cf9d91ab..087f1384f233 --date=short --no-merges --format='%ad %ae %s'
2019-09-30 jmadill@chromium.org Vulkan: Introduce CommandQueue helper class.

Created with:
  gclient setdep -r src/third_party/angle@087f1384f233

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@google.com

Bug: None
Change-Id: I36b69ed92d69f8979ff6f5978ca33c3e8f16fdcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832245Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#701289}

Clarifying documentation to make it clear that a disabled feature
does not necessarily result in Security_Impact-None.

Also, bringing note on Sheriffbot behavior up to date.

R=cthomp@chromium.org, nasko@chromium.org

Change-Id: I6073b579dc490e8dd67e0faf240ad8232cb58af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829743
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701288}

Change-Id: I628b4ae3bc43c11764c64ba537491ae2d77fee0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809503
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701287}

This is a reland of Ie6bc51cf71f82228df32db551489bf66168a54e6

OnAddressListChanged, OnCreditCardsChanged
Instead it should have a single OnPersonalDataChanged call

Bug: 923868
Change-Id: I08f99ddaadffb84bfb9fd6fb8584313fbf10a9c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631451
Commit-Queue: sebsg <sebsg@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Original-Commit-Position: refs/heads/master@{#664246}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680537
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#701286}

Added a flag to |ChromeTestCase| class to indicate whether
+setUpForTestCase has been executed in a test case, preventing
+setUpHelper from being called twice after one relaunch during test
case set up.

Bug: 1008495
Change-Id: I6f7b6fbda5d2fb08c98d6a61a66043852587f86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828076
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701285}

Change-Id: I5af333c9554762e332999450fba1b432920e305f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825104Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701284}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c475f5650417..a9dc7707d610

git log c475f5650417..a9dc7707d610 --date=short --no-merges --format='%ad %ae %s'
2019-09-30 srisser@google.com Optimize "max(t, t)" to fold into just "t"
2019-09-30 amaiorano@google.com Fix regres script

Created with:
  gclient setdep -r src/third_party/swiftshader@a9dc7707d610

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: Ia2815df7c84b516309952cc6e9ebbb526cd38ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832048Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#701283}

Previously we had AddToHomescreenManagerTest#testAddAdaptableShortcut
broken because we were not mocking the AddToHomescreenView fully.
This CL fixes this.

Bug: 977173
Change-Id: I643d4e26c354ae14792a2e85f720edad712a60cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832287Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701282}

Change-Id: Ieda66129f16756e97cd72fae57aa618377e59e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831454Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701281}

The classes that required ServiceWorkerContextCore to outlive them no
longer take the context core by WeakPtr.

Also fixed a few missing include for used headers.

Change-Id: Id5f8079c631ed36ef83b50ddd24ac26c2ac3af9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830064
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701280}

No functional changes intended, please revert if things break.

This function is a large, and hard to follow. I'm hoping to break out a
bunch of functions that are clearer about what they're doing and make
ordering clearer.

Bug: 1006927
Change-Id: I18acde0a5ef857875e94c0311930dd3b0a00fdd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832004
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701279}

Recent changes in Blink caused this to start crashing. Directly using
v8::Null instead of ScriptValue::CreateNull fixes the issue. It looks like
is related to crbug.com/1008765 where it's no longer value to create a Null
ScriptValue when the value is no longer "in context".

This CL applies a small fix for the crash so we can roll the WebGPU CTS and
prevent further regressions.

Bug: 1009635
Change-Id: I4d4de6b499b05bb1833ec34128239ca135692378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830283
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701278}

When we are still waiting for the drop callback
we shouldn't end the drag. Instead we should wait
for the drop callback first (which sends a drop js
event) and then end the drag (which sends a dragend js
event) so that the ordering is guaranteed.

Bug: 1005747
Change-Id: I8dd9eb4b5321e00f6c32c210541ce516eacafec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825457Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701277}

Bug: 489687
Change-Id: I13da4c428a3dfcf30660d9a0a38465678b3cd55e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797483
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701276}

PrerenderManager is already a profile keyed service, so will be
shut down (with ShutDown()) and destroyed when the profile is destroyed.

Since NOTIFICATION_PROFILE_DESTROYED comes before
ShutDown(), in practive we never logged FINAL_STATUS_MANAGER_SHUTDOWN
(see Prerender.FinalStatus histogram for confirmation). So to maintain
continuity in UMA, this change obsoletes FINAL_STATUS_MANAGER_SHUTDOWN
and replaces it by FINAL_STATUS_PROFILE_DESTROYED.

Bug: 268984
Change-Id: I97f95d2f8d693432022955ba58ed152ff81a89db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830399Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701275}

Change-Id: I8d8b301ccb6b3d3b3abe48c1ea916a4bbe36d4cf
Bug: 1009290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830237Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Rob Schonberger <robsc@google.com>
Cr-Commit-Position: refs/heads/master@{#701274}

InMemoryURLIndexTest.AddNewRows
InMemoryURLIndexTypesTest.OffsetsAndTermMatches
InMemoryURLIndexTest.Retrieval
KeywordProviderTest.URL
InMemoryURLIndexTest.CacheSaveRestore
OmniboxEditModelTest.InlineAutocompleteText

Bug: 1009588
Change-Id: Ia3e749b64e5618bee25cac2874d4ba5e7ece1d45
TBR: jdonnelly@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830285Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701273}

The onSheetReleased event is unused and a similar result can be
achieved using onSheetStateChanged.

Bug: 986310
Change-Id: Ia9da5333429a7d98ed463c29ada92350e3a05abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825888
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701272}

Bug: 1009443
Change-Id: Iaf4ed0b2f02e016a665c42da2082c207e2a2ee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829710Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701271}

https://chromium-review.googlesource.com/c/chromium/src/+/1825659
hid both the night light screen temperature and schedule when the
night light toggle was off.

We actually only want to hide the screen temperature slider. The
schedule should always be visible.

Bug: 1009416, 1000683
Test: updated browser_tests
Change-Id: I04179face9d25a3c0517d823fd91247594c2ce4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831008
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701270}

GCMDriverFunctionalTest.UnregisterWhenAsyncOperationPending
GCMDriverTest.GCMClientNotReadyBeforeRegistration
GCMDriverFunctionalTest.Register
GCMClientImplTest.RegisterAgainWhenTokenIsFresh
GCMClientImplTest.DispatchDownstreamMessageSendError
GCMClientInstanceIDTest.DeleteAllTokens
GCMClientImplStartAndStopTest.DelayedStartRace
GCMClientImplStartAndStopTest.StartStopAndRestart
GCMClientInstanceIDTest.GetToken

Bug: 1009586
Change-Id: Id9a51969b6d4cd2caa63c8689faf8f9be31fbf69
TBR: fgorski@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829674Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701269}

Convert the remaining bits in both the implementation and clients from the
browser and renderer processes for the mojom.FaceDetection[Provider]
interface, and adapt tests.

Bug: 955171, 978694
Change-Id: I97c5ebebb2d3e3df24a4fe481987042ce0dff9de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827279Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#701268}

Convert the remaining bits in both the implementation and clients from the
browser and renderer processes for the mojom.BarcodeDetection[Provider]
interface, and adapt tests.

Bug: 955171, 978694
Change-Id: I619bdfd9e96e08fd0648cf805710588d6ad3981c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827359Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#701267}

Now that we're launching to stable, Chromeshine should be on by default.

Change-Id: I3a7176ad933ba4557f97fc81113d891f9e79e739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832290Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701266}

Example error:
Traceback (most recent call last):
  File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 14, in <module>
    import extract_histograms
  File "C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py", line 60, in <module>
    import HTMLParser
ModuleNotFoundError: No module named 'HTMLParser'

Also fixed deprecation warnings:
C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py:150: DeprecationWarning: The unescape method is deprecated and will be removed in 3.5, use html.unescape() instead.
  return HTMLParser().unescape(line)
...C:\Google\chromium\src\tools\metrics\histograms\extract_histograms_test.py:481: DeprecationWarning: Please use assertEqual instead.
  self.assertEquals('This is a summary with & and " and \'',

The changes are backwards compatible.

Bug: 941669
Change-Id: Ieb22e72b37ec26886f3ca1341e487be4f0ba3ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830657
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701265}

Add the DCHECK into the ExternalPolicyDataFetcher's destructor that it's
executed on the right sequence.

Before this CL, the destructor contained the comment that stated that
such DCHECK isn't technically possible due to unusual destruction order
in some tests, but we can't repro this problem with the current ToT
anymore.

Bug: 727645
Change-Id: I6490227656a876d546cd5b659f5d88b2d2ec0dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828820Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701264}

For grammatical correctness

Change-Id: I2d5faa4acc6b1855c21c25cb23d9afacf243f8f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829295Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701263}

base::Bind/base::Callback are deprecated in favor of either
base::BindOnce/base::OnceCallback or base::BindRepeating/
base::RepeatingCallback (depending on whether the callback
is invoked once or multiple time).

Convert all uses of base::Bind/base::Callback in ui/events
to the recommended methods/types.

Bug: 1007850
Change-Id: Id725e2236e305a5b0b1eb5f555c3c412b8139416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831866
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701262}

Some ConfirmInfobars like Restore tabs are important enough that we
don't want some users to miss them. Either because they are not presented
because some other Infobar is being presented, or because they time out
before the user has seen it.

This CL adds a BOOL flag to InfobarCoordinator, which InfobarContainerCoordinator
will use in order to add that Infobar's banner to the top of the queue and display
it for a bit longer.

I didn't want to create a more granular system since this might be temporary until
we migrate some of these Infobars to alerts or something similar, and its also
not currently needed.

Bug: 961343
Change-Id: Icf03748ec50b63bd9c99ead96ccae5c7fc644b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828237Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701261}

Convert the remaining bits in both the implementation and clients from the
browser and renderer processes for the shape_detection.mojom.TextDetection
interface, and adapt tests.

Bug: 955171, 978694

Change-Id: Ic528a0940a051c4dd692c2aa1bf08e1843ff8d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826617Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#701260}

This reverts commit b78156eb.

Reason for revert: Compile failures regarding template parameter shadowing: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/5546

Original change's description:
> Roll abseil_revision 4ef574064e..ccdd1d57b6.
> 
> Change Log:
> https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4ef574064e..ccdd1d57b6
> Full diff:
> https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4ef574064e..ccdd1d57b6
> 
> Bug: None
> Change-Id: I8df493afa9903590cf61a51cda3b4988d122dfd7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819237
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#701231}

TBR=thakis@chromium.org,mbonadei@chromium.org

Change-Id: I07a7c5ce83040a71d58fe7abc678b6c12a4b93b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831414Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#701259}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/c37a501458e2..839a023619b5

git log c37a501458e2..839a023619b5 --date=short --no-merges --format='%ad %ae %s'
2019-09-30 wl@gnu.org * src/sfnt/sfwoff2.c (reconstruct_font): Fix memory leak.
2019-09-30 wl@gnu.org [woff2] Reject fonts without `head' table.
2019-09-29 wl@gnu.org [woff2] Fix compiler warnings.

Created with:
  gclient setdep -r src/third_party/freetype/src@839a023619b5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
TBR=bungeman@google.com,drott@google.com,thestig@google.com

Bug: None
Change-Id: Icf8a8a0488c0845d9d4fe2d9dd20e19bf5a6efd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831594Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701258}

Introduce a new namespace "Root" to be able to disambiguate between
Runtime the namespace and Runtime the object.

roll CodeMirror
The above line is necessary to fix the presubmit, which complains
about CodeMirror changes. This is only updating a type reference.

Bug: 1006759
Change-Id: I04941d9f18649701060e3035f7eeb2ef3abb51e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829708Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701257}