GitLab

This reverts commit 5665173d.

Reason for revert: this is ranked as #1 renderer process related crash on the latest chrome dev 71.0.3554.0 on Windows. 97 crashes from 90 clients so far.

Original change's description:
> Use of dump without crashing to debug smooth scroll animation bug.
> 
> Bug: 797708
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Icce9d0c3eeed94297936aebc81681f5db2ec0682
> Reviewed-on: https://chromium-review.googlesource.com/1226825
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591377}

TBR=bokan@chromium.org,sahel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 797708, 884592
Change-Id: I1e2787982eb1920e28e9a38281de0c76334162f2
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1233954Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592409}

This does not fix any known issues (and in fact doesn't change any
behavior), but it seems wasteful to set the background blur to the
exact same value multiple times.

Bug: 881134
Change-Id: I3762c486385d9136f1aea3e50d1e304d69aef141
Reviewed-on: https://chromium-review.googlesource.com/1233122Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592408}

Bug: 844242
Change-Id: I980a50866506181759ad78424e9c35bfc3cd9edc
Reviewed-on: https://chromium-review.googlesource.com/1201627Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592407}

In QUIC, consider session has pending crypto data if crypto stream has buffered data waiting to be sent. Protected by FLAGS_quic_reloadable_flag_quic_fix_has_pending_crypto_data.

Also rename HasPendingCryptoData to HasUnackedCryptoData.

Merge internal change: 213505364

R=rch@chromium.org

Change-Id: I7225bf701a96dd4f07b1b0388d632d286fcfd4b2
Reviewed-on: https://chromium-review.googlesource.com/1232036
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592406}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce2e95b6cc38..be50d76e46ea


Created with:
  gclient setdep -r src-internal@be50d76e46ea

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6e48aac8d9d3dd595ca7779927ea8660b464f7c1
Reviewed-on: https://chromium-review.googlesource.com/1233634Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592405}

This prevents a crash in chrome://sync-internals in some situations, e.g.
when we're waiting for a custom passphrase to be entered.

This is analogous to https://crrev.com/c/1160229 and
https://crrev.com/c/1228198.

Bug: 878887
Change-Id: I3e1261fb7f0d98d73f98a82622ee4bb7511c9d6f
Reviewed-on: https://chromium-review.googlesource.com/1233697Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592404}

Fixed one test that I expected to pass, but didn't because it was
pointing to the wrong ref. Fixed that, and now it passes. Updated
some expectation files. More stuff from various tests (but not
whole tests) is passing than before.

Bug: 781135
Change-Id: Ieb1312b8bf13c7a45afe644ad2a58f3f955044b6
Reviewed-on: https://chromium-review.googlesource.com/1228073Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592403}

If the Response body object is a readable stream then check whether
the object is disturbed or locked.
If the condition is true then throw TypeError.

refernce: https://fetch.spec.whatwg.org/#concept-bodyinit-extract

Bug: 878281
Change-Id: I0593d048e7bd146863efdc9f1d355bc70857cdc0
Reviewed-on: https://chromium-review.googlesource.com/1226718Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592402}

Currently, UIDevToolsTest tests the whole system together
in a single test file. This file uses WindowElement in most
tests, which makes it difficult to port for the forthcoming
Mac implementation, which does not have WindowElement due
to not being an Aura platform.

This  is the first of a series of changes that will
break most of UIDevToolsTest up into more granular tests,
which will make it easier to isolate WindowElement use
to Aura.

This change takes the functionality that was previously
being tested in the style tests in UIDevToolsTest, and
breaks it into:
- css_agent_unittest.cc, which tests interaction between
elements and CSSAgent
- Separate files for individual element subclasses, to
ensure the mapping between the elements and their underlying
objects.

Additionally, it fixes a few bugs smoked out by the new
tests in CSSAgent and WidgetElement.

Bug: 769352
Change-Id: Ie24f2166a2dbe7fef31db2800c8bf88a1f470057
Reviewed-on: https://chromium-review.googlesource.com/1231033
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592401}

This reverts commit 0f374eff.

Reason for revert: http://crbug.com/886918

Original change's description:
> Reland "Enable Perfetto by default for all telemetry tests"
> 
> This is a reland of 32c8ebbe
> 
> Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306
> 
> Original change's description:
> > Enable Perfetto by default for all telemetry tests
> >
> > This will use Perfetto instead of TraceLog for all
> > trace-based Telemetry tests running on Mac/Windows/Android.
> >
> > R=nednguyen@google.com
> >
> > Bug: 839084
> > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> > Reviewed-on: https://chromium-review.googlesource.com/1176119
> > Commit-Queue: oysteine <oysteine@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Cr-Commit-Position: refs/heads/master@{#585368}
> 
> TBR=nednguyen@google.com
> 
> Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e
> Reviewed-on: https://chromium-review.googlesource.com/1208955
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592127}

TBR=sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com

Change-Id: I7e3984b90f8f53d1dface9459ea07d7383e7c6d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1233717Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592400}

This CL streamlines IdentityManager's interaction with
ProfileOAuth2TokenService when getting accounts with refresh tokens
to have IdentityManager act as a straight passthrough rather than
using its internal state that is updated via Po2TS::DiagnosticsClient.
The motivation is to enable conversion of the codebase to
IdentityManager as smoothly and painlessly as possible, as explained in
detail in crbug.com/883722.

IdentityManager's internal state is currently still used for obtaining
the AccountInfo to send in the
OnRefreshToken{Updated, Removed}ForAccount callbacks. Changing that will
require first modifying OnRefreshTokenRemovedForAccount() to pass only
the account ID, as at the time that PO2TS::OnRefreshTokenRevoked() is
fired, AccountTrackerService does not necessarily know about the account
anymore.

Bug: 883722
Change-Id: Ia13c7f9162449fa0ea60de5fb9e67b5373a82dea
Reviewed-on: https://chromium-review.googlesource.com/1225758Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592399}

This change fixes a number of bugs in FidoBleTransaction and adds
corresponding tests. In particular, it fixes a race condition, where
the completion callback was run before the last write was acknowlegded.
In addition, it improves the robustness with regard to malformed input.

Bug: 880053
Change-Id: I81f6d5c02d01b9d7ea1a184a7236cd74d52f356d
Reviewed-on: https://chromium-review.googlesource.com/1224383
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592398}

This reverts commit d54e0de4.

Reason for revert: Tests added in this CL are failing. See https://crbug.com/886533

Original change's description:
> [Autofill] Browser Tests for Sign-in After Local Save.
> 
> Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt.
> 
> Bug: 855186
> Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7
> Reviewed-on: https://chromium-review.googlesource.com/1196918
> Commit-Queue: Manas Verma <manasverma@google.com>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592227}

TBR=mathp@chromium.org,estade@chromium.org,msarda@chromium.org,jsaul@google.com,manasverma@google.com

Change-Id: I6fe0b1508df0980aded5fa38fb5d43b3664db83f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855186
Reviewed-on: https://chromium-review.googlesource.com/1233938Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592397}

Bug: 878534
Change-Id: I08caf24449e619087dbf5ab27d122ef9115ba0ad
Reviewed-on: https://chromium-review.googlesource.com/1230513Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Cr-Commit-Position: refs/heads/master@{#592396}

Bug: 516866
Change-Id: I15a23355de0d4dca083f671dece10bf2059d1800
Reviewed-on: https://chromium-review.googlesource.com/1230063
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592395}

Also add a caveat about a restriction of std::aligned_alloc on its size
parameter (size must be an integral multiple of alignment).

Change-Id: I83389f78650bf51e819d4f992789f0361a4b29db
Reviewed-on: https://chromium-review.googlesource.com/1232633Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592394}

A different fix is under discussion at
https://chromium-review.googlesource.com/c/chromium/src/+/1233814
but since there's some disagreement on the approach, let's land
this while the review over there is ongoing, to heal the bot.

Bug: 886629
Change-Id: I80c64f6bf969b5b1edf108d2a46155f2f4252595
Reviewed-on: https://chromium-review.googlesource.com/1232591Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592393}

These prefs are generated at compile-time. Currently, the perf benchmarks
will hard-fail if the JSON is invalid. This CL adds tests for that case.

Bug: 884035
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I58610eb69a4b2610dce72e6de2f8cba2104a29d6
Reviewed-on: https://chromium-review.googlesource.com/1231840Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592392}

This reverts 7d96627b.

Reason: adb problems possibly fixed.

Bug: 885071, 758566
Change-Id: Id1abd6f5ab2022ecb50232b8f02e5cab8940ec84
Reviewed-on: https://chromium-review.googlesource.com/1233695
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592391}

I suspect that we are encountering back to back begin frame requests
that cause use to write out two begin frame responses which cause
us to crash. Ensure that the begin_frame_response_valid_ is false
when we generate a BeginFrame.

BUG=885124

Change-Id: I21332bccaea142f8daf18a15805142f03f59c339
Reviewed-on: https://chromium-review.googlesource.com/1231733Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592390}

Bug: 758566
Change-Id: I9ec28cc5bb1be7baac6ac232bd9db1a10870b3cc
Reviewed-on: https://chromium-review.googlesource.com/1233595Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592389}

Change-Id: I78b9172711cad010a754ad4d524758df39af5e61
Reviewed-on: https://chromium-review.googlesource.com/1233337
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#592388}

The scheduler assumes that all database tasks succeeded and continues
accordingly. This change propagates the errors, and if there are any,
the scheduler will abandon the fetch.

Change-Id: I813ab23107369799ada4cc39a5eee9944433ed44
Reviewed-on: https://chromium-review.googlesource.com/1228015
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592387}

RequestQueueStore and RequestQueueStoreSQL were combined.

I went ahead and added a test fixture for request queue tasks. This ensures
we actually delete the database in TearDown.

Bug: 883938
Change-Id: Ia56698061685440402d82b5a6836c827f30b546a
Reviewed-on: https://chromium-review.googlesource.com/1227134Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592386}

This reverts commit 673081e3.

Reason for revert: Test complete. One day in the field is sufficient.

Original change's description:
> Field crash if histogram bucket creation isn't as expected.
> 
> There are reports from the field that the "maximum" of a histogram
> does not match what was configured.  The working theory is that it is
> due to rounding errors in the creation of exponential buckets.
> Verify this assumption.  If it's behaving wrong, it should crash
> during the creation.
> 
> Bug: 836238
> Change-Id: I4cf5e4bc3986e288c728ae37e2ff8cf841b7598d
> Reviewed-on: https://chromium-review.googlesource.com/1228840
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592128}

TBR=asvitkine@chromium.org,bcwhite@chromium.org

Change-Id: I0c7ecfc65d31aa2d161f1b689a178432a9364e27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836238
Reviewed-on: https://chromium-review.googlesource.com/1233893Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592385}

To shrink LayoutBlock back to its previous size, store the
constraint space as a pointer again. This seems to actually have a
slightly positive effect on performance according to pinpoint (?!)

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9de7205eefbce457a9b7a82a6d5529adb13d58c4
Reviewed-on: https://chromium-review.googlesource.com/1232584Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592384}

This avoids having a destructor being run when terminating the process.
These destructor could have ordering issues wrt to the destruction of
the AtomicStringTable. Using DEFINE_STATIC_LOCAL also shrinks the binary
a bit. (The android-binary-size bot says -16375 bytes.)

Remove some redundant '\0' characters for some additional (but minor)
savings.

Change-Id: I4f5c19fceb9b668e74d3ef9bad58b104182ddb86
Reviewed-on: https://chromium-review.googlesource.com/1233700Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#592383}

Bug: 886549
Change-Id: Id0576ecc1e66b79e4dfeae708c1849231dad49ab
Reviewed-on: https://chromium-review.googlesource.com/1233696Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592382}

The tests perform operations on sockets that are expected to fail,
and verifies they fail as expected. Unfortunately, some platforms
can return one of two errors. This CL updates the tests to allow
both errors.

Also removes a bunch of extraneous "network::"'s

Bug: 880492,880493
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id085ece9ef0cf2e0b1581d6969f0295dd86910b8
Reviewed-on: https://chromium-review.googlesource.com/1231737Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592381}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/aa61ad05..e4c6d03d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic6d71829b0d5861d8deaec7f1e019148ba15d395
Reviewed-on: https://chromium-review.googlesource.com/1233184Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592380}

On Mac, the spacebar activates buttons on keydown; on other platforms it
activates them on keyup. Not implementing this behavior here caused the
following bug:

1) User focuses the bookmark bar star
2) User hits space to activate it, which opens the bubble
3) User tabs to the "Remove" button
4) User hits space to activate that button
5) The "Remove" button activates on keydown and the bubble dismisses
6) The star gets keyboard focus again
7) The star immediately handles the keyup and reopens the bubble!

The fix is for PageActionIconView to honor the platform spacebar affinity. There
is an old TODO in this code to merge it with views::Button but I would not want
to merge such a change back to beta so this small fix seems more expedient.

Bug: 712341
Change-Id: If932928bb069493e61f78f2d34e95a0aa45fb504
Reviewed-on: https://chromium-review.googlesource.com/1230437Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592379}

This exposes a parameter on WebContents::DispatchBeforeUnload which causes
the beforeunload dialog to automatically cancel itself if the beforeunload
handler returns a non-empty string.

This also adds plumbing to expose the value of |proceed| to the existing
WebContentsObserver::BeforeUnloadFired.

A follow-up CL will use these changes in order to create a "beforeunload"
helper to determine whether or not a page contains unsaved user data, and
is therefore unsafe for proactive discarding.

BUG=877550

Change-Id: I3d7b09709985656dc48bbbf408f8b2bdf87b186c
Reviewed-on: https://chromium-review.googlesource.com/1220307
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592378}

Using the border inset directly, instead of trying to recompute it from the
MenuConfig, avoids positioning bugs when the submenu will have a border applied
to it.

Bug: 834934
Change-Id: Ic6c23f7dd5e34b643724c346bb89dac038dd58e4
Reviewed-on: https://chromium-review.googlesource.com/1231736Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592377}

Before this CL, opening an accessory sheet would cause weird states when
requested while opened from within a contextual search.
As there currently isn't any reason to provide the accessory (log in can
not happen and interaction with new sites will happen in a new tab),
disable the accessory for the duration of a contextual search.

Bug: 885106
Change-Id: Iaf71ccb79650618a79fc7f61ec47af2168f2b91d
Reviewed-on: https://chromium-review.googlesource.com/1232960Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592376}

Add Internals>GPU>Metrics component for rendering.desktop
and rendering.mobile benchmarks.

Also, update the scripts to point to the correct script.

BUG=none

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ib1e1899d21d14033518ccad09166a131fd4a1f3a
Reviewed-on: https://chromium-review.googlesource.com/1232515
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592375}

Bug: 884675
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9a7ac9b2cd525d976a3e5d5644004067cdb9d982
Reviewed-on: https://chromium-review.googlesource.com/1228056
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592374}

They no longer fail.

BUG=392771,869308

Change-Id: I8c9dd48eb481ade4626327f737c8e577da577665
Reviewed-on: https://chromium-review.googlesource.com/1233105Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592373}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e67e094d0bb..ce2e95b6cc38


Created with:
  gclient setdep -r src-internal@ce2e95b6cc38

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib6b31983016ee44bcb6e49cbce73ab0a216aad22
Reviewed-on: https://chromium-review.googlesource.com/1233633Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592372}

Using wpt-import in Chromium 987b42a8.
With Chromium commits locally applied on WPT:
87da8d40 "[Background Fetch] Miscellaneous cleanups."
29028a2d "[css-tables] Force layout when colgroups are removed or added"
66a74d2f "Revert "[css-tables] Force layout when colgroups are removed or added""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24833

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I0c4a80566dbf05d4427cb7d50bc2f0041ea8c83f
Reviewed-on: https://chromium-review.googlesource.com/1233183
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592371}

Replace |std::unique_ptr<base::Value>| with |base::Value| wherever
possible.

Change-Id: Id11c694a6d997118a96f6330b5ed23c8a1740289
Reviewed-on: https://chromium-review.googlesource.com/1228375
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592370}