- 15 Sep, 2020 40 commits
-
-
manukh authored
This CL fixes a typo introduced in crrev.com/c/2324212 that would prevent the omnibox's width being updated in |LocationBarView::Layout()| if: - RichAutocompletionShowAdditionalText was enabled (default) - RichAutocompletionTwoLineOmnibox was disabled (default) - The omnibox was empty This resulted in - The hint 'Search Google or type a URL' when the omnibox is cleared and blurred or when on the NTP. - The cursor being misplaced when entering keyword mode which clears the user text. Bug: 1128094, 1062446 Change-Id: I073a9c75db1266d02a192675149211bad7615a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410591Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#807087}
-
manukh authored
These histograms have not been used in a while and we don't expect to use them in the future. They were set to expire 9/19/2020. This CL removes the code logging this histograms and marks the histograms obsolete. Bug: 1037287 Change-Id: Ia0f277ab08e04d31de68b7b4681e18e0ccddcfab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398843Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Emily Stark authored
This is a reland of 71f44efe Original change's description: > Add test configs for URL display experiments > > This CL adds test configs for the URL display experiment group that > launches all three URL display experiments and SafeBrowsing Delayed > Warnings. > > SafeBrowsingDelayedWarnings was launched standalone for M85. In M86 and > above, it's launched with the other URL display experiments. It's also > no longer launched on Android as the URL display experiments aren't > implemented on Android. > > The CL also removes a couple of obsolete configs so that the bots > don't hit the command line length limit. > > Bug: 1111429 > Change-Id: I037fb3a456a31d7617516eb7ad554ec1a02f4d6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399563 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806380} Bug: 1111429 Change-Id: I672e02a632dd3309602dab23c0ec5a7ec8a53d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410819Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
This is a follow-up to crrev.com/c/2404663 https://screenshot.googleplex.com/7sg94xt2F9CqNFb Bug: 1127090 Change-Id: I523d509ff628071c436239ce61ce52c98d46ac95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411299 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Frédéric Wang authored
MathML Core currently defines fallback values to use when no MATH table is available. This CL performs the remaining work to ensure fractions align with the specification. It also adds WPT test to check these fraction fallback parameters, although testing them extensively is difficult. Bug: 6606, 1058369 Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#807083}
-
Piotr Bialecki authored
Step 2/N of moving ARCore device into device/vr. Previous step: https://crrev.com/c/2341811. Changes: - move vr_gl_util.h/.cc out of chrome/browser/vr/ into device/vr/ - it will be needed there once ar_renderer.cc gets moved - move gl_bindings.h out of chrome/browser/vr/ into /device/vr/ - the vr_gl_util.h depends on them - chrome/browser/vr:vr_ui now depends on //device/vr:vr_base for the vr_gl_util.h/.cc files - move vr_gl_mode config & vr_gl_bindings source set from chrome/browser/vr into device/vr - move use_command_buffer into device/vr/buildflags/buildflags.gni Bug: 843374 Change-Id: I4e5c4b50a1ff7e256ccebbf06da74700ad3bc9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405538Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#807082}
-
Mike Dougherty authored
On small devices, the "Payment Methods" row in settings may require scrolling the settings table in order to make it visible. Add a scroll down search action to scroll the settings table until the row is found. Change-Id: If4ff25908e117521236c01eca1d61ca8e61ba256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412249 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#807081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df4ddebf1c60..e049f9d1de14 2020-09-15 taylori@google.com Merge "perfetto-ui: Column sums" 2020-09-15 taylori@google.com Merge "perfetto-ui: Add privacy policy link" 2020-09-15 taylori@google.com perfetto-ui: Add isGoogler custom dimension If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:163130524 Tbr: perfetto-bugs@google.com Change-Id: Ia3b6a517c4995bb869a5eca2278f6c6eb0b830a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412348Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807080}
-
minch authored
Bug: b/168511137 Change-Id: I31f4a80fe543b8cc02dfe14b2d378ded6951e4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411703Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#807079}
-
Victor-Gabriel Savu authored
Bug: chromium:1125659 Bug: chromium:1125661 Bug: chromium:1125662 Change-Id: I29b83e3c9b2298f806f0cef37295ad73a2d9e420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410124Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#807078}
-
Adam Langley authored
This code will register with the cloud messaging service in order to receive notices from the tunnel server that a paired desktop wishes to connect. BUG=1002262 Change-Id: Ib8b9521304e557302a44cc2ad6498c60b44fe37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406700 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#807077}
-
Lepton Wu authored
We always remove invitee from pending_invitations_ before adding it to pending_broker_clients, so the old code actually is buggy and invitees in pending_broker_clients_ will never be added as a broker client. Fix it by checking peers_ instead of pending_invitations_. BUG=b:146518063,b:150661600,b:168250032,chromium:1121709 TEST=manual - Keep running arc.Boot.vm with updated mojo code. Change-Id: Ib0353944e7d5b9edc04947f8bd2db1442a4ed78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411560 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Lepton Wu <lepton@chromium.org> Cr-Commit-Position: refs/heads/master@{#807076}
-
David Bienvenu authored
Replace with is_type_app, is_type_app_popup, is_type_devtools as appropriate. Bug: 990158 Change-Id: I4df1b675ebec3408f690da7899653e00b851c388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401263 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#807075}
-
Trent Begin authored
This change syncs the mojom file in cros_healthd with the newly added OS version structures. This structure is not currently used anywhere in Chrome. This change also modifies a comment wrapping to make the files the same. Bug: chromium:1123998 Change-Id: I1ae5599807c72bd4826c456588c88668aaf03508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406597 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807074}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: Iba8ac41c84bf091bbf8c87a5d129364f1e38d76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409938 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807073}
-
Colin Blundell authored
The tests were employing the following pattern: 1. Launch a flow that should result in a certain event occurring (e.g., a navigation that should result in a language determined observer callback) 2. Create a waiter to observe the event and wait Most of the time this works just fine, but it's subject to a race wherein the event is fired as part of step 1. When this flow occurs, the test will end up waiting forever and timing out. In particular, this case is possible in the flow of navigating to a webpage and waiting for the callback that the language was determined, which means that all of the tests in this suite were subject to flake across all platforms (this can be seen from https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=weblayer_browsertests&tests=TranslateBrowserTest.*). This CL fixes the bug by ensuring that the waiters are created *before* step 1 in each instance of the above flow. There are long-lived waiters for each event of interest that are reset just prior to a new instance of the above flow. As the waiters by design quit their RunLoop when they receive the event of interest (whether they have yet received a call to Wait() or not), having the waiters pre-created ensures that the observation will work whether the event occurs as part of step 1 or subsequent to step 2. To verify, I ran the translate browsertest suite 100 times locally with logging added to detect this race condition. Prior to making the change in this CL I saw 3 failed tests that were indeed subject to this race. After the change I saw no failed tests. Bug: 1128384 Change-Id: I141dac490a0b486da3eff66a7bca7075cc76e403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410488Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807072}
-
Vincent Boisselle authored
Bug: 1128161 Change-Id: Ic5e6cc0439f88394b0d237490f66329f648d0180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411488Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#807071}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1126801 Change-Id: I78c51c5e11b9aa6e03e6f195ac2312162906b5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409425 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807070}
-
Andrew Grieve authored
Some code got copy/pasted, likely due to merge conflicts: 3ed7301e Bug: None Change-Id: Iffc859412b65c44c3252dc9f509e9754dac1b7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410344 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807069}
-
Philip Rogers authored
These metrics are still useful for https://crbug.com/1008483: Compositing.Renderer.LayerSkippedForDrawPropertiesDueToBackface Compositing.Renderer.LayerUpdateSkippedDueToBackface Bug: 1125655 Change-Id: Id534eb6c740d2986736da68508c8435cc78020be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408639Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Sinan Sahin authored
Bug: 1121402 Change-Id: Ia47af8941c19e531837f676664432cb4faf5d7b3 Binary-Size: Adds 9-patches needed for dark theme on tablets Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406840 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#807067}
-
Yuheng Huang authored
Since CTRL/CMD+SHIFT+E is already used in Google Docs, Product decided to change the shortcut to CTRL/CMD+SHIFT+A to avoid the conflict. Bug: 1099917 Change-Id: Idb3505b619f4dd16778ff3992f65dac507dff722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411228Reviewed-by:
-
Yi Gu authored
Gives more time to propagate the WebOTP bit. Bug: 1120305 Change-Id: Id350a03de42d3ea5895f01f47cdb5fff7ce801e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405374Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807065}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1126861 Change-Id: I561acf87ca2955705e2d1b40ced5143a93266d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409688 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 316409, 1126958 Change-Id: Ia94f5c26525e8058e23b955845997163b6554641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410101Reviewed-by:
-
Jit Yao Yap authored
Bug: 1101208 Change-Id: Ica3c8f5dd1d2592bb02b3e1c1f6f637732909139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398703 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#807062}
-
Federico Paredes authored
Bug: 1126671 Change-Id: I86ae7c3ba040fad1c0a09ef646e73687b907dde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402278Reviewed-by:
-
David Maunder authored
We now enforce that tab attributes cannot be acquired on an uninitialized Tab (including Tab#destroy). Adding in a fallback. Bug: 1117396 Change-Id: I0e8eeec1a982677e64d6d7f82f2fd883c1e0d4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411160Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#807060}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68241d4f5af5..9d6bf6eee8b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC iclelland@google.com,poromov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: iclelland@google.com,poromov@google.com Change-Id: Ib15c9c8851db9546a7f53995bdf3eb5f26ca7739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412275Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807059}
-
James Vecore authored
Adds a mojo interface on top of the existing contacts manager and makes it available for binding in both chrome://nearby and chrome://os-settings. Bug: b:166503584 Change-Id: I67b8588fae5c838f4f0a57bffd2078d99c9c83fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402758 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#807058}
-
Fredrik Söderqvist authored
Reflect the computation done by FEImage::MapInputs() in FEImage::CreateImageFilterForLayoutObject() to reduce the size of the destination rectangle to that of the bounding box of the referenced content. Bug: 109224 Change-Id: I24b5550e828f6bf1f4e3b0cbf51a34b8e9df2939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409941Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#807057}
-
Stepan Khapugin authored
When the app is starting and focusing the omnibox at the same time, the layout guides for the popup might not be constrained yet. It does not cause any issues if they are constrained later. Bug: 1112760 Change-Id: I9235ca681f18ea5b1c7882c955c1ffa28b533ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410132 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#807056}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I951ac22d3b517423a7dc1f53afe3a07a607ae7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411734Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#807055}
-
Victor Hugo Vianna Silva authored
runOnUiThreadBlocking() has no restriction on being called from the UI thread, so it should be safe to call the loadNativeLibrary...() methods from the UI thread as well. This CL also fixes one comment cross-reference to NativeLibraryTestRule, which apparently doesn't exist anymore. [1] https://source.chromium.org/chromium/chromium/src/+/master:base/android/java/src/org/chromium/base/ThreadUtils.java;drc=c741e070dbfcc33b2369e7a5131be87c7b21bb99;bpv=1;l=156 TBR=jdoerrie@chromium.org Bug: None Change-Id: Icd38029ac5dddd372485be00f03648068d7e3063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404351 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Victor Vianna <victorvianna@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#807054}
-
Caroline Rising authored
These changes are behind the kReadLater feature flag. This cl updates the read later string and adds capitalcase versions. Bug: 1117023 Change-Id: I26d62e659b06a113e63c3c457cdef85ce366a126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402105Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#807053}
-
Behdad Bakhshinategh authored
This reverts commit f1b689af. Reason for revert: crbug.com/1128390 Original change's description: > [Autofill] Returns all patterns that match given language and fieldtype. > > This CL provides new structure MatchingPattern that replace using > single regular expressions, but store more information about concret > pattern. Also it contains splitted MatchType into MactchFieldTypes > and MatchAttributes and sceleton of PatternProvider class. > > > Change-Id: I5acebf12aafaca67ae87260b2c897bdf35a38bea > Bug: 1121990 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385282 > Reviewed-by: Christoph Schwering <schwering@google.com> > Reviewed-by: Matthias Körber <koerber@google.com> > Commit-Queue: Mariia Shvedchenko <mariiash@google.com> > Cr-Commit-Position: refs/heads/master@{#806125} TBR=koerber@google.com,schwering@google.com,mariiash@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121990 Change-Id: I9d3b94cddf87dba1579caec56829fe75953ace5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411701Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807052}
-
Patrick Noland authored
When lazily inflating the MenuButton, the call to setThemeColorProvider doesn't trigger an immediate update, risking starting with the wrong color/useLight combination if inflation occurs in a context where the defaults aren't correct, e.g. incognito. This CL corrects the issue by initializing the color immediately. The need for this code should, however, go away once the color is read from the model instead of directly, since the initial bind will take care of problems like this. Bug: 1127826 Change-Id: I609f42427a0b8fa877f4c165e97372d34047f28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410590Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#807051}
-
Lukasz Anforowicz authored
This CL changes (and slightly renames) CreateWebUIURLLoaderFactory so that it returns mojo::PendingRemote to a WebUIURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<WebUIURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I6079a8b4b3a17d838539a62234b788a3353c76c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358309Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#807050}
-
Xianzhu Wang authored
BTW fixed a small invisible bug for anonymous LayoutObjects which just affects performance a bit. Bug: 1127474 Change-Id: I926bef2572a1d0099c2e106fdd4eb36756e99fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410816Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807049}
-
Matt Menke authored
The URLRequest constructor could accept a NetworkDelegate argument which would override the URLRequestContext's NetworkDelegate. However, URLRequest's constructor was private, and only URLRequestContext could call it, and URLRequestContext didn't have a method to pass a NetworkDelegate other than its own to URLRequest's constructor. As a result, not only was nothing taking advantage of this ability, but nothing *could* take advantage of it. To the extent of my knowledge, this ability has never been used, yet the per-request NetworkDelegate argument was wired through the entire URLRequestJob creation stack. Since this CL is already touching all URLRequestInterceptors, it also updates the URLRequestInterceptor API to return a unique_ptr. TBR= yuweih@chromium.org Bug: 1126597 Change-Id: I5f0fade639e06a2edc8f514853262af3afa6e110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401854Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#807048}
-
