- 28 Oct, 2019 24 commits
-
-
Koji Ishii authored
This is a reland of crrev.com/c/1882249 because the path names of some -expected.png were too long on Windows. * 3 crashes in native-file-system. * Mostly image rebaselines where scrollbar buttons became grayed when the scroll position is at begin/end. Probably someone fixed this. * A few pixel differences in rendering fonts, for vertical flow and "AM" in the date picker. TBR=ikilpatrick@chromium.org Change-Id: If1d67fb4a9d496c564bfe6246cc57e46288c565b Bug: 1018587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882259 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709800}
-
Meredith Lane authored
This reverts commit 81487c55. Reason for revert: https://crbug.com/1018627 Original change's description: > Exposing button's children internally and to AT > > The motivation behind this change is that we want text pattern APIs to > access the text content of both native buttons and ARIA role=button. > In order to achieve the above, we need to be able to serialize button > element's children to AXTree. This change enables all children of button > to be exposed in the AXTree. > > Additionally, if the button's children are text only and also exposed > in the Browser Accessibility tree, screen readers may double speak the > button's name. To prevent this, if button's only child is a static text > we mark the button Browser A11y node as leaf. > > On Android, we treat all its Browser A11y button nodes as leaves and > expose no child. > > Summary: > -------------------------------------------------------------------- > BEFORE: Exposed in AXTree & Browser A11y Tree (BATree): > > native button | role=button > single text child: AXTree[N],BATree[N] | AXTree[N],BATree[N] > BATreeAndroid[N] | BATreeAndroid[N] > > complex children: AXTree[N],BATree[N] | AXTree[Y],BATree[Y] > BATreeAndroid[N] | BATreeAndroid[Y] > -------------------------------------------------------------------- > AFTER: Exposed in AXTree & Browser A11y Tree (BATree): > > native button | role=button > single text child: AXTree[Y],BATree[N], | AXTree[Y],BATree[N], > BATreeAndroid[N] | BATreeAndroid[N] > > multiple children: AXTree[Y],BATree[Y] | AXTree[Y],BATree[Y] > BATreeAndroid[N] | BATreeAndroid[N] > -------------------------------------------------------------------- > > Note: > According to the ARIA spec (below), the children of role=button are > presentational, which means they should not be exposed to ATs > (a.k.a. should all be treated as leaf nodes). > However, we need the button contents to be exposed sometimes because > they may contain many rich, interactive descendants such as buttons > inside a calendar popup and screen readers need to interact with these > contents (See https://crbug.com/689204). > > Additionally, Firefox also expose the children of both native button and > role=button. > Due to the above, we decided to departure from the ARIA spec and not > enforce the leafiness of buttons. > > ARIA && core-aam specs: > https://w3c.github.io/aria/#button > https://www.w3.org/TR/core-aam-1.1/#exclude_elements > > ~~~~~~ > Note: > The actual functional changes are in the two files below, the rest are > tests: > content/browser/accessibility/browser_accessibility.cc > content/browser/accessibility/browser_accessibility_android.cc > third_party/blink/renderer/modules/accessibility/ax_node_object.cc > ~~~~~~ > > Bug:1013609 > > Change-Id: Ia7c4bac9940b34dd3a3122938057cb48e847b76a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845810 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709728} TBR=dmazzoni@chromium.org,boliu@chromium.org,aleventhal@chromium.org,kschmi@microsoft.com,adettenb@microsoft.com,vicfei@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013609 Change-Id: I2641def8c4e7b1fd610219ed3a99982c94b9f183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882198Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709799}
-
Jason Lin authored
Bug: 929571 Test: Enable CrostiniWebUIInstaller flag, and test manually Change-Id: I890d5154e570c0b9f3bd59173f2696cba0211ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874073Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#709798}
-
Ella Ge authored
The test was flaky failing with RemovePendingUserActivationIfAvailable true and HasTransientUserActivation false. It's probably because of timing issue (InputEventAck arrive sooner than the UpdateUserActivationState IPC). This CL changes to wait until the target frame get activated. This CL also adds the test to INSTANTIATE_TEST_SUITE_P. (The test wasn't actually running after the crrev.com/c/1850736 fixed the scope feature list) Bug: 995285 Change-Id: I5651115487d7dd1beba51933ec67dbc3d38c28e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869072 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#709797}
-
Joel Hockey authored
This reverts commit d5f9416a. Reason for revert: relanding as expected Original change's description: > Revert "Use attached browser CreateParams in CreateBrowserForDrag" > > This reverts commit 5a45cc91. > > Reason for revert: crbug.com/1015534 suspects performance regression. It is hard to interpret the results in that bug, so I will revert and rerun perf analysis. I suspect this change made no difference, and if that is confirmed, I will reland. > > Original change's description: > > Use attached browser CreateParams in CreateBrowserForDrag > > > > Use the attached browser CreateParams rather than > > BrowserList GetLastActive. > > > > It feels safer that the attached browser will always > > be the one that we want whereas BrowserList GetLastActive > > may not be so reliable. > > > > Bug: 1012169 > > Change-Id: Ifbbc13aa797db7942f5ce1d52decdac264c5d927 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862875 > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Peter Kasting <pkasting@chromium.org> > > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706220} > > TBR=pkasting@chromium.org,joelhockey@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1015534 > Bug: 1012169 > Change-Id: Ief9fa8770467e12c14a3b86b6c004a0b6d2b62cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882202 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709793} TBR=pkasting@chromium.org,joelhockey@chromium.org Change-Id: Ifdef35496534b04a22d4b0627ebd6ed6dc60f347 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015534, 1012169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882205Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709796}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to CreateMediaPlayerRenderer and CreateFlingRenderer in InterfaceFactory interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Replace MakeStrongBinding with MakeSelfOwnedReceiver. Bug: 955171 Change-Id: I8dabcba8ebe6e53dd3a561d786c8bd5bf1edb257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880988 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709795}
-
Gang Wu authored
Home page button seems enabled for a while on switching between tabs. It is because during transition between views, HomeButton only check the active tab, if no active tab, HomeButton did not check go-to tab. In this CL, HomeButton will check go-to tab if no active tab. Bug: 935266 Change-Id: I59f5a617ebefce21b461fbcbf95ca0d04c186ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873396 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#709794}
-
Joel Hockey authored
This reverts commit 5a45cc91. Reason for revert: crbug.com/1015534 suspects performance regression. It is hard to interpret the results in that bug, so I will revert and rerun perf analysis. I suspect this change made no difference, and if that is confirmed, I will reland. Original change's description: > Use attached browser CreateParams in CreateBrowserForDrag > > Use the attached browser CreateParams rather than > BrowserList GetLastActive. > > It feels safer that the attached browser will always > be the one that we want whereas BrowserList GetLastActive > may not be so reliable. > > Bug: 1012169 > Change-Id: Ifbbc13aa797db7942f5ce1d52decdac264c5d927 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862875 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706220} TBR=pkasting@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015534 Bug: 1012169 Change-Id: Ief9fa8770467e12c14a3b86b6c004a0b6d2b62cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882202Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709793}
-
Meredith Lane authored
This reverts commit a6f0d9ae. Reason for revert: Causing failures in chromeos_components_unittests. Bug: https://crbug.com/1018633 Original change's description: > [Wifi Sync] Implement the SyncedNetworkUpdater class. > > This is responsible for updating the local network stack to match > incoming WifiConfigurationSpecifics protos from the sync backend. > > Bug: 966270 > Change-Id: Ib4bdf1c22604b2528bc2abad5bc2ac1672e58290 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768877 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709627} TBR=xiyuan@chromium.org,stevenjb@chromium.org,khorimoto@chromium.org,jonmann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966270 Change-Id: Idce7f0208c06412b9c950e3f833f50b5f15a816b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882201Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709792}
-
David Staessens authored
The video_decode_accelerator_unittest is deprecated in favor of the video_decode_accelerator_tests and video_decode_accelerator_perf_tests. This CL removes all documentation related to the old tests. vdatest_usage.md documents both the VEA and VDA tests. It has been renamed to veatest_usage.md and all parts referring to the VDA tests have been removed. TEST=None BUG=1802897 Change-Id: I754c039238e553493bc4076b160ab6928e97a4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800853 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#709791}
-
Jinsuk Kim authored
https://crrev.com/c/1475135 refactored Tab to remove its direct dependency on AppBannerManager i.e. AppBannerManager inherited TabObserver, and updated its flag through activity attachment state event using TabDelegateFactory.canShowAppBanners. It works okay but among all the factory interface methods in TabDelegateFactory, |canShowAppBanners| looks like an odd one out. This CL moves it to TabWebContentsDelegateAndroid. It requires extra JNI hop but IMHO fits in there better. With this change, other callsites of |Tab.getDelegateFactory| are refactored so that the API can be private package. Bug: 995903 Change-Id: I6a3df8af917fccda5202d9f65f5cf71915b02f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877873Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#709790}
-
DongJun Kim authored
In the past, "content/*/file_system" was renamed to "fileapi" to contain both the code for the filesystem API and the blob system. But the blob system moved out to separate directories, we have the confusing situation that we have directories named after one API that contain the implementation of a different API. This patch rename "content/browser/fileapi" to "file_system" to actually match for reducing confusion. Bug: 921260 Change-Id: Iffb6dc2e9b453585f04642c534db324e99684737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873805 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#709789}
-
Meredith Lane authored
This reverts commit ab98b39d. Reason for revert: Consistently failing on MSan https://crbug.com/1018617 Original change's description: > Use resampler for playback speeds close to 1.0 > > The WSOLA algorithm introduces noticeable audio artifacts when doing > small adjustments to playback rate (e.g. 1.03 playback speed). The > distortions can be described as warbling or transient stuttering. > > This CL introduces fixes this issue by using resampling instead, for > speeds close to 1.00. The resampled audio doesn't have any distortions, > but its pitch is shifted proportionally to the playback changes. The > maximal slowdown/speed up we use resampling for is 5-6%, which > corresponds to shifting by 1 note tone. Beyond that, the WSOLA > artifacts become tolerable, and the pitch shifting doesn't. > > Bug: 920019 > Change-Id: Ia1f93dc6a5de8be14e054b9e165fb9508af491f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875654 > Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709679} TBR=dalecurtis@chromium.org,tguilbert@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920019 Change-Id: I5c7f531c446ebb2af24d26698994a0747dd68aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882255Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709788}
-
Ramin Halavati authored
storage::features::kEnablePersistentFilesystemInIncognito is added to enable/disable Persistent filesystem in incognito mode. Bug: 990592 Change-Id: I7766c2251116c8ed0d2d90af9f316179e40141a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879233 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#709787}
-
Gyuyoung Kim authored
As a following CL, this CL applies pending_receiver to the second parameter of CreateCastRenderer. - Convert FooRequest to mojo::PendingReceiver. Bug: 955171 Change-Id: I4e06c59e550c5ca0c17aadae40871de017c69f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881000Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709786}
-
Meredith Lane authored
This reverts commit ffff90fd. Reason for revert: Consistently failing on multiple ChromeOS bots. https://crbug.com/1018615 Original change's description: > [Sampling profiler] Implement signal-based stack copying in //base/profiler > > This CL extracts the core stack copying parts of > tracing::StackUnwinderAndroid into the dedicated base::StackCopierSignal > class, and adapts it for direct use by the sampling profiler stack > unwinding implementation. This drops some unneeded code; updates the code > to run on 32-bit Android, 64-bit Android, and 64-bit Linux platforms; > and converts the code to use C++ atomics. > > The StackUnwinderAndroid implementation will eventually be replaced > wholesale by the sampling profiler implementation for Android. This CL > does not attempt to reuse the extracted stack copying implementation on > its own, in order to avoid introducing bugs in StackUnwinderAndroid due > to the differing implementations. > > TBR=gab@chromium.org > > Bug: 988579 > Change-Id: I0293771679c5deae69fdbb007d8828ead575ee0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872967 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Auto-Submit: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709597} TBR=gab@chromium.org,wittman@chromium.org,ssid@chromium.org,charliea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 988579 Change-Id: Ib62446f431d971f2403b1fb9fcebaa130559c698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882190Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709785}
-
Kent Tamura authored
delegatesFocus: Share code in Element::focus() and MouseEventManager::SlideFocusOnShadowHostIfNecessary() This CL has no behavior changes. Bug: 1014094 Change-Id: I88dc1ca15210ff96c698f32416c3d284859ad583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880899Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#709784}
-
Meredith Lane authored
This reverts commit 07e39f96. Reason for revert: Causing flakiness on AppListClientImplBrowserTest.UninstallApp. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=AppListClientImplBrowserTest.UninstallApp Original change's description: > Reland "Use AppService to uninstall apps on Chrome OS." > > This CL is used to reland the CL:1864496 and fix the browser_tests. > > CL:1864496 is reverted because it breaks the browser_tests: > AppListClientImplBrowserTest.UninstallApp > > The reason is a NativeWindowTracker should be created to track whether > |parent_window_| got destroyed. If destroyed, or load icon failed, > call OnDialogClosed to notify AppServiceProxy to remove the > UninstallDialog from set, and destroy UninstallDialog. > > BUG=1009248 > > Change-Id: I1a2fe6f087a5cc2f723ac0256510a385555e9347 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875865 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709487} TBR=xiyuan@chromium.org,dominickn@chromium.org,nancylingwang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1009248 Change-Id: Ib3b60ce1f11e9b0dcd5f5bc3870702eaf96c9896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882195Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709783}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 437cc065. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org: external/wpt/compat foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iffe1946e7925604b8b3935a90bb2812f1c222f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882932Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709782}
-
Hiroki Sato authored
When the node is non-editable and doesn't have a text property, the accessibility name field had an extra space. This fixes the issue. This CL also refines unit test (AccessibleNameComputationTextField). Bug: None Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: I2dca6990215e98bdf2a9a57a0888f05298a2985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874995Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#709781}
-
Hiroki Sato authored
When DrawerLayout is opened, the contents behind the menu should not get accessibility focus. These nodes have ImportantForAccessibility=false attribute in Android. This CL respects the attribute to set ignored state in Chrome side. Bug: b:130186722 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manually confirmed with PlayStore, hangouts, Dropbox, etc. that drawer menu navigation is restricted in the menu. Change-Id: I390920f3ec5ba2943a7474483f3180c8cd587ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875853 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#709780}
-
David Staessens authored
This CL removes the md5 data files which are only used by the deprecated video_decode_accelerator_unittest. This test has been deprecated in favor of the video_decode_accelerator_tests and video_decode_accelerator_perf_tests, which get the md5 frame checksums from json files accompanying each test video. TEST=./video_decode_accelerator_tests on eve BUG=1802897 Change-Id: I2417dd1bda7ee9e23dcf5bdec75a04ade9497a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851631 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#709779}
-
Kunihiko Sakamoto authored
This is a doc for web developers who want to create Web Bundles that can be loaded with Chrome. Change-Id: I9cc05fa686e82910065fdd11d6e13e8ecec0ba6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880413Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#709778}
-
Rob Schonberger authored
This modifies Centroid calculation to be O(1) when calculating a centroid of a stroke. Centroid fetching/checking happens a lot, so it's worthwhile to optimize. Nevertheless this is still a heavy O(1) - so alternatives are happily considered. Bug: 1009290 Change-Id: Ia421502c1cdf5e37bd5c6f80dc4f866af2119b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880237Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709777}
-
- 27 Oct, 2019 6 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id5847d77875473521c8b9842386fcbab81637a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881784Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709776}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/403b00885ea5..97bcfab8abdd Created with: gclient setdep -r src-internal@97bcfab8abdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: None Change-Id: I76da19f2a1d077264062f35e60d32b66572c867a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882651Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709775}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff82e15d014a..62160f2f358a git log ff82e15d014a..62160f2f358a --date=short --no-merges --format='%ad %ae %s' 2019-10-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@62160f2f358a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Id0732cd090bb74d2fe335c1781e5fa7611ca4d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882570Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709774}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e9cc938..be638514 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I941b22302ac8b4bc23ce58f83b104dddea5fba1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882140Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709773}
-
Jamie Madill authored
This reverts commit c3d943c2. Reason for revert: Broke Windows builders. Bug: 1018587 Original change's description: > Update disable-blink-features=LayoutNG > > * 3 crashes in native-file-system. > * Mostly image rebaselines where scrollbar buttons became > grayed when the scroll position is at begin/end. Probably > someone fixed this. > * A few pixel differences in rendering fonts, for vertical > flow and "AM" in the date picker. > > TBR=ikilpatrick@chromium.org > NOTRY=true > > Change-Id: I1f8a9eb2fbb816f27bf2eb8d51e423919dbbf9a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882249 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709765} TBR=kojii@chromium.org,ikilpatrick@chromium.org NOTRY=true # Skipping CQ checks to get CQ in working state. Change-Id: I4551c8420fa9d28ff322abe59b02f6d9fd6609f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879345 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#709772}
-
Koji Ishii authored
Following bot results are included. 37 39 41 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iedc076dd23c41b3a90dae78e0ae52c448567acf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881002 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709771}
-
- 26 Oct, 2019 10 commits
-
-
Haines Sy authored
The NetworkChangeNotifier base class creates and initializes a NetworkChangeCalculator which synthesizes high-level network change notification events. Because it is created before the derived NetworkChangeNotifierFuchsia reads the initial network state, events must be dispatched for that initial state, for the NetworkChangeCalculator to be up-to-date. Bug: b/142796913 Change-Id: I51a319d0e5925721c81d7bb4b3eb15521dd1ba91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880449 Commit-Queue: Haines Sy <hainesy@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#709770}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e7c8e80dbb2e..95a736bd3347 git log e7c8e80dbb2e..95a736bd3347 --date=short --no-merges --format='%ad %ae %s' 2019-10-26 jmadill@chromium.org Reland "Add more test_utils functions." Created with: gclient setdep -r src/third_party/angle@95a736bd3347 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1015810 Change-Id: Ib4798f24b475e0691874d10dd007d331004011d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709769}
-
Yang Guo authored
Bug: 1011259 Change-Id: Ia8b5363d1d17416ce73f15366ab86d758a78b626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872002Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709768}
-
Koji Ishii authored
This patch fixes resolved direction for box items. Before this patch, it was set to the opposite direction. Bug: 982194 Change-Id: I1fcdd0c15fa453ac8a25ba6cc81769022cbfd2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880895 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709767}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Idb1c46c52fd89e96af99d076d05bd4122ebe808c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882161Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709766}
-
Koji Ishii authored
* 3 crashes in native-file-system. * Mostly image rebaselines where scrollbar buttons became grayed when the scroll position is at begin/end. Probably someone fixed this. * A few pixel differences in rendering fonts, for vertical flow and "AM" in the date picker. TBR=ikilpatrick@chromium.org NOTRY=true Change-Id: I1f8a9eb2fbb816f27bf2eb8d51e423919dbbf9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882249Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709765}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/76763cb90a43..e7c8e80dbb2e git log 76763cb90a43..e7c8e80dbb2e --date=short --no-merges --format='%ad %ae %s' 2019-10-26 jmadill@chromium.org Roll chromium_revision 60074bf9..5fe256ab (709436:709762) Created with: gclient setdep -r src/third_party/angle@e7c8e80dbb2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1017514 Change-Id: I75189db50e4ed3012535b7f11962c845b0d303a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709764}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id966f672c5140eed017b1ee5fc7fc0c6864e279f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709763}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7294eccd. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload mek@chromium.org: external/wpt/webmessaging tdresser@chromium.org: external/wpt/navigation-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic24792683389612d50c91fc6ae560d64eee074e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882129Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709762}
-
Henrique Ferreiro authored
Bug: 919392 Change-Id: Idbc7d23d127027834c70f09821ae0f389ce260be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876347Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#709761}
-