GitLab

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ec45b51785af..b21a40d6e974

2020-11-09 alexrudenko@chromium.org Set background color for focused summary in the Layout panel
2020-11-09 aerotwist@chromium.org Fix import for front_end/coverage
2020-11-09 mathias@chromium.org Simplify textToIconResolver map population
2020-11-09 szuend@chromium.org TypeScript-ify PersistenceImpl.js

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1139945
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I695aaa30d5bfb017b48f31b0a16f85520875a4d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525868Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825374}

When confidential content appears in the capture area, the screen capture is being paused.
User should be notified about this via a notification.
The same should be done when the capture is resumed as the content leaves the capture area.

Bug: 1134566
Change-Id: Ide75999dda0cea04f14b56407513a47897fbc7eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520834Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825373}

This reverts commit d8ad718b.

Reason for revert: Goldens break every day as they contain information relative to current time. Needs updating before they will consistently work.

Original change's description:
> Revert "🤠 Revert "enable FeedNewTabPageCardInstrumentationTest" "
>
> This reverts commit 1d9e3ca2.
>
> Reason for revert: Updated golden images, test should now pass
>
> Original change's description:
> > 🤠 Revert "enable FeedNewTabPageCardInstrumentationTest" 
> >
> > This reverts commit 46de280d.
> >
> > Reason for revert: still flaky.
> > See https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/707
> >
> > Original change's description:
> > > enable FeedNewTabPageCardInstrumentationTest
> > >
> > > Bug: 1143781
> > > Change-Id: Ic7c1adad83cb472aeaeb8e82534288184a89d544
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518183
> > > Reviewed-by: Dan H <harringtond@chromium.org>
> > > Commit-Queue: Arthur Wang <wuwang@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#824229}
> >
> > TBR=harringtond@chromium.org,wuwang@chromium.org
> >
> > Change-Id: I9ccace6afc3b4193000d094392c78468887a6249
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1143781
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519975
> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#824385}
>
> TBR=arthursonzogni@chromium.org,harringtond@chromium.org,wuwang@chromium.org
>
> Change-Id: I632bfabe8eacccec82dbd00d231569398f809b2c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1143781
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520812
> Reviewed-by: Dan H <harringtond@chromium.org>
> Commit-Queue: Dan H <harringtond@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824433}

TBR=arthursonzogni@chromium.org,harringtond@chromium.org,wuwang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1143781
Change-Id: Ia9f3b45b0f1924e809e95a0f7112b14237350623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526943Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825372}

The code is already modularized, and there are no dependencies to any
classes in chrome_java, so this can simply be removed.

Change-Id: I249f7b1e5efaf0e800bf9c2ec51508da678a30d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522908Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825371}

This tests the change reverted at r825301 <crrev.com/c/2525882>.

Bug: 1146797
Change-Id: Ibf5c0601efead3d9f31204c866458c5793af8dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526743Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825370}

This CL is fixing a bug introduced in previous refactoring. The word
callback is supposed to send to the TTS controller the character
position but it was not updated.

see: https://bugs.chromium.org/p/chromium/issues/detail?id=1146237#c3

The regression was introduced here:
  https://chromium-review.googlesource.com/c/chromium/src/+/2462341

R=dmazzoni@chromium.org,fdoray@chromium.org

Bug: 1146237
Change-Id: Idc30e25ed1565721797362a71b4b19f0432187fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523104Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825369}

This CL has tests that cause the code to be run; there is no easy way
to test the resulting behavior change at JS level.

Bug: chromium:1038754
Change-Id: I51d99e7fffbb66a0478f03d674fb3699925fa3f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986070
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825368}

This reverts commit 4039312e.

Reason for revert: I believe this failure was already fixed. See https://bugs.chromium.org/p/chromium/issues/detail?id=1147058#c3.

Original change's description:
> tools/perf: Disable blink_perf.parser.declarative-shadow-dom-cloning on Mac
>
> NOTRY=true
> TBR=masonfreed@chromium.org
>
> Bug: 1147058
> Change-Id: Ica80747af140f1c1eddff795fd14c709314647ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526069
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825352}

TBR=skyostil@chromium.org,masonfreed@chromium.org

Change-Id: Idcfe52f204e76cd495a37c619ef66f39dc4119a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1147058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525854Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825367}

The flag name has changed to WebOTP but the test was not updated.
Despite this it was working as expected since the test also uses the
broader "kEnableExperimentalWebPlatformFeatures" flags.

Removing the out-dated flag from the test.

Bug: None

Change-Id: Icadf911858b8165bd6c7148c7545e93ac46680f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491003
Commit-Queue: Yi Gu <yigu@chromium.org>
Auto-Submit: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825366}

https://android.googlesource.com/platform/external/perfetto.git/+log/0bec1380d03d..9b7f81867ddd

2020-11-09 primiano@google.com Merge "traced: prefer /run/perfetto for producer and consumer sockets on Linux"
2020-11-09 taylori@google.com perfetto-ui: Select first heap profile on opening trace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:168779595
Tbr: perfetto-bugs@google.com
Change-Id: I6fedc3a3dcb9c75d14f6cc10518a220ee3d98e50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525870Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825365}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/63061fa2..b4a39160

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id08aeab94c5e380fff5866591a13f02afcd97124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526730Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825364}

Moves session token management from the SearchProvider to
TemplateURLService.

Bug: 10664653
Change-Id: I48be94dbed74b7a3ca4e8c45a0d81687c2a2dea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519837Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825363}

https://skia.googlesource.com/skia.git/+log/cffe7e631c4e..2f30936d46eb

2020-11-09 kjlubick@google.com [canvaskit] Disable GrTextBlobMoveAround
2020-11-09 herb@google.com rename Gr*Subrun to *Subrun in .cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jlavrova@google.com
Change-Id: I54c3b742bd245f0fe083e2aee2fc413015f4608a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525867Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825362}

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/2499086
The original CL doesn't go through the refactor in
https://chromium-review.googlesource.com/c/chromium/src/+/2514077

Bug: 1139028,1099917

Change-Id: I36c7acc8c1adfcd749545bd1c0ce274ea009ce32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521838Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825361}

This CL updates the header asset design for all menus to be full bleed
by removing the 8px margin.

Screenshot: https://screenshot.googleplex.com/8DXjXJW4TZCsSdQ.png

Design Deck: go/alignmenus

Bug: 1105763
Change-Id: I3c4f142ca75bf1651325ddd9a5b157e15347acab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510402
Commit-Queue: Mariam Ali <alimariam@google.com>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825360}

Use CanContainOutOfFlowPositionedElement() to simplify a DCHECK
at NGOutOfFlowLayoutPart::IsContainingBlockForCandidate().
The call to CanContainOutOfFlowPositionedElement() is equivalent
to the previous code.

Change-Id: I361e368729dd5231b3cc5dc52492b01ba4336ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526321
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825359}

Add histogram and enum entries for ChromeStartupDelegate. These will be
emitted downstream in: https://crrev.com/i/3387163.

Bug: 1143402
Change-Id: Ic509f91c4823c3a3a6401e7d0025880d0200e13b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522902Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825358}

- adds FILE_SYSTEM_LAST_PICKED_DIRECTORY website setting
- prerequisite to the implementation of suggested filenames and
  directories for the file chooser

Bug: 1139907
Change-Id: I886cc4c6552cefbf3780e20d5b216ad460646e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478901Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Auto-Submit: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825357}

This reverts commit 6c47dde7.

Reason for revert: The fix creates a pop-in animation (when closing
the menu) issue which is worse than the initial bug.

Original change's description:
> [iOS][ContextMenus] Fixes ContentSuggestions preview
>
> This CL fixes the dismissal animation of most visited tiles.
> Most Visited tile appears blank for a moment switching from incognito to
> normal tab after opening the link in a new incognito tab from context
> menu because there was no preview configured.
> To fix this, the view of the ContentSuggestionsViewController is used as
> a preview.
>
> see: https://drive.google.com/drive/folders/1EZFa-TvlJRsqVp6mwMBz0H7e6EZL0c7e?usp=sharing
>
> Bug: 1117487
> Change-Id: I1d80592e566c92cdd3b9846e74a4af53d697ee47
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526086
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825349}

TBR=gambard@chromium.org,ewannpv@chromium.org

Change-Id: I579c1637e66efa707144a716fd3810cd2de62d32
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1117487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526925Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825356}

Follow up to sky's comment on
https://chromium-review.googlesource.com/c/chromium/src/+/2521691

Bug: none
Change-Id: I045f4fc2828b76688af5d51b9f8a4e573c1a1390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522126
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825355}

This reverts commit 0a590424.

Reason for revert: Breaks Kaleidoscope builds on waterfall: https://bugs.chromium.org/p/chromium/issues/detail?id=1146958

Original change's description:
> Don't include utils.js in builds anymore
>
> It is not used anymore since the test refactor.
>
> Change-Id: Ic8a5d95665f15f5d3498e4c29d8ffd7af6d82c5a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481684
> Auto-Submit: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825083}

TBR=beccahughes@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I47771e29d137453129e50178b5865d0b62e272c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526089Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825354}

These references were missed before removing PathToUgilfy at r814758.
Replacing with PathToTerser.

Bug: 1087970
Change-Id: Ie0cd65940e0a9307d76c48306c5dc94bb1ed481e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526260
Commit-Queue: Roman Arora <romanarora@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825353}

NOTRY=true
TBR=masonfreed@chromium.org

Bug: 1147058
Change-Id: Ica80747af140f1c1eddff795fd14c709314647ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526069Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825352}

I consider this histogram relevant for the foreseeable future, thus
extending by 1 year.

Bug: 1140039
Change-Id: I00c25bb7ddb39ca2ad7b3ef441da635396cc8e6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526343
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825351}

When RELROs from different processes come out not completely identical,
the LegacyLinker has functionality to share only the identical subrange.
This is because at least on some old devices it happened frequently.

The ModernLinker does not have this functionality.

Record a histogram to tell how often the ModernLinker fails sharing on
RELRO mismatches.

Later this histogram can be extended to more linkers and failure modes.

Bug: 979638
Change-Id: I5430dd3fd31f01b9909de3ac758d6ab151d26877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523182Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825350}

This CL fixes the dismissal animation of most visited tiles.
Most Visited tile appears blank for a moment switching from incognito to
normal tab after opening the link in a new incognito tab from context
menu because there was no preview configured.
To fix this, the view of the ContentSuggestionsViewController is used as
a preview.

see: https://drive.google.com/drive/folders/1EZFa-TvlJRsqVp6mwMBz0H7e6EZL0c7e?usp=sharing

Bug: 1117487
Change-Id: I1d80592e566c92cdd3b9846e74a4af53d697ee47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526086Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825349}

http://crrev.com/5e816e7d removed the only test case that used this
method. There are also alternate ways to do this via
RenderProcessHost::ForceCrash.

BUG=1146489

Change-Id: I7ae2f81bbaffd88b799a463b34fd78f4c61145d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521243Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825348}

Please see doc:
https://docs.google.com/document/d/1t5KUt_CnivUO4YKhViXcS_NEa56bBI9WoYqVM1XdsoU/edit#

Bug: 1083428
Change-Id: Ie4b4d43f64e7d95c5d2695a8c24365f4d1e4722b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349985Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825347}

* Use GetPaintLayerByElementId() as much as possible to remove the usage
  of ToLayoutBoxModelObject().

* Remove PaintControllerPaintTest::GetPaintLayerByElementId().
  It's redundant. RendringTest, which a a super class of
  PaintControllerPaintTest, has the same function.

* Add RenderingTest::GetLayoutBoxByElementId() to reduce the usage of
  ToLayoutBox().

* Use Element::GetLayoutBox() instead of Element::GetLayoutObject() to
  reduce the usage of ToLayoutBox().


This CL has no behavior changes.

Bug: 891908
Change-Id: Iec659fdc61cfdd7027e61de5c91f4b55fbccdb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524817
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825346}

This bug is caused by the StartSurfaceMediator registers an observer to
the empty tab model before the TabModel is initialized. In this CL, we
register an observer to the TabModeSelector first and registers an
normal TabModel observer after the TabModel is initialized.

Bug: 1126914, 1138162
Change-Id: I653aeac99c58ed032e9a604b4001a389832d3452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517623
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825345}

This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<>
for:
- LayoutDetailsMarker
- LayoutFileUploadControl
- LayoutProgress
- LayoutNGBlockFlow

This CL has no behavior changes.

Bug: 891908
Change-Id: I5da5b3c7a406b0e4d62256f571192d12f975f10b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525881
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825344}

[1] and related tests were triggering navigations and other actions
synchronously during the RenderFrameHostChanged event, which happens
before the new render frame host is properly committed. This could
lead to issues as the one encountered in another CL's test [2], where
the navigation triggered by test [1] would be seeded with an incomplete
RenderFrameHost. This could be one source of the test flackiness
on Android.

This solves the issue by executing the script asynchronously. I had
to leave the tests using postMessage with the synchronous behavior
though, as the test would fail otherwise.

[1] ProactivelySwapBrowsingInstancesSameSiteTest.NavigationAfterPagehideHistogram
[2] https://ci.chromium.org/p/chromium/builders/try/linux-rel/525214?

Change-Id: I7261ead90e46374a7787e4131e37bd3770141450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517359
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825343}

Use kSigninNotificationInfobarUsernameInTitle experimental flag to allow
switching between "Signed in as [username]" and "Signed in to Chrome"
titles in the sign-in notification infobar.

Bug: 1145592
Change-Id: I31a7b98137f1006f826ff18ee3168d9f87b65431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526420Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825342}

TBR=aluo@chromium.org

Bug: 1142821
Change-Id: I24d4c52296abd4aa9b148ca4ef6ca9f6f32b4ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521100Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825341}

https://android.googlesource.com/platform/external/perfetto.git/+log/0e30faf062f7..9eff30af501c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Iabcd8f8f844f347654132403267a9250e68c30c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526505Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825340}

The sign in API uses CoreAccountInfo. So in the long run its better to
use CoreAccountInfo for helper methods that interact with sign in API.
This cl refactors SyncTestRule so that the methods to add account and
toggle sync states return CoreAccountInfo.

Bug: 1135510, 1117006
Change-Id: I333f9dd87b093d781311a7ee286c04f274ee13ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523112
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825339}

https://android.googlesource.com/platform/external/perfetto.git/+log/9eff30af501c..0bec1380d03d

2020-11-09 taylori@google.com Merge "perfetto-ui: Keep slice selection on marking"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I9d8513906420fe39cc95f155b6234a2f9867a153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526724Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825338}

https://chromium.googlesource.com/angle/angle.git/+log/46f5f4386f7c..40c5e53e7bba

2020-11-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions)
2020-11-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 87451c55aa8b to 670ffea9d61b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: courtneygo@google.com
Change-Id: I1eb8377811385e944baa215c84f67a70694dbe22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526368Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825337}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2eb30ce3c37..ec45b51785af

2020-11-09 aerotwist@chromium.org Prevent resizing of Vitals lane
2020-11-09 janscheffler@chromium.org [WebAuthn] Fix focus on Authenticator name
2020-11-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-11-09 sigurds@chromium.org Also remember empty field in Application > Storage
2020-11-09 szuend@chromium.org TypeScript-ify profiler/ProfilesPanel.js
2020-11-09 changhaohan@chromium.org Avoid re-defining custom elements: CSSAngleEditor, CSSAngleSwatch
2020-11-09 sigurds@chromium.org Allow extra text in FrameDetailsView to get wrapped

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1057090,chromium:1146936,chromium:1146985
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9f8422c69abc9b1e6965ad7e8a29af812e9046f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526721Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825336}

This adds the ruleId field in triggered rules for DLP events, which
seems to have been omitted by mistake.

Change-Id: I468704163e49c1853ea4ba8b7f5432ddc53f933f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521244Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825335}