- 21 Oct, 2020 40 commits
-
-
Patrick Noland authored
This lets us re-hide the implementing class and wire dependencies to its constructor. Bug: 1140188 Change-Id: Idbe3c9c9b061cb657a3a04fa60cb6fc2dece260f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486079Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#819526}
-
Hajime Hoshi authored
Bug: 1117081 Change-Id: I655468fd6748b6e948edc0add545d6fbb7b3272a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489111Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819525}
-
Jonathan Ross authored
This reverts commit f454440c. Reason for revert: chromeos compile failed with a dirty tree. Ninja pointing to OS Settings as likely culprit: "ninja explain: output gen/chrome/browser/resources/settings/chromeos/preprocess_v3/chromeos/os_settings.html of phony edge with no inputs doesn't exist" https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/47276? Original change's description: > OS Settings: Update to use preprocess_grit > > OS settings is the last remaining user of unpack_pak. By migrating it to > use preprocess_grit, unpack_pak can be deleted, preventing any new UIs > from adding more usage. All UIs should instead use preprocess_grit > (and, eventually, autogenerate grd files with generate_grd). > > Planning to update OS settings to autogenerate grd files in a followup. > > Bug: 1132403 > Change-Id: I5378836543befb224a82e58b0211bafba9aead64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487885 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819485} TBR=khorimoto@chromium.org,dpapad@chromium.org,rbpotter@chromium.org Change-Id: Ibaed7c55cc29a22bde6272d6a29f2ee201e79111 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490511Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#819524}
-
Nina Satragno authored
On testdriver virtual authenticator tests, binary values were being encoded as base64 instead of base64url. This didn't blow anything up because the test values happened to have the same representation in both, but is still a bug. Bug: 1141104 Change-Id: I6edd7fdfd4ab0f9ae1d196d8f2e14ed2bd9e334d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490230 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#819523}
-
sczs authored
This way we make sure to stop/start observing whenever a new FeedView has been set, making sure the calls are balanced for all FeedViews. Bug: 1122031 Change-Id: If6392e5b3e9692141b441162665aebd95ddd4b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490024Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#819522}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2d615e49c1cb..982bf51c4052 2020-10-21 robdclark@chromium.org Add way to have a hidden container slice If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I0bbca1dafcd58dc472f4be83daf091d7f5fad829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489669Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819521}
-
Majid Valipour authored
It is important to unsubscribe WebOTPService from SMS fetcher when it gets destructed to avoid use-after-free bugs. This currently happens in CompleteRequest() but we only call it if there is a callback. At the moment using the existence of a callback as a proxy for the existence of a subscription is safe because we only subscribe when there is a callback. But it is more robust and safer to unsubscribe unconditionally and not rely on the existence of callback_ as an indicator for a subscription. R=kenrb@chromium.org BUG: 1138161 Change-Id: Ic69191fa7d895b211508b84f1b90c973f0c386a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490260Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#819520}
-
Jonathan Ross authored
Two Texture Copying tests have begun failing consistently on the ARM-based Apple DTK machines. This change suppresses the tests while the root cause can be identified. TEST=conformance/textures/misc/texture-copying-and-deletion.html conformance/textures/misc/texture-copying-feedback-loops.html Bug: 1141066 Change-Id: I63c40ccd01f4a8304b027738952ca862996181cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490482Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#819519}
-
Daniel Cheng authored
Bug: 1140588 Change-Id: Ib4429dd024d2571d574dcbd63d84dca6ec90e10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488082Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819518}
-
Zakhar Voit authored
This patch makes sure that cursor bitmap received via wl_pointer_set_cursor is scaled correctly before creating the corresponding PlatformCursor. The previous approach had two issues: 1. The cursor size was incorrect for scale less than 200% since we used default DSF (ManagedDisplayInfo::GetDensityRatio()) instead of the effective one (Display::device_scale_factor()). This led to cursor always being upscaled to 200%. 2. We didn't use the same logic that ash uses for scaling cursors: ui::GetScaleForScaleFactor() + ui::GetSupportedScaleFactor(). So the cursor size was different from ash when using fractional scale. Bug: 1140175 Change-Id: Id034cb6d92718a01e3ac0a70047b1e4224b9cf96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485157Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Zakhar Voit <zvoit@igalia.com> Cr-Commit-Position: refs/heads/master@{#819517}
-
Jeroen Dhollander authored
This folder is maintained by the Assistive team. Bug: N/A Change-Id: Ide7af49046a8326985acd19ab715e885961b673d Tests: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490841 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819516}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603281470-f96bc0fcebd9344c6ef9fb677ad5905993ab5142.profdata to chrome-linux-master-1603302740-e55fee2d2ced5621a041f91ab31ac53e5d576c91.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6ecef50926cd37dab7d5b4645f6f1b617699349e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490486Reviewed-by:
-
evliu authored
This CL updates the MediaDialogView to use the original profile for OTR profiles. The CaptionControllerFactory uses a redirected browser context in incognito mode, so the toggle button should affect the pref value of the original profile. Bug: 1055150 Change-Id: I50125192f0bcefbf9711840f042c9bc6a8586072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488618Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#819514}
-
Stephen Chenney authored
Enforce the requirement that all uses of images always orient when the image is cross origin. We rely on ImageResourceContent::IsAccessAllowed and ConvasImageSource::WouldTaintOrigin. Bug: 1110330 Change-Id: I017b4fbf045eb8b0080ba85c49abfba02d2843ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473799 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#819513}
-
Clark DuVall authored
This is a reland of b9d174e5 This was reverted because it broke component builds, should be fixed by http://crrev.com/c/2490330 Original change's description: > Enable isolated splits in canary > > All known issues have been fixed so enabling this in canary to see if > there are any major problems. > > Bug: 1126301 > Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819200} TBR=agrieve@chromium.org Bug: 1126301 Change-Id: I343572b03f99ec201df4fb021c56d13233db623e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490682Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819512}
-
kylechar authored
This is to provide a workaround for specific low memory devices to disable mipmap generation which should reduce memory usage. Bug: 1138979 Change-Id: I214a01fd57be202cc5c21f850f7de3176871110b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485520Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819511}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/718e25c7f990..87996d2e7b98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com,sebsg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1104817,chromium:1124873 Tbr: tluk@google.com,sebsg@google.com Change-Id: I3e117cc986547e2506fbc088972284fbe04da51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489926Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819510}
-
Brian Malcolm authored
The managing entity in the management warning disclosure can now either be a domain (foo.com - for Dasher domains) or the email address of the administrator (admin@foo.com - for FlexOrgs). BUG=chromium:1081272 Change-Id: I23819a68f581d0fc59d301a5846628cf97b01e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486785 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819509}
-
Sorin Jianu authored
If an active version of the updater is detected, and it is greater or equal than the version of the updater running `--install` then the setup execution path is skipped, and the code proceeds with installing the app, if needed. Otherwise, the code sets up the updater, as before. Bug: 1141037 Change-Id: I95e78c150acba7a5fadca2140cad4a9c22def5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490543 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#819508}
-
Fredrik Söderqvist authored
Rather than passing a pile of floats, pass FloatRect or FloatSize as appropriate. This better matches the values that are actually passed and doesn't require expanding earlier than necessary. Turn the align_ == kSvgPreserveaspectratioUnknown check in SVGPreserveAspectRatio::ComputeTransform(...) into a DCHECK since this is not a value that should ever be set. Change-Id: I84c1fd5dc6509abb60595479dfa5fb2e96175d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490004 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#819507}
-
Daniel Libby authored
There is code in FrameTree that updates AXTreeData on the root RenderFrameHostImpl for the given frame tree. However, this doesn't work for guest WebContents, since the global root BrowserAccessibilityManager is the object that determines which AXTree has focus, which influences which events are fired, etc. Instead, move a helper from cross_process_frame_connector.cc to retrieve the root RenderFrameHostImpl in the outermost WebContents to update AXTreeData. RenderFrameHostImpl::GetFocusedAXTreeID knows how do drill down into inner WebContents to get the correct AXTreeId. Bug: 1130710 Change-Id: I8c4cfdb559189bd02b174edbcd5f536c0cd2a2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470334 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819506}
-
Charlene Yan authored
This was previously broken since TabStrip::AddToGroup is used for both adding a tab from a group, and removing tabs from a group by setting |group| to base::nullopt (which is called when closing a tab). Add a check to exit tab closing mode only when we are adding a tab to a group. Bug: 1133485 Change-Id: I27d270e2093d37049fe1a9800412fc3176bc1fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472902Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819505}
-
Elly Fong-Jones authored
This test relies on getting the system to do a certain minimum number of idle wakeups, which depends on a) The frequency with which the system decides to schedule our worker, and b) The frequency with which the system decides to idle to begin with Neither of which can be relied on on the Mac bots. Bug: 1128471 Change-Id: I5128ce89702b99227200140653ae3716030525ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490781Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819504}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f736cabba58b..b3a1dbae309e 2020-10-21 ddoman@chromium.org [resultdb] move the cipd pin of infra/tools/rdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137506 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie9c4f90cac27a374640b2f2ec8ecf7eda510acef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490481Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/07829f27ec5f..e267464b897d 2020-10-21 michaelludwig@google.com Make small epsilons more rigorous for gpu gaussian blurs 2020-10-21 johnstiles@google.com Revert "Create a basic IRNode pooling system." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I9725ecace14bc8a430c778e23a6d2ca6e19bb495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489759Reviewed-by:
-
Rahul Arakeri authored
This CL builds the Bezier Curve for overscroll dynamically based on the fling velocity. When the user flings, the velocity of the scroller (when scroll bound is reached) is used to calculate one of the control points. This makes the "rubberbanding" feel more natural. Bug: 1058071 Change-Id: I250ed02374769c73097e4c4ad2babcc8b52204c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483766Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819501}
-
Tibor Goldschwendt authored
This CL makes the third-party theme box appear above the Chrome colors instead of beside them. Bug: 1140128 Change-Id: Ie8f0e03230f23ef49bc71e7c60866160bdc1ebed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488392 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819500}
-
Jeroen Dhollander authored
This CL introduces a new |BloomResponse| struct, which contains the response from the Bloom server. This is very similar to the JSON that the Bloom server returns, but it is a lot easier to use and it will isolate our code from minor changes in the Bloom server response. Bug: b/165356952 Test: chromeos_components_unittests --gtest_filter="Bloom*.*" Change-Id: Id2a7cd5ec69115c4350aef3c8a7aef71088495ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398910Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#819499}
-
Matt Mueller authored
Bug: b/170619368 Change-Id: I6681f36c4cdf78d8afcd4f43d9dcbebf0866e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488715 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819498}
-
Maggie Chen authored
Pass the foreground and backdrop filters flat_map<RenderPassId, cc::FilterOperations*> to Process() function and use it directly. No need to build the filter operation map again. Bug: 1064390 Change-Id: I1e688324aed0d7f75b27ad361f40c7fbdfb2ce49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489480 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#819497}
-
Brian Cui authored
This CL updates the Console counter tests to accommodate new strings that were added as part of changes to how the counters are displayed [1] The tests are now re-enabled and passing. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2480042 Bug: 1133060 Change-Id: I7c9ec2796e8f1c24ef0b22a9b0fdc2a7da681b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488880Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819496}
-
Anthony Cui authored
Bug: 1139799 Change-Id: I23a4c92316b47b1d95240702a758e799a00d05a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488368 Commit-Queue: Anthony Cui <cuianthony@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#819495}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d139f2661939..9606cffa66d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I615264b5c09e8eb2657943252d87fb68d8f58931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490540Reviewed-by:
-
Omer Katz authored
Weak containers are marked by the MarkingVisitor when reached through regular tracing. However, weak containers might not be traced (e.g. in case of a weak-to-weak HashMap). Ephemerons are traced, but only values belonging to live keys are marked. At the end of marking, all unmarked buckets in the container are removed. If the container is reachable from stack (e.g. via an iterator), all buckets become reachable, meaning all buckets should be marked as live. However, conservative GC does not re-trace a previously marked/traced container, resulting in dangling references (to deleted buckets) and invalid iterators. This CL marks all marked weak containers so that conservative GC knows to retrace them if they are found again through stack scanning. Bug: 1108676 Change-Id: I8790c4af2dcd70513b77c4a5fced4ce85852a9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489905 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819493}
-
Daniel Cheng authored
mojo::Remote already handles cancellation, so it's not necessary to have a redundant layer of cancellation with WeakPtr. Change-Id: Icda83b38d04eb5ba4a914c21933524a669b617ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490441Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819492}
-
Lijin Shen authored
Chrome side coordinator of message container can properly position the messages by aligning the message with the bottom line of url bar. Bug: 1123947 Change-Id: I3be7e9c15f8893b3889a889673a1e4b28c1082cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461570Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#819491}
-
chrome://usb-internalsdpapad authored
This is done so that the UI can be programmatically instantiated from within a test, with document.createElement('usb-internals-app'); in preparation of migrating to JS modules, where during tests, test_loader.html is loaded instead of the original landing HTML page. Bug: 1139849 Change-Id: I919179150385e906665746afbfc6ce0aa2480498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486963 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#819490}
-
Andrew Grieve authored
Bug: 1120190 Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#819489}
-
Nina Satragno authored
Add support for storing and retrieving large blobs through the WebAuthn DevTools Domain. This will in turn be used by WebDriver to implement the webauthn:extension:largeBlob capability [1]. This patch also wires up the CTAP version through devtools. This is a soft requirement for large blobs, and will also be used to move credProps tests to WPTs [2]. [1] https://w3c.github.io/webauthn/#sctn-authenticator-extension-capabilities [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/credentialmanager/credentialscontainer-create-with-resident-keys.html Bug: 1114875 Change-Id: Ia9a5353285bd9aec540d5e92ec737919c7790b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486254 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819488}
-
Manuel Rego Casasnovas authored
This is a revert of the change we did in r607786, on that patch we applied the optimization if the text doesn't wrap. However that was causing some weird issues related to overflow not being repainted as expected in some situations. Preventing people to use this optimization for real. This patch reverts that change, so the optimization will now be used in less cases, but won't cause issues. This only affects legacy layout. BUG=985723 TEST=fast/css/containment/change-text-node-data-nowrap.html Change-Id: Ibbfde6b570ea760025f371448774988b9f7694f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489503Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#819487}
-
