- 14 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db3e43bd9c5d..1680e702bb3f Created with: gclient setdep -r src-internal@1680e702bb3f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic9b3206c365407f978d0306b19a51c022207168c Reviewed-on: https://chromium-review.googlesource.com/c/1335773Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607982}
-
Antonio Gomes authored
BUG=904407 Change-Id: Ibfc219bb273a7ff8ee1d8693ca2f25994a038f5b Reviewed-on: https://chromium-review.googlesource.com/c/1335907Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#607981}
-
Ken Rockot authored
Fixes mojom JS lite serialization in cases where fields are intentionally packed out of order. This actually simplifies the serialization and deserialization logic significantly by leveraging precomputed byte/bit offset values from the bindings generator and preallocating the entire message buffer prior to serialization. It also is now correct instead of incorrect, which is nice. Bug: 904861 Change-Id: If08c301303004d164f4a0afcc3085dac86ca3089 Reviewed-on: https://chromium-review.googlesource.com/c/1335269Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#607980}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: Ib1c39da9570be4bdebccc23e896663f0eeb3ddd5 Reviewed-on: https://chromium-review.googlesource.com/c/1329628 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#607979}
-
Boris Sazonov authored
This CL checks that Intent received by SigninFragmentBase.onActivityResult isn't null before trying to get account name from it. The Intent can be null on older Android versions, leading to a crash. Also, after this CL AccountPickerDialogFragment won't be dismissed if onActivityResult can't get the account name from the Intent, letting the user to select the account manually. Bug: None Change-Id: I4740410da75023ee73fb90b6f7f9659982b96190 Reviewed-on: https://chromium-review.googlesource.com/c/1335577Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#607978}
-
Marc Treib authored
instead of syncer::FakeSyncService. TestSyncService already supports a good portion of the setters that are needed here, so this allows us to remove a bunch of boilerplate. Bug: 859874 Change-Id: I2520cfb526c81de566630dd7f956ddc45eabcee3 Reviewed-on: https://chromium-review.googlesource.com/c/1335593Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607977}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e7da3e75..388a62c2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I456267006d8b70fe61c2d95ff3d3ab9d4c1d6333 Reviewed-on: https://chromium-review.googlesource.com/c/1335828Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607976}
-
Alexandr Ilin authored
This CL allows to avoid the cost of calling GetCategoryGroupEnabled() in TRACE_EVENT macros for popular categories, in a way that doesn't require more macros, nor changing all the call sites. The idea is to put all popular categories into a static global array so an address of a category state may be determined at compile-time through a call to a constexpr function. This CL makes it impossible to use non constant expressions as a category name in the tracing macros. All the call sites that don't satisfy this requirement have to be converted. Hopefully, there aren't a lot of such callers. This change reduces the code size generated from each trace macro by ~16 bytes, check the full report here: https://docs.google.com/document/d/1piIq_yi2fsqOEKObx0tFHeunMyX7hp2ZdAGKK6t0k80/edit?usp=sharing. The total Android apk size savings are ~60 KiB. Bug: 702718, 708990 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9f7b48fd4ee614996feaabda3e5495fd9b786c3a Reviewed-on: https://chromium-review.googlesource.com/c/1251361 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#607975}
-
gogerald authored
Bug: 806868 Change-Id: I4848426960e868b600e238b0cbc0edd8aa1f443b Reviewed-on: https://chromium-review.googlesource.com/c/1331873Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#607974}
-
Jan Lamecki authored
It had race condition on unsynchronized access to static field. Fixed it by using clinit (static initializer). Other typical pattern for singletons would be "enum MyType {INSTANCE;}". Bug: None. Change-Id: I421e0b9f56ef1184194be2a4e083da7e06ab114c Reviewed-on: https://chromium-review.googlesource.com/c/1333470Reviewed-by:Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Jan Lamecki <jachor@google.com> Cr-Commit-Position: refs/heads/master@{#607973}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a69b0e63ca9f..db3e43bd9c5d Created with: gclient setdep -r src-internal@db3e43bd9c5d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1815728c8dcb62b5ec572f123e67d0fad29c094c Reviewed-on: https://chromium-review.googlesource.com/c/1335769Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607972}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6dbf0e43a5ff..c58c8a54224d git log 6dbf0e43a5ff..c58c8a54224d --date=short --no-merges --format='%ad %ae %s' 2018-11-14 mbonadei@webrtc.org Adding mbonadei@ to build_overrides/OWNERS. 2018-11-13 Peter) Slatala Add visibility to ana config proto Created with: gclient setdep -r src/third_party/webrtc@c58c8a54224d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd852cb7a7de44ac0fe95d98f797ba76192d67c2 Reviewed-on: https://chromium-review.googlesource.com/c/1335768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607971}
-
Yutaka Hirano authored
ThreadableLoaderClient has not been GarbageCollected mainly for WorkerThreadableLoader. Now WorkerThreadableLoader is gone, so we can make it an on-heap class. Doing so brings several benefits: - This is a blocker of removing ThreadableLoader after OOR-CORS is enabled, as ResourceClient is a GarbageCollectedMixin. - As ThreadableLoader holds a reference to its client as a raw pointer, each user needs to guarantee to cancel the loader properly before the client gets invalid. As most of clietns are already on-heap, this requires pre-finalizer for each client. Also, failing to keep the contract leads to crashes which are very hard to investigate. Bug: 900506 Change-Id: I67b3e3dab7e0600f06da5222d458ff2d81c36c7b Reviewed-on: https://chromium-review.googlesource.com/c/1335056Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#607970}
-
Colin Blundell authored
We'll see where things go long-term, but for now, these seem more intuitively like shared code than internal code. Bug: 901859 Change-Id: Ie3caff7ab36afa2453baa80199fd612e4ab9dfbb Reviewed-on: https://chromium-review.googlesource.com/c/1331472Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#607969}
-
Yutaka Hirano authored
Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EEo3kba4h2g Bug: 348985 Change-Id: Ia35a1075aca6a2a82de22bda737cb92885453d11 Reviewed-on: https://chromium-review.googlesource.com/c/1334987 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#607968}
-
Gauthier Ambard authored
This CL fixes few issues with Dynamic Type in the toolbar: - The steady view label is cut and wrongly positionned in fullscreen. - The location bar isn't pill shaped. - The incognito ntp's top icon can be cut out by the toolbar. Bug: 892145 Change-Id: Ic9c35f593bf776cc506661da35a786ed584ae6fb Reviewed-on: https://chromium-review.googlesource.com/c/1333392 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607967}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/666bded3..e7da3e75 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0c51fd1e5592a80e13fb15496c673ee1064b92d4 Reviewed-on: https://chromium-review.googlesource.com/c/1335283Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607966}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b58568c5cfc..4cda101d36dd git log 8b58568c5cfc..4cda101d36dd --date=short --no-merges --format='%ad %ae %s' 2018-11-14 lalitm@google.com Merge "traced_probes: capture stderr from atrace" Created with: gclient setdep -r src/third_party/perfetto@4cda101d36dd The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I976eeac69003378a80c5f375777d0348052cfac5 Reviewed-on: https://chromium-review.googlesource.com/c/1335767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607965}
-
Findit authored
This reverts commit e393ff47. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607924 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZTM5M2ZmNDc1M2JmZTk3ZjkwZTk2MTRmZWRhMTBhMGNhMWQ3M2YwOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4885 Sample Failed Step: browser_tests on Ubuntu-16.04 Sample Flaky Test: ExtensionsActivityLogTest.TestActivityLogVisible Original change's description: > [Extensions] Add recent extension activities to the activity log page > > Show recent extension activities by making a call to > chrome.activityLogPrivate.getExtensionActivities whenever the user > navigates to the activity log page. Currently, the activity type, > api call, event count and page url (if there is one) are shown > in descending order of event count. > > Note: the activity log database can sometimes store more than one entry > that has the same api call/event type. This CL currently does not > group any duplicate activity entries. > > Bug: 832354 > Change-Id: I0191d77cd7961bdc5d95ec8daea98d39b1a7c638 > Reviewed-on: https://chromium-review.googlesource.com/c/1321166 > Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607924} Change-Id: I0074574f067f532e3398b48254a52bb9f7a7af0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832354, 905278 Reviewed-on: https://chromium-review.googlesource.com/c/1335827 Cr-Commit-Position: refs/heads/master@{#607964}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbbca2b41db2..a69b0e63ca9f Created with: gclient setdep -r src-internal@a69b0e63ca9f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic7de6c48d9f809d0278b78d9e6934c13f606a004 Reviewed-on: https://chromium-review.googlesource.com/c/1335102Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607963}
-
Yutaka Hirano authored
It's marked as Skip but we cannot investigate the failure without running it. Bug: 870173 Change-Id: I110fdf24cbe625974f9596deaedcee88a92e384e Reviewed-on: https://chromium-review.googlesource.com/c/1334990Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#607962}
-
Rayan Kanso authored
The JobDetails were being deleted before the OIC could query for the updated visuals. The breaking change was not merged into M71. Change-Id: I8dcbaa5916001198006a3550c3bfc337436d62cf Reviewed-on: https://chromium-review.googlesource.com/c/1333807Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#607961}
-
David Roger authored
Change-Id: I4355145d640484cf056bb3fabb038fc99d682b71 Reviewed-on: https://chromium-review.googlesource.com/c/1335568Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#607960}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 678fc40f. With Chromium commits locally applied on WPT: 39c398ad "Worklet: Modernize service worker interception tests for worklets using async/await" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I9443f8ef437516c1faee136eefdca0e921dd8228 Reviewed-on: https://chromium-review.googlesource.com/c/1335284 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607959}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/96026fbcbeee..8b58568c5cfc git log 96026fbcbeee..8b58568c5cfc --date=short --no-merges --format='%ad %ae %s' 2018-11-14 hjd@google.com Merge "perfetto-ui: Bump omnibar placeholder size and darkness" Created with: gclient setdep -r src/third_party/perfetto@8b58568c5cfc The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4b63b411d616e3d828c914858ce40d7224a8651d Reviewed-on: https://chromium-review.googlesource.com/c/1335101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607958}
-
Eric Seckler authored
Adds a simple preferences menu under the developer options menu with a button to start recording a trace. The recording is controlled via a notification. For now, the recorded trace cannot be configured or shared, we will add these features in follow up patches. See bug for design doc. Bug: 898512 Change-Id: I3a6b4dd24359f8098234ed5fbf5b6db07071a608 Binary-Size: feature implementation, strings won't be translated. Reviewed-on: https://chromium-review.googlesource.com/c/1327208 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#607957}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: Iecbdac6cee1180b1cf1fdd08fb03e47813b0140f Reviewed-on: https://chromium-review.googlesource.com/c/1329927 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#607956}
-
Elly Fong-Jones authored
This change: 1) Adds c/b/flag-metadata.json, to store metadata about flags that is needed for other tooling but not for the browser; 2) Adds a disabled unit test AboutFlagsTest.EveryFlagHasMetadata, which asserts that every flag has an entry in this file. 3) Adds a unit test AboutFlagsTest.OnlyAllowedFlagsNeverExpire, which asserts that only a specified set of flags have no expiry milestone. Next steps are to make AboutFlagsTest.EveryFlagHasMetadata pass by adding entries for all current flags, then enable the test. Bug: 897809 Change-Id: Icbf0055cb88106e7212bd6a1f90fcf9350fc7bf4 Reviewed-on: https://chromium-review.googlesource.com/c/1309106 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#607955}
-
Clemens Arbesser authored
Use-case: This would allow a server to serve locale-specific content to users. For example, the server can decide to send a locale-filtered set of scripts (currently, all scripts are returned). The locale can also explicitly be set in the script parameters (new parameter `LOCALE', see http://critique.corp.google.com/220786955). The country code is currently retrieved from the SIM network provider, which only works for devices with active SIM cards. This is good enough for now, but will need to be extended in the future. A more general approach will likely involve the android LocationManager and Geocoder, as well as some application logic on our side. Bug: 806868 Change-Id: Ibacffe940117926157c35247e4e061d3d98a27d1 Reviewed-on: https://chromium-review.googlesource.com/c/1329145 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607954}
-
David Jean authored
Bug: 845472 Change-Id: Icb239377ea417d68c46d4a8bf4bc38ddf11b1b42 Reviewed-on: https://chromium-review.googlesource.com/c/1333810 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#607953}
-
jdoerrie authored
As discussed in https://crbug.com/899948#c2 we would like to keep the PasswordManager.BlacklistedSites.* histograms for another couple of milestones. This change accomplishes this by incrementing the expiration date to M75. Bug: 899948 Change-Id: I90a38d06cb36d6db3a06a0a4975d403182640d06 Reviewed-on: https://chromium-review.googlesource.com/c/1333308 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607952}
-
Shu Chen authored
Bug: 859432 Change-Id: I320f388acd90ed40d7343d9954ab067cadde15b6 Reviewed-on: https://chromium-review.googlesource.com/c/1335051Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607951}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I57c17eaa6add94d6defe8fea4e24c70bcb20af0b Reviewed-on: https://chromium-review.googlesource.com/c/1329165 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#607950}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87927acfcf75..cbbca2b41db2 Created with: gclient setdep -r src-internal@cbbca2b41db2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia95c5529310d51beffe037e8fce42f118947f9f8 Reviewed-on: https://chromium-review.googlesource.com/c/1335100Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607949}
-
Arthur Sonzogni authored
Disabled tests: NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler TBR=shimazu@chromium.org Bug: 889855 Change-Id: Ibbeb9faaf6d5d1657d893bf4d4c825045b1f0cbf Reviewed-on: https://chromium-review.googlesource.com/c/1335587Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607948}
-
Rune Lillesveen authored
Better overflow handling for CSSPrimitiveValue::Create. Bug: 904872 Change-Id: Ieafc28406497b4a676994efdc6515959549a7ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1335527Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#607947}
-
Clemens Arbesser authored
[Autofill Assistant] Changed autofill assistant payment request section order to: contact details -> shipping -> payment. Also removed the first section separator according to our mocks. The chrome feature WEB_PAYMENTS_METHOD_SECTION_ORDER_V2 is now disabled for autofill assistant payment PR. Bug: 806868 Change-Id: I52ed027192b145e50fb22c65fd50cfb5272d0fd2 Reviewed-on: https://chromium-review.googlesource.com/c/1333776 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607946}
-
Clemens Arbesser authored
before: https://screenshot.googleplex.com/je17gMxXPRX.png after: https://screenshot.googleplex.com/AQnyPSA2bs1.png Bug: 806868 Change-Id: Ia8b79c667d6b50a9f689d68831c1e6e29b3324c6 Reviewed-on: https://chromium-review.googlesource.com/c/1333777 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607945}
-
Matthew Cary authored
Obsolete and flaky tests for the disabled classical prerender are removed. This test also adds an ignored ExpectedContents to prevent a race condition in the test when a PrerenderContents final status may be checked before or after the test tears itself down. Bug: 903695 Change-Id: Ia77b3beb79bf579ca1904c54e469f0de4b648f94 Reviewed-on: https://chromium-review.googlesource.com/c/1333779 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607944}
-
Heng-Ruey Hsu authored
SetUpStreamsAndBuffers may be called twice when enabling blob stream. For the second call, kPreview stream already exists. Also reset repeating_request_settings_ in StopPreview. BUG=chromium:900900 TEST=./capture_unittest --gtest_filter="*VideoCaptureDeviceTests/*" Pass TakePhoto cases with DCHECK enabled. Change-Id: Iac89964b95e7d14f592c779f11a92ef46dba930e Reviewed-on: https://chromium-review.googlesource.com/c/1332974Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607943}
-