- 04 Dec, 2019 32 commits
-
-
Brandon Jones authored
Updated an error message string to more accurately describe the WebXR state needed to satisfy it, removed a couple of WebGL helper methods that were only being called by WebVR previously, and removed a Gamepad enum from the IDL that was WebVR-specific. Bug: 1030470 Change-Id: I6a4a53240f761eed94100dd374c4504f28a99b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949298Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#721274}
-
James Vecore authored
Looks like there was a copy paste error with IDS_ONC_TETHER_SIGNAL_STRENGTH_OKAY having the string "Weak" which was incorrect Change-Id: Ic0dbadc4fb34074a3fc633c2103e54bc7441abd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939686 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#721273}
-
chrome-search://ntpiconEsmael El-Moslimany authored
Bug: 1029175 Change-Id: I99956e145775cc5cc4a9b6f8f6a64a97c783442a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938033 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#721272}
-
Lei Zhang authored
Search and replace to spell "supported" correctly. Also fix lint errors in modified files. Change-Id: I4411bc2737f7ceb1b9cfa9c3316864d038a3afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949022Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721271}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84e94841f5ea..56f46565e9ed Created with: gclient setdep -r src-internal@56f46565e9ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I52703474b13478b05e9b5b2d00611a7ab4801da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948949Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721270}
-
Charlene Yan authored
Bug: 1021689 Change-Id: Ida4f922471b9e53684acfc683623150b82e2a7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906873 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#721269}
-
Hirokazu Honda authored
VA-API is a linux-specific API. This CL adds the assertion that lets gn fail if media/gpu/vaapi is built for neither Linux nor ChromeOS platform. Bug: 1000575 Test: compile chrome Change-Id: I71836047fe69bff28640297e58415983a97d6760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847591Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721268}
-
Ilya Sherman authored
We have a new component, Internals>Metrics>Tricium, just for Tricium bugs. R=bpastene@chromium.org Bug: 1030037 Change-Id: I093f2a684d2523c99bf1493084a9f85c24bf2507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949302Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721267}
-
Etienne Bergeron authored
This CL is fixing the owners for subfirectories. Since we remove alexei as owner for this folder, we rely on a ui/owners to stamp fonts/render-text related code. Change-Id: I514ae10e54fe9f75229d25c428ac5e3b67534372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947552Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721266}
-
Kasjan Siwek authored
Enterprise customers want to prevent websites from querying payment methods. This change adds an enterprise policy for that. Bug: 963906 Change-Id: I1253dcd0a3db3774d1cd74a0ca366f8f4fe3bf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940709 Commit-Queue: Kasjan Siwek <kasiwek@microsoft.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721265}
-
Wei Li authored
Use 'use_color_pipeline' build flag to gate the build and run of color_unittests. Since the flag is false by default, remove the unittest from buildbots for now. BUG=1003612 Change-Id: Idff6eefb720269e15c60ca69335a5eb0533bd592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947225Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#721264}
-
Kevin McNee authored
This test class was only used by a BrowserPlugin specific test which was removed. Bug: 533069 Change-Id: I614699cdf1acbd774eac1487511f41bc64593037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944628Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721263}
-
Kevin McNee authored
TestChildOrGuestAutoresize has a parameter to determine whether to use a BrowserPlugin code path. Since BrowserPlugin is being removed, we remove this parameter and the supporting test code. Bug: 533069 Change-Id: I5c7cde29b612eba62b14c2bafe9063a874fb15b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944608Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721262}
-
Clark DuVall authored
This is similar logic to what AwContents.java uses when creating a popup. Bug: 1030186 Change-Id: I0f207dae5ec53c0df68adb504544ec769534ce01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947639Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#721261}
-
Nate Chapin authored
This replaces a special case in Document. Bug: 1029822 Change-Id: I73a281ffaf29ae5ff9acf4b20c9fb87fd6e2e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949066 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721260}
-
Nate Chapin authored
These callbacks are going away. Bug: 1029822 Change-Id: I6871110447bfd6e7e90a059108dc8ef52b10d2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948493 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721259}
-
Nicolás Peña Moreno authored
This CL brings the longtasks API up to date with the recent changes on https://github.com/w3c/longtasks/pull/78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#721258}
-
Sorin Jianu authored
This CL refactors the implementation of the recovery component action handler for Windows so that most of the code can be reused in the future for macOS recovery component. It also adds a unit test. This is trying to reland https://chromium-review.googlesource.com/c/chromium/src/+/1946020 which failed on Linux with: recovery_improved_component_installer.cc:94:11: error: no member named 'start_hidden' in 'base::LaunchOptions' options.start_hidden = true; ~~~~~~~ ^ Bug: 1029953 Change-Id: I685963ed8b281d5709867c55b73617a121e7b78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949224Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721257}
-
Changwan Ryu authored
Showing file name and line in the output can be useful in searching the file name directly from your IDE. Bug: 1015236 Change-Id: If6f3ad0d4e84af9942e0e7d3b3fdb53925a391a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949106Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721256}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/240afdb1c43a..981da03f24d0 git log 240afdb1c43a..981da03f24d0 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 vadimsh@chromium.org [lucicfg] Update from v1.11.6 to v1.11.12. 2019-12-03 ehmaldonado@google.com gclient: Remove annotated_gclient. Created with: gclient setdep -r src/third_party/depot_tools@981da03f24d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030067 Tbr: agable@chromium.org Change-Id: I491ffcdd0df43a0cf595602909d7263ff47b8d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949430Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721255}
-
Lily Chen authored
This implements behind a default disabled base::Feature a mechanism by which cookies that were accessed recently enough (as specified by a FeatureParam value) from an eligible context are granted legacy cookie access semantics. A previous cookie access is considered eligible if it allowed HttpOnly cookies, and was same-site (strictly for get, laxly for set). Bug: 1029099 Change-Id: Id7bea1ca37e2d1d97a4c8c836f07758c8e647e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948233Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#721254}
-
Derek Schuff authored
Fixes: 1025869 Fixes: 1025806 Fixes: 1025810 Fixes: 1025815 Fixes: 1025816 Fixes: 1025817 Fixes: 1025822 Fixes: 1025826 Fixes: 1025828 Fixes: 1025830 Fixes: 1025832 Fixes: 1025838 Fixes: 1025848 Fixes: 1025852 Fixes: 1025864 Fixes: 1025868 Fixes: 1025869 Change-Id: Iff42f97056e8a78eb28784229b35a290436c82d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949182Reviewed-by:
Anthony LaForge <laforge@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721253}
-
Frank Liberato authored
This reverts commit c812ddcd. Reason for revert: underlying bug was fixed. Original change's description: > Add debugging for virtual MakeCurrent with no decoder. > > Dump without crashing on Android if this happens. > > Bug: 892490 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I824a4f4b9f09d3267113d6384370acae059e1690 > Reviewed-on: https://chromium-review.googlesource.com/c/1266335 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597385} TBR=kbr@chromium.org,khushalsagar@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892490 Change-Id: I9e1abd626d85a794d37f1e38fa59cb6ee827e446 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929646Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721252}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: I39333abd5ef6c5650c2bc7b333e08eb36c31ad8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946424 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#721251}
-
Thanh Nguyen authored
This CL adds a class to collect data for Smart Charging. The implementation of the class is not completed yet and will be changed in future CLs. Here is the design doc: go/cros-smart-charging-logging Bug: 1028853 Change-Id: I4a2b491be0d6929859a2fce1cb9a9d6bf6db0ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940315 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#721250}
-
James Hollyer authored
There is an android bug where Bluetooth low energy scans do not return results unless the app has fine location permission. Coarse location permission should be sufficient to that is what we requested previously. This is transparent to the user therefore it seems appropriate to simply request fine permission every time. Bug: 1025420 Change-Id: I0cec63857aa2c553f3ccf59c2f62db67fd07a93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941200 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#721249}
-
Mitsuru Oshima authored
Bug: None Change-Id: I8c19dce72cc631336002c5c979748ed78772046e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948512Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#721248}
-
Chris Harrelson authored
Other scroll types will still directly enqueue a scroll event. Forced layouts may cause scroll offset changes that are undone by later updates. There is no spec that requires the current behavior as far as I can tell. The CSSOM spec calls out that it should fire "when the viewport or element is scrolled" [1] [1] https://drafts.csswg.org/cssom-view/#eventdef-document-scroll Bug: 988991 Change-Id: I4e4ebcf2c5bcba8111d73ebd0b2b8a037034caaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928243Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721247}
-
Mehran Mahmoudi authored
This implements the player UI using a hierarchy of Views. This enables displaying the main the entire hierarchy of sub-frames. It also adds support for scrolling in both directions for each frame. Each Paint Preview frame is represented a PlayerFrame* sub-component (everything in the org.chromium.components.paintpreview.player.frame package). The approach is explained in more details on the design doc linked below. Internal design doc: http://go/fdt-player-2 Bug: 1021202,1020700 Change-Id: I7cc5310016c614f57105105a10d8db7a98e97654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925052Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#721246}
-
Darwin Huang authored
Change-Id: I5a89bd57a941378e355611067f2b978cf43413c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948049 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721245}
-
Garrett Beaty authored
All branch CQ builders have been moved to be low-experimental builders (chromium_presubmit is left as 100% experiment since it has such modest resource requirements). As we get capacity, they can be triggered more often. As the builds get into a good state, they can be made non-experimental. Bug: 1024641, 922150 Change-Id: I97f277a2b6ad54e2fc4408d3c0017e37ed09ca05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949486Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#721244}
-
Kevin McNee authored
The last use of WebInputEvent over legacy IPC is by BrowserPlugin which is being removed. We remove BrowserPluginHostMsg_HandleInputEvent and the legacy serialization of WebInputEvent. Bug: 533069 Change-Id: I9483b7645b7b413399f2ee6ad768fd84257e292d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944046Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721243}
-
- 03 Dec, 2019 8 commits
-
-
Justin Donnelly authored
- Postpone expiration of #omnibox-disable-instant-extended-limit. - Postpone expiration of #omnibox-zero-suggestions-on-ntp and add tommycli to owners. - Fix team email address on a few entries. Change-Id: I989a09a0e74a86a02c58870e423f34ef32ac9ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949447Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#721242}
-
Ken Rockot authored
Mechanical move of the Local Storage metadata proto into the Storage Service. This is in preparation for moving the Local Storage implementation itself into service. Bug: 1000959 Change-Id: I21a0d75556bc96b451ad1e1fb692cca02102c16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944322 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#721241}
-
Takumi Fujimoto authored
Disabled on debug build for flaky crashes. Sample failures: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15573 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15578 TBR=antrim Bug: 997685 Change-Id: I833785d8edf33a99eaafdc9847b990917ec4d9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949290Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721240}
-
Hiroshige Hayashizaki authored
This CL - Defines JSON test object format (see README.md) that describes the configurations and specifiers to be tested, - Implements the WPT test helper for executing the tests based on the JSON test objects (common-test-helper.js), - Converts Jest-based resolution tests into JSONs (with some refinement, and removing test cases depending on interoperability issues of underlying URL parsers), and - Removes imported resolution tests. The dependency to Blink internals remains after this CL. Removing this dependency is planned and discussed at https://github.com/WICG/import-maps/issues/170. Bug: 1026809, https://github.com/WICG/import-maps/issues/170 Change-Id: I993cc9cd7746d7175142f8296ac434571f5d7157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927852 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#721239}
-
Michael Crouse authored
This change updates the store in stages to ensure only one store update in flight at a time. It prioritizes storing the model features first and then stores the prediction models once that update is complete. Bug: 1001194 Change-Id: Ic2d0ccaf64b49ca934590e6b7d0051668e155016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938192Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#721238}
-
Finnur Thorarinsson authored
Adhere better to UX mocks: - Make Zoom button appear on first selection (and stay after that). - Remove selection border on full screen images. Other changes: - Evict full-screen cache on leaving full-screen. The cache takes up quite a bit of space and is not likely to be as useful after leaving full-screen mode. - Disable Zoom button while animations are taking place. Avoids starting animations twice in a row. Bug: 1029056, 656015 Change-Id: Idb58508c4f0ca691e2247ccd024b88f5d16f0eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948894 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721237}
-
Dana Fried authored
It improves but does not completely fix support for height-for-width calculations, allowing views to exceed preferred size in more cases where a custom flex rule or height-for-width relationship is present, especially in places where there is a vertical layout with horizontal stretch alignment. We have also added a specific regression test case for the bug in question, which has example code showing how to make the requested case work with the existing infrastructure. Bug: 1012119 Change-Id: I88380771aacfea29e750dd5033f1fa11e9eb999a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940714Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#721236}
-
Ahmed Fakhry authored
Histogram is added to report the state of the Auto NL notification as a result of the user's interaction with it. BUG=1026871 Change-Id: I52f7da9d7d65dcdd19a08a1e38144242c4c2a6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946856Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721235}
-