- 20 Apr, 2020 40 commits
-
-
Mugdha Lakhani authored
Remove this dependency from PageInfoController so it can be componentized. Bug: 1052375 Change-Id: Ic893b585d74360f1e5e78cbf0c38d905d46281a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153426 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#760431}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 196690 Change-Id: Ie45247ebaddad32e20b7da62a42d36d6841a402b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156326 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760430}
-
Colin Blundell authored
This CL adds the first pieces of infrastructure that will be necessary to integrate //components/translate in WebLayer: - Registration of the relevant prefs - A KeyedServiceFactory for the first of several services that will be needed to glue the component to //weblayer The factory is adapted in a straightforward way from the corresponding one in //chrome. Bug: 1025620 Change-Id: I4832388b45cfcf6b70ea06245a82aee1c4bb3326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152815 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#760429}
-
David Roger authored
Bug: 1061459 Change-Id: I2dc4bddfe27b583453090a1e14597a8599349071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128110Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#760428}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b4af53b2ac23..9d51b7587167 git log b4af53b2ac23..9d51b7587167 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 sigurds@chromium.org [issues] Refactor toolbar creation Created with: gclient setdep -r src/third_party/devtools-frontend/src@9d51b7587167 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1072304 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifb22c1359088da1a6173947fa4401a89c04ee51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156122Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760427}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //device/bluetooth. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=mcchou@chromium.org Bug: 714018 Change-Id: I387d142c672d7a867a13b80123f3443a40b08342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132394Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760426}
-
Ramin Halavati authored
Non-Primary OffTheRecord profiles are not used for incognito browser, so they are made available even if incognito is disabled. Bug: 1033903 Change-Id: I9342c586233db7dd21b1185e9bb8063ece97ec9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152822Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#760425}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //extensions/browser/api. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 714018 Change-Id: I96225d8d76d80f505b6c94a9d99013abccc9b2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132151Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760424}
-
Brian Liu Xu authored
Updates View::Focus() so that |ScrollView| contents do not unexpectedly scroll to the top upon their contents root receiving focus. By default, a |View| scrolls itself to local bounds upon receiving focus, but this does not make sense for the contents root of a |ScrollView|. To avoid this, we modify View::Focus() so that contents roots call their |ScrollView|'s ScrollViewToVisible() instead of their own. Bug: 811277 Change-Id: I845115f721ee2fe8f90c016cfc7669edcf451c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152626Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brian Liu Xu <brx@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760423}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //extensions/browser. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=benwells@chromium.org Bug: 714018 Change-Id: I773d1c4cff8078ba0bf915737cfd674bf27b8ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132190Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760422}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //extensions. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 714018 Change-Id: I5091b018198c9981a4b21c824602007580ea618e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132329Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760421}
-
Mario Sanchez Prada authored
Migrate all these tests out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This is a fairly big CL because it migrates 28 tests at once, but we decided to do that since the changes done for all those tests are pretty much the same, so both the elaboration of this patch and the review might become easier this way, as changes are quite mechanical in general. Bug: 767015, 1063749 Change-Id: Ib19287254bf6aa70553ba805b2844e36884f52e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154945Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#760420}
-
Marc Treib authored
Some functions in password_manager_metrics_util will soon depend on this enum definition, so this avoids a cyclic include between password_manager_util.h and password_manager_metrics_util.h. (password_manager_util.h already includes _metrics_util.h via password_manager_client.h.) The function ComputePasswordAccountStorageUserState() remains in password_manager_util where it fits well. While we're here, let's also clean up some unused includes from password_manager_metrics_util. Bug: 1063852 Change-Id: I0752138d4a6c7725e68b1a982ff22a9004899118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152813 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760419}
-
Koji Ishii authored
This patch creates |NGFragmentItem| without creating intermediate |NGPhysicalTextFragment|. Before this patch: |NGInlineItemResult| -> |NGPhysicalTextFragment| -> |NGFragmentItem| With this patch: |NGInlineItemResult| -> |NGFragmentItem| This patch improves benchmarks: * chapter-reflow by 4% * hindi-line-layout by 12% * line-layout by 4% https://pinpoint-dot-chromeperf.appspot.com/job/1670dc91e20000 Currently, these tests are slower than |NGPaintFragment|. https://pinpoint-dot-chromeperf.appspot.com/job/10ea2589e20000 This patch also improves the currently shipping code path by up to 5.8%. This is an unexpected surprise, probably because the change improves code locality. https://pinpoint-dot-chromeperf.appspot.com/job/14943f93e20000 Bug: 982194 Change-Id: I6ac7e8a9105ea05d3edee3048b3c8715baa07c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152063 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760418}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //content. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=boliu@chromium.org, raymes@chromium.org, tguilbert@chromium.org Bug: 714018 Change-Id: Icff62462cb0aa894ab23cce94862928d429ed572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132410 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#760417}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2657867e1fcb..5d440647d3a2 git log 2657867e1fcb..5d440647d3a2 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d25ce8725224..068611f07d28 (8 commits) 2020-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 41c6b825..290e9f6d (453 commits) Created with: gclient setdep -r src/third_party/skia@5d440647d3a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: Icc35c5e0cdf83b9a1b9fc7847a70f3e7490fd581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760416}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //third_party. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 714018 Change-Id: I2180ad22a06db35d2bc7395b8ab22b19d36939f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132375Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760415}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/media_galleries. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 714018 Change-Id: I3d788cb9612f958da998ac7ad5446d21aa80d433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132408Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760414}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/safe_browsing. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=nparker@chromium.org, proberge@chromium.org Bug: 714018 Change-Id: I230b3f3bd31dff7513d190f2a54f80ace401cf10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132409Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760413}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chromeos. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 714018 Change-Id: Ia70864538aeb8fc2828e8b5a36d91e6858026f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132150 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#760412}
-
Camillo Bruni authored
This adds test for document.write in different situations with modules that were previously not tested or documented to the same extent. This also adds a test for future top-level await implementation. - JavaScript proposal: https://github.com/tc39/proposal-top-level-await - HTML proposal: https://github.com/whatwg/html/pull/4352 Bug: 1022182, v8:9344 Change-Id: I873df1e6aab2aa1ac6f7bf1b842059053f4a7cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134132Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#760411}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //media. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=jcliang@chromium.org Bug: 714018 Change-Id: I51100250f1323f6a5fdc55060fb41d6fcb4dbf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132450 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#760410}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I4699c69b30b9879df0d04e123d247c19231ca31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156325Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#760409}
-
Noel Gordon authored
Remove one level of #ifdef indent to make that part of the code easier to read. Change the accelerated routine name to end in _simd as is our way elsewhere in chromium zlib. Minor: adjust the comments around the performance claims, and move the important comments re CHROMIUM_ZLIB_NO_CASTAGNOLI into that block. Bug: 1032721 Change-Id: Icb4044f3b87277d67f0ff004ac70813af0a91f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148893Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760408}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //ui. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 714018 Change-Id: I741a996064d7932749e6970992b333d0ae94cb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132214Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760407}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/android. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=twellington@chromium.org Bug: 714018 Change-Id: Ib7bc83521f16b2ce741ff1ddc3e8b42aa9d1099f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132149Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760406}
-
Hwanseung Lee authored
Currently payments uses the deprecated org.chromium.url.URI class, so we should replace URL class with GURL class. it chagned to pass GURL instead of string uri as a parameter. and add isURLValid() function in order to check validation of GURL. Bug: 1065577 Change-Id: I25ba336ea740b83e8672723c242c0a580d549a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141472Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#760405}
-
Maggie Cai authored
This CL fixes an error in common apps navigation throttle. After load app icons, we should return true to indicate we need to defer the navigation. Otherwise it will cause DCHECK error when resume navigation. BUG=853604 Change-Id: Ic618686070ab7eb237adf7b194de61cdceafcfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155764Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#760404}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ib92bf1b0c667b07a1c7efe106f1ca36b0569bd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155748 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#760403}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::ApplyPolicyUpdates(). Bug: 1055677 Change-Id: I85329c4651dc53851c77183b889b2abb76d2f9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154638 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760402}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/chromeos/file_system_provider. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=yamaguchi@chromium.org Bug: 714018 Change-Id: Id9aed7e19e1c1511e90ddbb5a53c862d5faaa0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132371Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760401}
-
Luciano Pacheco authored
Bug: 992821,1062902 Change-Id: I93d530b6963a9b1f9f15b8f674869e9321d4c2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155762 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760400}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/chromeos/dbus. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 714018 Change-Id: I322fc624930cfeb5fcebc0f24c243a408cee4af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132328Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760399}
-
Victor Hugo Vianna Silva authored
Instead of retrieving the SignInViewController on the fly, now a getter callback is bound on construction. A corresponding setter method is added that can be used to overwrite the callback in unit tests. Bug: 1070944 Change-Id: I26a7f81a580766c8ddd37281f365d8b876651b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153438Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#760398}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ied3e43e81c38bc6f941e87dc4ca35e7bef1ad1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155745 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#760397}
-
Guido Urdaneta authored
Remove Windows and Mac configs since work on those platforms is finished. Leave Sandbox for Linux as the only feature for experimentation. Bug: 1019245 Change-Id: I36a141ce875af5813dad14a230a1356beb4af059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153052Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#760396}
-
Koji Ishii authored
In the phase 1 of LayoutNG, two different "generated text" were added. This patch: 1. Distinguish them as "StyleGenerated" and "LayoutGenerated". 2. Add |LayoutObject::IsStyleGenerated| 3. Implement |NGFragmentItem::IsGenerated| not to require |NGPhysicalTextFragment|. 4. Change |NGPhysicalTextFragment::IsGenerated| to compute the value, the same way as |NGFragmentItem|. Some perf tests show up to ~3% regressions, but probably a noise because they don't call this function. This is part of preparations to avoid creating intermediate |NGPhysicalTextFragment| when |NGFragmentItem| is enabled. This patch has no behavior changes. Bug: 982194 Change-Id: Iddf4c37071d52bd7abbc98538411aa5fd5ea803e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154633Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760395}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1071928 Change-Id: I369d9bfd4024cea36397c7b9546b72903bf15302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155759Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760394}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c9327e48e9c..2657867e1fcb git log 0c9327e48e9c..2657867e1fcb --date=short --first-parent --format='%ad %ae %s' 2020-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 53f694b34a8d..99655bcf85ca (11 commits) Created with: gclient setdep -r src/third_party/skia@2657867e1fcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: If08c3c9f859b24843f3eb5d838bf311197d3ba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760393}
-
Hirokazu Honda authored
When application requests simulcast, libwebrtc configures temporal layers on each stream. If VaapiVEA and V4L2VEA refuses the temporal layer encoding, then we cannot make use of HW encoders on ChromeOS in simulcast case. Ignoring temporal layers and producing a simple stream causes a little less flexibility on a video call background, but not so critical. So V4L2VEA and VaapiVEA ignores the request as intended. Bug: 1030199, 1071089 Test: webrtc.RTCPeerConnection.* Change-Id: Iff153d76c05a1a994a609b97956dbb1fe041c627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154359 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#760392}
-