- 21 Dec, 2018 24 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82c17e7b8d31..964017de7f68 Created with: gclient setdep -r src-internal@964017de7f68 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibb2e9f59710149e5b560f2ee18d5bd37f671748f Reviewed-on: https://chromium-review.googlesource.com/c/1388144Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618414}
-
vikas soni authored
This reverts commit 8dc8014f. Reason for revert: This is causing crash on android devices causing a DCHECK to fail - '[FATAL:feature_list.cc(305)] Check failed: CheckFeatureIdentity(feature). DefaultEnableOopRasterization' Original change's description: > Vulkan backed skia representation of SharedImageBackingAHB. > > 1. Implemented Vulkan backed skia representation of > SharedImageBackingAHB. > 2. Added synchronisation between gl backed and Vk backed > representations. > > Bug: 891060 > Change-Id: I46ba32dea62569cd67d6f3b24559f4ef28307168 > Reviewed-on: https://chromium-review.googlesource.com/c/1370471 > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618320} TBR=ericrk@chromium.org,vikassoni@chromium.org Change-Id: I559954ae7556f32ddc110a84e8433f24b41e4d88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891060 Reviewed-on: https://chromium-review.googlesource.com/c/1388179Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618413}
-
Zhenyao Mo authored
BUG=913301 TEST=Linux/AMD bot TBR=jdarpinion@chromium.org NOTRY=true Change-Id: I8eab8e0326d4bb01043047ecfe4064453603daae Reviewed-on: https://chromium-review.googlesource.com/c/1387694 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#618412}
-
Matthew Wang authored
Creating histogram for BSS Transition Management status. This is a success metric for 802.11v. Histograms implemented in CL:1033359. Bug: 836381 Change-Id: I8192756bc5b3f122ad2edb2e119d553cabe0dc39 Reviewed-on: https://chromium-review.googlesource.com/c/1033729 Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#618411}
-
Sergey Ulanov authored
Previously the net_unittests was not stopping test server spawner as expected. This change should help debug the linked bug: now if a test server is not stopped by one of the tests it will be reported by the SpawningServer.Stop() in the log. Bug: 913156 Change-Id: If4ad371f4a03b4f44ca4f8cb51b2c8a2a328f647 Reviewed-on: https://chromium-review.googlesource.com/c/1387810Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#618410}
-
Justin DeWitt authored
* Adds chrome://explore-sites-internals to webui urls * Adds a mojom file defining the interface, and the UI and handler classes as required by Mojo webui pages. * Implements the interface on native side. * Adds a placeholder HTML page. This leaves the JS/CSS/HTML work to a future CL. Bug: 900673 Change-Id: Ic3506010828e9db385099d9289f45d69861e05c4 Reviewed-on: https://chromium-review.googlesource.com/c/1383491 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#618409}
-
Jinsuk Kim authored
Removes unnecessary indirection through WebContentsImpl for Activity instance, which may access it after destruction. We already have a null check for safe access to content layer in native ContextMenuHelper (when getting RenderFrameHost in CMH::RetrieveImageInternal) we can rely on, in case the WebContents gets destroyed before the context menu action is performed. Bug: 915953 Change-Id: I508f07f664b3d09bfba35748ba30afae991aae00 Reviewed-on: https://chromium-review.googlesource.com/c/1382712 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#618408}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5e19d3febca6..bdc2ab93563f git log 5e19d3febca6..bdc2ab93563f --date=short --no-merges --format='%ad %ae %s' 2018-12-20 stevenperron@google.com In LICM don't place code between merge instruction and branch. (#2252) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@bdc2ab93563f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I95d8de63019f20b33352b0c67a44ac0e8189e6e6 Reviewed-on: https://chromium-review.googlesource.com/c/1387677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618407}
-
Peng Huang authored
This reverts commit 13676929. Reason for revert: CHECK failure: context_type == context_type_ in feature_info.cc https://bugs.chromium.org/p/chromium/issues/detail?id=917150 Original change's description: > Improve system_healtm.memory_mobile metrics > > Improve memory related metrics by: > * Sharing gles2::FeatureInfo between RasterDecoderContextState > and RasterDecoders. It can avoid unnecessary GL calls for multiple > gles2::FeatureInfo. > * Only initialize (create) ContextState & GLContextVirtual in > RasterDecoderContextState when it will be used or is being used. > > Bug: 913591 > Change-Id: Ia553513ed13b1d2b1ccf53b827757d341d847e06 > Reviewed-on: https://chromium-review.googlesource.com/c/1380943 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618246} TBR=penghuang@chromium.org,backer@chromium.org Change-Id: I831eaf8db1b69cb060779c62f1b3537cdd39173a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913591 Reviewed-on: https://chromium-review.googlesource.com/c/1388175Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#618406}
-
Lukasz Anforowicz authored
In presence of Strict Site Isolation (aka site-per-process) this CL should prevent a compromised renderer from being able to commit an origin incompatible with the process lock. Note that more work is still needed to protect other isolation modes (citadel-style protection is needed to prevent non-locked processes from committing an origin that requires a dedicated process). Change-Id: Ifc39a81d8a1ded184c2ceb64c943f7ed2babb858 Bug: 770239 Reviewed-on: https://chromium-review.googlesource.com/c/1383293 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#618405}
-
Jay Harris authored
The custom tab bar should appear as an extension of the title bar. Before this CL, this was not not the case on Linux or Windows without DWM (disable-dwm-composition), as we draw small borders between the window frame and the toolbar. This CL removes them when displaying the custom tab bar. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=372746&signed_aid=ybrF8gUqHfRhz-mI-R7-SQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=372747&signed_aid=-_9BQ_5YxzT6Gg67Aj49ag==&inline=1 Bug: 853593 Change-Id: Ice90aef02c074d344066f8b5dd8e50fe77310a8e Reviewed-on: https://chromium-review.googlesource.com/c/1385685 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#618404}
-
James Robinson authored
This adds a black-box test of the webrunner's functionality as a runner for http:// URLs in Fuchsia. The test opens up a random port on the device, instantiates web runner via launching a web URL, then verifies that the URL is fetched and parsed. Change-Id: If3084760eb96bdc9c609ab9beef1a3507ee77011 Reviewed-on: https://chromium-review.googlesource.com/c/1387813 Commit-Queue: James Robinson <jamesr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I612a908d462425630e3c14778fde679e6eee4308 Reviewed-on: https://chromium-review.googlesource.com/c/1387675Reviewed-by:
-
Tien Mai authored
TBR=rogerta@chromium.org Bug: 917155 Change-Id: I1ac44cfe4b25264f954b97350c7b0e69ec029aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1388043Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#618401}
-
Lukasz Anforowicz authored
The following tweaks were made: - Use NavigationSimulator where possible (instead of manually calling individual functions of TestRenderFrameHost). - Target the correct RenderFrameHost (which might change during a navigation that requires a process swap). This is achieved by introducing the GetNavigatingRenderFrameHost helper method. - Fix several tests that used a different url 1) when initiating the navigation and 2) when committing the navigation. - Change interstitial tests so that the target page doesn't change while the interstitial is shown. - Make sure that Forward_GeneratesNewPage and Reload_GeneratesNewPage unit tests pass the correct value of |did_create_new_entry| (which is |false| in browser tests / in production). This changes the expectations of Reload_GeneratesNewPage to match the production (reload should replace the history entry, instead of creating a new entry) and Forward_GeneratesNewPage (no pruning needs to take place). This change is supported by introducing a new browser test that replicates the scenario of Reload_GeneratesNewPage. Cleaning up unit test will help proceed with enforcement of CanCommit origin checks (which might have otherwise introduce "renderer kills" during the tests). Bug: 770239, 916783 Change-Id: I0af7e1049376a0d0834d48f4de05fb0fe38d56df Reviewed-on: https://chromium-review.googlesource.com/c/1387196Reviewed-by:
-
Tommy C. Li authored
Updates the bookmark copy to write a hyperlink. The justification to not write a hyperlink no longer applies. It also makes copying bookmarks more congruent with how copying from the Omnibox will work soon. See: https://chromium-review.googlesource.com/c/chromium/src/+/1370909 This CL also simplifies the copy API a bit. Bug: NONE Change-Id: Ibfd097a0ba6675a831fa8746987a15986e2337fa Reviewed-on: https://chromium-review.googlesource.com/c/1387949Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#618399}
-
Dana Fried authored
This fixes a DCHECK caused by a race condition between listeners. It is possible to try to resize a ToolbarActionsBar which has not yet been notified that an action was added; the inconsistency resulted in an immediate layout, which resulted in a DCHECK failure in toolbar_actions_bar.cc:223: DCHECK_EQ(model_->toolbar_items().size(), toolbar_actions_.size()); This bug occurs deterministically when launching the old Cast dialog, which adds its icon to the browser actions container rather than as a first-class toolbar icon as the new Cast dialog does. Now we only lay out the view after all of the callbacks take place, so the containers all have the proper number of things in them. We remove the callback on resize started, since the only time this can affect things is if the actions bar in the toolbar is resizing smaller while the menu is open, which should not happen. We continue to lay out after a drag operation, because we need to immediately resize the view if the number of lines of icons changes. Bug: 916687 Change-Id: Id22c6f1697ace1cddc8813016c02a488fb5134bb Reviewed-on: https://chromium-review.googlesource.com/c/1384929Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#618398}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2b35654dcf74..92b16ea26290 git log 2b35654dcf74..92b16ea26290 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 courtneygo@google.com Re-land: Compress symbols for libraries Created with: gclient setdep -r src/third_party/angle@92b16ea26290 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I4a6c1c9b07eec679b1e24aaae7100c173dca8f80 Reviewed-on: https://chromium-review.googlesource.com/c/1387663Reviewed-by:
-
Fergal Daly authored
Currently there is "setup" which runs before every test and "done" which runs after all tests are finished. This adds "teardown" to run after every test as a inverse of "setup". It seems like many tests thought "done" was already behaving this way. Bug: 914276 Change-Id: I9fdb83c5616d77f187624fea21cd7b07898765ed Reviewed-on: https://chromium-review.googlesource.com/c/1381397Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#618396}
-
Xiaocheng Hu authored
This patch converts the web test with testharness to reduce usage of legacy editing.js. This is also a preparation for implementing bidi caret affinity. Bug: 917165 Change-Id: I84bbcba69f6a9dc768e92081b274146689635e28 Reviewed-on: https://chromium-review.googlesource.com/c/1388026 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618395}
-
Ehsan Karamad authored
This CL introduces a new enumeration metric for feature policies, namely, "PotentialViolation". This new metric tracks potential violations of each feature policy in a document; that is, for feature policy X this metric would emit a potential violation if the conditions to violate feature X are (regardless of the actual feature X being disabled in the document). In other words, the metric tracks the percentage of pages that would have violated the given feature X if it was disabled in all documents. Most current policies are covered by this CL. The few cases where a policy generates its own violation report, or does not support reporting violations yet, will be addressed in future CLs. Bug: 915788 Change-Id: Iccb77ee8f47995a0debe7bb1faafbee3686b2ed6 Reviewed-on: https://chromium-review.googlesource.com/c/1380933 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#618394}
-
Li Lin authored
Send the server side experiment ID for enabling OPEN_APP action in AS if open app is supported in the client. Bug: b:121043828 Change-Id: I4e22800649a30498b61e116e304b123767de0502 Reviewed-on: https://chromium-review.googlesource.com/c/1387161 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#618393}
-
Lei Zhang authored
Messages with placeholders should be written as: <message>Foo <ph>$1</ph></message> and not as: <message>Foo $1</message> Detect this case and print warnings. In unit tests, throw exceptions. Once all GRD files are warning free, follow up and always throw exceptions. BUG=915681 Change-Id: I242b86bc0b8653e654c7a595a61f7668978f9bca Reviewed-on: https://chromium-review.googlesource.com/c/1385456 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#618392}
-
Katie D authored
Also changes 'let' to 'const' per new git cl presubmit error. Bug: 913369 Change-Id: I922ccccb6425a680f6da30200c8f0535fbd2daff Reviewed-on: https://chromium-review.googlesource.com/c/1376094Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#618391}
-
- 20 Dec, 2018 16 commits
-
-
Albert J. Wong authored
This changes the deletion order of RenderView and RenderWidget. From analysis, it seems the two pieces of code should be independent. Bug: 545684 Change-Id: I470c390eb7c3e51a6868fa758f76718c3d1cdcf7 Reviewed-on: https://chromium-review.googlesource.com/c/1387747Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
David Benjamin authored
Noticed this while I was in the area. Bug: none Change-Id: I2e0190ca2966ff6d9ed14daf584b76e82df3ff79 Reviewed-on: https://chromium-review.googlesource.com/c/1387840Reviewed-by:
-
Steven Bennetts authored
Previously the translation code assumed that onc::ipconfig::kIPAddress would never be empty, however that is not enforced in ONC. If the address is empty it should be treated as if it is not present. With this change the code will fall back to a Saved or Static IP Address if the value is missing or if it is empty. If none are available the IP Address will not be set. Bug: 902713 Change-Id: I2f9880966661a85a8aace04e56bdac8516e5b3e4 Reviewed-on: https://chromium-review.googlesource.com/c/1379207 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#618388}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4beab79cd67..578b089986fa git log e4beab79cd67..578b089986fa --date=short --no-merges --format='%ad %ae %s' 2018-12-20 jvanverth@google.com Revert "Tweak Plot size to try to get better perf." 2018-12-20 herb@google.com Convert GrGlyph::PackedID to SkPackedGlyphID 2018-12-20 reed@google.com add gm and fix origin for xform-based blobs 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@578b089986fa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ifd8c78a579a8634b7ce0e327d6a8947f3935557c Reviewed-on: https://chromium-review.googlesource.com/c/1387660Reviewed-by:
-
Nick Harper authored
Removal request received via email and validated via DNS. Change-Id: Iec03253374fc203a7c9785511151771ccc0162d7 Reviewed-on: https://chromium-review.googlesource.com/c/1387605Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#618386}
-
Kristi Park authored
TBR=sdefresne@chromium.org Bug: 893362 Change-Id: I9ad091f564dfc9d0e1772fb34222007e7cc51388 Reviewed-on: https://chromium-review.googlesource.com/c/1387910Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#618385}
-
Sergey Ulanov authored
Previusly when ssh port forwarding command exits with exitcode != 0 the script was trying to format error message with output.returncode, where output is a pipe, i.e. it doesn't have returncode field. Updated the script to use task.returncode instead. Change-Id: I132f7de42344244dfbdf16f4f4a500ac1a48b7df Reviewed-on: https://chromium-review.googlesource.com/c/1387726Reviewed-by:
-
Peter Wen authored
This option no longer exists in Android Studio 3.4+. Bug: 917016 Change-Id: I533d40288faf2693ad32fe9646d48073c30ac7c8 Reviewed-on: https://chromium-review.googlesource.com/c/1387155 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/bbf63435c37a..17da9f8231f7 git log bbf63435c37a..17da9f8231f7 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 cepheus@frii.com Reserve tokens for float controls and no integer wrapping: Created with: gclient setdep -r src/third_party/spirv-headers/src@17da9f8231f7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ied8db2e8b2d87d962c41bc8b0854b04e2bc8c551 Reviewed-on: https://chromium-review.googlesource.com/c/1387673Reviewed-by:
-
Abhishek Bhardwaj authored
This change removes a separate test implementation of wake locks. This results in more production code being unit tested. BUG=chromium:913353 TEST=Run WakeLockTest unit tests. Change-Id: Ie4b3d3384c148c90c6ee937b91710bfe9b87d9c8 Reviewed-on: https://chromium-review.googlesource.com/c/1379704 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#618381}
-
Jay Harris authored
An instance of the badge service can be moved between different browsers so we should find the delegate/hosted_app as needed instead of storing them at instantiation. Bug: 916904 Change-Id: Ia91875f3342be0bb7b2e7dd1807efd2cdd36206c Reviewed-on: https://chromium-review.googlesource.com/c/1385726 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#618380}
-
Dave Tapuska authored
Remove the paused_calls vector on WorkerGlobalScope because all the calls executed occur on pausable task queues after http://crrev.com/1eb2d22. BUG=907125 Change-Id: I42ad827eb1131f643158f9c6e565d69886896ccc Reviewed-on: https://chromium-review.googlesource.com/c/1385015 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618379}
-
Tomasz Wiszkowski authored
Presentation is done by Mediator instead. Bug: 871798 Change-Id: If7fc3d1243990580d3e95c6ce3023fe23f03cd65 Reviewed-on: https://chromium-review.googlesource.com/c/1384632 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
-
James Robinson authored
This function shadowed the 'package_name' local so it always ended up running the most recently installed package instead of the specified package. This works fine for invocations with a single package, or with the target package last, but not for tests with multiple package dependencies. Change-Id: I1fe16ab22bd46970a99043fa42c810c32d323701 Reviewed-on: https://chromium-review.googlesource.com/c/1387905Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Matthew Denton authored
This missing space may have screwed up WHERE statements when creating indexes (or might not have, since I don't see any errors. Adding anyway) R=metzman@chromium.org, pwnall@chromium.org Bug: 909886 Change-Id: Idd322f43a2b715d1d282546df4c504148a5014a4 Reviewed-on: https://chromium-review.googlesource.com/c/1387837 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#618376}
-
Leonard Grey authored
This change: - Mostly implements UX's secondary UI spec - Switches topchrome to use the same colors as incognito, though this may be temporary - Replaces some temp colors Bug: 912375, 850098 Change-Id: I447c3062455330b01c0e7381d3a9eabd2709a970 Reviewed-on: https://chromium-review.googlesource.com/c/1378408 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#618375}
-
