- 12 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/537f11c11412..12cf8695092d 2021-01-12 sigurds@chromium.org Add performance measureMemory in FrameDetailsView If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1139899 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I617484c4568fd4dd8027e578899a757a3fb57848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842454}
-
Stephane Zermatten authored
This change introduces a way for content to set arbitrary bottom sheet offsets while the content is active. The offset set that way stays as long as the sheet doesn't change state or need to be refreshed (onLayoutChange) This change also ignore onContentSizeChanged calls that report no changes, as this would otherwise reset the sheet offset for no reasons. The immediate goal of this change is to allow controlling the height of the Autofill Assistant bottom sheet to have it scroll in sync with the browser. Change-Id: I020f393a580df0e85921ec7dd9388b72944f566d Bug: b/171792266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599863 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#842453}
-
Miriam Polzer authored
During re-enrollment, if install attributes are present, we check that the domain to re-enroll to matches the one in install attributes. Only compare install attributes domain to the login-given domain if it is non-empty, i.e. if a gaia login took place. If no login happened, e.g. during auto re-enrollment, the domain is provided by the server and stored in the enrollment config. Policy validation will fail if the server provided domain is different from the one in install attributes. The check edited in this CL is not necessary in this case. Bug: 1158573 Change-Id: I4c65c5d91f237a24d02edfac6aec6c5f31a6eeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598852Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#842452}
-
Ramin Halavati authored
ProfileAttributesStorage::GetAllProfilesAttributes is updated to exclude Guest profile unless it is explicitly requested by the caller. Bug: 1161494, 1125474 Change-Id: I1f006d6fb8c58bb23099d111d83da0f84c2ec2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621299Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#842451}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/84c7d11419c5..a3806cb35923 2021-01-12 tsepez@chromium.org Avoid inifinite loop in agg_math_stroke.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Id2f046aed5779c8e1923b7eb3bc921d4fa1d7875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623988Reviewed-by:
-
David Roger authored
See go/spaces-strings Main view screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/a064193913da1c2d06ab2a932d094c622e45a837 Menu screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/cce701c74e713ef7261c237cb86d70425f50d285 Remove confirmation screenshots: Actual: https://storage.cloud.google.com/chromium-translation-screenshots/2a3a3c3d5bf360187d890afbfe303e8c733403c5 Mock syncing: https://storage.cloud.google.com/chromium-translation-screenshots/408fca9dc377d9224566b3b54d059f351c2b7673 Mock local: https://storage.cloud.google.com/chromium-translation-screenshots/2bacc5f33ddef4d028243d6e97f85797d5792774 Change-Id: I3ccd4d0bee5e46eb119f101d0042c95d2b531216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622173 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
-
Side Yilmaz authored
This CL updates the functions of DownloadManagerService to support multiple off-the-record profiles by passing OTRProfileID instead of isOffTheRecord boolean. Bug: 1099577, 1060940 Change-Id: I3fb81d8eea3b0c3fc34e6772fb525d6507285566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617794Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842448}
-
Ulan Degenbaev authored
This generalizes the existing handling of FrameNodes using ExecutionContextTokens. Bug: chromium:1085129 Change-Id: I483c0fcfef85e9d82151e09ca3c99ff0a8377081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621634 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#842447}
-
Collin Baker authored
Bug: None Change-Id: I5ace2a9bdcb2333e03d5b1118747f2b41d74d081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618626 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#842446}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4c3f342596793f6be0e49fb1bd5323f2fdad8a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623805Reviewed-by:
-
Irem Uguz authored
Currently, screen-reader reads the field title and the values separately in the dialog page. However,the desired behaviour for screen-reader is to read out all information about a field in one-go for better user experience. This cl improves this behaviour. Bug: 1157398 Change-Id: Icce01a076411c66c8aa667b7642fc48e9bb038b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602293Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Irem Uğuz <iremuguz@google.com> Cr-Commit-Position: refs/heads/master@{#842444}
-
Hirokazu Honda authored
ForceKeyFrame requested after the frames are released specified times and checks if the first bitstream returned by VideoEncodeAccelerator is keyframe after requested. However, releasing frames and producing bitstreams are asynchronous. This check is wrong. This CL corrects the fix by seeing if the keyframe exists in a few produced bitstreams after requested rather than the first bitstream. Bug: b:176252185 Test: video_encode_accelerator_tests on grunt Change-Id: I442635a3c1ffefd4fcade9abdd81e74205e931be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614527Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842443}
-
Victor Vianna authored
The method is unused. Bug: 1156620 Change-Id: Iedccf2b93b2b0c6e9391c243b8312283706ddec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579967Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#842442}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b97affa04ee..13694cecae39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ib6b3661cab426ee9e9c593875678abf0039e36f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623947Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842441}
-
Daniel Hosseinian authored
Meanwhile, consolidate calls to FPDFAvail_IsLinearized() to a private helper. Bug: 93619 Change-Id: I0b1fd52e9067e2c05e66034caf3d3ceb641411de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622515 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842440}
-
Mike Dougherty authored
Bug: 1042335 Change-Id: I5caadeedf9b94344f535c9171c381530820eaf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555580 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#842439}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2c65da28a2ee..bdbcbe94074d 2021-01-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 193bb22c to 734de1a6 (311 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I0f464b6662af8ac1efb1efd482f3b6b1ced7fd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623794Reviewed-by:
-
Alice Wang authored
This CL changes Context to Activity as argument to open Settings on android device. Bug: 1163470 Change-Id: I5ef9b166f0168140510f163eb83a96805bda2898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621633Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842437}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4281a3f2..0e5a5d24 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9fad47cbe78789879ef6c258a77f79b383b4167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623853Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842436}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610408110-5a618b6e0bdb5b4a60796f5aa8c6f6759f78cdd3.profdata to chrome-mac-master-1610431066-5d7d40ce59ba8e505b376b46e02fe57205cb3e46.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6d664ec96b53885b31375fc981a7a6998f200c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623803Reviewed-by:
-
dpapad authored
Bug: None Change-Id: I6df66bd19eab1edff837b340dd63d1ae4040ec61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620467 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#842434}
-
Colin Blundell authored
This CL abstracts RealTimePolicyEngine's dependence on signin and sync for determining whether safe browsing access token fetches are supported, instead having it take in a callback supplied by its client. We place the abstracted functionality in //components/safe_browsing/core/browser/sync along with adjusted versions of its unittests. The purpose of this abstraction is to enable this code to be reused by WebLayer, which does not use signin or sync. This CL binds the callback in RealTimeURLLookupService, but a followup will do the binding in the embedder of the SafeBrowsing component. Bug: 1080748 Change-Id: I7bf0d3d15eae173b107f95cdc1616e08e0f69eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616352Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#842433}
-
Ewann authored
This is a reland of 60e867a2 Original change's description: > [iOS] Updates system colours to use google material colours > > This CL replaces the existing system colours by Google material colours. > > Bug: 1155472 > Change-Id: Ia9c9e8f31d65fe1db70fd29ad94ca370d0aede07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595050 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Javier Flores <javierrobles@chromium.org> > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840999} Bug: 1155472 Change-Id: I4ce77a7ffbe2cb75fe3c3434e54f1ff34fdae7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620804Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#842432}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610408110-1b25c741a858a17df9d643531610232aedd2e5da.profdata to chrome-linux-master-1610431066-b046cf295bac84ed9eefc440cb75a6df945c21fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54747662dcc6290e178ced85691a6bf5188766bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623802Reviewed-by:
-
Matt Falkenhagen authored
This is a reland of f4b58578 The fix is to add an early return of null `handle_` in MaybeCreateSubresourceLoaderParams() which is a weak ptr. The comment for `handle_` explains that for workers it can be destroyed before the interceptor, because {Dedicated,Shared}WorkerHost can be destroyed during loading. Also change WorkerScriptLoader to early return when the host is already destroyed, to avoid unexpected behavior like going to network instead of the service worker when it should. Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (3/3) > > Bug: 1138155 > Change-Id: Iafb12ae9de19e68e637e7fb990bb8439ec4df848 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602307 > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842305} Bug: 1138155 Change-Id: I0b76d1cc9f0365d4bb0f063e1b42e5cb96d6d11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623609Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842430}
-
Colin Blundell authored
This CL incorporates Chrome's adjustment of subresource filter page activation decisions based on content settings within WebLayer. To do so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle directly invoke the logic in question rather than having ChromeSubresourceFilterClient do so. That change necessitates some others, also made in this CL: - WebLayer brings up ProfileInteractionManager. - SubresourceFilterClient provides an accessor for ProfileInteractionManager. - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment logic via a new Delegate interface rather than doing so via SubresourceFilterClient. This interface is implemented by ProfileInteractionManager in production while allowing for porting of tests that provide custom (or nil) stub logic. We also add browsertests of this interaction in //weblayer. Note that this CL does not do any incorporation of the relevant *UI* for content/site settings of ad blocking in WebLayer; that will be followup work. This CL is a reland. The original CL was reverted as the introduced tests were flaky. I have since debugged the source of the flake; the fix is contained in the diff between PS1 and PS2. It turned out to be a pre-existing problem in //weblayer's subresource_filter_browsertest.cc that the new tests simply tickled: I was holding the TestRulesetCreator in a local variable and sending the temporary files that it creates to renderer processes, but it destroys those temporary files when it is destroyed. D'oh! Bug: 1116095 Change-Id: I25f5dca647761f652c9d5a2dfc41db1a4d7712b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622215 Auto-Submit: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#842429}
-
rajendrant authored
This reverts commit 9bdf89ef. Reason for revert: Landing the failing tests separately Original change's description: > Revert "ImageCompression: Disable on logged-in pages" > > This reverts commit d672f7b5. > > Reason for revert: SubresourceRedirectLoginRobotsBrowserTest.TestCancelBeforeImageLoad is flaky. > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/96887 > > Original change's description: > > ImageCompression: Disable on logged-in pages > > > > This CL adds a mojo to disable image compression on likely loggged-in > > pages. > > > > Bug: 1160424 > > Change-Id: I42dda576947aa04e51d3cb3a5fac712945ac9651 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598858 > > Commit-Queue: rajendrant <rajendrant@chromium.org> > > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840523} > > TBR=kinuko@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I150cc38bc4c2fb7113e6bdcb68c9dad0f6a2fffa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1160424 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613025 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840578} TBR=kinuko@chromium.org,rajendrant@chromium.org,mstensho@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Bug: 1160424 Change-Id: Iaf5ff91bad4246c23941b1ae2974d4d4c0d56c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617213Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#842428}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610398040-59038019b78fe7d9277311f636fda97275a69be4.profdata to chrome-win32-master-1610420273-f729673981a14d4f8cc70d6513013e1d16474c41.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic969507c13ac42ab14ff3b122489bdfbc864b88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623796Reviewed-by:
-
Mustafa Emre Acer authored
This CL adds a switch to chrome://flags to turn the omnibox experiment on with 3 and 10 second fallback timeouts. Bug: 1141691 Change-Id: I812e06b29f14829d9cf40ac45e5b82935a0a292d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620462 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#842426}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/ui/: - drag_selector.js - file_manager_dialog_base.js - file_manager_dialog_base_unittest.m.js - files_confirm_dialog.js - files_menu.js - suggest_apps_dialog.js In //ui/file_manager/file_manager/foreground/js: - launch_param.js - providers_model.js - providers_model_unittest.m.js - web_store_utils.js Bug: 1133186 Change-Id: I5bdd717c5643f5a0d0ae8fe3d23ab06623c9b62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620744 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842425}
-
Marc Treib authored
Before this CL, the "field trial name" specified for the "PasswordChangeInSettings" feature was different between about_flags.cc and the corresponding entry in fieldtrial_testing_config.json. This caused a crash if the about:flags entry was enabled in a developer build. This CL changes about_flags.cc to match the fieldtrial testing config. Bug: 1108692 Change-Id: I21112af815aa8e6bca361c1e9cafd17aceeae5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599805 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842424}
-
Wei Lee authored
Since the maximize button under tablet mode does not work. Bug: b/175322338 Test: Manually Change-Id: I9e8f21c81b33d5e964f95e2fc259e88eea8bcdef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622365 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842423}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f7379c80b03..1b97affa04ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yoichio@google.com Change-Id: I8f937d8ea76a0ce1c156a1eb0268ec8823a4f4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623887Reviewed-by:
-
Asami Doi authored
This is a reland of 475e9c81 The original change is reverted due to the difference between the default value of the CheckOfflineCapability feature. In fieldtrial_testing_config.json, the CheckOfflineCapability feature is set to be enabled and its check_mode is "enforce". However, some environment seems to use "warn_only" check_mode. So use parameterized tests for the CheckNotOfflineCapableStartUrl test. Original change's description: > Add installability test for when start_url has no offline response > > The following case should not pass the offline capability check: > - manifest's scope: /banners/ > - manifest's start_url: /banners/manifest_test_page.html?ignore > - service worker's scope: /banners/ > > Bug: 1157242, 965802 > Change-Id: I2832fbc102fd931aecc9d42394f5429e4c66e6aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596902 > Commit-Queue: Asami Doi <asamidoi@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840905} Bug: 1163791, 965802 Change-Id: I5b7fc2697708027db5543f47800dd69fdfa005d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616645 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842421}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2af8b31616a5571473feb5965a933c66790cc44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623797Reviewed-by:
-
Gyuyoung Kim authored
This is a reland of 967a3ef4e72a61dec5f1c7475711f03737f16cf7 Original change's description > This CL fixes the build error caused by exceeding the max token limit > using the function overloading in text_link_colors.h. This CL makes the > file include forward.h files instead of shared.h using below change. > FooColor(ColorScheme color_scheme = ColorScheme::kLight) const; > => > FooColor() const; > FooColor(ColorScheme color_scheme) const; > Original change's description: > > Use blink::mojom::ColorScheme instead of blink::ColorScheme > > > > This CL replaces the existing uses of native ColorScheme > > with ColorScheme Mojo enum type defined in frame_owner_properties.mojom > > in order to remove unnecessary type conversion. > > > > Bug: 919392 > > Change-Id: Iebc2cf4a2094293027a07c643e75e57d75651e91 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473739 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#817773} Bug: 919392, 1162834 Change-Id: I3f506bafe1929fb48b7097f686818bf4793865d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620125Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |FirstLetterTextLayoutObject()| in |FirstLetterPseudoElement| not to find first-letter text out side first- letter parent as follow-up of [1], which makes finding first-letter text outside parent. In below example, before this patch changing "contenteditable" attribute of <div> causing rebuilding layout tree for <p>, then we have unexpected <::first-letter> element for <p> with first-letter text "abc". Then we have invalid layout tree with invalid |NGOffsetMapping| to crash painting selection. <style>p::first-letter { ... }</style> <div contenteditable><p><b></b></p>abc</div> [1] http://crrev.com/c/2560522 [CSS] Skip empty span when finding the first-letter text Bug: 1159762 Change-Id: I41f5d9e75080633f34c68b328945e1c92721e60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622362 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842418}
-
David Black authored
Previously holding space commands were not enabled for recents sections of the Files app. Now, holding space commands are enabled provided that the selection of entries contains entries from supported volumes. Per UX recommendation, entries from unsupported volumes are ignored with respect to command execution. Bug: 1160933 Change-Id: Iaccb0a756c4ec07c301f335fc3f5468f9a6d7a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623175 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Kenichi Ishibashi authored
We collected enough information about the execution time of GetAllOriginsInfo() so we don't need this UMA any more. Bug: 1165261 Change-Id: If6ef0ad8e49ead0fdd2d34d8bd25e7fd10c2fc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622355Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842416}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ea26a8ce553f..2bd95f1cf454 2021-01-12 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c3c70f848a71 to 987376cd21a8 (7 revisions) 2021-01-12 hao.x.li@intel.com Query API: Non-precise occlusion query on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I023defb110a2846b67d79a6fc263874563e6bafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623793Reviewed-by:
-
