- 30 Oct, 2019 6 commits
-
-
Benjamin Beaudry authored
The text-runs break heuristic now considers the text style. With this change, a text run will break if it encounters a difference in the following text style properties: * font-family * font-weight * rendering mode * font-size * fill color * stroke color * italic flag * bold flag Before this change, it used to break only if a font-size difference was observed. I added an "ultimate" dump test that tests for all of those properties. Bug: 985604 Change-Id: Ice4b4a2dcdd8cc9642ca0e9d069a415c5b2700fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771987 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710522}
-
Tom Sepez authored
SurfaceViewManagerMsgStart obsolete in f7df5b34. PeerConnectionTrackerMsgStart obsolete in bc917af8. Change-Id: I275f10fe0e1d66b427ca55f96223ed22d7b06ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888382Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#710521}
-
Sergio Collazos authored
This reverts commit cf629e19. Reason for revert: Causing a compile issue: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8898221248587802272/+/steps/compile/0/stdout This removes kAdvancedSigninSettingsLinkIdentifier which is used by external_url_signing_egtest.mm Original change's description: > Extract unified consent constants target. > > Preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2 migrations. > > Bug: 922813, 1015907 > Change-Id: I47e4678e40f1820b22938463c5a791c04a662f3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884286 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710479} TBR=rohitrao@chromium.org,jlebel@chromium.org,zhaoyangli@chromium.org Change-Id: I1035a519391d68b553770ba3c12747cfe23e6050 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922813, 1015907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888721Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710520}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/0a3d2bb99b45..b75031a26eed git log 0a3d2bb99b45..b75031a26eed --date=short --no-merges --format='%ad %ae %s' 2019-10-25 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_open_font): Check `num_fonts' for TTCs. Created with: gclient setdep -r src/third_party/freetype/src@b75031a26eed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I4716583e7880f9a2d01c1e80826cd8306cecd5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710519}
-
manuk authored
In preparation for launching to all channels in finch. Change-Id: I581f451ba7e6852df056d785ba824c8d75c7dc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888125Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710518}
-
Aaron Colwell authored
- Fix NavigationRequest() constructor to set source_site_instance for history navigations. - Add DCHECKs in NavigationRequest and OpenURLParams to catch callers that try to construct these objects w/o providing source_site_instance for URLs that need it. Bug: 1014483,1018803 Change-Id: I51bbd8c45fcd2f508793b379df06076c8c4ee498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872463Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#710517}
-
- 29 Oct, 2019 34 commits
-
-
Mingyu Hu authored
Bug: chromium:906739 Change-Id: Ibbd8715c900220242d44ddfef51449b155f81c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877610Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Mingyu Hu <mihu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710516}
-
Julie Jeongeun Kim authored
This CL converts WatchTimeInterceptor to new Mojo types using PendingReceiver, Remote and SelfOwnedReceiver. Bug: 955171 Change-Id: I04db71110cc0d5371754f0e0e142b4893ff061e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885863Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#710515}
-
Peter Kasting authored
This reverts commit c56d4c6c. Reason for revert: I get the following 13 times per update: C:/src/trunk/src/build/toolchain/win/setup_toolchain.py:284: SyntaxWarning: assertion is always true, perhaps remove parentheses? assert (vc_lib_atlmfc_path, Original change's description: > Added assertion message when ATL is not installed. > > The comment above assert did not match behavior > of assert. This comment has been fixed and an > explanatory assertion message was added. > > Bug: None > Change-Id: If9ac26c578ac45fb9e6dd50b1605ecff13bf1323 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881161 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> > Cr-Commit-Position: refs/heads/master@{#710425} TBR=brucedawson@chromium.org,yura.yaroshevich@gmail.com Change-Id: I18f9431edb7d21435c029a0ce825bfd421f0cc27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888322Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#710514}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fea4a2548205..512f92b73181 git log fea4a2548205..512f92b73181 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 gbeaty@chromium.org Fetch the input commit ref when both ref and id are specified. 2019-10-29 hypan@google.com Skip non-text files for CheckDoNotSubmitInFiles Created with: gclient setdep -r src/third_party/depot_tools@512f92b73181 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:922150,chromium:1017286 Change-Id: Ia33d062c9956843c511bfa6ececb4eddeccc79d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710513}
-
Karan Bhatia authored
Add the << operator for RequestAction so that gtest can print a RequestAction object whenever an assertion/expectation fails. Also, improve how the equals operator for RequestAction is implemented. BUG=696822 Change-Id: Ic93382d0459274548f850b4279f1db9944ef4864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888068 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710512}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/412547ad4b75..9b73e21c0df8 $ git log 412547ad4..9b73e21c0 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 hienho remove clang flag for integer sanitizer testing 2019-10-01 hienho vpx_dsp/x86/avg_intrin_sse2: fix int sanitizer warnings 2019-10-23 johannkoenig simplify darwin autodetection 2019-10-23 johannkoenig add darwin18 target 2019-10-23 johannkoenig use a compile time constant for kDataAlignment 2019-10-22 jzern vpx_int_pro_col_sse2: use unaligned loads 2019-10-22 angiebird Make gop size independent from kf_zeromotion_pct 2019-10-21 angiebird Add get_frames_to_next_key() 2019-10-21 angiebird Rename i by frames_to_key in find_next_key_frame 2019-10-21 angiebird Remove input_stats when decide frames_to_key (...) 2019-10-14 angiebird Make get_zero_mtion_factor avoid using cpi 2019-10-14 angiebird Add check_transition_to_still() 2019-10-14 angiebird Add compute_arf_boost() 2019-10-11 angiebird Correct the num_frams of fps_init_first_pass_info 2019-10-11 angiebird Simplify the logics of computing gf_group_err etc 2019-10-11 angiebird Add calc_norm_frame_score() 2019-10-11 angiebird Remove mod_frame_err in define_gf_group 2019-10-11 angiebird Simplify the if clause in define_gf_group 2019-10-04 hienho vpx_dsp/inv_txfm: fix int sanitizer warnings 2019-10-03 hienho vp8/decoder/decodeframe: fix int sanitizer warnings Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I1b862258e20d77113087bbf2418624222860031f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887733Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#710511}
-
Brian Geffon authored
Add a SwapSetParameter dbus message and then add a feature with the corresponding parameter for changing min_filelist. BUG=chromium:1014871 TESTED=On a betty VM CrOS image. Change-Id: I2c875d0d2963fdbc253ae1c4419e6ad6794e5de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880966Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#710510}
-
James Vecore authored
The screen reader was reading each radio button three times. Once for the polymer element and once for each inner div. To Fix the issue I moved the aria attributes out the polymer element and gave the inner divs the role of presentation so they are not re-read. Bug: 1007054 Change-Id: I9f4e8e2954a097c78bc1668e40b27fbff5759055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881480Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#710509}
-
Dale Curtis authored
There's no reason to wait for idleness in these tests, the ended, error, or seek completion signals should be sufficient to quit immediately. BUG=1014646 R=gab Change-Id: I066c7c5718ee9efeb9ab1ef38fdab642619cb423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888830Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710508}
-
Deepanjan Roy authored
Change-Id: I9a6784d653ecb0a81b73761677e6324d35291239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886369Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#710507}
-
chrome://weblayerClark DuVall authored
This is a reland of 90c5851b ASan failures fixed in http://crrev.com/c/1887830 Original change's description: > [WebLayer] Add tests for chrome://weblayer page > > This page recently broke (fix in http://crrev.com/c/1880171), so tests > seem like a good idea. > > This also adds a test helper for executing javascript, and makes the > NavigateAndWaitForCompletion function work more similarly to the one in > the instrumentation tests by waiting until the page is finished loading. > > Bug: 1017924 > Change-Id: I8ca048f9a9a92808abf6cfa5d0e091550cc3d9a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880173 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709552} TBR=sky@chromium.org Bug: 1017924 Change-Id: I249d22946e0bb240e32d38c33637c73bf6c63fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887725Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710506}
-
behdad authored
- If a run has high noise, it's value is not valid. - If multiple valid values exist, the average is used for comparison. Bug: chromium:1012922,1013696 Change-Id: I884bfe87f64415a13c65e413898c5389c4eb539d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856824 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#710505}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I8c54ab0ef0820bbea239da9855aae50e47d0d6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875346Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710504}
-
John Rummell authored
There are crashes reported with UnsatisfiedLinkError when creating MediaCodecListHelper, so catch all exceptions during creation and continue on as if MediaCodecList is not supported on the device. Bug: 1019153 Test: compiles Change-Id: I56f69ed83d070d8b0ad302c9eb3a0a7fe145f60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888133Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#710503}
-
Max Li authored
Change-Id: I027a10a7f993f8f33220e7b0395cfb6f918a48ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887831 Commit-Queue: Max Li <themaxli@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#710502}
-
Joon Ahn authored
Histograms page includes title descriptions but it isn't reflected on the window frame, which is WAI. Including a header information, similar to system information page will be helpful for context. Bug: 1005549 Change-Id: Ibdbe49fb5b478be472a1ec0d3a674596ac6c5192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879562Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#710501}
-
Dale Curtis authored
Downstream code has always assumed that when the unique_id for a VideoFrame doesn't change there's no work to be done. The fix is simply to use a wrapper frame which will have a unique id when a new frame is generated. It's surprising this ever worked, but the reason is that we have a boolean on VideoFrameCompositor which forces repaint of even non-unique frames. That can now be removed since we have multiple sites where unique frames are now required. BUG=1018904 TEST=repro steps from bug no longer repro. R=tguilbert Change-Id: I9e134bdf0f8b7b58d66c23b7e48658dd2be86a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888122 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#710500}
-
Tommy Steimel authored
This CL removes uses of set_owned_by_client in the Global Media Controls code. Bug: 1009708 Change-Id: I08a0c49310b356a225a92f5522189f3e69621524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885499Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#710499}
-
Clark DuVall authored
If the client app also has a default FileProvider, the build system will try to merge both of them, which is not what we want. Using a unique name for our file provider and file path resource fixes this. Change-Id: I800efa70a2075a498839f64c303334f1f6c6261b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887660 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#710498}
-
James Cook authored
After running the C++ preprocessor ax_enums.mojom.h expands to 100,000 lines of code. ax_enums.mojom-forward.h is 300. Switch headers to use ax_enums.mojom-forward.h where possible. This usually means removing default arguments from functions. Bug: 1001715 Change-Id: I792ab8a22ce6c86763f35a7815af7ada9a1ce04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759821Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#710497}
-
zhaoyangli authored
- Added new files for constants. - Added constants target in BUILD.gn for new files. - Added/Modified headers of where the constants are used. This is preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2 migrations. Bug: 922813, 1015907 Change-Id: I41fc3223ebef4ba4e52e7f60e670eb6fdb0b42b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885225 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#710496}
-
Peter Kasting authored
This is nice-to-have on its own as it removes const_casts, and gives a small perf boost by no-oping when calling Layout() twice with the same size with an intervening different size calculation (e.g. GetHeightForWidth(...)). However, I'm mostly writing it because it's a necessary precursor to fixing logical constness bugs in KeyboardShortcutItemView that produce layout glitches. That class needs a non-modifying way of getting at detailed layout info like the width and height of the first line of children, which after this change will be captured in StyledLabel::layout_info_. Bug: 1015717 Change-Id: Ia62ef35dc421d5fe80861afec0e0a9cdda855866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874713 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#710495}
-
Lei Zhang authored
AwPrintManager and PrintViewManagerBasic are the only subclasses of PrintManager that use |pdf_writing_done_callback_|. The two classes do not interact with one another, and no other code changes |pdf_writing_done_callback_|. Given this, since both classes initializes |pdf_writing_done_callback_|, there is no need to check if the callback is null. Change-Id: I73c8a309e3cb7fde0286950e0ef2be2211881373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885108 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710494}
-
Oriol Brufau authored
Symbol markers are painted as geometric shapes, not as text. However, they are still represented by a text run, which may break into multiple fragments. To avoid painting the symbol multiple times, the symbol is painted only for the first one. Before this patch, this was simply done by checking that the 'from' data of the NGTextFragmentPaintInfo was 0. However, markers can have a non-normal unicode-bidi, because the value is inherited from the list item, or via the ::marker pseudo-element once it gets implemented. The problem is that some unicode-bidi values can insert bidi control characters like U+202A, U+202D, U+2066 or U+2068. This makes the first 'from' data to be greater than zero, so the symbol was not painted. This patch checks whether the first 'from' characters are bidi controls, if so, the symbol is painted. Otherwise it's not painted. BUG=1018696 TEST=external/wpt/css/css-lists/list-marker-symbol-bidi.html Change-Id: If5ec4eee624f27ab63df81940f1fc2ea727a5681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884291Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710493}
-
Ingvar Stepanyan authored
Until http://crrev.com/c/devtools/devtools-frontend/+/1872581 is merged. Bug: 1016772 Change-Id: I7322b65b3b0aff789aba909f326c6306eec619d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888670Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ingvar Stepanyan <rreverser@google.com> Cr-Commit-Position: refs/heads/master@{#710492}
-
deepak1556 authored
size is defined in `<xutility>` with VS 2019 Bug: none Change-Id: I337599b8808f36d2c2c3ad1b327352d440c9dea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879683 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#710491}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I033f535716aa7f281114c6fdbb3ae12109109f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888491Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710490}
-
Pavel Shmakov authored
Instead of rotating screen, which is now handled without activity recreation, just use Activity#recreate(). Change-Id: I96a91ab09409d3cc4f9868741846bde11c9fdcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887690 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#710489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f67b33f0e7b..567c7481c849 Created with: gclient setdep -r src-internal@567c7481c849 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:934252,chromium:None,chromium:1018879 Change-Id: I8cfcd2f8c0260ba6929a6d590c2143f08371202e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888135Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710488}
-
Moe Ahmadi authored
- Makes changes to support having no selected matches. For instance, 'Enter' should do nothing when there are no selected matches. - Selects the first match after populating the matches only if it can be the default match. For NTP zero-prefix suggestions, no match is allowed to be the default match. Therefore there will be no default selection. - Adds a new test and makes changes to the existing ones. Bug: 243926,1016845 Change-Id: Iba56b0aef467c917d96cd01966f15d18258264df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884266Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710487}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/287b0a670fbf..88a74e59f04c git log 287b0a670fbf..88a74e59f04c --date=short --no-merges --format='%ad %ae %s' 2019-10-29 ianelliott@google.com Vulkan Android: Remove support for EGLConfig's with GL_RGB10_A2 & GL_RGBA16F 2019-10-29 courtneygo@google.com Roll dEQP to VK-GL-CTS Created with: gclient setdep -r src/third_party/angle@88a74e59f04c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I4ac261a579fd591db6364f352b7e275b29c4484c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710486}
-
Xianzhu Wang authored
This is because we only rebaseline-cl for unexpected failures. We can't remove lines from TestExpectations because the lines contains expectations other than Failure. Bug: 1012792 Change-Id: Iaa710b002af7f4f75eb15bdefe4d7a14bb9da675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883624Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710485}
-
Aaron Krajeski authored
Looks like the winding rule was missed. Bug: 1015360 Change-Id: I3d48ac413780c97492f69de78ff6f43cec94ac67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888117Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#710484}
-
Andrew Grieve authored
CIPD does not allow them. Splitting this off from larger change where the problem was hit: http://crrev.com/c/1885951 Bug: 693079 Change-Id: I068bf8fd01044f5c80307f7f68de5bd03b1ed1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888373 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#710483}
-