GitLab

Issue 798467: It's not yet clear what ImplType should be, but we
technically don't need both of ImplType and ResultType.  We can
implement IDLNullabe without ResultType.

At this moment, ImplType looks implementation helper used only by
IDLXxx and NativeValueTraits.  ImplType doesn't look a public API.

Issue 798470: It's reasonable that NullValue() is defined iff
type T can represent IDL null value.  We can tell whether
base::Optional is necessary or not by looking at existence of
NullValue().

Issue 798471: This patch requires NullValue() only in
NativeValueTraits and not in IDLXxx.  IDLXxx is a simple tag
type just like the original design.

Bug: 798467, 798470, 798471
Change-Id: I08e3cf54f3059ec308b4b455045c0bc1cfd5967b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002551
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732345}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3b5fd175..90815b65

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I764091eb8a3f8b1964daae130f62b1ff0d6d3b2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002637Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732344}

This CL is a pure refactoring. This moves the duplicated implementations
of GetEntries/GetMetrics from test files to TestUkmRecorder.

Bug: 1033410
Change-Id: I97c4686421fb26d7084414826e5dc99e778045bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986655
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732343}

BUG=104106
R=dcheng@chromium.org, dtapuska@chromium.org, haraken@chromium.org

Change-Id: Ib778b3cdb059dd5079f3b9e7ec61af1bb5107cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002750Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732342}

This CL is used to integrate ARC's context menus for app list to
AppService:
https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc?l=43
https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc?l=73

BUG=1038487

Change-Id: Ib1fa21ad7400bf990ec546c8eb527767a4f32362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003149
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732341}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/308c74fe7331..813483f04139

git log 308c74fe7331..813483f04139 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 szuend@chromium.org [cleanup] Remove unused _toolbarItems field from View.js

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@813483f04139

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib0623d50a3f4dfa49b44c85085314d43d47de411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004489Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732340}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c06fa2e9433..d5722304fcfc


Created with:
  gclient setdep -r src-internal@d5722304fcfc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I548bf1af43ddccf2eab39d9f8158e24a113859f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003826Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732339}

Analogous to the recent https://crrev.com/c/1968991, this patch adopts
org.chromium.base.Promise as mechanism to avoid blocking the UI thread
while the Intent is constructed as part of
TrustedVaultClient.createKeyRetrievalIntent().

This patch also adopts PendingIntent as opposed to Intent, which fits
better the need to launch a possibly external flow.

Bug: 1012659
Change-Id: Ib8db263f8b5ce3aa255b90603e4def60456d1459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972131
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732338}

We run these checks in the devtools-frontend repository and roll the
code in. There is no need for running these checks in Chromium as well.

Moreover, there appears to be a configuration difference in the Chromium
buildbots compared to our own waterfall. Since these checks already run
in our repository, we should remove them rather than fix them.

Bug: 1041811
Change-Id: Icc879116b8593310b15276bf413647d34ffced3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000707Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732337}

This is a follow-up of r728894. It affected the behavior of the WPT test
grid-layout-properties.html, but I didn't notice it since it was marked
as failing.

Mozilla updated the test in https://bugzil.la/1599206, but they didn't
cover some cases that were already failing for them since Firefox
doesn't serialize shorthands.

Also, a case that used to expect "150px 50px 50px" should have been
changed to "150px" (removing the trailing implicit tracks), but Mozilla
changed it to "50px" since it's what they get due to a Firefox bug.

Here I'm fixing the test to expect the correct values, unmarking it as
failing, and adding an -expected.txt for the cases that fail due to
bug 511177.

BUG=1024927

Change-Id: I7ff8d248a708af273cd89d438ffd2692783a5bc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002579Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732336}

The field gets populated only if the committing client is sure about
the GUID being the authoritative one (consistent with the originator
client item ID).

Instead of introducing a new field for the originator item ID or a
boolean representing whether the GUID is indeed authoritative/final,
the existing field |client_tag_hash| is leveraged for this purpose,
which was unpopulated for bookmarks prior to this patch.

This is aligned with future plans to actually introduce a client tag
for bookmarks, just like for the rest of sync datatypes.

Bug: 978430
Change-Id: I66dd9d46d2d23aa86b0c9d88dcd6aed4a896c834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981610
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732335}

This is similar to crrev.com/c/1999974 but for
FindRegistrationForScope().

DidFindRegistrationForClientUrl() and
DidFindRegistrationForScope() in ServiceWorkerStorage are merged
into a single method because these became identical.

Bug: 1039200
Change-Id: I7eead23192734fa7a5cf743801474975fd47a17b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003163
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732334}

`Referrer-Policy` test subresources moved out of //referrer-policy, into
//common so that they could be used by other tests more easily. When we
did so, we neglected to update the URL in
//external/wpt/referrer-policy/generic/inheritance/iframe-inheritance-data.html.
This patch addresses that oversight.

Change-Id: I1989df8dc4e39ad26de8ac9562f81796bda5aebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003311Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732333}

This change extends PasswordManager's ShowAllSavedPasswordsShownContext
and ShowAllSavedPasswordsAcceptedContext histograms and cleans up
logging code. Lastly it transfers the responsibility of the histograms
to vasilii@ and fhorschig@, who are more appropriate owners.

Bug: 1037197
Change-Id: Ibcae394a9bf2194500bbfbd0c76137b04fffeb82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000709
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732332}

https://skia.googlesource.com/skia.git/+log/7edb0eb8a458..2900040bc4a0

git log 7edb0eb8a458..2900040bc4a0 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 146e16f68fdc..5fc197dc7669 (10 commits)
2020-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 86f730971751..a7b91502cd7f (2 commits)
2020-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b83f9414..98818e57 (437 commits)

Created with:
  gclient setdep -r src/third_party/skia@2900040bc4a0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: mtklein@google.com
Change-Id: I5dd50060b1b5e95a616f66efbbee2f10c237a879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003118Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732331}

Bug: 1038799
Change-Id: Ia5f917405c2eed46fe1d9c07bf110f9f3aac0ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003153Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732330}

This patch implements |BuildBackplate| for |NGFragmentItem|.

Bug: 982194
Change-Id: I352a8edef64d3c936d34075742e42d124c1bfdbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003150
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732329}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a04803267c6..e9730d75a005

git log 2a04803267c6..e9730d75a005 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 raul@tambre.ee subprocess2: Ensure environment keys and values are strings on Python 3

Created with:
  gclient setdep -r src/third_party/depot_tools@e9730d75a005

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:984182
Tbr: agable@chromium.org
Change-Id: I4da110b37114c9040f24c8a9ec39fc341d84fa32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003434Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732328}

BlinkTypeInfo.is_nullable is confusing with IdlType.is_nullable
despite that their meaning are different.  Rename the former to
has_null_value.

Bug: 839389
Change-Id: I0ebd15f460730f8b612da60592cfa90ec024cb76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004366Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732327}

The update checker and the new script loader now reflect the COEP value to the
ServiceWorkerVersion. That value is stored in the disk properly.
Note that, in this CL, a loader factory passed to a new service worker is
created before the new script loader loads the main script. That means the COEP
value doesn't take effect until the service worker is restarted.

Bug: 1039613
Change-Id: Id23fc14f7acdddb4b7473331cb1376ce5f6fc358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991064
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732326}

PathManager for union types fails if a Union doesn't contain user
defined types, because its |components| is empty.

This CL makes it to set core as its default component in such cases.


Bug: 839389
Change-Id: I423f4691d0435352b0e873af5d679b898afc9465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004358Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732325}

This CL adopts the aspect ratio from Finch to thumbnail size. If the
JPEG has different aspect ratio, regenerate the JPEG file from the ETC1
file.

Integration with tab_grid_layout_android_new_tab_tile variation is also
added.

Everything introduced in this CL is gated by field trail under the
enable-tab-grid-layout flag. And most of the Java part is verified to be
behind the gating functions
FeatureUtilities.isTabThumbnailAspectRatioNotOne() and
FeatureUtilities.isAllowToRefetchTabThumbnail() by formal equivalence
checking tool here: http://crrev.com/c/1934235. Note: the tool does not
support native yet.

TBR=yusufo@chromium.org

This is based on http://crrev.com/c/1990214/14.

Bug: 1041536
Change-Id: I5db65a72b7c56a4546491a13d43872b46ee6e55b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003825
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732324}

As a step to convert legacy IPCs to the Mojo, this CL
converts renderer side's BlinkTest IPC messages to the Mojo.
This CL adds the IPC messages to WebTestControl interface in
web_test.mojom file. Now it starts to support the original
messages. The added methods are as follow,

 - Reset();
 - TestFinishedInSecondaryRenderer();
 - LayoutDumpCompleted(string completed_layout_dump);
 - ReplyBluetoothManualChooserEvents(array<string> events);

This CL should not change any behavior.

Bug: 1039247
Change-Id: I43dbdbb9d9d4fb20a4f7a55e4e10fbf33e5622ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991045Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732323}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/772588160e90..308c74fe7331

git log 772588160e90..308c74fe7331 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 szuend@chromium.org Remove SimpleView.syncToolbarItems and use async variant instead
2020-01-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@308c74fe7331

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032016
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5533072c0f2e0f7dd2a5cddd889598f97ba96e72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003815Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732322}

It now reports CancelledOnWebAppProviderShuttingDown, which is better
conveys the cause.

This is a followup for https://crbug.com/1021813.

Bug: 1021813
Change-Id: Ib988f30a45a362d3d818ceb6d9a7844cc35d0376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997424Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Jiewei Qian  <qjw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732321}

https://dawn.googlesource.com/dawn.git/+log/0ecc48ecb7a1..631f4258a1ac

git log 0ecc48ecb7a1..631f4258a1ac --date=short --first-parent --format='%ad %ae %s'
2020-01-16 enga@chromium.org Suppress Depth32TextureCreationDepthClears on D3D12 NVIDIA
2020-01-16 enga@chromium.org OpenGL: Simplify lazy clear of render pass attachments
2020-01-16 enga@chromium.org D3D12: Simplify lazy clear of render pass attachments
2020-01-16 enga@chromium.org Vulkan: Simplify lazy clear of render pass attachments
2020-01-16 enga@chromium.org Directly load Swiftshader if no Vulkan driver is available
2020-01-16 enga@chromium.org Metal: Implement lazy texture clears

Created with:
  gclient setdep -r src/third_party/dawn@631f4258a1ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I2b0e54f5eb773ac971bd09de80f0a648f7f59932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003818Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732320}

This method depends on in memory representation of some service
worker objects (e.g. ServiceWorkerRegistration and
ServiceWorkerVersion). Move it to ServiceWorkerRegistry.

Bug: 1039200
Change-Id: I2c11ff418504289c85ffbeb570b934069899b56c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004355
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732319}

This CL adds tests for deleting custom search engine.

Fixed: 1041399
Change-Id: I0ce5434551538dd793fde8098209e37db0813707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002569
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732318}

This component is responsible for actual sending print job to the
Chrome printing pipeline.

Bug: 996785
Change-Id: I9d1e2f2b55fffbf0d876af222fdebb0b8d0989a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962200Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732317}

Bug: 839389
Change-Id: Ic00dc613f470f10c3ada307d313fb12bd7c813df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994037Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732316}

This patch introduces |DCHECK()|s to |AssociateWithLayoutObject()| to help
identify root cause of issue 1039470.

Bug: 1039470
Change-Id: I29aeb05eb7015c62f9908d9ce538460d72742aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004176
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732315}

Using wpt-import in Chromium 453258c6.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I83e707b643d9ea2f2e86d281f32a5c0140b0719e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002634Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732314}

Also,
 - Remove LayoutMenuList::DidSelectOption().
 - Add HTMLFormControlElement::UpdateFromElement() to add
  DidUpdateMenuListActiveOption() to each of
  LayoutMenuList::UpdateFromElement() calls.

This CL is a preparation to build a LayoutNG counterpart of LayoutMenuList.
This CL has no behavior changes.

Bug: 1040828
Change-Id: If7917af101119a830e899a50711a6c1491e22eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003164Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732313}

This is now being set in builder.star().

R=agable@chromium.org, gbeaty@chromium.org, tikuta@chromium.org

Bug: 1040754
Change-Id: I61eaadb39886f78edcd0a265da36f689b0261cf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004352Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732312}

https://webrtc.googlesource.com/src.git/+log/5b8d2fcb2c08..52ccb5e5b6e7

git log 5b8d2fcb2c08..52ccb5e5b6e7 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1d541bc5..374f209d (732155:732255)

Created with:
  gclient setdep -r src/third_party/webrtc@52ccb5e5b6e7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I2aa14012419c84c3f1edd17fdef578e330807466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003120Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732311}

This brings back counter descriptions reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1982338
for those browsing historical data.

Bug: 1018156
Change-Id: I12b2d952c5517d7fa98a858e314c5c78768255b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980602
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732310}

It is confusing when we want to add ATS, because these builders
use Linux machines, which get enable_ats=True if they have an RBE
goma_backend.

Better to remove the goma_backend setting to avoid this confusion.

R=agable@chromium.org, gbeaty@chromium.org, tikuta@chromium.org

Bug: 1040754, 950413
Change-Id: Ie445bad69756ea24b7129f085e384af8635bdf60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004351Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732309}

Change-Id: I6e1109cf6ab7b8e3a40910fec3f2e9a54cb4d578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994267
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732308}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c885431d04db..1c06fa2e9433


Created with:
  gclient setdep -r src-internal@1c06fa2e9433

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1028270,chromium:1034629,chromium:1041618,chromium:1041701
Tbr: jbudorick@google.com
Change-Id: If5439d4d79c30a9e429a05903ffe72e92a91a4ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003121Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732307}

Preview Tab is using PreferenceManager to control the visibility of
"new" label on the corresponding context menu items. This CL migrates
it to use the feature engagement system so that it is fully controlled
as IPH.

The context menu has 2 menu items for preview tab feature (open link
and image) but their 'new' labels are handled as one. i.e. they disappear
at the same time if user accesses preview tab via either of the menu items.

The label handling for Google Lens is reverted. It needs to be
taken care of by a separate feature engagement entry. The label remains
visible for now.

Bug: 1027718, 902140
Change-Id: I5d68d4f5e8c71f66c2c3c91a875152d1c4b128dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985838
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#732306}