- 01 Aug, 2017 40 commits
-
-
Tim Song authored
This CL also refactors ProximityAuthProfilePRefManager to handle the syncing of profile prefs to local state. BUG=748879 Change-Id: Ia09a772b10b7b3e2305153c52b1457101cd950c5 Reviewed-on: https://chromium-review.googlesource.com/585899 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#491102}
-
Emircan Uysaler authored
Tests is failing, see bug below. TBR=hbos@chromium.org Bug: 751211 Change-Id: Ic7e09dde421f1fa2b85db7da3de48c1001e128d3 Reviewed-on: https://chromium-review.googlesource.com/596513Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491101}
-
Sebastien Marchand authored
Using LazyInstance seems to be discouraged (crbug.com/686866) now that Chrome supports Thread-safe static initialization. Change-Id: I7649ad76ada5bd2292341f46fa1955d2ae51385e BUG: 686866,720131 Reviewed-on: https://chromium-review.googlesource.com/594491Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#491100}
-
danakj authored
R=reveman@chromium.org Bug: 722935 Change-Id: Ib412fda34cf0e55529a0f288863decbca7f73616 Reviewed-on: https://chromium-review.googlesource.com/596515Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#491099}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4d5d88c3e04c..3ec578154f4f $ git log 4d5d88c3e..3ec578154 --date=short --no-merges --format='%ad %ae %s' 2017-08-01 simonhatch Dashboard - Clone Pinpoint dialog into Dashboard Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I68347b886136f6658a666527279a0221ed249a6b Reviewed-on: https://chromium-review.googlesource.com/596532 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491098}
-
Conley Owens authored
We need to be able to simulate the removal of a characteristic. This addition to the interface seems to be the most straightforward way of accomplishing this goal. BUG=569709 Change-Id: If700ea99a6df9badc98fc81ef5f7461e574b7985 Reviewed-on: https://chromium-review.googlesource.com/583640Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#491097}
-
Adithya Srinivasan authored
TBR=alexclarke@chromium.org, eseckler@chromium.org Bug: 751180 Change-Id: Ied56d06a9147c92903d1680159ddbbd4956cf28f Reviewed-on: https://chromium-review.googlesource.com/596767 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#491096}
-
Dave Schuyler authored
This CL removes old class="..." entries for cr-dialog .title, .body, .button-container, and .footer. The CSS that used those classes have changed to [slot=...] instead. Bug: 747552 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ice802ab9cd238e24c8e66809e5d7907141a0b339 Reviewed-on: https://chromium-review.googlesource.com/584001 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491095}
-
Will Chen authored
Bug: 667560 Change-Id: I4f8f168de679d5cdcc16353349332c9aaedce709 Reviewed-on: https://chromium-review.googlesource.com/592497 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491094}
-
sczs authored
This CL Removes the use of the following commands and uses the dispatcher instead: IDC_READER_MODE IDC_SHOW_READING_LIST Bug: 738881 Change-Id: I72e1dd2add7905e3168daca502084c53a42fa4c8 Reviewed-on: https://chromium-review.googlesource.com/596530 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#491093}
-
Yuzhu Shen authored
This CL follows how run_telemetry_as_googletest.py handles --xvfb flag. BUG=717738 Change-Id: I0bb746d18be7818c782b7086ca96605a60af0761 Reviewed-on: https://chromium-review.googlesource.com/595227 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491092}
-
Alex Newcomer authored
Background blur is enabled behind the appropriate flag. The flag will be set for either certain devices or all devices based on blur performance. The flag will eventually be removed when blur is acceptable for all devices. Bug: 739405 Change-Id: If03bbc7bcfbeb5f8609def3b582a05113ef1571e Reviewed-on: https://chromium-review.googlesource.com/592289 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491091}
-
Eric Roman authored
Examples: # Fetches the certificate chain for www.google.com and pretty prints it ./print_certificates.py www.google.com # Pretty prints all the certificates contained in certs.pem, followed by # the single DER-encoded certificate foo.crt ./print_certificates.py certs.pem foo.crt Change-Id: I3719d1bd3bddc262829f4e6afd7309a205f15c4b Reviewed-on: https://chromium-review.googlesource.com/585570Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491090}
-
Mark Pearson authored
Sets default values for all relevant parameters to the ones we decided to launch. In particular, this change: * makes it so that URLs that match the input--even if only visited once or twice--are likely to score above low quality query suggestions that come from the server. * boosts a URL suggestion if it appears the URL suggestion is clearly seeking that URL. In particular, if the omnibox input only matches that single URL from history, it gets a 3x boost (in effect we count it as having three times as many visits). This boost decreases as the number of matching URLs increases, so that if the user input matches five or more items from history, nothing gets a boost. * lowers the threshold for how well a URL must match the input in order to be displayed. Previously, for example, we wouldn't return URLs that match a word in the input if the word matches in the ?query or #hash section of the URL. Now we do. * reduces the relative weight of a "typed visit" (a time the URL is selected from the omnibox) compared with a regular visit (click on a link). It used to be that the former was worth 20x the latter. Now it's only 1.5x. * changes to a scoring model in which additional visits to a URL are guaranteed to increase its score. Previously we used a model based on the average quality of a visit, which means that if a URL has many typed visits and then gets a new untyped visit, its score (the average) will go down. Now we use simply a sum, which means the score will definitely increase. Precisely, in terms of code / config, we're launching the following settings: "HQPExperimentalScoringBuckets": "0.0:550,1:625,9.0:1300,90.0:1399", "HQPTypedValue": "1.5", "HQPFreqencyUsesSum": "true", "HQPNumMatchesScores": "1:3,2:2.5,3:2,4:1.5", "HQPExperimentalScoringTopicalityThreshold": "0.5" In the process, removes some of the flags for frequency scoring that I don't think are useful (not the right model for scoring) and aren't worth going back to. Bug: 695560, 327085, 369989, 508262, 580688, 591981, 598184 Change-Id: Id349c5aaa2e09e6b5284c55fc5790f4b14b8fa7b Reviewed-on: https://chromium-review.googlesource.com/585377 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#491089}
-
Menglu Huang authored
This reverts commit 7405f12a. Reason for revert: <INSERT REASONING HERE> This CL breaks ios_showcase_tests. https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/30194 Original change's description: > Add AccessibilityCustomAction to ContentSuggestions > > In order to have the feature accessible, all the actions using gestures > (long press, swipe to dismiss) must have custom accessibility actions. > Also adds action sheet to Read Later cells. > > Bug: 749131 > Change-Id: I2c81f6443a49bdf0cdccc3ec747b0ffd42513ef1 > Reviewed-on: https://chromium-review.googlesource.com/593652 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Jean-François Geyelin <jif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490930} TBR=jif@chromium.org,gambard@chromium.org Change-Id: I805e907403106623dc9c67cc89ccbbc5546d0ee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749131 Reviewed-on: https://chromium-review.googlesource.com/596591Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#491088}
-
Ulan Degenbaev authored
BUG=chromium:730036 Change-Id: Ie31d6e2f0375655185b7fcd8a9809bc24969b861 Reviewed-on: https://chromium-review.googlesource.com/595982 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491087}
-
Sergey Ulanov authored
base::RandBytes() may be called with output_length=0 and all implementations supported this case, except Fuchsia. On Fuchsia the function was crashing due to a failed CHECK(). This was breaking MemoryDataSourceTest.EmptySource test. Bug: 737802 Change-Id: Ib9ec20a82dd6966a146f0c66936e232c061466a5 Reviewed-on: https://chromium-review.googlesource.com/595012 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491086}
-
Justin Schuh authored
Disable integer overflow warnings in integer overflow tests. TBR=thakis@chromium.org Bug: 751198 Change-Id: Ia5680199a51f0ecb951744838e624f9d6f1d7573 Reviewed-on: https://chromium-review.googlesource.com/596511Reviewed-by:
Justin Schuh <jschuh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491085}
-
Kenichi Ishibashi authored
We need to migrate pagesets to WprGo but I don't think blink_memory_mobile is worth updating because it tracks almost the same metrics as system_health benchmarks do. This benchmark should be superseded by system_health.memory_mobile. BUG=730036 Change-Id: Ic6877c733efce8ffd42cb3d570fb8ec55456d7b7 Reviewed-on: https://chromium-review.googlesource.com/595347Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491084}
-
Etienne Pierre-Doray authored
Bug: 729154 Change-Id: Ifc313411a21c340588fd41a97ba74ccc9a84dbfa Reviewed-on: https://chromium-review.googlesource.com/570767Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#491083}
-
sunxd authored
When tiling masks, sometimes we get tiles that are completely outside the layer's visible rect. This would lead to problems in determining whether quad rect contains visible rect, because an empty rect's origin is not always contained by a quad rect that locates at a random origin. This would result in problems when converting draw quads to RPDQs in IPC, thus breaking Android WebView. This CL makes RenderSurfaceImpl::TileMaskLayer throw away such quads. Bug: 740810 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I07c4024894740d09ba4708d5ead37a4bec99d7ea Reviewed-on: https://chromium-review.googlesource.com/570630Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491082}
-
Bruce Dawson authored
VC++ is much less frequently used now so it can easily accumulate compiler warnings. A couple were fixed a few hours ago but two more remain. This fixes them by adding casts. Arguably the better fix would be to make the types actually match so that no casts are required. TBR=toyoshim@chromium.org BUG=750999 Change-Id: I1776d93a66db6b74175ed02548525e458be05117 Reviewed-on: https://chromium-review.googlesource.com/596348Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491081}
-
Reilly Grant authored
This change rewrites the single Payments API layout test that uses Mojo mock services to use the new Mojo JS bindings. Bug: 699569 Change-Id: I6fa74bfb2e926d35ccf3232c87f7a0114592ce9a Reviewed-on: https://chromium-review.googlesource.com/595246 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491080}
-
Reilly Grant authored
This change rewrites the WebShare API layout tests to use the new Mojo JS bindings. Bug: 699569 Change-Id: Id95a016765c5b101ee347f760e7cec8b74ec4b7e Reviewed-on: https://chromium-review.googlesource.com/587412Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491079}
-
dpapad authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida67f99137833161bdccc05b29f41e0f184bb7a0 Reviewed-on: https://chromium-review.googlesource.com/592132Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491078}
-
Jiaquan He authored
This relands commit cc2fbf55, which was reverted by f87a709b. We create threads to load icons while initializing ArcPlayStoreSearchResult objects, so we have to wait for them to finish, otherwise the test will be flaky and fail the base::MessageLoop::current()->IsIdleForTesting() test in test_browser_thread_bundle.cc. Bug=736552 Change-Id: Icd054ea66367f3c28c3333522795e85475f40a1f Reviewed-on: https://chromium-review.googlesource.com/590027Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491077}
-
Paul Jensen authored
Some devices/emulators run quickly so requests take less than 1ms, which causes some test failures. Fix them using MetricsTestUtil.assertAfter() and also clean up copies of that code. Bug: 751184 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Icdce80479a887276b8921b4168a96c65b12d0143 Reviewed-on: https://chromium-review.googlesource.com/596073 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491076}
-
Andrew Grieve authored
This reverts commit cfa74c50. Reason for revert: Broke downstream compile Original change's description: > Android: Make all targets depend on specific play services targets > > Deletes google_play_services_library GN variable. This should reduce > compile times a bit, but mostly is just a good idea in general. > > Change-Id: Ia991772db4a8549490926ad46808ceefaf12853f > Reviewed-on: https://chromium-review.googlesource.com/585450 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Reviewed-by: Paul Miller <paulmiller@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Michael Case <mikecase@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490968} TBR=lambroslambrou@chromium.org,nyquist@chromium.org,mariakhomenko@chromium.org,mikecase@chromium.org,agrieve@chromium.org,paulmiller@chromium.org,jochen@chromium.org Change-Id: I404413dfe809a6918015d109524c4995ec202789 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751199 Reviewed-on: https://chromium-review.googlesource.com/596807Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#491075}
-
Diana Gage authored
CanCut() should be renamed to CanEditText() because this method can also be used for asking a plugin if it can paste text. As before, with respect to the PDF plugin, this method returns true if focus is within a user-editable form text area and returns false otherwise. BUG=59266 Change-Id: I0ac86a86c96d64c42cc1246615b54ad3246c8513 Reviewed-on: https://chromium-review.googlesource.com/588067 Commit-Queue: Diana Gage <drgage@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alexandre Elias <aelias@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#491074}
-
Reilly Grant authored
This change rewrites the Budget API layout tests to use the new Mojo JS bindings. Bug: 699569 Change-Id: I4af6e3a78c16cf4ecc6aeedc5317eaf1021ca9eb Reviewed-on: https://chromium-review.googlesource.com/595234 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491073}
-
spqchan authored
Using field editors is finicky especially when there's multiple textfields. Using one field editor is enough, so this CL combines the name and URL field editors into one. In addition, like what the AutocompleteTextFieldEditor is doing, the field editor's fieldEditor property will reset each time windowWillReturnFieldEditor:toObject: is called so that notifications will be sent properly. Bug: 744211 Change-Id: I2367d2abc788aaf1ef3daa037c879a222440015a Reviewed-on: https://chromium-review.googlesource.com/595214Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491072}
-
Stefan Zager authored
Previously, LayoutUnit's between NearlyMax() and Max() would round down, even though their fractional parts are > 0.5. Similarly, LayoutUnit's between Min() and NearlyMin() would round up (toward zero), even though their fractional parts are < -0.5. Change-Id: I824db066f6f45b58512a30ed32c1d280604bfefe Reviewed-on: https://chromium-review.googlesource.com/592854Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#491071}
-
Hongchan Choi authored
In some cases where the worklet cannot function, registering AudioContext is not possible. (e.g. detached iframe from the document) So BaseAudioContext needs to check the existence of worklet before registering itself. The fix is locally confirmed; ASAN does not crash anymore with it. Bug: 750502 Change-Id: Id35358b0811c7f4c3476ab62e49611a8d28bad60 Reviewed-on: https://chromium-review.googlesource.com/594852 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#491070}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8e13a185..6329c5bd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I0d98eac5a9cfed543f3452b910e1fdfb6bfa8271 Reviewed-on: https://chromium-review.googlesource.com/596068Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491069}
-
Sean Kau authored
We need to generate a make and model string from a PpdReference for edit to behave reasonably. So, lookup make and model from our PPD index. Because we don't want to assume anything about the relationship of the effective_make_and_model strings and manufacturer names, iterate through all of them. Bug: 685673 Change-Id: I016e2cbc45abc9ee6e8a6edf556a962c07c94541 Reviewed-on: https://chromium-review.googlesource.com/592767Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491068}
-
DongJun Kim authored
Previous codes do not return directly even if plugin_instance and load_manager are null. It can occur crash whenever accessing each variables. This patch add return codes for avoiding crash if variable is null. BUG=NONE Change-Id: Ia5c59a9473124d6ad1ff76ee909d9396af35e96c Reviewed-on: https://chromium-review.googlesource.com/586488Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#491067}
-
Ehsan Karamad authored
When an OOPIF is hidden through changing CSS properties of its frame- owner element, the state is reported to the browser and the IPC handled in the CrossProcessFrameConnector associated with RWHV. This will also lead to a call to RenderWidgetHostImpl::WasShown/WasHidden for the corresponding local root. However, when the browser is shown all RWHVs are asked to Show which will invalidate the current state of CSS visibility. Specifically, this causes a hidden frame to generate compositor frames. This CL will add a bit to RenderWidgetHostViewChildFrame to remember its CSS visibility state. Also when RWHVCF::Show is called, the view will verify that neither itself nor an ancestor view are CSS invisible before calling RenderWidgetHostImpl::WasShown. BUG=628700 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I42c3d7f50aacd47b12f0de151c856233e8942510 Reviewed-on: https://chromium-review.googlesource.com/583729 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491066}
-
Devlin Cronin authored
api_resource_manager.h mentioned the FILE thread in a comment when discussing resources on named threads (and theoretically would have allowed its use). Update the comment to not mention the FILE thread and add explicit notes that the only allowed threads are the IO and UI threads, which are all we currently use, along with a note about how the API could be expanded, if need be. To be safe, also add a static assert to ensure that resources use no other threads. Since we currently only need IO and UI threads, this CL doesn't rearchitect anything unnecessarily. Bug: 689520 Change-Id: I5d304fd9153865af7c9778d93b34f2e20ddb95a6 Reviewed-on: https://chromium-review.googlesource.com/591688Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491065}
-
Alex Newcomer authored
OnMousePressed now properly returns true if the event is consumed. This fixes the bug where unhandled mouse events were not propogating to the AppListView. Bug: 744778 Change-Id: I46cf1eb64994221b37ef186754d5409c5ddbd466 Reviewed-on: https://chromium-review.googlesource.com/589819Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#491064}
-
Paul Irish authored
Bug: 750767 Change-Id: I7acea758a3142f599326eb745ae16db5f020b06b Reviewed-on: https://chromium-review.googlesource.com/594633 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491063}
-