- 29 Jan, 2018 40 commits
-
-
Christian Dullweber authored
In order to remove tab history correctly, we need to know the time range that was specified for a history deletion. Otherwise there can be edge cases, where a NavigationEntry could not be removed because it doesn't have a corresponding history. This CL replaces the boolean all_time parameter of HistoryServiceObserver::OnURLsDeleted with a DeletionTimeRange object. Bug: 407074 Change-Id: Id0fc5535e6cfd0874edb83fe75f61e6d112666e7 Reviewed-on: https://chromium-review.googlesource.com/800932 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#532375}
-
vitaliii authored
This reverts commit 3d3a5267. Reason for revert: Causes UnhandledEventOnPeeking to fail constantly (see crbug.com/806690). Original change's description: > cros: Don't dismiss AppList on right click/two finger tap > > UX request: > - Don't dismiss AppList if the right click/two finger tap > is on the shield of the AppList. > > - Added a test. > > Bug: 805937 > Change-Id: Id38b5872c3836680d08adbcb84922fe62201be19 > Reviewed-on: https://chromium-review.googlesource.com/887282 > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532023} TBR=jennyz@chromium.org,newcomer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 805937, 806690 Change-Id: I4acd4bbea8a85988224efa7573b719655628e445 Reviewed-on: https://chromium-review.googlesource.com/890264Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532374}
-
Sylvain Defresne authored
There is a global comparison operator allowing to check whether a GURL is equal to a constant URL. This avoid needlessly parsing the constant to a GURL everytime the comparison is done. Bug: 655467 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9c876b542f09235042c36026b32977d88c2f0d0b Reviewed-on: https://chromium-review.googlesource.com/886421 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532373}
-
Juan Antonio Navarro Perez authored
- Add explicit calls to SetUp-/CleanUpEnvironment. TBR=tengs@chromium.org Bug: 804292,801578 Change-Id: I54d0925b308867020ed69b4330abd529beb61d77 Reviewed-on: https://chromium-review.googlesource.com/881142Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#532372}
-
Niels Möller authored
Bug: webrtc:8504 Change-Id: I8e227e17c521cb2825cdda909e8071ba0366e69f Reviewed-on: https://chromium-review.googlesource.com/870119 Commit-Queue: Niels Möller <nisse@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#532371}
-
Yoichi Osato authored
GetLocalSelectionEndpoints uses a boolean argument |selection_start| to compute a selection bound. This patch refactors the function by removing the argument and splitting the function into GetLocalSelectionStartpoints and GetLocalSelectionEndpoints for code health. Bug: 789870 Change-Id: I7a2f3e7ab9f086c286c0f60bd1e8ce8a1d1c94a8 Reviewed-on: https://chromium-review.googlesource.com/890695Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#532370}
-
Gabriel Charette authored
https://chromium-review.googlesource.com/c/chromium/src/+/878825 didn't cause as big of a spike as I expected (~250 instead of ~1000), will wait for it to settle a bit more before landing this CL (to confirm whether this one still causes havoc and there's more to uncover or not) R=asvitkine@chromium.org Bug: 804345 Change-Id: Iee2d1f52d55dff2e840420c28e6af7c80d526ca1 Reviewed-on: https://chromium-review.googlesource.com/883122Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532369}
-
Gauthier Ambard authored
This CL constrains the OmniboxLayoutGuide so it is positioned on the omnibox of the adaptive toolbar. Bug: 806248 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I84a19370868ff152402a6039c626acb28cc6a26c Reviewed-on: https://chromium-review.googlesource.com/888640Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#532368}
-
Yoichi Osato authored
This patch changes the function to use a SelectionInDOMTree instance rather than VisibleSelection one. This patch is a preparation for removing VS canonicalization: crrev.com/c/872811(WIP) Bug: 789870 Change-Id: I38388e01b3262bc3a8abf455dfb9f566ef9cf510 Reviewed-on: https://chromium-review.googlesource.com/890574Reviewed-by:
-
Kent Tamura authored
The purpose of this function is to reduce the number of callsites for FooElementFactory::createFooElement(), which don't support prefixes correctly and contain unnecessary custom element processing. The implementation of CreateRawElement() is equivalent to Document::createElement(qname, flags) without custom-element processing. * Document::createElement(local_name, options, exception_state): Replace createElement(local_name, exception_state) with CreateRawElement(). createElement(local_name, exception_state) contains V0 custom-element processing, but it isn't necessary here because it's already done before calling createElement(). * Document::createElementNS(ns, qname, exception_state): Replace createElement(qname, flag) call with V0 custom-element processing and CreateRawElement(). createElement(qname, flag) does V0 custom-element processing in this path. This CL adds the custom-element processing here, and use CreateRawElement(). * Document::createElementNS(ns, qname, options, exception_state): Replace createElement(qname, flag) call with CreateRawElement(). createElement(qname, flag) contains V0 custom-element processing, but it isn't necessary here because it's already done before calling createElement(). Bug: 806641 Change-Id: Ib3d0f3e8cc05b17c69945594b307d76988a840ea Reviewed-on: https://chromium-review.googlesource.com/890958Reviewed-by:
-
Yutaka Hirano authored
A request with keepalive set should continue working after the associated FetchContext is detached, but no one cares its status after it gets response. With this change such requests will be cancelled. Bug: 764589 Change-Id: I9a5b9de6d658311bab27ab85fee3dea406457488 Reviewed-on: https://chromium-review.googlesource.com/885702Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#532365}
-
Takuto Ikuta authored
/d2Zi+ is replaced by /Zo and /Zo is enabled by default. https://docs.microsoft.com/en-us/cpp/build/reference/zo-enhance-optimized-debugging clang-cl ignores this option. https://github.com/llvm-project/llvm-project-20170507/blob/fdd1e44ea4b98dd1c02d5f2181cca6bbb854aadd/clang/include/clang/Driver/CLCompatOptions.td#L319 Change-Id: I35d24b6d3c5d7e3c3dbd2e0c37f41683b062f650 Reviewed-on: https://chromium-review.googlesource.com/890572Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#532364}
-
Nico Weber authored
Bug: 177475 R=msarda@chromium.org Change-Id: Iab13eae6474e49f9890fc55f9ecf66b4ae11879d Reviewed-on: https://chromium-review.googlesource.com/889724Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#532363}
-
Yuki Shiino authored
This patch removes use of filesystem's FileWriterCallback. The motivation is the same as https://crrev.com/844307 . Bug: 778580 Change-Id: I69866c23290627a84ddedbaceaeae80b584b46e7 Reviewed-on: https://chromium-review.googlesource.com/886762Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#532362}
-
Donna Wu authored
This is a preparation work for MTP servicification. BUG=769630 Change-Id: I4ff39ddf9968ef35328c17b3ffefd6165b85725b Reviewed-on: https://chromium-review.googlesource.com/846659 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#532361}
-
Nico Weber authored
This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 177475 Change-Id: I9bf72aa8640eb2d566687d126e89b0d1c24f2606 Reviewed-on: https://chromium-review.googlesource.com/889729Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#532360}
-
Nico Weber authored
This CL was uploaded by git cl split. R=nhiroki@chromium.org Bug: 177475 Change-Id: Ia487f9629a4b9c129d6361a6720fd9782819ef80 Reviewed-on: https://chromium-review.googlesource.com/890064Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#532359}
-
Nico Weber authored
This CL was uploaded by git cl split. R=tzik@chromium.org Bug: 177475 Change-Id: Ibe37c2986bded10b271c0548b5fe375285504acb Reviewed-on: https://chromium-review.googlesource.com/889946Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#532358}
-
Gauthier Ambard authored
This CL cleans up the SideSwipeView, moving from trailing underscore for ivar to leading underscore. It also moves the ivar declaration from the public header to the private implementation. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4310bbb9a078668d96720fd01111d3522418a7bb Reviewed-on: https://chromium-review.googlesource.com/887201 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL invalidates the layout of the collection view displayed by the NTP (the content suggestions' one) when the frame changes. It allows to have a snapshot with the correct layout when opening a tab from the stack view. Bug: 806069 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2e79a0f9ec72e753d552006f1f31013f51173523 Reviewed-on: https://chromium-review.googlesource.com/888580Reviewed-by:
-
Gauthier Ambard authored
This CL adds the action to focus the omnibox from the omnibox button in the bottom toolbar. Bug: 804717 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id03a2aea1572bb2b23b2aa6733a5cdc1b96ccc33 Reviewed-on: https://chromium-review.googlesource.com/888583Reviewed-by:
-
Nico Weber authored
This CL was uploaded by git cl split. R=alancutter@chromium.org Bug: 177475 Change-Id: I691a0d422f4d22065d4d686be190efaeda0b97d5 Reviewed-on: https://chromium-review.googlesource.com/890065Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#532354}
-
Yoshifumi Inoue authored
This patch adds [HTMLConstructor] IDL extend attribute[1] to interface declaration to following elements to support custom element: - <canvas> - <iframe> - <input> - <video> Note: This is a follow-up patch of the patch[1]. [1] http://crrev.com/888228 Make most HTML elements to support custom element Bug: 805326 Change-Id: Ib2ddf6f3436810df9cafb06f13026375ee4a61e9 Reviewed-on: https://chromium-review.googlesource.com/890570 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#532353}
-
Nico Weber authored
This CL was uploaded by git cl split. R=kinuko@chromium.org Bug: 177475 Change-Id: Idd08baf5677ac2e2c6da37c1a73c9c2dd957ecc9 Reviewed-on: https://chromium-review.googlesource.com/889942Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532352}
-
Christopher Cameron authored
On Mac, the browser's ui::Compositor is always the same size as the renderer's ui::Compositor. In non-viz and non-surface-sync mode, this is done by resizing the ui::Compositor to match the renderer frame size at SubmitCompositorFrame. This isn't suitable anymore, since SubmitCompositorFrame is going away. Change this so that the ui::Compositor is resized to match the surface size, at OnFirstSurfaceActivation. Add a method to DelegatedFrameHostClient to plumb this signal through to the BrowserCompositorViewMac. Also rename WasResized to OnNSViewWasResized, to be more clear. This mechanism works with and without surface synchronization enabled. Bug: 805774 Change-Id: I7a85b2e4eba8c962ef1c67446b38425637fdeb62 Reviewed-on: https://chromium-review.googlesource.com/887966 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532351}
-
Nico Weber authored
R=alancutter@chromium.org Change-Id: Ic7b6bda1eb48346cb0f2f5f285f458023d8eb798 Reviewed-on: https://chromium-review.googlesource.com/889764Reviewed-by:
-
Tetsui Ohkubo authored
MessageListView::SetRepositionTargetForTest just calls SetRepositionTarget internally. We can simply replace all references to SetRepositionTargetForTest by SetRepositionTarget. TEST=ash_unittests BUG=none Change-Id: I3294e2cce6d995585baed3a0ce29dd068e656b20 Reviewed-on: https://chromium-review.googlesource.com/882629 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#532349}
-
Philip Jägenstedt authored
This is a no-op change that makes it easier to later remove them. The copyright license is required to pass presubmit. Bug: 690582 Change-Id: I8f4074102dff3ef87b35d239f06ce2c93246d88d Reviewed-on: https://chromium-review.googlesource.com/693861Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#532348}
-
Takayoshi Kochi authored
This reverts commit 9784fa2f. Reason for revert: crbug.com/806216, potential cause for CSS perf regression (and 3/5-5/5 were already reverted due to crbug.com/805383 and have not relanded). Original change's description: > Remove dead code after multiple shadow removal [2/5] > > Remove > - ElementShadow::YoungestShadowRoot() > - ElementShadow::OldestShadowRoot() > > TBR=mlamouri@chromium.org for media_controls > > Bug: 795221 > Change-Id: I391b737acf04b45978ab1474725314442c979a06 > Reviewed-on: https://chromium-review.googlesource.com/828344 > Commit-Queue: Takayoshi Kochi <kochi@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531452} TBR=kochi@chromium.org,hayato@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 795221, 806216 Change-Id: I123f9da565b8b43cbb808d613c35171321b76c49 Reviewed-on: https://chromium-review.googlesource.com/890842 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532347}
-
Yuzu Saijo authored
This CL moves www.infomoney.br into resource_loading_list because it loads resources continuously, which leads to flakiness. Change-Id: Ib6c974ef3569965aef777f72afe268aa6fc00c73 Reviewed-on: https://chromium-review.googlesource.com/890692Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#532346}
-
Megumi Hattori authored
This CL enable the reply button on the right of the textfield in the inline reply. So, the message in the textfield can be submitted not only by pressing enter key but also clicking the reply button. TEST=message_center_unittests Bug=803759 Change-Id: I6e7518d0fabd329d52d589b2024357869aca2fa2 Reviewed-on: https://chromium-review.googlesource.com/885693 Commit-Queue: Megumi Hattori <megumihattori@google.com> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#532345}
-
Makoto Shimazu authored
This reverts commit b6486594. Reason for revert: speculative revert for fixing browser_tests failure on Win (32) Tests bot. ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked started to fail continuously after the CL. I'm not fully confident of the relationship between the failure and this change, but trying to revert to see if it helps. Original change's description: > Use SCANOUT_* usage in GpuMemoryBufferVideoFramePool > > Currently GpuMemoryBufferVideoFramePool allocates buffers with > GPU_READ_CPU_READ_WRITE usage. This means these buffers won't be used for > scanout (no fb added on CrOS). > > This CL simply changes the usage used when allocating buffers to > SCANOUT_CPU_READ_WRITE, in this way this buffers will be created for > scanout, if possible. > > Note that SCANOUT implies GPU_READ, meaning that in case the allocation > of the buffer for scanout will fail, the buffers will be allocated > exactly as they'd be if GPU_READ_CPU_READ_WRITE were used instead. > > Bug: b/71837407 > Change-Id: I3a03daf721f1cc04038a4f6f91985b5affe2a276 > Reviewed-on: https://chromium-review.googlesource.com/884401 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532286} TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org,ddavenport@chromium.org Change-Id: I13c479543ac53694f6f413c83aa15481e9c80c53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/71837407 Reviewed-on: https://chromium-review.googlesource.com/890978Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532344}
-
nikhil authored
Fixing names of password_manager kEnableHtmlBasedUsernameDetector feature as per the naming convention. Bug: 785953 Change-Id: I8818a2e2335d9a651d02ab9925bd7e4987a661a3 Reviewed-on: https://chromium-review.googlesource.com/878101 Commit-Queue: NIKHIL SAHNI <nikhil.sahni@samsung.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532343}
-
Ricky Liang authored
BUG=None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib3c36ecb62f932b0aa03752732b02f745014e6ea Reviewed-on: https://chromium-review.googlesource.com/890881Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#532342}
-
tanvir.rizvi authored
InsertOrderList command creates a numbered ordered list for the selection. We try to restore the original selection by storing the index of the original start and end positions. There are cases where after list command is applied the index changes, causing wrong selection shown. This CL tries to fix those cases by introducing a TextIteratorBehavior, which suppresses the extra new line added for a <p> tag. Bug: 345935 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8019f6176f859f4d2c19030e08e1836b1f05a27d Reviewed-on: https://chromium-review.googlesource.com/850252 Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532341}
-
Makoto Shimazu authored
This reverts commit c70ba0e8. Reason for revert: The original CL caused failures of AnimationPlayerTest.SwitchToLayer on Linux CFI bot. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AnimationPlayerTest.SwitchToLayer&testType=cc_unittests Original change's description: > Group effects support in cc::AnimationPlayer > > The current cc/animations logic assumes a single animation has a single > keyframe effect and can only affect a single layer. To enable animations > with multiple keyframe effects, cc::AnimationPlayer need to support > multiple AnimationTickers each corresponding to one keyframe effect. > > Currently there is a 1:1 relationship between AnimationPlayer and > AnimationTicker. This patch is to extend it to 1:n. Here is a summary of > changes: > - Introduce a sub-class of AnimationPlayer, a.k.a > SingleTickerAnimationPlayer, to handle the existing logic (single > effect). SingleTickerAnimationPlayer owns only one AnimationTicker as > the AnimationPlayer does today. > - Currently a AnimationTicker is created upon creating AnimationPlayer. > In this patch, tickers are created separately and added to the player > afterwards. Tickers that the player owns may belong to different targets > therefore the player needs to coordinate with AnimationHost regarding > this situation. > - Adjust existing unit tests according to the changes above. > > Bug: 767043 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: Ibd2ed2f396effec9fbc206ff52c7b94474342d39 > Reviewed-on: https://chromium-review.googlesource.com/742162 > Commit-Queue: Yi Gu <yigu@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532244} TBR=vollick@chromium.org,flackr@chromium.org,majidvp@chromium.org,yigu@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 767043 Change-Id: I7547dfad1e8835d1218b2c704ba1ee69a09544a8 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/890918Reviewed-by:
-
Matt Falkenhagen authored
This uses promise_test for each test case instead of an all-or-nothing result, which makes the test easier to extend and debug. It also adds more explanatory comments. R=horo, shimazu Bug: 780435 Change-Id: I3ac77448cd19e66b9db806e6b8b5530857713c6c Reviewed-on: https://chromium-review.googlesource.com/890694 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#532339}
-
Nico Weber authored
This CL was uploaded by git cl split. R=kouhei@chromium.org Bug: 177475 Change-Id: I09a969c86b5250e6104caf8b0d7ba1672425a8d3 Reviewed-on: https://chromium-review.googlesource.com/889945 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#532338}
-
Hajime Hoshi authored
Now it is assured that all the tasks in a task runner are executed before the task runner is deleted, it is no longer needed to set the default timer task runner when shutting down the document. This is part of efforts to replace non-per-frame task runners with other appropriate per-frame task runners in the renderer. Bug: 804694 Change-Id: I03150b0412df185f2d61abfd8dcab44bfbdc2a12 Reviewed-on: https://chromium-review.googlesource.com/885691Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Hwanseung Lee authored
values attribute should be immutable to prevent cyclic references in CSSMathMax, CSSMathMin, CSSMathProduct, CSSMathSum. Bug: 803687 Change-Id: Ibb93165ffd7a279a80febba0543ac186b67dbe56 Reviewed-on: https://chromium-review.googlesource.com/890558Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#532336}
-
