- 09 Oct, 2019 40 commits
-
-
Moe Ahmadi authored
Swaps the existing implementation with one that queries the keyword search terms table in the in-memory URLDatabase instead of the URLs table. - This table is smaller so querying it is likely faster. - The step to parse URLs is avoided. - Is more consistent with how SearchProvider offers local search history matches. Also improves and re-enables LocalHistoryZeroSuggestProviderTest.Delete which was failing for Linux ChromiumOS MSAN, likely due to using an uninitialized |history_db_task_id_| which no longer exists. Bug: 996516,1010944 Change-Id: I183fb7367285dcb453fb42e46651550baf0e3036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835182 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#704062}
-
Jinho Bang authored
This is a spec match-up with[1] [1] https://github.com/gpuweb/gpuweb/pull/459 Bug: 877147 Change-Id: I080324cbb083160ae84aa109623e311f24a875cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845132Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#704061}
-
Tim Song authored
Each pop-up is contained in its own Widget, which we need to add to ash's FocusCycler. TEST=manually verified BUG=1007027 Change-Id: I330465bc4a63c5ac26951b8bebfb2ee7f2700327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832669 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704060}
-
Miyoung Shin authored
This CL removes Authenticator from the frame registery in chrome_content_browser_client.cc because this mojo interface for Java is already bound in browser_interface_binders.cc, and rename ForwardToJavaFrameRegistry and BindAuthenticatorRequest. Bug: 936482 Change-Id: Iee29077fa23b05e2369d08217c7327271946e845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844515 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704059}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I415a9d2f64f326797876998fd9bdd5f28c14b84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849132Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704058}
-
Robert Sesek authored
The framework is bundled within the .app, but none of the dependent shared libraries created by the component build are. Those need to be expressed as runtime dependencies of the framework, and by extension the app. But GN does not propagate that across the create_bundle rule so it must be done manually. Bug: 1010347 Change-Id: If4b08329c97e7ef5b0e5073fbb26252b922c50a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846075 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#704057}
-
Julie Jeongeun Kim authored
This CL converts SelectFileDialogRequest and SelectFileDialogPtr to new Mojo types using PendingReceiver, Remote and SelfOwnedReceiver. Bug: 955171 Change-Id: I776fe70be72a02ba451324b6ff0c9b436e8ff56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846633Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
Patrick Monette authored
This is a reland of 7c390807 The fix for the issue that caused the revert is here: https://chromium-review.googlesource.com/c/chromium/src/+/1835164 Original change's description: > [PM] Add SharedWorkerWatcher > > This class observes running shared worker instances, keeps track of > the connection to their client frames and manages the lifetime of > worker nodes in the Performance Manager graph. > > Bug: 993029 > Change-Id: I2e0c7cd9f194a06405293c22fd543a14ff3c6cbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757283 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701445} Bug: 993029 Change-Id: Ib77ea36b9cc71ec83ccbe28173fc6053e4a497f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829796 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704055}
-
Nicholas Hollingum authored
X11 applications have two common ways of bringing their windows to the user's attention: sending NET_ACTIVE_WINDOW and setting the urgency flag in NET_WM_HINTS. These tricks are used by applications to, e.g. refocus their windows when the user opens a file in an already-running app. In crrev.com/c/1824398 we add support to sommelier to identify these requests. We must now add a method to the aura protocol so that we can communicate the request to chrome. For the time being the request will do nothing, as we are awaiting UX input on how to respond to the request. Bug: 899587 Change-Id: I0e8b6e639a389055b6e2adbaeb77d0881dd2c18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824726 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#704054}
-
Nicholas Hollingum authored
Two main changes - Removed "uninstall" from the terminal's menu, which previously would uninstall crostini. This must now be done via settings. - Fixed "uninstall" for shelf apps, which previously did not work. Bug: 1009925 Change-Id: Icba200b4ed054a09a8fe1c5d777362cf353438d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846631 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704053}
-
Dmitry Gozman authored
Previews state change with a new document load, so it's natural to host this state in the DocumentLoader (as opposed to frame). Drive-by: removed unused LocalFrame::IsUsingDataSavingPreview(). Bug: none Change-Id: Icbb7a335c456ca32c5b0e30f7dfd8ad7c329423d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844431Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704052}
-
Lindsay Pasricha authored
Bug: 1012488 Change-Id: Ie6a758ea7e90d8f023c9dfc766737e20996157bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848791Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#704051}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8955c8337fc..955a6a3e261a Created with: gclient setdep -r src-internal@955a6a3e261a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4492f166061ba948f6d4ca1b3be684235813942f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848457Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704050}
-
Dan Beam authored
Bug: 1003210 Change-Id: I89ed4851798663207098743fd551a378fbd1060b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834231Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704049}
-
Dana Fried authored
toolbar. This eliminates a lot of complicated math in favor of just finding the offset of the child (bookmarks bar, toolbar) into the background image and painting the view background. Bug: 993502 Change-Id: I0502a1468abfe50ea919de863244f0bd5558d4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847775 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704048}
-
Marina Sakai authored
Return different functions with the same behavior between cross-origin access and same-origin access for data properties According to the spec (test), when a data property of cross-origin properties is called, different functions with the same behavior should be returned between cross-origin access and same-origin access. However, completely the same functions via the same function template are returned currently. This CL fixes the gap by using a different template for each. Bug: 715418 Change-Id: Ibb410999e87547ead088a49f86274150783724a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846620Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
nancy authored
This CL is used to move RecordActiveHistogram and RecordOpenHistogram from src/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h to AppService. BUG=1005640 TBR=xiyuan@chromium.org Change-Id: I682184ebd2fe5ae9d672e54de91bb9b5436992c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816495 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704046}
-
David Vallet authored
Bug: 1008331 Change-Id: Iea56e04c43bfb3418951701d7b9e903a609d2be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847702Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#704045}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ed44674b. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." af04c51f "css-flexbox: updates special case for flex-box emulating webkit-box" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Icc8886b1fb0a3f716376dbe12d390f1ad2b7ca0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848615Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704044}
-
Dana Fried authored
This replaces the separator normally drawn on the toolbar or bookmarks bar with a standard(ish) separator view. Still to do: - Simplify BrowserView and BrowserViewLayout - Add Webby UI separator - [Re]start A/B test (but safe for Beta/Stable) Bug: 993502 Change-Id: If2f617281cab4f8db63d613dbe2176b7022b0a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845600 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Julian Watson authored
Change-Id: I06110b752a105f4d7bd0d6ba9b38d62b49370a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839933 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
-
Brandon Wylie authored
The text is animating over the status icon because there's no check to prevent it from happening. Adding that explicit check here fixes the problem. Bug: 1011403 Change-Id: I2d46b3a12eeced9108c8b0e5b2382f48e6523dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845936Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704041}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cef11fda71f6..be83c310e3d5 git log cef11fda71f6..be83c310e3d5 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 ehmaldonado@chromium.org git-hyper-blame: Make tests run on Python 3. Created with: gclient setdep -r src/third_party/depot_tools@be83c310e3d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1009809 Change-Id: Ib625d4372f0512f92a2d13597b8ec490b61283f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848456Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704040}
-
Joel Hockey authored
TBR=ellyjones@chromium.org Bug: 1012169 Change-Id: I66512bdab46358e96bbcf90e3fd056bc8468bdea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847704 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#704039}
-
Rob Paveza authored
By presenting an interstitial dialog (like Ctrl+P), keyboarding users might get to a point where they can't put focus back into the styles pane. This is because tabIndex is set to -1 for all of the style blocks. Typically, losing focus causes the styles list to reset the first style block to tabIndex=0, but only if the style container doesn't already have focus. Because of an event ordering issue, the styles still have focus before the interstitials receive focus. This change allows the styles tree elements to reset the styles when they lose focus. Bug: 963183 Change-Id: I227c48fd88dbe46bbebc982b0c6e10232769d860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842521Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704038}
-
Hiroki Nakagawa authored
CompositorWorker API was already removed in favor of AnimationWorklet API. Bug: 746212 Change-Id: I6e7fcfbeb4a0967442081a9f8a6eff6d39e1d85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847462Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#704037}
-
Nicholas Hollingum authored
This change works by keeping track of a requested removal time and fading out the spinner over that duration. This is a continuation of crrev.com/c/1830254. The external API of this class is preserved, w.r.t. HasApp() calls and the like, but internally the controller will only actually evict its items once the fade-out animation has completed. Bug: 922977 Change-Id: Ief07b33157403d2141187558dabd866a7ebbbd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837323Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#704036}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d01ae535b36c..7de9f95df905 git log d01ae535b36c..7de9f95df905 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 efoo@chromium.org Add COMPONENT and TEAM information in OWNERS file Created with: gclient setdep -r src/third_party/angle@7de9f95df905 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:977050 Change-Id: I02d9a5607be907ca865993370f10d2a1602768ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848455Reviewed-by:
-
John Delaney authored
This CL adds a boolean histogram that records true if an intervention did not occur due to being over the per-origin limit of the heavy ad intervention. This metric is important to monitor what percent of interventions are lost due to the imposed limits. Bug: 1012440 Change-Id: I28d5abaac8af3e80732478a5f2ca529ee7993520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846318 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#704034}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e7bc8cf04b5..5eaaf59c1774 git log 4e7bc8cf04b5..5eaaf59c1774 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-08 lamontjones@chromium.org config: update configs to reduce skew. 2019-10-08 zamorzaev@chromium.org cbuildbot: Respect disabling HWTests. 2019-10-08 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@5eaaf59c1774 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iddcaa87725b2bd3f8771a1cb8977071fd6ab5100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848458Reviewed-by:
-
Rohit Rao authored
BUG=934252 Change-Id: Icf5009055afa0b4d83ece18022746c5bd373aafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848771Reviewed-by:
-
Nancy Wang authored
This reverts commit ae4de2d6. Reason for revert: <INSERT REASONING HERE> Original change's description: > Update uninstall dialog heading from Remove to Uninstall. > > Currently, the uninstallation dialog head text is inconsistency for the > ARC apps and extension apps. ARC apps use Uninstall, and Remove for the > shortcut only, because for the shortcut, ARC apps use the extension > apps' IDS_EXTENSION_UNINSTALL_PROMPT_HEADING. Per request from the bug, > change the head text from Remove to Uninstall, and remove the quotes. > Linux apps use Uninstall as well, so I think Uninstall sounds better. > > BUG=1010303 > TBR=rdevlin.cronin@chromium.org > > Change-Id: I0e939943c37c295ebe2c8a73824c235420a98195 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844756 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704004} TBR=rdevlin.cronin@chromium.org,dominickn@chromium.org,nigeltao@chromium.org,nancylingwang@chromium.org Change-Id: I4a037d6c8fc2141bc6fac60c78550d5583f734e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847465Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704031}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/139e88015cb5..df2726ee7a36 git log 139e88015cb5..df2726ee7a36 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 jcgregorio@google.com Revert "Another attempt to fix vpython in Cloud Build." 2019-10-08 robertphillips@google.com Add GrRenderTask and GrOp prePrepare framework Created with: gclient setdep -r src/third_party/skia@df2726ee7a36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:993053 Change-Id: Ic60725d041f89df912fb4562ba8e2922339aa849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848544Reviewed-by:
-
Rakina Zata Amni authored
Bug: 1011694 Change-Id: If6610901703899d0f54aa44fdcc4cacb7fdb434d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846891Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#704029}
-
Julie Jeongeun Kim authored
This CL converts SpellCheckPanelRequest and SpellCheckPanelPtr in spellcheck_panel.mojom using PendingReceiver, ReceiverSet, and Remote. Bug: 955171 Change-Id: I145e80e71f152f6ac621299d5c2918bf174a8614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845131Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704028}
-
Kenneth Russell authored
Should be passing now that ANGLE has rolled forward. Tbr: jdarpinian@chromium.org Bug: 1011653 Change-Id: Ib889a711406026d7742b912b72a074ac96890966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848547Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704027}
-
Stefan Zager authored
Change-Id: I462d24c87b55710ceb1981833648545198449522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848414Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#704026}
-
Mounir Lamouri authored
In practice, it means: - https://www.example.com => example.com - http://www.example.com => example.com - https://m.example.com => m.example.com Bug: 1011900 Change-Id: I9713dd22693e35c67ecdebdca67f4642442d2c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846472Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6e9395c6b785..e1092c0bc8b8 git log 6e9395c6b785..e1092c0bc8b8 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a78cc9b4..b2d00427 (703818:703937) Created with: gclient setdep -r src/third_party/webrtc@e1092c0bc8b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ibd75fcaa785ba3fd7988a9aa2c74da3a214fef62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848499Reviewed-by:
-
John Lee authored
This updates the pinned tabs' dimensions to be dependent on the variable that controls an unpinned tab's height to prevent their dimensions from becoming out of sync when an unpinned tab's size changes. https://imgur.com/a/48J3hJF Bug: 989131 Change-Id: Ibfd7e45550a4d0490a28878c0d13884cf90f86bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848057 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#704023}
-
