- 28 Jan, 2019 40 commits
-
-
Ben Mason authored
This reverts commit 200a953f. Reason for revert: Breaking official build due to APK merge. Original change's description: > Make sure unwind tables are added for 32 bit libraries in arm64 monochrome > > The assets were not added since we checked "can_unwind_with_cfi_table" > value, which depends on "build_secondary_abi" build arg. So, explicitly > add the asset for 64-bit monochrome apk, which contains 32 bit library. > > BUG=924842 > > Change-Id: I6488d5c4e5a80787735c5b09134b013a87b5c553 > Reviewed-on: https://chromium-review.googlesource.com/c/1432836 > Commit-Queue: ssid <ssid@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625789} TBR=ssid@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 924842 Change-Id: Ic8e542cc1cf52f24b7866c1620ac764bf2f92672 Reviewed-on: https://chromium-review.googlesource.com/c/1439074Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#626505}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=emaxx@chromium.org Bug: 925652 Change-Id: Iee7db9c383552ba51ff2a72c4c05f707ae3dba64 Reviewed-on: https://chromium-review.googlesource.com/c/1438381 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#626504}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 925652 Change-Id: I445f4f95d8a656e531fe96b8dfa42fef9ea7728d Reviewed-on: https://chromium-review.googlesource.com/c/1438290 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#626503}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=emaxx@chromium.org Bug: 925652 Change-Id: I1f3436a182d6047e8b2989835df355c1a14880c6 Reviewed-on: https://chromium-review.googlesource.com/c/1437342 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d67f15701b39..cd3ac65a2361 Created with: gclient setdep -r src-internal@cd3ac65a2361 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:803846,chromium:803846,chromium:916292,chromium:916292 TBR=mmoss@chromium.org Change-Id: Ib07172c81af7aec1856e16b6b4c11d2b86be792e Reviewed-on: https://chromium-review.googlesource.com/c/1439054Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626501}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: I443f2f1fde84edc612efe505d837a25144f0496e Reviewed-on: https://chromium-review.googlesource.com/c/1437191 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#626500}
-
Oleg Davydov authored
ShouldBlockRequestForFrame method of URLBlacklistManager was removed a long time ago, but its definition persists. However, it's not needed and therefore should be removed. Change-Id: If2654066256afd35c90b0bf0e1b4d3615356b193 Reviewed-on: https://chromium-review.googlesource.com/c/1436051Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#626499}
-
Mohamed Amir Yosef authored
The default implementation in the base class ModelTypeSyncBridge should be sufficient. Bug: 903249 Change-Id: I4c755be07240b979e16a989f06b439449b26312f Reviewed-on: https://chromium-review.googlesource.com/c/1437188 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Lowell Manners authored
Reverting this, it looks like it caused some Andriod trybots to fail due to an invalid cast. This reverts commit 05caea21. TBR=droger@chromium.org Bug: 907782 Change-Id: I57e11af47c3bfbdb79faae2aa9f52742c49be411 Reviewed-on: https://chromium-review.googlesource.com/c/1437631Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626497}
-
Jiajia Qin authored
Bug: 859249 Change-Id: I852f2f4c72883302d953ea694e8b80c89a2eef2f Reviewed-on: https://chromium-review.googlesource.com/c/1420273Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#626496}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: I4b01ff184fc57d68a7944421aaace1d475df89a7 Reviewed-on: https://chromium-review.googlesource.com/c/1437184 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Christian Dullweber authored
LocalStorageInfo doesn't have any interesting additional data compared to StorageUsageInfo so we can replace it with the more generic class. Change-Id: Ibb924349a2eaf5f571ea3fdf244de2ec638c575c Reviewed-on: https://chromium-review.googlesource.com/c/1433765Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#626494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/834c3ddbba12..d67f15701b39 Created with: gclient setdep -r src-internal@d67f15701b39 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibc171889042a2a3e590fc3dea2c7ef9eb9b785f7 Reviewed-on: https://chromium-review.googlesource.com/c/1438845Reviewed-by:
-
Robbie McElrath authored
When ExternalFileURLLoader gets an error when reading data from disk, it handles the error, and then tries to continue copying data. This makes it stop when it encounters an error. Bug: 925565 Change-Id: I61938040c485ecd7e607363366433532281547e0 Reviewed-on: https://chromium-review.googlesource.com/c/1437706Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#626492}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b0397d69a93a..f380284035bd git log b0397d69a93a..f380284035bd --date=short --no-merges --format='%ad %ae %s' 2019-01-26 steveanton@webrtc.org (7) Rename files to snake_case: remove forwarding headers 2019-01-26 Peter) Slatala Only create no-op DTLS if media transport is used for both media and data 2019-01-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 33436180..334d413a (626126:626249) 2019-01-25 mbonadei@webrtc.org Remove rtc_base/scoped_ref_ptr.h. 2019-01-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6a5b2b19..33436180 (626014:626126) 2019-01-25 ouj@fb.com Check "rtc_include_internal_audio_device" before creating unittest for audio_device_ios_objc 2019-01-25 Peter) Slatala Do not modify media transport config when falling back to RTP 2019-01-25 terelius@webrtc.org Don't attempt to unwrap RTP timestamps for RTX stream. 2019-01-25 nisse@webrtc.org Delete leftover method MaxConfiguredBitrateVideo and member remote_ssrc_ 2019-01-25 srte@webrtc.org Improving robustness of stable bandwidth estimate test. 2019-01-25 nisse@webrtc.org Delete unused method SetSelectiveRetransmissions 2019-01-25 titovartem@webrtc.org Fix initialization to prevent SIGSEGV 2019-01-25 ilnik@webrtc.org Revert "Always use real VideoStreamsFactory in full stack tests" 2019-01-25 guidou@webrtc.org Make webrtc::ParseCandidate() public. 2019-01-25 gustaf@webrtc.org AEC3: Remove unused kill-switches from AdjustConfig 2019-01-25 oprypin@webrtc.org frame_analyzer: exit with status 1 when video files fail to open 2019-01-25 kron@webrtc.org Make sure lost packets are removed from FakeNetworkPipe. 2019-01-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b483b4fc..6a5b2b19 (625914:626014) 2019-01-25 gustaf@webrtc.org AEC3: Remove legacy render buffering 2019-01-25 nisse@webrtc.org Delete constant RTP_PAYLOAD_NAME_SIZE 2019-01-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision eedb2069..b483b4fc (625788:625914) 2019-01-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3432970f..eedb2069 (625619:625788) 2019-01-24 titovartem@webrtc.org Introduce VideoQualityAnalyzerInjectionHelper. 2019-01-24 nisse@webrtc.org Reland "Delete RtpUtility::Payload, and refactor RTPSender to not use it" 2019-01-24 philipel@webrtc.org Turn off automatic quality scaling for simulcast in video_loopback. 2019-01-24 srte@webrtc.org Allow repeated feedback packets in log parser. 2019-01-24 eladalon@webrtc.org Add RTC event logging of LossNotification RTCP messages 2019-01-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1aa6cb92..3432970f (625210:625619) 2019-01-24 sakal@webrtc.org Override default manifest from Chromium in WebRTC. 2019-01-24 ssilkin@webrtc.org Handle zero number of spatial layers at calculation of VP9 SVC padding. 2019-01-24 eladalon@webrtc.org Create new RTCP feedback message - LossIndication 2019-01-24 oprypin@webrtc.org Revert "Roll chromium_revision 1aa6cb92..faaba5b0 (625210:625596)" 2019-01-24 titovartem@webrtc.org Revert "Delete RtpUtility::Payload, and refactor RTPSender to not use it" 2019-01-24 brandtr@webrtc.org Negate flag name for prerender smoothing and update comments. 2019-01-24 mbonadei@webrtc.org Remove deprecated code from audio device. 2019-01-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1aa6cb92..faaba5b0 (625210:625596) 2019-01-24 titovartem@webrtc.org Introduce QualityAnalyzingVideoEncoder and QualityAnalyzingVideoDecoder. 2019-01-24 nisse@webrtc.org Delete RtpUtility::Payload, and refactor RTPSender to not use it 2019-01-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1cac36a7..1aa6cb92 (624101:625210) 2019-01-24 amithi@webrtc.org Moving UniqueIdGenerator into rtc_base. 2019-01-23 thomasanderson@google.com Prevent mac_framework_bundle configs from getting reset 2019-01-23 amithi@webrtc.org Fixing snake_case files that were renamed in PRESUBMIT.py 2019-01-23 sprang@webrtc.org Fix potential race in CallTest. 2019-01-23 sprang@webrtc.org Move simulcast hysteresis factor parsing to RateControlSettings 2019-01-23 orphis@webrtc.org Use EncoderSimulcastProxy for all codecs 2019-01-23 nisse@webrtc.org Make UlpfecReceiverImpl use rtc::TimeMillis, not Clock::GetRealTimeClock 2019-01-23 sprang@webrtc.org Move parsing of trusted rate controller to RateControlSettings 2019-01-23 srte@webrtc.org Introduces common AudioAllocationSettings class. 2019-01-23 danilchap@webrtc.org Publish task queue test suite. Created with: gclient setdep -r src/third_party/webrtc@f380284035bd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:683094,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:923477,chromium:922656,chromium:923330,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:924121,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I44f9ddf16048f7ccbe8ebadc0152955be094818c Reviewed-on: https://chromium-review.googlesource.com/c/1438876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626491}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=grt@chromium.org Bug: 925652 Change-Id: If5a0980fbf3dc29db5129f7abd42d8ed623398a2 Reviewed-on: https://chromium-review.googlesource.com/c/1438384 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#626490}
-
Friedrich Horschig authored
Next to suggestive and input chips, there are assistive chips which perform more sophisticated actions (like autofilling the whole page). This CL doesn't change: - input chips (e.g. in accessory sheet) - suggestive chips (e.g. in Downloads header) This CL adds: - styles for assistive chips - a secondary text used in assistive chips - a consumer (autofill chips) using assistive chips Minor fix: - RTL support for accessory sheets (wrong padding uncovered by this CL) - allow setting untinted icons Autofill suggestions before this CL: https://photos.app.goo.gl/9GxKMy4oeCyKcbgY9 Autofill suggestions with this CL: https://photos.app.goo.gl/5qPEdXWbA4jxbyVZ6 Autofill suggestions with follow-up (using secondary text and icons): https://photos.app.goo.gl/nMVp3jxnGULSLLtd7 Autofill chip mocks: http://slides/1f8LgG2PgUTXJWgXSO2Y9yOhYDKTmkGv1f27_KYb7ICQ#slide=id.g4c6efbd9b1_0_51 Bug: 853772 Change-Id: I08b2f22c77f21376b998188da145c63c188befb9 Reviewed-on: https://chromium-review.googlesource.com/c/1430012 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#626489}
-
danakj authored
Instead of applying it after using the device scale factor, move the application to the top of OnSynchronizeVisualProperties() so that it is used unconditionally and throughout the entire method. R=dcheng@chromium.org Change-Id: Icf3fc4b5af3141671f49bf35916469e98cec06c8 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1436490 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#626488}
-
Maksim Sisov authored
Use display::FindDisplayWithBiggestIntersection to find a display with biggest intersection with the specified rect. If no display found, return a default display with invalid id. Bug: 875161 Change-Id: I585c3c23daba8ff0c2c58bc94f074fff6783a2d7 Reviewed-on: https://chromium-review.googlesource.com/c/1430002 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#626487}
-
Marc Treib authored
Bug: none Change-Id: I0d9651396226a6fb7f82a73b23c5e4a151eff26f Reviewed-on: https://chromium-review.googlesource.com/c/1436236 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Fixes emoji subdivision flag rendering when fallback is needed to find the emoji font that covers subdivision flags. Fixes conflicts between Chromium and HarfBuzz' preferences for compiler warnings configuration by using HarfBuzz' new HB_NO_PRAGMA_GCC_DIAGNOSTIC_WARNING define which avoids overriding Chromium's -Werror. Rebaselines due to a change in fallback mark positioning centering marks at the middle of the advance width instead of the middle of the ink rectangle. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/36fb2b4da971..f60282c5bff4 $ git log 36fb2b4da..f60282c5b --date=short --no-merges --format='%ad %ae %s' 2019-01-24 behdad More pragma control 2019-01-24 behdad Comment 2019-01-24 behdad Fix test 2019-01-24 behdad Form cluster for Emoji sub-region tag sequences 2019-01-24 behdad Fix macos tests with previous commit 2019-01-24 behdad Adjust mark offsets when zeroing from fallback mark positioning code Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org,thakis@chromium.org Bug: 924848, 907385 Change-Id: I9427ea4255bd3afc02c9adffc80810520caefb33 Reviewed-on: https://chromium-review.googlesource.com/c/1434277Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#626485}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=grt@chromium.org Bug: 925652 Change-Id: I244fe5e2b7d7dbbf9bd14c2bcf0f7862c71b8788 Reviewed-on: https://chromium-review.googlesource.com/c/1438259 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 925652 Change-Id: If24a3cab76df609b0452d6bf785d4c42f4ff67c9 Reviewed-on: https://chromium-review.googlesource.com/c/1437823 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#626483}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=mastiz@chromium.org Bug: 925652 Change-Id: I1fd7cc06e0a0cb6c4a083316df9eecafbdbfcc8c Reviewed-on: https://chromium-review.googlesource.com/c/1438330Reviewed-by:
-
Hiroki Nakagawa authored
This finally gets rid of content/common/shared_worker/ directory. Bug: 911415 Change-Id: I57c272dce17ddbfb8799c5bac68f611e5b9b386e Reviewed-on: https://chromium-review.googlesource.com/c/1438796 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626481}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 925652 Change-Id: I0dbcf574eaa0c466dfcd3db3c083fac7ef9ab53c Reviewed-on: https://chromium-review.googlesource.com/c/1438366 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626480}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 925652 Change-Id: Id0b5da9e630ff7363e5ec335b7070fa63f5a3a9e Reviewed-on: https://chromium-review.googlesource.com/c/1438389 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
We used to store ComputedStyle in NodeRenderingData temporarily between style recalc and layout tree building as non-attached-style. After layout tree attachment, we would have to look up ComputedStyle from the LayoutObjects. Additionally, for element which were not rendered like elements styled with display:none or display:contents, we would store ComputedStyle in ElementRareData. This CL changes that to persist ComputedStyle in NodeRenderingData both when rendered with a LayoutObject, or display:content, or when ensured from getComputedStyle in display:none subtrees. There are a few reasons for doing this: * We don't want to store ComputedStyle in two different place in Element. * For LayoutNG and Houdini, we might not have LayoutObjects to pull the ComputedStyle from. * Changing the display property of a subtree root should not cause a full style recalc of the subtree if only that root display type is the only style change. * We got the possibility to move ComputedStyle/animation/recalc dependencies out of AttachLayoutTree methods in this CL. In addition to store the ComputedStyle in a single place in Element, we make the following changes: 1. New nodes are now style clean per default, and all nodes are style clean before layout tree building. Instead of requiring a full style recalc traversal of the whole subtree when inserting a subtree, we mark the root with kLocalStyleChange and skip recalc of display:none subtrees in the following recalc. 2. Made StyleRecalcChange a class instead of an enum to separate style recalc propagation and the need for layout tree reattachment. 3. Style recalc now happens down the flat tree which means we got rid of the hack of marking shadow host children dirty for inheritance through slots. Bug: 914784 Change-Id: I55a9ac7b4e3bbf0b23c78f10941dfb2a86e1bb88 Reviewed-on: https://chromium-review.googlesource.com/c/1323555 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#626478}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 925652 Change-Id: I93fc68a67fcc5df2c1547465fe5bed33eeb2868e Reviewed-on: https://chromium-review.googlesource.com/c/1437826 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 925652 Change-Id: Ic9d36d670eb64d6e13c89f2d9b785715752b6428 Reviewed-on: https://chromium-review.googlesource.com/c/1437350 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#626476}
-
Marc Treib authored
TBRing trivial test call site updates TBR=sebsg,vasilii Bug: none Change-Id: I555fb199aa9fd7391dcd557659e19f7cd1edc1a1 Reviewed-on: https://chromium-review.googlesource.com/c/1436237 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d1214aeb988..834c3ddbba12 Created with: gclient setdep -r src-internal@834c3ddbba12 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If1d60b6c44326b0f36f8750a96ab5959b0b59233 Reviewed-on: https://chromium-review.googlesource.com/c/1438878Reviewed-by:
-
Gauthier Ambard authored
This CL reorganizes the Settings directory, moving the Clear Browsing Data files to their own directory as the directory has too many files. Bug: 925357 Change-Id: I29533c3ea27c98b59ac95e6064eff6a55de173de Reviewed-on: https://chromium-review.googlesource.com/c/1437178 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#626473}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/media/webrtc/webrtc_event_log_manager_common_unittest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 925652 Change-Id: I9e896043df954dc48b883eb78b1f0bbe6ab97558 Reviewed-on: https://chromium-review.googlesource.com/c/1437832 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL splits EmbeddedSharedWorkerStub::WorkerScriptLoaded() into WorkerScriptLoaded() and WorkerScriptEvaluated(), and make them called in appropriate places. Before this CL, WorkerScriptLoaded() is called after EvaluateClassicScript(). This is strange. Literally WorkerScriptLoaded() should be called immediately after script fetch, not after script evaluation. This stems from that the function does 2 things: 1) notifying the completion of script fetch, and 2) dispatching connection requests on SharedWorkerGlobalScope. 2) is required to be called after script evaluation on the worker thread, so the call timing of the function is delayed until that. Bug: 924041 Change-Id: I09aa947696e5b0d77373f7feee9fbb3768b28a73 Reviewed-on: https://chromium-review.googlesource.com/c/1438755Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#626471}
-
Mathias Carlen authored
Before this patch we initialized AA and its UI via the webContents from the currently active tab. A current tab is not immediately set and we were using a null webContents object. This patch uses the existing tab instead of a "current" tab instead. AA no longer crashes when a payment request UI is shown. Bug: 806868 Issue: b/123338819 Change-Id: Ibf14792b43dcd317f99236bc5368215de8f9f4c1 Reviewed-on: https://chromium-review.googlesource.com/c/1437077Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#626470}
-
Darren Shen authored
We currently have several tast integration tests that test the VK under real devices. However, in rare cases, the VK doesn't show up and it's not clear why. One route of investigaiton is to first determine whether the issue is due to C++ or JavaScript. We put an error log when there's a lingering state. If we linger in LOADING_EXTENSION, that probably means it's a C++ issue, as the extension should load in under 5s (if the extension has a runtime error, it also counts as "loaded"). If we don't linger, then it means the extension is not resizing the keyboard window. Bug: 879073 Change-Id: I60945fd1f5c2dd8284c0ea416b4127e12a9d394c Reviewed-on: https://chromium-review.googlesource.com/c/1436277 Auto-Submit: Darren Shen <shend@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#626469}
-
Sara Kato authored
Android side change ag/5900087 Bug: b/121359095 Change-Id: I2a1e95909429556fa47dcfbc123b1b9ec73a5147 Reviewed-on: https://chromium-review.googlesource.com/c/1391651Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#626468}
-
Takashi Toyoshima authored
In HandleResponseHeader(), we checked net::HttpResponseHeader's existence, but we should do the same check even in CreatePreflightResult(). Bug: 925380 Change-Id: I9b93d52b595dd066ac325a4b41139fe04abaa8b7 Reviewed-on: https://chromium-review.googlesource.com/c/1438856Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#626467}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/webrtc_logging_private. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=grunell@chromium.org Bug: 925652 Change-Id: I02e600e50b04228866f1b2cc050d57158779bc95 Reviewed-on: https://chromium-review.googlesource.com/c/1438379 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626466}
-
