- 16 Jan, 2020 40 commits
-
-
Oriol Brufau authored
Change-Id: I0059ca822f3d492be3d8175c8ea0e2fe51fa2cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932367Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#732361}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug:chromium:1042632, chromium:878390 Change-Id: I1fe537eb6181f2c0ed2e217cfd4e86e9719a0e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989079 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732360}
-
Md. Hasanur Rashid authored
This change enforces returning of one AccountInfo based on unconsented primary account from signin_ui_util::GetAccountForDicePromos(). Bug: 1006167 Change-Id: I46dbd8e307210f80b1fe3e9e8539ff026f137334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991043 Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#732359}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/52ccb5e5b6e7..6ca908f48c88 git log 52ccb5e5b6e7..6ca908f48c88 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 phoglund@webrtc.org Shorten the fir filter adapt test quite a bit. 2020-01-16 danilchap@webrtc.org Delete RtpDepacketizer interface as no longer used Created with: gclient setdep -r src/third_party/webrtc@6ca908f48c88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I36531911651bec5c6f5a964d53e36d0b44733a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004495Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732358}
-
Anton Bikineev authored
Unmarking phase must be called before major GC to clear all mark bits. Design doc: https://bit.ly/2ZXGU20 Bug: 1029379 Change-Id: Ifcfa4af9710f72b9bdea24e89c2c613d0f34eaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003308 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732357}
-
Raul Tambre authored
Works on both Python 2 and 3. There should be no behavioural changes. Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 210, in _GenerateModule salt = ''.join( TypeError: sequence item 0: expected str instance, bytes found Bug: 941669 Change-Id: Ie77d9fd53f9f0077f07bbbe6e22ed2a565d2c3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995398 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#732356}
-
Michael van Ouwerkerk authored
Also not subtract the ack time from the timeout received by SendMessageToDevice to generate the TTL, that seems like unexpected behavior that might reduce send message reliability. Bug: 1042242 Change-Id: I30e14d3f0c3ef10ecf76e5f46c7a9bc8e38e7290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002574Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732355}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/363ca672af34..1039ef14d7ad git log 363ca672af34..1039ef14d7ad --date=short --first-parent --format='%ad %ae %s' 2020-01-16 skyostil@google.com Merge "Enable -Wpedantic to improve GCC compatibility" Created with: gclient setdep -r src/third_party/perfetto@1039ef14d7ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8af3a848ae5fafef30805693979bf6e51d26b6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004494Reviewed-by:
-
sandromaggi authored
Before this change, texts like "<link0>Click</link1>" would hard-crash with "java.lang.IllegalArgumentException: Input string is missing tags <link0></link0>". Now such mistakes are ignored. Bug: b/147482903 Change-Id: I8eae2b57d6b1c2141b2d5870ffea5c0c6ba92aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000236 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732353}
-
Polina Bondarenko authored
Install a fake RSA key mapped to the real subject public key info to ARC certificate store via ARC command. Later on the key source will be recognized by the dummy subject public key info. Bug: b:119914122 Test: ./unit_tests --gtest_filter=Arc* Change-Id: I8e68bcee6c8a1c80545730e5fe2980d14021884d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962246 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732352}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/813483f04139..0cfd3dc2afae git log 813483f04139..0cfd3dc2afae --date=short --first-parent --format='%ad %ae %s' 2020-01-16 tvanderlippe@chromium.org Update remove global scripts to run on legacy files 2020-01-16 aerotwist@chromium.org Migrates services/ to ESM internally 2020-01-16 szuend@chromium.org [cleanup] Replace {pushAll} helper with {push} plus spread operator 2020-01-16 szuend@chromium.org [cleanup] Remove unused {sortNumbers} utilities function 2020-01-16 janscheffler@chromium.org Add karma tests for text_utils/Text.js 2020-01-16 changhaohan@chromium.org [karma-tests] add unit test for BezierUI Created with: gclient setdep -r src/third_party/devtools-frontend/src@0cfd3dc2afae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib4ebb9eb9efeefefa629858e508563a59cef9ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004493Reviewed-by:
-
Marc Treib authored
Before: PerUserTopicSubscriptionManager always invalidated any existing access token before requesting a new one. That was useless and wasteful. After: PerUserTopicSubscriptionManager only invalidates an access token when receiving a 401 (unauthorized) error from the server, indicating that the access token was invalid. Bug: 1020117 Change-Id: Ida9b4b77da079a062292f13964d9906403917de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000939 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732350}
-
Aaron Tagliaboschi authored
Currently there are two different flags that control sending Client Hints to cross-origin resources: Feature Policy delegation (off-by-default) and a build flag that sends legacy hints on Android. This CL makes sure that these two flags play nice together, and adds virtual test suites to exercise them. (This is an attempt to reland crrev.com/c/18931963. It was reverted due to a flaky WPT that has now been fixed.) BUG: 1022366 Change-Id: I495fc4a2d783fb1df9f7b6a65d4034757ff47ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974512Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#732349}
-
Antonio Gomes authored
This is a preparation CL for migrating FrameMsg_UpdateUserActivationState to mojo. Today FrameMsg_UpdateUserActivationState takes the enum blink::UserActivationUpdateType as argument. The corresponding mojo method (to be added), will need to pass a blink::mojom::FrameMsg_UpdateUserActivationState enum instead. Hence, this replaces blink::UserActivationUpdateType with blink::mojom::UserActivationUpdateType. BUG=1041066 R=avi@chromium.org, dcheng@chromium.org, dtapuska@chromium.org, haraken@chromium.org Change-Id: Iaf0f857df04033790b8c0f59f09cdfb3258c857b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002754Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#732348}
-
Abhijeet Kandalkar authored
This CL uses new downcast helpers for below classes 1. HTMLCollection 2. HTMLFormControlElementWithState 3. HTMLOptionsCollection 4. HTMLDataListOptionsCollection 5. HTMLTagCollection 6. HTMLImportTreeRoot Bug: 891908 Change-Id: I082414d2765d3972c872bb5517ea81cd411883ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999968 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732347}
-
Nick Diego Yamane authored
Remove dcheck for clean state (group bits) when extracting keyboard group info from XEvent's state as it's not true on Gnome+IBus setup. In this case, when called from GtkEventLoopX11::ProcessGdkEventKey(), for example both state and group fields are already set correctly. Bug: None Change-Id: Ib816e31b85126163b7ae8caa2cde286e77e5f029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002757 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732346}
-
Yuki Shiino authored
Issue 798467: It's not yet clear what ImplType should be, but we technically don't need both of ImplType and ResultType. We can implement IDLNullabe without ResultType. At this moment, ImplType looks implementation helper used only by IDLXxx and NativeValueTraits. ImplType doesn't look a public API. Issue 798470: It's reasonable that NullValue() is defined iff type T can represent IDL null value. We can tell whether base::Optional is necessary or not by looking at existence of NullValue(). Issue 798471: This patch requires NullValue() only in NativeValueTraits and not in IDLXxx. IDLXxx is a simple tag type just like the original design. Bug: 798467, 798470, 798471 Change-Id: I08e3cf54f3059ec308b4b455045c0bc1cfd5967b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002551 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#732345}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b5fd175..90815b65 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I764091eb8a3f8b1964daae130f62b1ff0d6d3b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002637Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732344}
-
Hajime Hoshi authored
This CL is a pure refactoring. This moves the duplicated implementations of GetEntries/GetMetrics from test files to TestUkmRecorder. Bug: 1033410 Change-Id: I97c4686421fb26d7084414826e5dc99e778045bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986655 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#732343}
-
Antonio Gomes authored
BUG=104106 R=dcheng@chromium.org, dtapuska@chromium.org, haraken@chromium.org Change-Id: Ib778b3cdb059dd5079f3b9e7ec61af1bb5107cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002750Reviewed-by:
-
nancy authored
This CL is used to integrate ARC's context menus for app list to AppService: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc?l=43 https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc?l=73 BUG=1038487 Change-Id: Ib1fa21ad7400bf990ec546c8eb527767a4f32362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003149 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#732341}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/308c74fe7331..813483f04139 git log 308c74fe7331..813483f04139 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 szuend@chromium.org [cleanup] Remove unused _toolbarItems field from View.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@813483f04139 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib0623d50a3f4dfa49b44c85085314d43d47de411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004489Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c06fa2e9433..d5722304fcfc Created with: gclient setdep -r src-internal@d5722304fcfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I548bf1af43ddccf2eab39d9f8158e24a113859f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732339}
-
Mikel Astiz authored
Analogous to the recent https://crrev.com/c/1968991, this patch adopts org.chromium.base.Promise as mechanism to avoid blocking the UI thread while the Intent is constructed as part of TrustedVaultClient.createKeyRetrievalIntent(). This patch also adopts PendingIntent as opposed to Intent, which fits better the need to launch a possibly external flow. Bug: 1012659 Change-Id: Ib8db263f8b5ce3aa255b90603e4def60456d1459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972131 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#732338}
-
Tim van der Lippe authored
We run these checks in the devtools-frontend repository and roll the code in. There is no need for running these checks in Chromium as well. Moreover, there appears to be a configuration difference in the Chromium buildbots compared to our own waterfall. Since these checks already run in our repository, we should remove them rather than fix them. Bug: 1041811 Change-Id: Icc879116b8593310b15276bf413647d34ffced3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000707Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#732337}
-
Oriol Brufau authored
This is a follow-up of r728894. It affected the behavior of the WPT test grid-layout-properties.html, but I didn't notice it since it was marked as failing. Mozilla updated the test in https://bugzil.la/1599206, but they didn't cover some cases that were already failing for them since Firefox doesn't serialize shorthands. Also, a case that used to expect "150px 50px 50px" should have been changed to "150px" (removing the trailing implicit tracks), but Mozilla changed it to "50px" since it's what they get due to a Firefox bug. Here I'm fixing the test to expect the correct values, unmarking it as failing, and adding an -expected.txt for the cases that fail due to bug 511177. BUG=1024927 Change-Id: I7ff8d248a708af273cd89d438ffd2692783a5bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002579Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#732336}
-
Mikel Astiz authored
The field gets populated only if the committing client is sure about the GUID being the authoritative one (consistent with the originator client item ID). Instead of introducing a new field for the originator item ID or a boolean representing whether the GUID is indeed authoritative/final, the existing field |client_tag_hash| is leveraged for this purpose, which was unpopulated for bookmarks prior to this patch. This is aligned with future plans to actually introduce a client tag for bookmarks, just like for the rest of sync datatypes. Bug: 978430 Change-Id: I66dd9d46d2d23aa86b0c9d88dcd6aed4a896c834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981610 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#732335}
-
Kenichi Ishibashi authored
This is similar to crrev.com/c/1999974 but for FindRegistrationForScope(). DidFindRegistrationForClientUrl() and DidFindRegistrationForScope() in ServiceWorkerStorage are merged into a single method because these became identical. Bug: 1039200 Change-Id: I7eead23192734fa7a5cf743801474975fd47a17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003163 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#732334}
-
Mike West authored
`Referrer-Policy` test subresources moved out of //referrer-policy, into //common so that they could be used by other tests more easily. When we did so, we neglected to update the URL in //external/wpt/referrer-policy/generic/inheritance/iframe-inheritance-data.html. This patch addresses that oversight. Change-Id: I1989df8dc4e39ad26de8ac9562f81796bda5aebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003311Reviewed-by:
-
Jan Wilken Dörrie authored
This change extends PasswordManager's ShowAllSavedPasswordsShownContext and ShowAllSavedPasswordsAcceptedContext histograms and cleans up logging code. Lastly it transfers the responsibility of the histograms to vasilii@ and fhorschig@, who are more appropriate owners. Bug: 1037197 Change-Id: Ibcae394a9bf2194500bbfbd0c76137b04fffeb82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000709 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732332}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7edb0eb8a458..2900040bc4a0 git log 7edb0eb8a458..2900040bc4a0 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 146e16f68fdc..5fc197dc7669 (10 commits) 2020-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 86f730971751..a7b91502cd7f (2 commits) 2020-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b83f9414..98818e57 (437 commits) Created with: gclient setdep -r src/third_party/skia@2900040bc4a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I5dd50060b1b5e95a616f66efbbee2f10c237a879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003118Reviewed-by:
-
Isabella Scalzi authored
Bug: 1038799 Change-Id: Ia5f917405c2eed46fe1d9c07bf110f9f3aac0ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003153Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732330}
-
Koji Ishii authored
This patch implements |BuildBackplate| for |NGFragmentItem|. Bug: 982194 Change-Id: I352a8edef64d3c936d34075742e42d124c1bfdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003150 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732329}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a04803267c6..e9730d75a005 git log 2a04803267c6..e9730d75a005 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 raul@tambre.ee subprocess2: Ensure environment keys and values are strings on Python 3 Created with: gclient setdep -r src/third_party/depot_tools@e9730d75a005 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:984182 Tbr: agable@chromium.org Change-Id: I4da110b37114c9040f24c8a9ec39fc341d84fa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003434Reviewed-by:
-
Yuki Shiino authored
BlinkTypeInfo.is_nullable is confusing with IdlType.is_nullable despite that their meaning are different. Rename the former to has_null_value. Bug: 839389 Change-Id: I0ebd15f460730f8b612da60592cfa90ec024cb76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004366Reviewed-by:
-
Makoto Shimazu authored
The update checker and the new script loader now reflect the COEP value to the ServiceWorkerVersion. That value is stored in the disk properly. Note that, in this CL, a loader factory passed to a new service worker is created before the new script loader loads the main script. That means the COEP value doesn't take effect until the service worker is restarted. Bug: 1039613 Change-Id: Id23fc14f7acdddb4b7473331cb1376ce5f6fc358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991064 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#732326}
-
Hitoshi Yoshida authored
PathManager for union types fails if a Union doesn't contain user defined types, because its |components| is empty. This CL makes it to set core as its default component in such cases. Bug: 839389 Change-Id: I423f4691d0435352b0e873af5d679b898afc9465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004358Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#732325}
-
Wei-Yin Chen (陳威尹) authored
This CL adopts the aspect ratio from Finch to thumbnail size. If the JPEG has different aspect ratio, regenerate the JPEG file from the ETC1 file. Integration with tab_grid_layout_android_new_tab_tile variation is also added. Everything introduced in this CL is gated by field trail under the enable-tab-grid-layout flag. And most of the Java part is verified to be behind the gating functions FeatureUtilities.isTabThumbnailAspectRatioNotOne() and FeatureUtilities.isAllowToRefetchTabThumbnail() by formal equivalence checking tool here: http://crrev.com/c/1934235. Note: the tool does not support native yet. TBR=yusufo@chromium.org This is based on http://crrev.com/c/1990214/14. Bug: 1041536 Change-Id: I5db65a72b7c56a4546491a13d43872b46ee6e55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003825 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732324}
-
Gyuyoung Kim authored
As a step to convert legacy IPCs to the Mojo, this CL converts renderer side's BlinkTest IPC messages to the Mojo. This CL adds the IPC messages to WebTestControl interface in web_test.mojom file. Now it starts to support the original messages. The added methods are as follow, - Reset(); - TestFinishedInSecondaryRenderer(); - LayoutDumpCompleted(string completed_layout_dump); - ReplyBluetoothManualChooserEvents(array<string> events); This CL should not change any behavior. Bug: 1039247 Change-Id: I43dbdbb9d9d4fb20a4f7a55e4e10fbf33e5622ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991045Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/772588160e90..308c74fe7331 git log 772588160e90..308c74fe7331 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 szuend@chromium.org Remove SimpleView.syncToolbarItems and use async variant instead 2020-01-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@308c74fe7331 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5533072c0f2e0f7dd2a5cddd889598f97ba96e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003815Reviewed-by:
-
