GitLab

Bug: 1075444, 1131038
Change-Id: I276aa7628088d810e422235f85564f0ac0930681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431428Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#811789}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009290800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/BJBtNPmOWXzOskdkiFU6S5dpkVPd-1G-Mq2BUPzToSUC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa
Bug: b/161406194
Tbr: media-app@grotations.appspotmail.com
Change-Id: Ic9e8c59c47099ae70c834e62db58105971c58d33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438433Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811788}

Bug: 772945
Change-Id: I466d0232ccdc0a621d7075bebbcb7adaca6bd767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437610
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811787}

This reverts commit f3134574.

Reason for revert: WebUSB devices are too identifying to instrument per identifiability privacy study.

Original change's description:
> Instrument WebUSB.getDevices/requestDevice for Identifiability study.
>
> Bug: 973801
> Change-Id: Ia87925e48d9f0953b5f4e3a2d89472129e4ecee7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432424
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Russ Hamilton <behamilton@google.com>
> Cr-Commit-Position: refs/heads/master@{#811456}

TBR=reillyg@chromium.org,behamilton@google.com

Change-Id: I873fa51c11d3cd851ef6d8dc4bbf80cd33aa761a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 973801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437699Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/master@{#811786}

Remove the accidentally committed assert that caused test failures and
reland:

> When using a subdirectory of the Android cache dir (e.g. in WebView),
> explicitly create the directory in PathUtils instead of relying on any
> user of the directory creating it implicitly.

> Set the directory mode to 02700 which is what it currently gets set to
> when created implicitly.

This reverts commit fbdad03f.

Fixed: 963640
Fixed: 1132987
Change-Id: Ic94acaa1fd4dacb55839086699cc2974496e6bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438469Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811785}

This patch switches the custom "add overlay" methods for a single
unified "addSceneOverlay". This new method does insertion sort based
on a predefined list determining the order of each overlay. Display
order is no longer based exclusively on the order in which the
overlays were added. If two overlays of the same type are added, the
most recently added overlay will display above the others.

Bug: 1070281, 1131536
Change-Id: I5764593debb13d30389f78303120ec4b4fcbb28f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392403
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811784}

Adds the domain of the frontmost tab along with the number of tabs
in the window to the UIScene's title, which gets displayed in the
OS-level application switcher next to the application name.

BUG=1132344
TEST=Will show only the domain for a single tab, and correctly
pluralized strings of the number of other tabs when there are
more than one.

Change-Id: Iba8da572f8e042c8ab47092304a729b1b3de8bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435939
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811783}

https://skia.googlesource.com/skia.git/+log/842805ced156..c73bff39bd21

2020-09-29 senorblanco@chromium.org Dawn: factor SKSL-to-SPIRV conversion, creation of ShaderModule.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: brianosman@google.com
Change-Id: I721a2cdb0bcb740122accbc00f22513c629c0ee9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438429Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811782}

TODO: report DID_NOTHING.

Bug: 1132230
Change-Id: Icb2c2c6bbe84efdbb66ba59598488d4f2589a95e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410226Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811781}

Bug: 1130478
Change-Id: I185dbda5351a59afe463a7a61f6a0a4b8028b918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436518Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811780}

This cl is just a cleanup of the now unused flag for smart text
selection.

Bug: 1110727
Test: This is non-op as the flag was removed from chrome://flags already
Change-Id: Ib04755ca7eefa42a0b320874cc99c6f08633ec00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437592
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: David Jacobo <djacobo@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811779}

This is needed to add buttons for tab scrolling.

Bug: 1129675
Change-Id: I07e57eb3cef149ec1b5606a96299a287467ee4bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435815Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811778}

All the other ClearBrowsingData_* metrics are logged
when the user clear them using the clear browsing data
screen.
ClearBrowsingData_Cookies is the only one that is also
log when destroying an incognito browser, leading to
metrics inconsistencies.

Only log ClearBrowsingData_Cookies for normal browser
fix the issue.

Bug: 1132818
Change-Id: I169d474b326fd1d53885524ab584000336768d46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434338Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811777}

Fix an issue on the login screen that caused the pin pad
on the login/lock screen to vanish when hiding the virtual
keyboard that is used in tablet mode.

Fixed: 1129183
Change-Id: I2facd941f0201c0c7d5924528f352a07f3638305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437377Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/master@{#811776}

Fixed issue where metrics were recorded as GEOLOCATION permission regardless what the permission was.

Bug: 1119738
Change-Id: Ib0f5d372727a26b9294536a03928a2d79305dea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438369
Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811775}

Reading list manager talks to reading list backend and converts data
to a BookmarkNode tree.

Bug: 1128074
Change-Id: I0a59530b667021e2aa0d58842a4c0495bfde7af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427635Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811774}

We're having issues with high pending times on the linux CQ pool.
Disabling this for now, since experiments are optional and are
currently using up capacity.

No-Presubmit: true
Bug: 1133410
Change-Id: I4d34c8a7403249601dfbbdba450b46b97d3ef869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438672
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811773}

Replace SetCertificatesForExtension (which does not actually exist) with
SetCertificatesProvidedByExtension (which does).

Bug: 1067683
Change-Id: Idd0c25686f9f9228642ccb8891d3c1098b052ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438449Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811772}

This CL updates the subtitle string in the web sign-in bottom sheet.

Screenshot: https://crbug.com/1133279#c1
Bug: 1133279
Change-Id: I0a5a914747065980610baf08266499dede0b7841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437952Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811771}

Add metrics tracking which font names are requested by the renderer.
This may be used to determine whether it is worthwhile to continue
preloading fonts like Google Sans Bold, which are not used in the Chrome
UI.

Bug: 1129668
Change-Id: I45d4d671cdb989cb38c4d1d2e333a4ffaf54c86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433028Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811770}

These browser tests launch a separate browser process to communicate
with. The browser process starts its own GPU process, and MSAN can hit
uninitialized values in some GL drivers on Chrome OS.

This ensures that the launched browser always uses swiftshader for GL to
avoid any such memory issues.

Fixed: 1131586
Change-Id: I012853118d390c4893933279930a64bba42028bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437017Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#811769}

Currently, Chrome’s print dialog on macOS in German shows the option
“Keine Besuche” (“no visits”) in the margin drop-down, which does not
make any sense and is most likely the translation of “none” in a
different context.

The meaning= properties should make this clear,
for all print margin settings.

R=weili@chromium.org

Skip-Translation-Screenshots-Check: True
Change-Id: Iae824b190fab816a11c7d6e9a7edacba2ac3ce21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436739Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811768}

This change inverts Change password on website icon for RTL languages.

Bug: 1106323
Change-Id: Ib7c78f01525c99c64cb2707112139199556b0f7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438349Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/master@{#811767}

Add a method to media::VideoDecodeAccelerator to indicate whether
SharedImage-backed picture buffers are supported. Make this return
true only for the VTVideoDecodeAccelerator.

Add a parameter to media::PictureBufferManager::CreatePictureBuffers
to indicate if SharedImage-backed PictureBuffers are desired.

Hook the two of these together in the ProvidePictureBuffersAsync
method of media::VdaVideoDecoder. Leave this disabled for now.

Bug: 1108909
Change-Id: I539f03bdca232fe32969ab5e92b6aea34c6d99f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436313Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811766}

Omaha now supports one off checks, add Omaha integration to Safety
Check.

Bug: 1078782
Change-Id: Ie8c9bc295b89e2148c2586331e9a7712cede7ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435097Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811765}

CL that implements the feature : crrev.com/c/2408502
Doc about the feature : go/arc-r-documents-ui

Cq-Depend: chromium:2434070
Bug: 1126742
Test: browser_tests --gtest_filter="*FilesApp*SearchQueryLaunchParam"
Change-Id: I7d241f9e9e42b5669be6a4a012296537aad9f218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434008
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Auto-Submit: Satoshi Niwa <niwa@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811764}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/chromeos/policy
This CL was uploaded by git cl split.

R=rsorokin@chromium.org

Change-Id: I5c0f9ac978d5e6c7ed3b71690ea29a734e7e1fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435819
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811763}

Verified that local device data manager unit tests failed with an ASAN
build before this change and pass after the change.

Fixed: 1133295
Change-Id: I51dfd183948c967aefff77defa36e689afa16a59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438167
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#811762}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5c1904772b36..92e869a63782

2020-09-29 alexrudenko@chromium.org Refactor the rest of inspector tools
2020-09-29 patrick.brosset@microsoft.com Fix import module error
2020-09-29 alexrudenko@chromium.org Add a button to scroll an element into view in CSS Overview
2020-09-29 alexrudenko@chromium.org Fix a11y issues in Layout panel
2020-09-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-09-29 szuend@chromium.org [ts] Type-check TimelineFlameChartNetworkDataProvider.js with TypeScript
2020-09-29 pfaffe@chromium.org Download emscripten-releases binaries for building wasm tests
2020-09-29 jacktfranklin@chromium.org Fix assertions of 0 mutations in component test
2020-09-29 szuend@chromium.org [ts] Type-check timeline/UIDevtoolsUtils.js with TypeScript
2020-09-29 szuend@chromium.org [ts] Type-check timeline/TimelinePaintProfilerView.js with TypeScript
2020-09-29 tvanderlippe@chromium.org Remove usages of Runtime.sharedInstance
2020-09-29 alexrudenko@chromium.org Include inspector_overlay in presubmit
2020-09-29 jacktfranklin@chromium.org Fix bug with mutation expectations
2020-09-29 tvanderlippe@chromium.org [globals] self.runtime

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1115011,chromium:1120316,chromium:1128888,chromium:1129881,chromium:1131801
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ide0d85a110fe84caf2a852e8faf726e08f8ec057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438166Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811761}

Bug: 1125106
Change-Id: Ic94c679f4efa77d4c3fea97f67b8975b40eabd00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437019
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811760}

This CL updates the behavior of ToggleButton on Android.

With this change, the state of a ToggleButton ("On"/"Off")
will now be read during swipe navigation when a node is
initially selected. Until now the state of the toggle button
has only been announced during a toggle action.

We append the state of the Toggle in the stateDescription
element of the node's corresponding AccessibilityNodeInfo
object.

This CL also updates associated unit test expectations.


AX-Relnotes: ToggleButtons on Android now explicitly announce their state.
Bug: 1121743
Change-Id: Iaa25379fa9c478c6c96c9a58d99495a8a8fe978f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432211Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#811759}

This reverts commit 2d4e58ed.

Reason for revert: Suspecting that the patch crashed some tests when running test urls. https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/11891 

Original change's description:
> Repeat path canonicalization in ContentSettingsPattern::Builder
>
> The fuzzer discovered an input that uncovers non-idempotency in
> ContentSettingsPattern::Builder::Canonicalize. First, the function
> changes |parts->path| from "/.//" to "//". On a second call, the "//" is
> changed to "/".
>
> This CL repeats the path canonicalization until we reach a fixed point.
>
> Bug: 1117622, 1132957, 1128999
> Change-Id: I96da902e50a4a9b654a7d4184ef4ad2c0689e705
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406332
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811717}

TBR=engedy@chromium.org,dmcardle@chromium.org

Change-Id: Icf5b20112f621b6012d58987c85205b511b4263a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1117622
Bug: 1132957
Bug: 1128999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436520Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811758}

The file in question does not seem to contain any of deprecated types or
functions.

Bug: 1007635
Change-Id: I1b9e8b769423615546d79a4dec3430cc25553083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434528
Auto-Submit: Andrew Shulaev <ddrone@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#811757}

Updates the expires_after attribute for 138 histograms that show
frequent access in the past 90 days.  These are the 91% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2020-12-28.

TBR=chromium-metrics-reviews@google.com

Change-Id: Ib5e9a37895c61d6c3b3640963a61b2972da6b5f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437760Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#811756}

CustomTabToolbar follows different coloring logic that isn't fully
captured by either AppThemeColorProvider or TabThemeColorProvider, since
it also tracks the color set by CustomTabToolbarColorController due to,
e.g. the possibility of customization by the host app. Unfortunately
CustomTabToolbarColorController isn't a ThemeColorProvider, but we can
instead create a dumb ThemeColorProvider that just blindly tracks it.

Bug: 1128337
Change-Id: I9d910ee049a7a96d485053214b6dab6c0110f28d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430228Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811755}

The viewport zoom can have a non-integer value, but, currently,  when
focus passes through the zoom input, the 'zoom-changed' event is
dispatched for the integer value.

Consequently, on the blurring of the zoom input, the zoom of the PDF
content slightly changes to the nearest integer value of the viewport
zoom, even though the value in the zoom indicator does not change.

To fix this, only dispatch the zoom-change' event when the difference of
the input value and the viewport zoom value is less than 0.5.

Change-Id: I8380d148cbd3219c34c56a51af47c2e9a351efd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436856Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811754}

This test has been flaky for a while. See the bug for details.

TBR=arthursonzogni@chromium.org

Bug: 1133342
Change-Id: I115c2bd2c84958e2e9f46bd9c0f378756af3c9eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436764Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811753}

Otherwise Python doesn't find git when it's available as git.bat:

>where git
c:\src\depot_tools\git.bat

>python tools\clang\scripts\build.py --llvm-force-head-revision
[...]
Traceback (most recent call last):
  File "tools\clang\scripts\build.py", line 1098, in <module>
    sys.exit(main())
  File "tools\clang\scripts\build.py", line 498, in main
    CLANG_REVISION = GetCommitDescription(checkout_revision)
  File "tools\clang\scripts\build.py", line 180, in GetCommitDescription
    ['git', 'describe', '--long', '--abbrev=8', commit]).rstrip()
  File "c:\src\depot_tools\bootstrap-3_8_0_chromium_8_bin\python\bin\lib\subprocess.py", line 216, in check_output
    process = Popen(stdout=PIPE, *popenargs, **kwargs)
  File "c:\src\depot_tools\bootstrap-3_8_0_chromium_8_bin\python\bin\lib\subprocess.py", line 394, in __init__
    errread, errwrite)
  File "c:\src\depot_tools\bootstrap-3_8_0_chromium_8_bin\python\bin\lib\subprocess.py", line 644, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

Bug: 1015315
Change-Id: I403a0cb4006f274e4a438e6d69fbbb5540b97570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438056
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811752}

Bug: b/150034512
Test: Run existing tests
Change-Id: I1a0349a96fe1c640d0611e174410861ab4864e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431792Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811751}

There's a NullPointerException crash caused when a tab is closed while
paint preview is fading out. This fixes that.

Bug: 1133170
Change-Id: I3d3b025fdc70ea83113c09a054f7120555e51f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437739
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811750}