- 20 Apr, 2020 40 commits
-
-
Zach Trudo authored
File Changes: ~ chrome/browser/chromeos/ | ~ BUILD.gn | Added reporting_record_proto, and reporting_constants_proto | targets + chrome/browser/chromeos/policy/messaging_layer/ | + proto/record.proto | Contains Record, WrappedRecord, and EncryptedRecord. | + public/record_constants.proto | Contatins constants that the user will use to indicate the | destination and priority of their records. Change-Id: I2ee585d8294781ea4cece76d74b72513d787596f Bug: b:153365169 Change-Id: I2ee585d8294781ea4cece76d74b72513d787596f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139854 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#760573}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: I939f1d9d0db3e858c539a436021f47dc619222b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157065 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#760572}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca96cb78e35e..1f9465beae14 git log ca96cb78e35e..1f9465beae14 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 vapier@chromium.org chrome_committer: convert to python3 only 2020-04-20 slangley@chromium.org reven: Don't generate factoriy image or run HWtests for reven image. 2020-04-18 vapier@chromium.org perf_uploader: fix various bugs caught by python3 2020-04-18 manojgupta@google.com cros_fuzz: Fix bytes vs str for msan 2020-04-17 vapier@chromium.org cbuildbot: make builders/stages subdirs python3 only [reland] 2020-04-17 rohitbm@chromium.org Stop arc-cts-qual and arc-gts-qual suites kicking off from builders 2020-04-17 vapier@chromium.org paygen: fix bytes-vs-str comparison Created with: gclient setdep -r src/third_party/chromite@1f9465beae14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I3c404b26bee66fc81890be5663fc2e950250a27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157185Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760571}
-
Nate Chapin authored
This gets us to a point where all cases where we swap the attached Document based on web content go through DocumentLoader. XSLT was the last case that directly instructed LocalDOMWindow to install a new Document. This had caused problems with extensions getting document lifecycle notifications in an unexpected order because the Document was changing without a "navigation". Note that LocalFrame::ForceSynchronousDocumentInstall still manually calls LocalDOMWindow::InstallNewDocument, as do a few unit tests. Bug: 1041916 Change-Id: I01d669c2e82de55bec9cd90dbc7fd376fab35234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148828 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#760570}
-
Sean Gilhuly authored
On Windows, create a VsyncProviderWin in SkiaOutputDeviceDawn. Then following each swap buffers, use the current timestamp snapped to the next vsync interval as the presentation time. Bug: 1021566 Change-Id: Id7e1fb3ec4c4d63517e556be6e36a824356e7e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154596Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#760569}
-
Alice Wang authored
This CL removes a null check for Robolectic version < 3.7. Since our current Robolectric version is 4.3, we don't need this check anymore. Bug: 779568 Change-Id: I6a325a807304efb3769c5291e82c127250ecdb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152835Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#760568}
-
Chris Lu authored
TranslateInfobarDelegate is currently only allows for one observer. This change replaces its observer_ property with a ObserverList so that more than one object can be an observer. Change-Id: I67c2a1ee2e2bee8ba532bc4b4adc1d2237dc1bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153330Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#760567}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/449b1157a738..9b5e16c09e4f git log 449b1157a738..9b5e16c09e4f --date=short --first-parent --format='%ad %ae %s' 2020-04-20 jvanverth@google.com Add capture routines for D3D 2020-04-20 mtklein@google.com Revert "gather8/16 JIT support" 2020-04-20 mtklein@google.com gather8/16 JIT support 2020-04-20 robertphillips@google.com Handle mipmap creation failure in DDL test harness 2020-04-20 michaelludwig@google.com Add inner bounds of round rect function Created with: gclient setdep -r src/third_party/skia@9b5e16c09e4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: Ic94d83ec094c4a375afd597d246d91f10b2b07ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157188Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4a5765265d3d..bef0404d78ed git log 4a5765265d3d..bef0404d78ed --date=short --first-parent --format='%ad %ae %s' 2020-04-20 jbudorick@chromium.org devil: update arm & arm64 chromium dependencies. Created with: gclient setdep -r src/third_party/catapult@bef0404d78ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: If45fa01f724eb90e2e90e22cfdd40371f982c9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157190Reviewed-by:
-
Javier Ernesto Flores Robles authored
This is a reland of 2d2185d8 The fix is to remove the ifdef check. I incorrectly assumed that DCHECK would strip the code on release configurations. Original change's description: > [iOS][Credential-Provider] Observe changes in the password store > > Updates the credential store with changes from the password store. > Renames SyncAllCredentials to RequestSyncAllCredentials to make clearer > the async nature of it. > Creates entry functions for adding, updating, and removing passwords > which will be used to also keep up to date the OS metadata in a follow > up CL. > Injects the credential store for easier testing. > > Bug: 1066803 > Change-Id: Id79c3b276517c7bb223b3988db4d1a8c25e00025 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152814 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760483} TBR=vasilii@chromium.org Bug: 1066803 Change-Id: Ie50f790c6cc8715c13017fc930327019f137fb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157045Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#760564}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f3fda0023405..ab16a956e574 git log f3fda0023405..ab16a956e574 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 alexrudenko@chromium.org Reattach the target before reloading Created with: gclient setdep -r src/third_party/devtools-frontend/src@ab16a956e574 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f28d90bbc58989f0c81c9c5ebb97c381c497232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157186Reviewed-by:
-
Bo Liu authored
Copy implementation from chrome. Retrieve min_width from ui::Display. Bug: 1052496 Change-Id: I453919244580e4c22439b8d7aa5a7da1c9aec289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154852 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#760562}
-
Sergey Ulanov authored
Previously FuchsiaAudioRenderer wasn't reporting any statistics to the pipeline. As the result the pipeline was always reporting 0 for audio_decoded_bytes. Fixed it to report this parameter after every packet it sent to the AudioConsumer. Note that decoding itself is handled by the AudioConsumer implementation, so the data may be decoded a bit later than it's reported. Bug: 1067068 Change-Id: Iecbce0d757b6c753360073faf5a073b71b33e1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148379 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#760561}
-
Andrew Xu authored
This CL verifies that home launcher animation smoothness metrics are recorded correctly in the following two scenarios: (1) Enter/exit overview mode (2) Show home launcher from in-app shelf by gesture swipe. Bug: 1059449 Change-Id: If908f0d0a0e5f545fbbbe6f06a1b47f1cc9beaf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155351Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760560}
-
Peter Wen authored
Lint target API should be updated when we support new android APIs. Fixed: 999000 Bug: 999000 Change-Id: Ie724208e04689f2a4c90671f18a8599c258186f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156747 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#760559}
-
Katie D authored
The bubble is by default centered in its anchor view, and can be moved anywhere within the anchor view as long as it is not too close to the sides or bottom. If the bubble is moved within the anchor view, it tries to stay at the same place with respect to the anchor as the anchor changes size. Bug: 1055150 Change-Id: Ic161a99e75bfcc7387b44ee14bed0bc996276e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150691 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760558}
-
Andrew Grieve authored
They are unused since Chrome doesn't run on Wear OS. Bug: None Change-Id: I0282de56b7c35d4e651543a8cf649b1fe259a227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154823 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#760557}
-
Dan Harrington authored
LoadMore is different enough from LoadStreamTask, that I made a new task type, LoadMoreTask. This workflow requires that the model is already loaded. Additionally, StreamModel is responsible for saving changes to persistent storage, which is not the case for LoadStreamTask. Bug: 1044139 Change-Id: Id9d8bd932a7d855c91bd01161ed03b572ba04208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148041Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#760556}
-
Peng Huang authored
The crash is because the vkAcquireNextImageKHR() fails with VK_ERROR_SURFACE_LOST_KHR, probably the platform window is closed, or a new swapchain is created with the same platform window. Since vkAcquireNextImageKHR() is called just before rendering DDL to the vkmage, if there isn't a new vkimage is available, it is too late to properly handle it. Fix the problem by call vkAcquireNextImageKHR() immemorially after vkQueuePresentKHR() call. If vkQueuePresentKHR() call is successful, then the surface should be good, and vkAcquireNextImageKHR() should be successful too. If surface is lost, vkQueuePresentKHR() will return VK_ERROR_SURFACE_LOST_KHR., and then the PresentBuffer() will return SWAP_FAILED to caller. Caller should be able to handle it properly like it does with GL and glSwapBuffers(). Bug: 1070754 Change-Id: I697cca3a282d046e9592d554403f7c10c811cf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155197 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#760555}
-
gogerald authored
Change-Id: I8b922761cf9bb18af70e09dfa78b3711fcb067ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157245 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
I cannot repro on my eve or caroline device, but according to comment#4 in bug 1050195, and comment#9 in bug 1050330, it seems theoretically it can be caused by aync reading of the lid angle driver "cros-ec-lid-angle". So when the device first starts or comes out from sleep, the driver "cros-ec-lid-angle" is not present yet, so Chrome is doing its own lid angle calculation, and later when the reading result comes back and"cros-ec-lid-angle" flag is properly set, Chrome does not do the lid angle calculation anymore, but the old lid angle is not reset to 0.f, so it might interfere with the tablet state calculation. Bug: 1050195, 1050330 Change-Id: I9c650ee2becbabfb20101a192ebfa5eeb7b677dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153899 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#760553}
-
arthursonzogni authored
Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/2152797/1 improves ./stale-image.html For consistency and because the test looks slightly nicer, this patch applies the same kind of refactoring to ./stale-css.html Bug: 1070117 Change-Id: I5a30c105aca4c2bde0962004f9a97e4fbde2ab4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152798 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#760552}
-
Jonathan Wright authored
Change libpng build configuration to optimize for speed on Arm platforms. This allows the compiler to inline some of the NEON filter functions and significantly increase performance. Binary size increase is minimal (<10KB increase in normalized Android APK size.) Bug: 1071398 Change-Id: I109dea8b490bfdd2c0a80e2f1259797f1485e14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149331Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#760551}
-
arthursonzogni authored
Mainly for improving my own understanding. I would like to make some tests about CSP vs stale-while-revalidate for issue 1070117 This patch: 1) Use Promise(s) instead of callback(s). This unwrap the logic flow. 2) Make "last_modified_count" to count the number of new version being served. Previously, it was a bit confusing to me. 3) Extend the test to check the "revalidated" version is served on the 3rd load. 4) Small misc refactorings. Bug: 1070117 Change-Id: Ifba23d78e539eb50262244f59e7c16e1b9ca56ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154786Reviewed-by:
-
danakj authored
We remove the secondary window bool in renderer as we no longer need to rely on it to avoid logging in devtools inspector windows. The devtools tests disable console logging in WebTestRuntimeFlags, and if we correctly replicate it to the inspector window's renderer processes (both for the first test and for subsequent ones), then no logs will be produced in the inspector. The tests in /devtools/ have console logging disabled in TestInterfaces::ConfigureForTestWithURL(), which is propagates as a WebTestRuntimeFlag to all windows and frame tree fragments - including the inspector secondary window. The /inspector-protocol/ tests similarly use console logging to drive their tests, and have a secondary window, though provided through other means seen below: #2 0x55d55b531129 content::WebContentsImpl::Init() #3 0x55d55b527234 content::WebContentsImpl::CreateWithOpener() #4 0x55d55b526f34 content::WebContents::Create() #5 0x55d55b938b57 content::Shell::CreateNewWindow() #6 0x55d55b93ce57 content::ShellDevToolsManagerDelegate::CreateNewTarget() #7 0x55d55b0d8296 content::protocol::TargetHandler::CreateTarget() #8 0x55d55b0d840e content::protocol::TargetHandler::CreateTarget() #9 0x55d55aebcbcf content::protocol::Target::DomainDispatcherImpl::createTarget() #10 0x55d55ae7fdf8 std::__1::__function::__policy_invoker<>::__call_impl<>() #11 0x55d55a3d6913 v8_crdtp::UberDispatcher::DispatchResult::Run() #12 0x55d55b0793a0 content::DevToolsSession::HandleCommandInternal() #13 0x55d55b0792cb content::DevToolsSession::HandleCommand() #14 0x55d55b07c688 base::internal::Invoker<>::RunOnce() #15 0x55d55b7fa48e content::DevToolsManagerDelegate::HandleCommand() #16 0x55d55b0791eb content::DevToolsSession::DispatchProtocolMessageInternal() #17 0x55d55b078d96 content::DevToolsSession::DispatchProtocolMessage() #18 0x55d55b94ade5 content::DevToolsProtocolTestBindings::HandleMessageFromTest() Thus we disable console logging in /inspector-protocol/ tests also to not cause regressions due to unexpected logs appearing in the secondary window. Lastly, web platform tests log to stderr instead of the console to avoid including browser-specific console logs in test expectations. However we were only setting the "IsWebPlatformTestMode" in the main frame renderer, so web platform tests that use window.open() would include logging from that window unintentionally. We move the web platform test mode into the WebTestRuntimeFlags set, so that it is propagated to all renderer processes, allowing secondary windows to stop console logging, and also allowing them to perform other tasks correctly as a bonus, such as translating URLs to the correct location. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I4ba2deb635e57d2a1f293e849e01190135064064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153891Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#760549}
-
Ben Kelly authored
This feature is gated behind the "ThrottleInstallingServiceWorker" feature flag and uses the "limit" field trial param to control how many outstanding requests to permit. This CL includes the following changes: * Changes ResourceFetcher and associated classes to use FrameOrWorkerScheduler instead of FrameScheduler. * Moves FrameOrWorkerScheduler::GetWeakPtr() from private to public so that ResourceFetcher and friends can use it. * Factors the outstanding throttle limit into a virtual method on ResourceFetcherProperties. This makes it easier to expose a different limit for workers vs frames. * Moves existing frame throttle limits from ResourceLoadScheduler to FrameResourceFetcherProperties. * Updates the features controlling frame throttle limits to use the new base::Feature and base::FeatureParam<> syntax. * Introduces a ResourceLoadScheduler::ThrottleOptionOverride enum that be set on the ResourceFetcher to override default ThrottleOption behavior. * Makes ServiceWorkerGlobalScope set a ThrottleOptionOverride, expose its new throttle limit, and update the scheduler to enable throttling while in the installing state. * Adds a significant new content browsertest that validates installing service workers throttle requests based on the feature and field trial param. Bug: 1035448 Change-Id: Icdbe82ef8db1573cd5acb26e53946166ac3bdbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015880 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#760548}
-
Steve Kobes authored
Also declare the capacity of the HeapVector for the attribution list, accept it in the LayoutShift constructor, and allow the binding layer to cache the FrozenArray. Bug: 1053510 Change-Id: If0dde547631d3fd95d087d7b8d2116055e382b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153002 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#760547}
-
Michael Ershov authored
For key_type == KEY_DEVICE the key_name_ is empty that causes stable device public key to be returned. To return public key for the newly generated key pair, key_name_for_spkac_ should be used instead. Bug: 1045895 Change-Id: I5fd16b4605a16aefa8e48394f86d6a99e51eb6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157070Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#760546}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: Ib8732b1732c3a92dc2a81eaf1e58fa063db45f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157007 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#760545}
-
Anastasiia Nikolaienko authored
Add SecondaryAccountConsentLogger to log the consent. Bug: 1043108, 1070656 Change-Id: Ife29a9a5fe16e0133a838324b210fe377f2e57d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115471 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#760544}
-
Jinho Bang authored
There is a bug that the save prompt is not shown if the password value is set as an empty value by JavaScript before form submitted. The bug is a regression since crrev.com/c/2029514 (M81 stable), but it is enough reasonable. So, this patch fixes FormParser instead of reverting the CL. In the current implementation, FormParser is treated as parsing error if |value| is empty. On the other hand, according to crrev.com/c/1404093, if |typed_value| is present, we preferentially use it rather than |value|. Similarly, this patch makes FormParser use |typed value| preferentially even if |value| is empty. Reproducible sites: - https://m.naver.com - https://zino.dev (This is a minimal test page I wrote) Bug: 1042196 Change-Id: I6652822fd7fe268b54647434c23c68d41abf5010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154644Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#760543}
-
Albert Chaulk authored
Bug: b/146151793 Test: None Change-Id: I5df1739ce29d9fec4480988ef3a405a93de9d1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072473Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#760542}
-
Xiaohui Chen authored
Bug: None Change-Id: I5d03b6ef8853bdb58b09335c591014cb573fdae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153885 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This CL introduces a BrowserContextHandle interface that provides a pointer to a native BrowserContext, and can be used to by components to take a BrowserContext reference within Java code. Clank's Profile class implements this interface, which allows us to pass a Profile to components that need a BrowserContext. In the future, WebLayer's Profile representation will also implement this interface. This change was motivated by the componentization efforts underway as part of the WebLayer project, several of which would benefit from a Java representation of the BrowserContext. Bug: 1058600 Change-Id: I65778791731c8d1f1529f06eab543774a60155ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130674 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#760540}
-
Ella Ge authored
To include extraCommand and ITrustedWebActivityCallback for location delegation. Bug: 1069506 Change-Id: I333a652db193167606360c7d4da7482e904b5f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130771Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#760539}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: If0ae65768b8b03077e06c70d37a221b7a4392971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157085 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#760538}
-
Nasko Oskov authored
The bindings stored on the RenderProcess object are not longer needed and can safely be removed. Once that is done, the MockRenderProcess becomes a trivial object providing no extra functionality, so this CL goes a step further and removes it as well. Bug: 1069939 Change-Id: I79e047faa0a418b7362a303b5d45210de394b97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145815 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#760537}
-
Ioana Pandele authored
If the saving of passwords is generally disabled from settings, or if the save passwords prompt can't be shown, the toggle should not be shown either. Bug: 1044930 Change-Id: I017ed562cfc1dc10eddf31306d0e7730cd5206a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149332 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760536}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: If22a9fad1fb5c1fa306e539ff8aa27c020f3ec5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156415 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Tim van der Lippe authored
This ports https://github.com/ChromeDevTools/debugger-protocol-viewer/pull/115 to Chromium. Note that the DOM domain depends on Page (as getNodeForLocation has a reference to Page), but if you would add this to the .pdl there would be a circular dependency between Page and DOM. Thus, the generated code does not compile if you add this dependency. This probably requires follow-up work to either remove the circular dependency or update the code generator to handle a circular dependency. Change-Id: I11b444c4af5498c83ca8471e507f93f5dd6485e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148744 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#760534}
-
