- 04 Nov, 2020 40 commits
-
-
Liquan (Max) Gu authored
This CL moved respondCanMakePaymentQuery() and respondHasEnrolledInstrumentQuery() into PaymentRequestService. Bug: 1144527 Change-Id: Idd33310232c6ca46865bd4ff6e0c4100b29f4fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515133Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824067}
-
Dave Tapuska authored
This moves a bunch of methods from WebViewImpl into WebViewFrameWidget. This now makes the WebFrameWidgetBase is now a PageWidgetEventHandler so that we can share common code in the base class. In follow up CLs duplicate code in WebFrameWidgetImpl will be removed. BUG=1097816 Change-Id: I3bf9610f6eb8ce6b5bd36c5db9b374ff5d100be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518127 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#824066}
-
Tim van der Lippe authored
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517500 has been submitted. R=aerotwist@chromium.org Bug: 1011811 Change-Id: I247d3dcba9e1bab20c031237ae2b7950bea230e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519453 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#824065}
-
Aya ElAttar authored
When ClipboardHistory tries to check whether clipboard data read is allowed, no notification should be shown because this action isn't triggered by the user. Bug: Change-Id: If9d82fb92660a322c35a276454ff0d6be1a7fcda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514212Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#824064}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: I3b3983f2fdd9eb9f7d66283aa5fbe0363aa8fe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505674Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#824063}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1145347 Change-Id: Iac5603761900d5e006db6d78064c281b65fa779f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519805 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Stephen Lin <stephenlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824062}
-
Anthony Cui authored
Bug: 1145384 Change-Id: I5eb7f1a9599eefe4e7cd0e6992f1322c4b6a5db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518248Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#824061}
-
Nick Diego Yamane authored
Chrome crashes when the tab drag session is cancelled (ie: pressing esc) in attached mode. The crash happens because a use-after-free in ExtendedDragSource's destructor, when attempting to notify registered observers about its destruction. More specifically, the issue happens because DragDropOperation instance doesn't remove itself from the extended drag source's observers list when it's destroyed in response to a session cancellation. This patch fixes it and, additionally, cleans up how DragDropOperation access to the extended drag source instance is done, by associating it with its seat instead of the data source, simplifying code handling (ext-)source destruction, etc. R=oshima@chromium.org Bug: 1099418 Change-Id: I265379fb0aed0742674d3dcd97815b1cffdc709f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514360 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#824060}
-
Liquan (Max) Gu authored
Refactors disconnectIfNoPaymentMethodsSupported() so that: * it becomes ready to be moved into PRService, * hasAvailableApps() becomes ready to be delegated through BrowserPR * disconnectForStrictShow() becomes ready to be delegated through BrowserPR Bug: 1144527 Change-Id: I4dab80acf293fc332729970e546a5c059b8c9e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515522Reviewed-by:
-
Amr Aboelkher authored
This CL add unit tests that tests all different scenarios that the PSM can encounter. That doesn't include tests for PSM + hash dance. See go/cros-psm-client-unittests-coverage for an overview of the test cases for the different cases. BUG=chromium:1136866 Change-Id: I69d16af68fecde5212f362f84ed5bbcb05a971e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461343 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824058}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604447854-94cc190ab0ce9114e706f7027e39b9e22ef628e2.profdata to chrome-win64-master-1604480374-c14bff331808fa9a4e787bbbdb6a7c4b82678afd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ida011a017387f5d96c1d7163687503a4d8814a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824057}
-
Mason Freed authored
This CL removes the WebComponentsV0 feature added in [1] for WebView. This was a temporary feature, to enable developers to control these features starting in M86, because a Finch config began disabling M86 Web Components for all users. Now that M86 (and M87) are out of Dev, this CL removes this feature flag completely. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2268544 Bug: 1021631, 1021631 Change-Id: Ie6d14040105f2a239b8f95caae88a95d1da1f7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514590Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#824056}
-
Rob Buis authored
Implement italic correction [1] when laying out scripts. In order to signal that an operator has an italic correction we add SetMathItalicCorrection on the fragment builder and set it if needed when laying out the operator. The script layout algorithm uses this value when laying out the script, where appropriate. [1] https://mathml-refresh.github.io/mathml-core/#dfn-italic-correction Bug: 1125136, 6606 Change-Id: I2995b0fad1e1c8e96cc08818d50927d28cb54f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414240Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#824055}
-
Michael Thiessen authored
Updates imports in chrome/browser/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: I13e7a3352607cf4ec907a8a5ec1b99a827ce85af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518133 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824054}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py c9f69ee7`. Disable ArcDataSnapshotdManagerBasicTest.RestoredAfterCrash under msan since it has uninitialized memory accesses that the new compiler identifies (https://crbug.com/1144452) Bug: 1126953,1144452 Change-Id: I8e526de19b723ac7a4b5ca36c511d70378b7f68f Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518420 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#824053}
-
Michael Thiessen authored
Updates imports in chrome/android/features/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: Iff732b193bc6da12aa7b9c4e39aba032989f1fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518215 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#824052}
-
Dan Sanders authored
This CL adds support for VideoFrame.createImageBitmap() for frames that are PIXEL_FORMAT_XRGB. This includes all frames produces by VDAs that are configured to request PIXEL_FORMAT_UNKNOWN, such as DXVA VDA in its FP16 mode. Bug: 1145292 Change-Id: I853c6b92d84ffdc3f678f62e9407f8ee53efe683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518112Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#824051}
-
zhiyuancai authored
Bug: 1139194 Change-Id: If4fb560c5be11a613830ab76b2b9908904c882eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490022Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#824050}
-
Arthur Sonzogni authored
This reverts commit be0013d4. Reason for revert: http://crbug.com/1145139 Original change's description: > [OutOfBlinkSandbox] Reenable the DumpWithoutCrashing. > > Those DumpWithoutCrashing have been removed twice. > > A few potential issue have been solved recently: > - [ignore-csp-sandbox-report-only] > - [sandbox-vs-mhtml] > - [non-optional-frame-policy] > > This patch adds them again. I would like to know if they would still be > triggered into the wild. > > ------- > > [ignore-csp-sandbox-report-only]: > https://chromium-review.googlesource.com/c/chromium/src/+/2498605 > > [sandbox-vs-mhtml]: > https://docs.google.com/document/d/13jcj_mATRxKakPEGy72YYHZBTBkkNrAHzaNIIjVsC8I > https://chromium-review.googlesource.com/c/chromium/src/+/2450270 > https://chromium-review.googlesource.com/c/chromium/src/+/2467917 > https://chromium-review.googlesource.com/c/chromium/src/+/2480083 > https://chromium-review.googlesource.com/c/chromium/src/+/2479365 > https://chromium-review.googlesource.com/c/chromium/src/+/2467917 > > [non-optional-frame-policy]: > https://chromium-review.googlesource.com/c/chromium/src/+/2460890 > > Bug: chromium:1041376 > Change-Id: Ie503453ed163b01643a90122b61fa2567ec7660f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502930 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821856} TBR=lukasza@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1041376 Change-Id: I626d2ba70dbfc9038ee00ac2f54d24eeb8967a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517575Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824049}
-
Gayane Petrosyan authored
Bug: 1139864 Change-Id: I17686adaf4241202e400acb18f6c8fc8b6a83a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513290 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
-
Antonio Gomes authored
With this method implemented, immersive fullscreen starts to visually behave in Lacros/Chrome: the slide-down tabstrip shows up upon user hovering over the screen upper boundary. BUG=1113900 R=jamescook@chromium.org Change-Id: I2fa155c108854b709d49e020eb7add4b2bc6e14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519481Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#824047}
-
Jordan Demeulenaere authored
This CL is a pure refactoring that aims to simplify ElementFinder by removing the current_match_arrays_ field. Instead, ElementFinder now stores all current matches in current_matches_. If a filter returns more than one match in a JS array, then this array will be directly resolved and the elements it contains will be added to current_matches_. This should make it easier to make ElementFinder return multiple elements matching a selector in the same order than they have in the document. See [1] for more background on why we would need that. [1] https://docs.google.com/document/d/167LaI_WQNr31wBuO3DNlCPD2sx3If2GOHpPsT4atXIk/ Change-Id: I859183d48e0ed85de111c6d7bf0a497363c4e230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510331 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824046}
-
Greg Kerr authored
Bug: 11395583 Change-Id: Icbc2309ab65fbd4ab197f0c9f695453ba476a90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519030Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df4c267aa2c7..bf4d166806ec 2020-11-04 alancutter@chromium.org Fix chrome_update_extension_cache.py 2020-11-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-04 ahassani@chromium.org cros_flash: Fix the issue with /test xbuddy path 2020-11-03 seanabraham@chromium.org OWNERS.ci: add Jack and Julio 2020-11-03 tcwang@google.com afdo: Allow multiple Chrome ebuild to exist when getting version 2020-11-03 manojgupta@google.com cros_setup_toolchains.py: Install llvm libraries for i686 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib25bce07e15678c4c8078e3f3ccd055e6546cc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519052Reviewed-by:
-
Nico Weber authored
cflags is empty on Win, so no need for this if anymore. Bug: none Change-Id: I3ca13bf2b5b189a7d204fffd3f464c47c6fca1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519754 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Benoit Lize authored
Bug: 998048, 1141752 Change-Id: I3b351981e4b51740a51b9756f214bb0f02eb6ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505830Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824042}
-
Xianzhu Wang authored
Cc requires additional bookkeeping for the case, including setting the mask layer as a backdrop mask layer, etc. Also let CompositeAfterPaint composite the backdrop mask layer which is also required by cc. Bug: 1144520 Change-Id: Id9be79d398c1c4b41aa97a7c8c3e23546ce87365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518440Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824041}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 1142671 Change-Id: I509e155d3310bea9c1cc59bcd997d0bdcf24c5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500489 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#824040}
-
Tibor Goldschwendt authored
This CL: * Merges InstantTestBase::Init into InstantTestBase::SetupInstant. Both functions were required to be called successively for instant setup to take effect. Merging the functions makes this more explicit. * Removes option to initialize a suggestion URL since that functionality was never used. * Removes some getters and fields, which are no longer needed. Change-Id: Ia0c9f7f601f71b5fe41c74e067a0aa1f6aaa543d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515222Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824039}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/265c5fa9a7e0..8a275449c2e8 2020-11-04 lehoangq@gmail.com Metal: Add ES3_METAL to ANGLE_ALL_TEST_PLATFORMS_ES3 2020-11-04 xiaoxuan.liu@arm.com Vulkan display mode: fix skia build failure 2020-11-04 lehoangq@gmail.com Metal: fix max varyings, copyImage between mips, depth fmt 2020-11-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b5bf82693f85 to 19f01495a8a1 (6 revisions) 2020-11-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 1b2f8307f21d to 128608f6da3a (17 revisions) 2020-11-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 5735576f87be to bcf5b211db92 (4 revisions) 2020-11-04 lehoangq@gmail.com Metal: Support tri-fan & line-loop with primitive restart 2020-11-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ce54b897 to 9c36b526 (443 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ie723bfb9139e232fc77979f437441e60c00fb134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519656Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011040600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/aw2f7hpx9WRCZvGKvQ8vsqeXQ5wsrhcHZ-1mxf3jOEQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I05e3fae6c8833240919ee48cb1972eab22ed0cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519657Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824037}
-
Francois Doray authored
[PM] Remove expectation that DidStartLoading/DidStopLoading are invoked in alternance in PageLoadMetricsWebContentsObserver. R=chrisha@chromium.org Bug: 1145482, 1145572 Change-Id: Icedfcd1675de8751cf17ee44d396090270131ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519478 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#824036}
-
Sam Maier authored
Calling GMSCore's isGooglePlayServicesAvailable(context) uses our SDK to check what corresponding version of the GMSCore app we need on the device. This assumption (that we need the GMSCore app to be ahead of the SDK) hasn't been true for years for most Google apps, and that requirement is breaking us when we update to bleeding-edge GMSCore SDKs. This is currently blocking new users from signing into Canary. Testing: Was able to reproduce error message with local build: https://photos.app.goo.gl/e9PJ9cmhRaeH7THt6 With this change, error message did not appear, and signin button was not greyed out. This is consistent with another local build made before the breaking roll occurred. TBR: nyquist, mattreynolds, bsazonov for urgent refactor Bug: 1144669, 1145211 Change-Id: Iea18fc7340222bbf6027e210318cca6c68105a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518219 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
Due to a mistake in refactoring, the EULA was never marked as read, and the location pop-up was never shown. Fix these by moving relevant code to scene controller. It seems like running this code multiple times (if multiwindow is used in FRE) is safe and will not cause issues. Bug: 1145063 Change-Id: If61e1fdb75b8cf6e1743c543d4570279f1f7a2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517953 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824034}
-
Peter Kasting authored
Bug: 772945 Change-Id: I6623910c2a85b4b662e9bef1951f3c9f811eb0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515100 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#824033}
-
Danila Kuzmin authored
Change-Id: Ic67cc2f5f47ac21a392cc2c0c66530819ee96c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517724Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#824032}
-
Mario Bianucci authored
This CL includes several improvements to autotest.py: -Slightly expand the GTest regex. -Previously, it missed some tests due to them not explicitly including gtest via #include "...gtest.h". Variations included <...gtest.h>, gmock.h, or via *test_utils.h. Expand the regex to include these cases. -In my (limited) testing I didn't see any large regressions in terms of number of files added via the expanded regex, but its possible there is something I missed. -Add utf-8 encoding when opening a file to read. -This avoids errors when opening files with non-English characters. -Debugging lines to output all files that matched the regex. -Added sys.executable to beginning of call to make-gtest-filter.py. -This enables it to work on Windows, which requires 'python3' before calling a python script. Change-Id: Ic9e67658b7298867d997ba4cc396320bf5d61c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517944Reviewed-by:Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#824031}
-
ssid authored
The flush in discard buffer mode happens only at end of trace and the packet is discarded if the buffer is already full. So flush after writing the metadata packet. Change-Id: I4cc75a03909629eace1e8bdfcb4eeb2239ad1309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518520 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#824030}
-
Yue Li authored
Bug: b/168541952 Test: Run existing tests Change-Id: I3aa883b677516b646658c583165eff017e728117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518722 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824029}
-
Henrik Boström authored
I looked at the implementation of libyuv::MJPGSize() and discovered that part of "loading" the data required validating it, which involves reading up to 1 kB of bytes looking for an End of Image marker. Loading and unloading it like this seems like an awful waste if all we want to do is get the width and height... Luckily, the CVSampleBuffer contains a format description that has the dimensions, which I assume means getting them without reading 1 kB of raw data. This CL gets the dimensions that way instead of libyuv::MJPGSize(). (Note that libyuv::MJPGSize() is still used for sanity-checking inside of the unit tests.) Bug: chromium:1132299 Change-Id: I2c32bc319d3ae61cd6ea863ce59ab38f9fdd9d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517948 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#824028}
-
