- 21 Oct, 2020 40 commits
-
-
Rohit Agarwal authored
This CL refactors the test code on profile and adds Incognito CCT tests. Bug: 1060940 Change-Id: I1e340b9dc34d080c1b2a191720c37d7c6db17cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489903Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819409}
-
Tommy Li authored
For HistoryQuickProvider, we use an in-memory URL database called URLIndexPrivateData. This in-memory database is rebuilt from History if its own cache file is missing or corrupt. Previously, Android devices were limited to 1000 entries during the rebuild step, whereas other platforms had no limit. There are some pathological cases where unlimited is bad, such as when users are stuck in a redirect loop with autogenerated URLs that spam their history. This CL adds a 20,000 entry cap for all platforms, and that should be safe, as that will affect only 0.01% of Windows users. I plan to add further per-eTLD+1 caps and per-URL length caps as well in followup CLs. NOTE: This only affects the case where the HQP cache file is missing or corrupt, and the HQP index has to be rebuilt on startup from the History DB. This is an unusual case, so further work will be needed to address the typical present cache file case. Bug: 750845, 1032679 Change-Id: Ia9e309dd43e3272823d69c707cceb8abe1a192ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488384Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#819408}
-
Andrew Grieve authored
Abstracts the pattern of looping over weak references and removing stale ones. * Converts UnownedUserDataKey to use WeakSet since order does not matter. TBR=agrieve # Trivial refactor in AutofillManagerWrapper.java Bug: 1131047 Change-Id: Idf226faecb31de69f7b7bbae32d6c795dca3dca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477050 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819407}
-
Achuith Bhandarkar authored
BUG=chromium:1115622 TEST=chromeos-betty-arc-r-chrome Change-Id: I002720f117ca6bad652fe44d42222da4b584ac16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488900Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#819406}
-
Hai Bi authored
The ScopedService* publishing templates infer the service name from the supplied Interface class. It is sometimes desirable to publish a service under a manually-specified name, e.g. if the service isn't actually defined as [Discoverable], or it's needed to publish it under a different name. The templates now accept an explicit |name| parameter which defaults to the name of the Interface, if available. Bug: b/171256428 Test: locally tested and pass unit tests Change-Id: If206fea8a7555baea5806b8526be2affc1e0dc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486620 Commit-Queue: Hai Bi <bihai@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#819405}
-
rbpotter authored
Bug: 987318 Change-Id: I7c8943f15724e6387c5a1a9fc1666c1940422020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486459Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#819404}
-
David Grogan authored
Just a test, no behavior change. Fixed: 965672 Change-Id: Iaf1f86a92aa6c65e33736850ea2fbd5411db45d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488984Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819403}
-
Lukasz Anforowicz authored
Similarly to r778581, after this CL, the rewriter will no longer unconditionally skip fields in the following scenarios: - Field pointing to a struct/class with deleted operator new - Fields in generated code Instead, the rewriter will emit such fields as candidates for the --field-filter-file blocklist - in the following section of the output: ==== BEGIN FIELD FILTERS ==== GeneratedStruct::ptr_field # generated-code MyStruct::ptr_to_stack # pointee-has-no-operator-new NoNewOperator::field # embedder-has-no-operator-new ==== END FIELD FILTERS ==== Skipping via filter list is desirable, because it helps with auditing and counting the filtered fields. In particular: - operator-new-based cases should be vetted to ensure the heuristic is sound and check what kind of cases are present outside of Blink - generated code should eventually be fixed (to use CheckedPtr as appropriate) after the rewrite and explicit auditing will help scope this work Note that the "embedder-has-no-operator-new" case was not present (i.e. was not unconditionally skipped) before this CL - this case is new. Bug: 1069567 Change-Id: Ic67ac7a94225d0e11e1e405e75dc41a7248ab67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488744Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#819402}
-
Marc Treib authored
This method was always called synchronously from ModelAssociationManager::Associate(), so no need for a delegate method - instead, the one implementation is inlined at the relevant place. Bug: 1102837 Change-Id: Ic69b0f93baa5780c76ab95f45904fd2ca9e08b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489642Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#819401}
-
Yuly Novikov authored
Prefer to configure directly when possible. TBR=bsheedy Bug: 1140626 Change-Id: I083b48a520f2dc2def0986793096b40e898b9bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490384Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#819400}
-
Ghazale Hosseinabadi authored
This CL removes WINDOWS_GETCURRENT API test coverage from ServiceWorkerBasedBackgroundTest. The reason is 1)The test is flaky, 2)The API test coverage is already added in NonPersistentExtensionTabsTest.TabCurrentWindow. Bug: 1140254 Change-Id: I90d93a27d3c3f420b2a12f17a38503850f33bf79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487868Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#819399}
-
Idries Hamadi authored
When visibility metrics are written to histograms only the currently tracked visibility bucket is logged. This can lead to some data loss. This patch changes the behaviour of the record implemeantation to write any outstanding data for all buckets. Also fixed a couple of spelling errors in comments. R=tobiasjs@chromium.org Bug: 1139372 Change-Id: Idad1e18c9f581dab2579bce315b7b5f0750c736e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480565Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Idries Hamadi <idries@google.com> Auto-Submit: Idries Hamadi <idries@google.com> Cr-Commit-Position: refs/heads/master@{#819398}
-
Paul Moy authored
Now that the battery health and capacity routines have good default parameter values, and can look up board-specific parameters from cros_config, we no longer need to expose these parameters to the end user. This will make the routine easier to run effectively, because the user doesn't need to know what good values for the parameters are. Bug: chromium:1131609 Change-Id: Ie4a11fefbce13b4777144c06e67139b91f53f839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477287 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#819397}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be6747613d78..d139f2661939 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I97907b4f90025157ec3dce017124022b3700f404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490068Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819396}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010210700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ce3CRtV0VP2yelnNkFkhuX0bCzB4BFzKPeYxeIRHf70C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159867576,b/165720635,b/169021817,b/171275470 Tbr: media-app@grotations.appspotmail.com Change-Id: I7ff7d995e1b91f85571af41112f59fbfe811a898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490300Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819395}
-
Chris Lu authored
Bug: 1138603 Change-Id: I72ecd463778caa7adac8a0ef041ec01dbd0c5f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486071 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819394}
-
cfredric authored
Change-Id: I4edb4c31afbd3d54b2bbe673778a783810312dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477041 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#819393}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be6747613d78..d139f2661939 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib23dbfb3bac151ac4abcc2d66881dd326a482f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489786Reviewed-by:
-
Wez authored
This reverts three auto-roller commmits: https://chromium-review.googlesource.com/c/chromium/src/+/2488154 https://chromium-review.googlesource.com/c/chromium/src/+/2487918 https://chromium-review.googlesource.com/c/chromium/src/+/2488154 Reason for rollback: Broke the Fuchsia ARM64 build (crbug.com/1140854). TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I11c4365476e0d827e76e6ca2f7d2e8f97424152c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140854 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490106Reviewed-by:
-
Koji Ishii authored
Legacy does not use hyphenation points that are beyond the line end, but LayoutNG does. The LayoutNG behavior is more correct. This patch updates the expected file to the LayoutNG behavior, and marks the test to fail in `disable-layout-ng`. Note, while crbug.com/870219 was fixed in LayoutNG, the test from the reporter still has a few undesired results, due to crbug.com/1022415 (sometimes it hyphenates though, which is unexpected) and crbug.com/1140738. By adding one more word and using the build the latter issue was fixed, the result looks correct. TBR=ikilpatrick@chromium.org, tkent@chromium.org, yosin@chromium.org Bug: 870219 Change-Id: I6ec6262b2a79e3a5815f4ffd4cd7a34507b2735d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489777Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819390}
-
Aya Elgendy authored
Fix a typo in the pin dialog error message which read "1 attempts left" instead of "1 attempt left" when the user has attempted incorrect pins and there's only 1 attempt remaining. Fixed: 1060695 Change-Id: Ic9f51d03f87e8d4090cb6f93a5968e0436fdcdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487106Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
-
Fergus Dall authored
We translate this folder name when it's initially created, but if the folder already exists in the sync service we don't touch it. Since this folder name is not set by the user, we should re-translate the name whenever this might be necessary. Language changes aren't required to take effect without restarting chrome, so doing this on startup is sufficient. Bug: 1133151 Change-Id: I91f656029e71c88a40641447d1e001f1a0751ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489923 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819388}
-
Jesse Schettler authored
Replace the temporary app icon with the finalized app icon. Bug: 1059779 Change-Id: I6105da8922cb0ccc0ac40c9fe061ebdb8ec9a44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486480Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#819387}
-
Elly Fong-Jones authored
It flakily hangs, which is being investigated but is not a blocker since the hang watcher isn't shipped on Mac currently. Bug: 1140207 Change-Id: I47ab3bfc8770c85b0b3de608295ade53a43e7669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486078Reviewed-by:
Oliver Li <olivierli@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819386}
-
Finnur Thorarinsson authored
It is a much simpler and easier way to load native in the PWA Install test for IPH. Bug: 1135551 Change-Id: I4d20f9ac5a4cfd1cdc00f81bae713c4b514c54d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489902Reviewed-by:
-
Ramin Halavati authored
Unnecessary code is removed from GuestProfileWindow browser test. Bug: 1125474 Change-Id: Ica812265c273a8cfe041046a44ce65e8c8b0f83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490101Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#819384}
-
Wei Li authored
Add support for unique_ptr type of properties. Set their type converter to be non-serializable. Convert Combobox's 'model', 'owned_model', and 'callback' into properties. And apply them into the example builder to show the usages. Bug: 938501 Change-Id: I065f35420e266a0641754edf8edfebd8188f4144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477484 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819383}
-
Ramin Halavati authored
Ambient Authentication browser tests are updated to cover both current and ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I76a6e4ec9de4dd079377ed3d01a68cfdc3fe6cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488563Reviewed-by:
-
Olivier Li authored
Change-Id: Ie80616b0071da96a1879f84ba67c0c9fb08af6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490222Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#819381}
-
Nidhi Jaju authored
This is a reland of b52b97cb Original change's description: > Remove NotEnumerable from Transform Streams WebIDL > > According to https://github.com/whatwg/streams/pull/1035, all methods > and accessors are now enumerable, per Web IDL defaults, instead of > non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can > be removed from the Streams WebIDL files. This CL specifically > removes them from transform streams. > > Bug: 1093862 > Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006 > Commit-Queue: Nidhi Jaju <nidhijaju@google.com> > Reviewed-by: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819230} Bug: 1093862 Change-Id: Ic3d119e1c5d2192a3159fb672a5782fa2af8aedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488946 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#819380}
-
Fernando Serboncini authored
Change-Id: I5eec0c769d43c51078d759f4f9765b8b3d792c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490381Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#819379}
-
Paula Vidas authored
Server puts the invalidation payload in message.raw_data, and not in message.data["payload"]. Bug: 1140988 Change-Id: I92a01fc6e7e83cc0065fb464660dd6e25a5cbe27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489888Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#819378}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d139f2661939..9606cffa66d0 2020-10-21 fmayer@google.com Support PERFETTO_EINTR in clang-tidy analyzer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4e5dfff37bc9c8d19b0f2edfb4b525ce86ee403c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490066Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ffad5d3b2d0a..01771c17f1d6 2020-10-21 robertphillips@google.com Increase encapsulation of GrThreadSafeCache::Entry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: egdaniel@google.com Change-Id: Ic4993ef9e30a33a0c446de3a7451b65b90fd329d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490067Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7854287f1b6c..ee87b994218e 2020-10-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-21 sigurds@chromium.org Increase timeout for long-running test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140926 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6c4167a4cac59311c0366c3534f2a29ecc46e465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489769Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f176182440e7..7b3ad4f25a17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com,sebsg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: apotapchuk@google.com,sebsg@google.com Change-Id: I43740d81653785374ae01b975e2230d9da94371c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489664Reviewed-by:
-
Mugdha Lakhani authored
Deletes three methods that aren't used anymore. Bug: 1106294 Change-Id: Id330a6b8b56d339f3a596fcdefea9d5c21b32f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478947Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#819373}
-
Mihai Sardarescu authored
As is_default_promo_account is always true for the native turn sync on promos, this CL removes this argument from the DiceBubbleSyncPromo and its delegates. Bug: 1140978 Change-Id: I343b9e1a8cab16232f618bd7ca34bcbfdb44748f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489982Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#819372}
-
Sylvain Defresne authored
The parameters of a script invocation needs to be relative to the directory where the script is invoked which is available as the `root_build_dir` variable. Using `root_out_dir` is incorrect as it has a different value for secondary toolchains (i.e. current_toolchain != default_toolchain). Bug: none Change-Id: I3fc329e27657377493c3c7cca6b7ff060531ec87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489624 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#819371}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0a69b07fe85f8ddab1929ee0e8b22a4213d3bda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490160Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819370}
-
