- 06 Oct, 2018 16 commits
-
-
Chris Palmer authored
It might? be the cause of some test flakage. Bug: 892550 TBR: ajwong Change-Id: I4ac98e2e5e3d02526ed2c187157d097b82adc756 Reviewed-on: https://chromium-review.googlesource.com/c/1266199 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597390}
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Idcb7d92facb808a6ab457f03f8a666d042b29a37 Reviewed-on: https://chromium-review.googlesource.com/c/1265131 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#597389}
-
Xiaohui Chen authored
Bug: None Test: locally build Change-Id: I621187794e1261d4fc7c91221dfb5bfaa3eef079 Reviewed-on: https://chromium-review.googlesource.com/c/1266599Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#597388}
-
Xiaohan Wang authored
Now the CDM is loaded as a shared library. We do not need the .lib file in the build process. Bug: 772160 Change-Id: Iee1fe3995a72b5fa79ead43f2e10880a6f4bc433 Reviewed-on: https://chromium-review.googlesource.com/c/1265909Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#597387}
-
Nate Chapin authored
This adds a new task queue API that returns a handle for the posted task, and allows future tasks to take this handle as a parameter. This creates a dependency between the two tasks, and the prerequisite task will pass its return value as a parameter to the dependent task. Also, fix a Persistent-rooted reference cycle that was causing ThreadPools (and their associated threads) to leak. Bug: 879306 Change-Id: I9af6b85ca2e56da464d4316b29bda53ba694e35a Reviewed-on: https://chromium-review.googlesource.com/c/1242074 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#597386}
-
Kenneth Russell authored
Dump without crashing on Android if this happens. Bug: 892490 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I824a4f4b9f09d3267113d6384370acae059e1690 Reviewed-on: https://chromium-review.googlesource.com/c/1266335Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597385}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f75ce5a16f89..ff45f4b0da47 git log f75ce5a16f89..ff45f4b0da47 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 dgarrett@google.com gen_luci_scheduler: Update deployment docs. 2018-10-05 richardfung@google.com Copy cheets_arm64 artifacts on Android uprev 2018-10-05 briannorris@chromium.org manifest_version: more verbose messages for UpdateStatus() failures 2018-10-05 vapier@chromium.org paygen: {file,gs,uri}lib: drop unused Size helpers 2018-10-05 dgarrett@google.com firmwarebranch: Use WorkspaceInitSDK. 2018-10-05 dgarrett@google.com firmwarebranch: Improve "dummy" metadata.json. 2018-10-05 dgarrett@google.com portage_util: Readd CROS_WORKON_SUBDIR compatibility. Created with: gclient setdep -r src/third_party/chromite@ff45f4b0da47 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If1f5bc93d1cf86ee376a1dad09d0312e72cbb830 Reviewed-on: https://chromium-review.googlesource.com/c/1266037Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597384}
-
Scott Violet authored
This makes the event serialization code handle TouchEvents. I plan on doing a cleanup pass to make MouseEvent serialization use the PointerDetails struct traits. BUG=865781 TEST=covered by tests Change-Id: I190ac58a3066c10bc08cd083702bc15232d4141d Reviewed-on: https://chromium-review.googlesource.com/c/1265160 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#597383}
-
Miguel Casas authored
This CL follows up on comments on crrev.com/c/1238798 and splits MockEmbeddedFrameSinkProvider onto a file on its own. It also adds a member to be passed to MockCompositorFrameSink to signal the expected number of calls to SetNeedsBeginFrame. Bug: 888122 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iceb35a215c6a4b34b152d2d1be077ef2c14e0234 Reviewed-on: https://chromium-review.googlesource.com/c/1248627Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#597382}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2cefd983..a9fed87a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0947c346151f7dd0216271eafbea5f950d911120 Reviewed-on: https://chromium-review.googlesource.com/c/1266097Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597381}
-
Xiaoqian Dai authored
It's needed for crbug.com/874510. Since we have different WindowResizer for laptop mode and tablet mode, and they will have different behavior for fling/swipe events, we should let WindowResizer to do the fling/swipe event handling. So move the logic to WindowResizer. No functionality is changed in this CL. I'll add special logic for tablet mode window fling/swipe in a following-up CL. Bug: 874510 Change-Id: I91b917e8ec947681db12d5be8b8c8b982299af9a Reviewed-on: https://chromium-review.googlesource.com/c/1262457 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597380}
-
Kenneth Russell authored
This code path de-duplicates video uploads to textures, but something is wrong with the de-duplication logic and it's causing video frames to sometimes not be uploaded when they need to be. The WebGL conformance tests run on the waterfall with --enable-experimental-web-platform-features in order to exercise some upcoming features, but this particular one must be disabled for reliable test execution. This experiment can be manually enabled with the command line flag --enable-blink-features=ExtraWebGLVideoTextureMetadata . Moved the layout test verifying this functionality into its own virtual test suite. Bug: 830901 Change-Id: Ic7bc75cd71f6a8d74ce85ded6153fb9782f73eb6 Reviewed-on: https://chromium-review.googlesource.com/c/1264542 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#597379}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/edc5b1e7e7ce..a17c8cd6fb46 Created with: gclient setdep -r src-internal@a17c8cd6fb46 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I33e6c7cf7311a28841fa43a322fbd11c28ab8fe4 Reviewed-on: https://chromium-review.googlesource.com/c/1266038Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597378}
-
Ned Nguyen authored
The recipe is removed in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1262098 TBR=jbudorick@chromium.org Bug: 786243 Change-Id: Ia989be803ba4baf683939943069bd8d1c016181d Reviewed-on: https://chromium-review.googlesource.com/c/1265134Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#597377}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b20364c99015..a0032a2a2c53 git log b20364c99015..a0032a2a2c53 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 thestig@chromium.org Remove optional matrix parameter from CPDF_PageObject::GetBBox(). 2018-10-05 tsepez@chromium.org Remove one CSection::m_pVT null check 2018-10-05 tsepez@chromium.org Tidy CPVT_WordRange 2018-10-05 thestig@chromium.org Add booleans for form flags in CPDF_FormField. Created with: gclient setdep -r src/third_party/pdfium@a0032a2a2c53 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie86a6896ac1af26739e269a968dc145b9b49c482 Reviewed-on: https://chromium-review.googlesource.com/c/1266036Reviewed-by:
-
rbpotter authored
Re-enabling: CrSettingsCrostiniPageTest.All since it now seems to be passing on ToT. Fixing and re-enabling: CrSettingsBluetoothPageTest.All Bug: 875454 Change-Id: I0a4211439267d5e9efc9a4cb6a04e6964ba0e7fd Reviewed-on: https://chromium-review.googlesource.com/c/1265824Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597375}
-
- 05 Oct, 2018 24 commits
-
-
James Cook authored
Display observers have historically caused problems on Chrome OS. They are not performance critical, so converted from UncheckedObserver to checked observer. Bug: 842987 Change-Id: I803afb4c6b5a2ef8e2bf1652183a8835243d07ec Reviewed-on: https://chromium-review.googlesource.com/c/1263338Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#597374}
-
Ella Ge authored
This reverts commit 9bdc415d. Reason for revert: This workaround is causing issue such as: crbug/888440 and the also black patch mentioned in crbug/879766#50 Original change's description: > solid color quads workaround for use-zoom-for-dsf > > solid color quads used scale = 1 for non-mask layer, so when > use-zoom-for-dsf is enabled, it generates a lot more solid color > quads, which causes a bunch of rendering performance regression. > > This CL makes the scale = 1 / dsf when use-zoom-for-dsf is enable, > so we generate same amount solid color quads as before. > This should not break solid color quad as it doesn't count dsf before. > > Bug: 871347 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7f30ebf51fbd9bfe8800aa34f228b98985358c39 > Reviewed-on: https://chromium-review.googlesource.com/1234362 > Reviewed-by: weiliangc <weiliangc@chromium.org> > Reviewed-by: Xianda Sun <sunxd@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593221} TBR=weiliangc@chromium.org,sunxd@chromium.org,eirage@chromium.org, kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 871347, 888440 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaac40f237a97cc57cb91905d73b65ccb3afd5d6f Reviewed-on: https://chromium-review.googlesource.com/c/1264740 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#597373}
-
Andrew R. Whalley authored
Including a reminder for sheriffs to download attachment and unzip zip files, and how to deal with Chrome OS issues. Change-Id: I286b2a3f25a19d43f11ebc92c7bcda6e489322c8 Reviewed-on: https://chromium-review.googlesource.com/c/1266057 Commit-Queue: Andrew Whalley <awhalley@google.com> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#597372}
-
Sidney San Martín authored
- The old implementation recreated the Touch Bar on each keystroke (including when hidden, I believe), which burns a significant amount of power while typing. This new implementation updates the existing candidate list, if it exists and isn't collapsed. - Removes a bunch of support code for a behavior that was disabled in r590669. It moves the remaining code into RWHV itself instead of a dedicated controller class, which I have mixed feelings about, but ultimately picked because after the support code was removed, most of what was left was plumbing between RWHV and TextSuggestionsTouchBarController. - [Bigish change] Moves text suggestions out of the window and into the RWHV, so that hiding and showing as focus and web contents change is left to AppKit and the responder chain. - Fixes small lifecyle-ish bugs around when use this kind of Touch Bar — now it's tied to the RWHV's input type instead of using a special WebContentsTextObserver. Bug: 717553, 881545 Change-Id: I8e1eff6da7918f92cfdb47465196d5841a88a7e4 Reviewed-on: https://chromium-review.googlesource.com/c/1212004 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597371}
-
chaopeng authored
The crash log shows SetNeedsPaintInvalidation maybe causes by PLSA destroyed before dispose. In this patch, we change the HasBeenDisposed DCHECK to CHECK to make it crash early. Bug: 883876 Change-Id: Idc65a71861bc93462030b9f7193be074abf3343f Reviewed-on: https://chromium-review.googlesource.com/c/1263594Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#597370}
-
Matthew Jones authored
Layout#usesToolbarLayer is never used and can therefore be removed. Bug: 882508 Change-Id: Id255a67c696e47080e00f58e74500643f3ed04c8 Reviewed-on: https://chromium-review.googlesource.com/c/1265120 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#597369}
-
Matthew Jones authored
This patch removes some old Chrome Home code that caused the bottom sheet to peek when exiting VR. Instead, the BottomSheetController now listens to VR events and suppresses the sheet if necessary. Bug: 840481 Change-Id: Iad8e20cd9876c2487150eac69693bac60266dee5 Reviewed-on: https://chromium-review.googlesource.com/c/1265834 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#597368}
-
Vladimir Levin authored
This patch unaliases effect nodes in two places in layout object: - HasDistortingVisualEffects - HasNonZeroEffectiveOpacity, both of which navigate up the effect node chain and check properties. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib035679dff6822a7cc6127d6b7589e10a89e0cc3 Reviewed-on: https://chromium-review.googlesource.com/c/1265088Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597367}
-
Xiaohan Wang authored
- Update cdm type converters to support high bit depth video formats. - Update ClearKeyCdm to support more video formats. - Add a new MojoSharedBufferVideoFrameTest to test high bit depth video frames. - Add a browser test to test end-to-end playback of encrypted 10-bit VP9 video. Bug: 707127 Test: New tests added. Change-Id: I2459454a36b44c0427458c903237d3872acfaa54 Reviewed-on: https://chromium-review.googlesource.com/c/1261970 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I10953860800adba8ee8aba894f3e2e099895589c Reviewed-on: https://chromium-review.googlesource.com/c/1265635Reviewed-by:
-
Ryan Sturm authored
If the InfoBar is being closed (animation playing) the InfoBar sticks around without an owner. owner_ should be checked for null before doing anything with it. Fortunately there is a helper method for exactly this case. Bug: 892627 Change-Id: I1b0f3286663bcb7b89c29f2ff097b3a41f3d0cd0 Reviewed-on: https://chromium-review.googlesource.com/c/1265715Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#597364}
-
Meilin Wang authored
Add API in ash_message_center_controller.mojom to support DO_NOT_DISTURB setting modification when query comes. Test: local compile and manually test. Change-Id: I645cff4aace79038ff8a7a39a498464cfced9979 Reviewed-on: https://chromium-review.googlesource.com/c/1260504Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597363}
-
Marijn Kruisselbrink authored
This reverts commit cf9baf41. Reason for revert: Seemed to cause test failures on Fuchsia https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/20283 Original change's description: > [service-manager] Introduce ServiceBinding > > Adds a new ServiceBinding helper to the Service Manager's client > library. This is intended as a replacement for ServiceContext, because > ServiceContext is cumbersome in its insistence to own the > corresponding Service object. > > ServiceBinding, like ServiceContext, deals with the IPC interface > between a local Service instance and the Service Manager, exposing > interesting events to the Service implementation while also providing > it access to its Connector and assigned Identity. > > Some particularly gnarly tests have been updated to use ServiceBinding > in lieu of ServiceContext. Furthermore, without ServiceContext and with > a lot of its legacy motivations gone, ServiceRunner isn't terribly > useful either. The tests have also been trivially updated to manage > their own MessageLoop instead of using ServiceRunner. > > This is the first in a series of patches which aim to completely > eliminate ServiceContext, ForwardingService (in service.h), and > ServiceRunner, requiring Service implementations to write a little more > boilerplate in exchange for flexibility with ownership semantics. > > Bug: 891780 > Change-Id: Ib0c1d3263f34a5e33a167a8187edad1d52413f73 > Reviewed-on: https://chromium-review.googlesource.com/c/1259485 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597324} TBR=rockot@chromium.org,reillyg@chromium.org Change-Id: Ib638e97e13b4d0ab24b0123323ff9941da6eb1fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891780 Reviewed-on: https://chromium-review.googlesource.com/c/1266135Reviewed-by:
-
Jialiu Lin authored
During the migration to IdentityManager, we noticed that some Arc* related tests setup are incomplete, such that they will potentially fail after IdentityManager migration. This CL adds more initial test setup to seed AccountTrackerService and SigninManager properly. No behavior or logic change. Bug: 883318, 892116 Change-Id: I4db443d7bd0c7df396e1c188743b869d2b9c2e82 Reviewed-on: https://chromium-review.googlesource.com/c/1265079Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#597361}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/37377c3e485a..edc5b1e7e7ce Created with: gclient setdep -r src-internal@edc5b1e7e7ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8d1f51e216bc8a187eec60a8f385528ca80dfb46 Reviewed-on: https://chromium-review.googlesource.com/c/1265917Reviewed-by:
-
Aiden Benner authored
First iteration of the JNI annotation processor for static methods. Adds a new annotation @JNIStaticNatives that when used on an inner interface, will trigger the annotation processor to generate native declarations and a wrapper class. I provided a sample usage in example/jni_generator/SampleForAnnotationProcessor.java Change-Id: If888b6fd41eafccb54af32aebde3a850bab55849 Reviewed-on: https://chromium-review.googlesource.com/c/1239348 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597359}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/78df3362ac21..450bf36f7918 git log 78df3362ac21..450bf36f7918 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 ynovikov@chromium.org Workaround Adreno driver not supporting unsized EXT_texture_rg formats Created with: gclient setdep -r src/third_party/angle@450bf36f7918 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ica3053cf8d719ea3d2b94352c089ad26df8cccd4 Reviewed-on: https://chromium-review.googlesource.com/c/1265916Reviewed-by:
-
Chris Harrelson authored
Also, rename the recursive recalc methods to remove the "AfterStyleChange" suffix, because it may not only be due to style, and the update is not going to happen right after style soon. This is a pure refactoring patch. It is step 1 of work to split work to recompute visual overflow from work to recompute layout overflow. See the referenced bug for more details. Bug: 892347 Change-Id: I791c143da4486763cea256036fc4c68b1cf79264 Reviewed-on: https://chromium-review.googlesource.com/c/1265509Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597357}
-
Xiaoqian Dai authored
The refacotring CLs exposed an underlying issue that caused b/117075672. I need to revert all the refactoring for now, and fix the underlying issue first and then reland these refactoring cls. Basically the assumption of "--enable-touchview" USE flag is not longer true, thus Chrome can't reply on this flag to decide whether a device is capable of entering tablet mode. We need to find other ways to do so. Since it's a pure revert, TBR xiyuan@. Revert "TabletModeController refactoring II." This reverts commit 43b3f48d. Revert "TabletModeController refactoring III." This reverts commit 95f93d44. Revert "Fix the regression caused by the refactoring." This reverts commit 5b0a138d. Bug:887042, b/117075672 TBR=xiyuan@chromium.org Change-Id: I494a8d05be1fb07bea404cd714b0b1d9689e46d4 Reviewed-on: https://chromium-review.googlesource.com/c/1265996Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#597356}
-
mrefaat authored
Some websites try to open itunes app, then redirects immediatly to http itunes url, in that case Chrome present app launch prompt and while it's there itunes url is loaded, so it allocates a storekit view and tries to present it and fails. The problem is on subsequent itunes http navigations, the coordinator check if there's a controller allocated, if so it will exit. And because the one allocated in the previous case was never dismissed it breaks the expected behavior. Bug: 892503 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie08160e37c6f27c02a081e06c9b956bc835cf4c7 Reviewed-on: https://chromium-review.googlesource.com/c/1263876 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597355}
-
Findit authored
This reverts commit ccb83d4a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 597330 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NjYjgzZDRhNTUxMjgwMmYxMTkzYTUwNmI1NDMxZTg1ZTAxMzgwNDMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8190 Sample Failed Step: compile Original change's description: > Implemented AXVirtualView > > Some widgets in Views, such as table and tree view controls, make use of lightweight objects to display their contents. > These lightweight objects are not View classes and hence have no native accessibility support. > To make them accessible, we introduce a virtual accessibility view that will be used to provide the accessibility support for those objects. > In addition, we could make use of virtual accessibility views to override the children of a real view and create a completely new accessibility tree hanging off that real view. > This creates more flexibility as it allows us to construct a virtual accessibility tree that is not always a mirror image of the hierarchy of the real views. > R=dmazzoni@chromium.org > > Bug: 101762 > Tested: unit tests > Change-Id: Iab8fea36ef44373e06d9408c407a27caa7c4219c > Reviewed-on: https://chromium-review.googlesource.com/c/1229234 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597330} Change-Id: Icc03389f14319c85bc30b101c9f30cc25aa16b75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 101762 Reviewed-on: https://chromium-review.googlesource.com/c/1265877 Cr-Commit-Position: refs/heads/master@{#597354}
-
Ned Nguyen authored
BUG:760498 This also reshard android_nexus5x_fyi_4_shard_map.json which may cause shifting data of heap_profiling.mobile.disabled benchmark TBR=pasko@chromium.org Change-Id: I561d9fbd628b2f53f6e043b524b93c32b03c56d1 Reviewed-on: https://chromium-review.googlesource.com/c/1265129 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/be4e055bce62..b20364c99015 git log be4e055bce62..b20364c99015 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 thestig@chromium.org Make CPDF_RenderStatus matrix params const-ref. 2018-10-05 rharrison@chromium.org Remove SetSaveCalled API 2018-10-05 thestig@chromium.org Add methods to read specific field flags in CPDF_FormField. Created with: gclient setdep -r src/third_party/pdfium@b20364c99015 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If62ef591bb2d525a0c73c6192ea89464629d4778 Reviewed-on: https://chromium-review.googlesource.com/c/1265915Reviewed-by:
-
Kyle Horimoto authored
(1) Previously, <multidevice-setup> contained the following line: <slot name="forward-button" slot="backward-button"></slot> This should have read: <slot name="forward-button" slot="forward-button"></slot> (2) Change closing </paper-button> to </div>. These didn't seem to cause an error as the page still rendered correctly, but this CL fixes these issues anyway. Bug: 884058 Change-Id: Ib7131d3126f664c8dd4f7aac82f94ce0bf28e8dc Reviewed-on: https://chromium-review.googlesource.com/c/1255048 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
