GitLab

This was deprecated since M58 (having been replaced by
chrome://net-export/)

If users still have bookmarks to #export, they will now get a dialog
prompt asking them if they want to be redirected to
chrome://net-export/

BUG=678386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856223006
Cr-Commit-Position: refs/heads/master@{#469574}

1, Fix hard code always translate value and show correct "always translate" state in the same session.
2, Refresh langauge list every time, in case use changed source/target language.
3, Fix menu button desc under talkback mode.

Tested on my local N5.

BUG=703887

Review-Url: https://codereview.chromium.org/2858013003
Cr-Commit-Position: refs/heads/master@{#469573}

Mediated three methods through WebDevToolsAgentImpl, which encapsulates
overlay logic inside. This will avoid changes outside of WebDevToolsAgentImpl
in case of multiclient.

BUG=590878

Review-Url: https://codereview.chromium.org/2859273002
Cr-Commit-Position: refs/heads/master@{#469572}

There are two redundant lines in this file, and this CL removes them. This CL
has no behavior change, only clean up code.

BUG=None

Review-Url: https://codereview.chromium.org/2863633002
Cr-Commit-Position: refs/heads/master@{#469571}

In preparation for upcoming MSE PTS/DTS compliance fixes, this change
fixes some code style and unclear comments in SourceBufferRange's
header.

BUG=398130

Review-Url: https://codereview.chromium.org/2857983005
Cr-Commit-Position: refs/heads/master@{#469570}

Replaced animation list parsing method ConsumeAnimationPropertyList
with a new more general list parsing method ConsumeCommaSeparatedList.
This removes the need to pass property information to the list parsing
method, instead passing a callback function to be called on each of the
items in the list.

This is pre work to implementing the parseSingleValue method in the
property APIs for the animation properties that expect a list, as the
APIs do not take property as an argument.

The new ConsumeCommaSeparatedList method can be used in other parts of
the code base, which may be done in future patches.

This patch
- Added ConsumeCommaSeparatedList templated function to
  CSSPropertyParserHelpers
- Made each animation list property in parseSingleValue use the new
  ConsumeCommaSeparatedList method instead of
  ConsumeAnimationPropertyList
- Deleted ConsumeAnimationPropertyList method

BUG=668012

Review-Url: https://codereview.chromium.org/2849363002
Cr-Commit-Position: refs/heads/master@{#469569}

Also made "Inspect Element" open DevTools for main page now.

BUG=652783

Review-Url: https://codereview.chromium.org/2859063002
Cr-Commit-Position: refs/heads/master@{#469568}

I stumbled on isValidForIntentFallbackNavigation and found that having this
more verbose tests would make it easier for me to understand what I can expect
from this method, without having to trace down its implementation.

Not feeling strongly, but I think these are worth adding.

BUG=

Review-Url: https://codereview.chromium.org/2855293002
Cr-Commit-Position: refs/heads/master@{#469567}

This patch generates the following fields as part of a group:
- background ('storage_only' of type FillLayer)
- background_color ('storage_only' of type Color)

Since both fields correspond to shorthands, we specify them in
ComputedStyleExtraFields.json5.

All deleted code are correspondingly generated in
ComputedStyleBase, apart from the line

  background_data_(o.background_data_)

which is implicit in the compiler generated ComputedStyleBase
copy constructor.

Diff of generated files:
https://gist.github.com/darrnshn/c2d2e7f7429b6281987c8f1ff6e2c313/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2861623002
Cr-Commit-Position: refs/heads/master@{#469566}

The Trusty sysroot was only used for building Chromium for ARM.  Since
this is now the responsibility of the Jessie sysroot, the Trusty
sysroot can be removed.

R=thestig@chromium.org,sbc@chromium.org

Review-Url: https://codereview.chromium.org/2859323002
Cr-Commit-Position: refs/heads/master@{#469565}

In most locations callers assumed the function returned !HTMLElement
already. Changed the one location (in advanced_settings.js line 177)
that did not assume this to not call the function, and changed
getChildElement to return !HTMLElement.

Also removed some asserts that are no longer necessary.

This CL reduces print preview closure compiler errors to 180.

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2857983007
Cr-Commit-Position: refs/heads/master@{#469564}

The method is fundamentally flawed (it invalidates the TaskRunners for
anything that might have already be initialized), and also isn't
actually used other than in one particular test that doesn't seem to
need what it does anyway.

BUG=None

Review-Url: https://codereview.chromium.org/2863023002
Cr-Commit-Position: refs/heads/master@{#469563}

This avoids the condition from being repeatedly checked.

Also tweek other methods to avoid unnecessary checks. Add test.

BUG=717128

Review-Url: https://codereview.chromium.org/2858143003
Cr-Commit-Position: refs/heads/master@{#469562}

This CL adds UMA and Revocation reporting from site settings when a site
exception is added or removed. The goal is to match the behavior of the
old options.

BUG=718544

Review-Url: https://codereview.chromium.org/2861793005
Cr-Commit-Position: refs/heads/master@{#469561}

Remove unnecessary zoom argument from GetImage() as its value is always available through the LayoutObject argument. (rebased)

BUG=716203
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2847303002
Cr-Commit-Position: refs/heads/master@{#469560}

This will allow me to increase code reuse with a nice custom @Rule.

BUG=640116

Review-Url: https://codereview.chromium.org/2854943005
Cr-Commit-Position: refs/heads/master@{#469559}

Copy the shared-memory NV12 GpuMemoryBuffer into an NV12 D3D11 dynamic
texture, which can be used as the source for the video processing that
goes to the backbuffer.

This still needs --enable-gpu-memory-buffer-video-frames to be enabled.
In my testing it reduces power on a 1080p60 VP9 video from 4W to 3.1W.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849963003
Cr-Commit-Position: refs/heads/master@{#469558}

This CL adds multiple trace events (TRACE_EVENTX) in various points in
the rendering to investigate the cause of glitches.

("webaudio", "AudioDestination::Start")
("webaudio", "AudioDestination::Stop")
("webaudio", "AudioDestination::RequestRenderOnWebThread", "frames_to_render", frames_to_render)
("webaudio", "AudioDestination::Render", "callback_buffer_size", number_of_frames)
("webaudio", "AudioDestinationHandler::Render")

BUG=718554

Review-Url: https://codereview.chromium.org/2858223003
Cr-Commit-Position: refs/heads/master@{#469557}

This CL rolls the sysroots after https://codereview.chromium.org/2863663003/

R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2866583002
Cr-Commit-Position: refs/heads/master@{#469556}

R=dpapad@chromium.org
BUG=696910
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855123004
Cr-Commit-Position: refs/heads/master@{#469555}

Android did not update the docs when multiwindow was implemented. But
essentially Display.getSize/getMetrics no longer refer to the Display
size, but to the window size, in order to be backwards compatible.

Fix and simply DisplayAndroid. Remove the distinction between "size"
and "physical size" by removing the concept of "physical" size. Always
just get the most correct size available.

Went through all use cases getSize. They all either don't care, or
was already trying to get the most correct value.

Review-Url: https://codereview.chromium.org/2859313002
Cr-Commit-Position: refs/heads/master@{#469554}

If ReassociateLocalTab is called with a tab node that is already mapped to a
tab, it's possible to wind up with the synced session tracker holding two
tab objects referring to the same tab id. This can lead to memory corruption.

This CL makes the tracker defensive against that scenario, and adds some more
data verification in the unit tests

BUG=714524, 639009

Review-Url: https://codereview.chromium.org/2856913007
Cr-Commit-Position: refs/heads/master@{#469553}

The PNaCl compiler does not understand -Os.

BUG=660216
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2865573002
Cr-Commit-Position: refs/heads/master@{#469552}

This is a (less ambitious) re-land of http://crrev.com/2852613002 which
was reverted due to content_browsertests crashes on ChromeOS. That CL is
a re-land of http://crrev.com/2779193002 which was reverted due to build
errors on Mac.

Instead of rolling Google Test to 1.8.0, this CL uses the last commit
before a breaking change was introduced. Details about the breakage are
in https://crbug.com/630705#c27 and https://crbug.com/630705#c28. It is
expected that rolling Google Test from there to the next usable version
will be much less disruptive.

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate locations of
  third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
  depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and headers
in testing/{gtest,gmock} for now.

BUG=630705
TESTED=out/Default/content_browsertests --gtest_filter=MojoTest.Init
TESTED=ninja -C out/Default/ ced_unittests && ninja -C out/Default
TBR=rkc, dpranke

Review-Url: https://codereview.chromium.org/2856383002
Cr-Commit-Position: refs/heads/master@{#469551}

BUG=715859

Review-Url: https://codereview.chromium.org/2855943003
Cr-Commit-Position: refs/heads/master@{#469550}

This moves the views-related dependencies (including chrome/app/theme)
out of the top-level //apps static library.

Some DEPS includes were dropped entirely as they are no longer used in
//apps.

BUG=679971
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2820563004
Cr-Commit-Position: refs/heads/master@{#469549}

Sanitizer coverage instrumentation increases linker memory consumption
significantly.

BUG=717552
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2866443003
Cr-Commit-Position: refs/heads/master@{#469548}

https://skia.googlesource.com/skia.git/+log/783c43658d91..02ab8cc2909d

$ git log 783c43658..02ab8cc29 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 mtklein Revert "Factor out common code from sweep and linear."
2017-05-04 amaury.leleyzour CRC32 no longer restricted to ARM64

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ib7a60db4a9ca23c9543f61c3bb0b6b47e8d67f99
Reviewed-on: https://chromium-review.googlesource.com/497007Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469547}

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus, --mash, and neither in /etc/chrome_dev.conf
     and check that user activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key

Review-Url: https://codereview.chromium.org/2863623005
Cr-Commit-Position: refs/heads/master@{#469546}

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Also, since crrev.com/2835203002 we no
longer allow empty render pass lists to be sent over IPC. Fix the tests
and remove the checks for empty render pass lists in prod to simplify
code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2855723002
Cr-Commit-Position: refs/heads/master@{#469545}

This allows us to remove the conditional dependency from //media/gpu to
//media/mojo/services, thus allowing future dependencies in the other
direction.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857953006
Cr-Commit-Position: refs/heads/master@{#469544}

The cursor surface is parented to the primary root window, which may
change when using multiple displays. This CL fixes a crash caused by
removing the child from the primary root window when the parent is a
different root window or the child is orphaned.

BUG=714832
TEST=No crashes after changing primary display.

Review-Url: https://codereview.chromium.org/2862953002
Cr-Commit-Position: refs/heads/master@{#469543}

With this we can see how often different workarounds are being hit.

Review-Url: https://codereview.chromium.org/2841273002
Cr-Commit-Position: refs/heads/master@{#469542}

https://chromium.googlesource.com/angle/angle.git/+log/677bb6f..aa7203e

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862723006
Cr-Commit-Position: refs/heads/master@{#469541}

Whitelisted Linux apps can access chrome.bluetooth. Initialize Bluetooth so
we don't crash on those apps.

BUG=711142
R=rkc@chromium.org,rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2819593003
Cr-Commit-Position: refs/heads/master@{#469540}

Pure code movement.

Review-Url: https://codereview.chromium.org/2857143005
Cr-Commit-Position: refs/heads/master@{#469539}

This CL was generated mechanically with:

$ git grep -l m_callback -- third_party/WebKit/Source | \
      xargs -n 1 sed -i -e 's/\bm_callback\b/callback_/g'

No intended behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2858153004
Cr-Commit-Position: refs/heads/master@{#469538}

Map ShelfID to AppLaunchId and use that instead of uint32_t.
ShelfModel no longer assigns int ids, clients supply unique strings.

ShelfID/ShelfItem/ShelfModel:
-Add comparison operators and IsNull() helper function.
-Add a corresponding ShelfID mojo struct with traits and test.
-Allow empty app_id strings (iff the launch_id string is also empty).
-Nix ShelfItem's AppLaunchId, use its ShelfID |id| instead.
-DCHECK unique non-empty ShelfIDs (avoid odd ShelfModel behavior).

Properties:
-Remove aura::client::kAppIdKey, use ash::kShelfIdKey instead.
-Move kShelfIDKey to ash/public/cpp to approve Chrome usage.
-Register kShelfIdKey for mus/mash conversion and mirroring.
-Require a kShelfIDKey property for ShelfWindowWatcher item creation.

Misc/Chrome:
-Set non-empty ShelfIDs for AppList, Task Manager, Settings.
-Apply ExtensionWindow* ShelfIDs for panel windows too.
-Use ShelfID in ExtensionAppWindowLauncherController maps.

TODO: Rename AppLaunchId to ShelfID (can do in this CL if desired)
TODO: Remove ShelfModel id conversion functions; audit users.
(also used to check item presence in ShelfModel, map ARC ids...)

OPTIONAL: Keep kShelfIDKey in ash/wm/window_properties for now?
OPTIONAL: CHECK in ShelfModel for prod/arc? Loosen checks for tests?

BUG=557406
TEST=No Chrome OS shelf or app regressions.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,reveman@chromium.org

Review-Url: https://codereview.chromium.org/2860503002
Cr-Commit-Position: refs/heads/master@{#469537}

https://pdfium.googlesource.com/pdfium.git/+log/b8a8c43f3942..e8c1d4144e84

$ git log b8a8c43f3..e8c1d4144 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 thestig Give a couple of char to int functions better names.
2017-05-04 thestig Reduce 1D barcode DrawPath calls.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I0f31d35b9bebe501f81431b5bb0a94e9c91c6509
Reviewed-on: https://chromium-review.googlesource.com/497006
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469536}

Bug=712331

Review-Url: https://codereview.chromium.org/2865553002
Cr-Commit-Position: refs/heads/master@{#469535}