- 27 Oct, 2020 40 commits
-
-
Dave Tapuska authored
In anticipation of the RenderWidget removal, move RequestPresentation into WebWidgetTestProxy and rename it to match the bindings name. BUG=1097816 Change-Id: I1fa060ee6d3c788bb519830ae61a0e01bebcb859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499741 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821459}
-
bttk authored
Bug: 1139481 Change-Id: Iff40d93d02e6e35aaf6573ecb1a60b582a263c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500529 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#821458}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a01dd2af4292..5d3967cb630c 2020-10-27 chonggu@google.com [Fuchsia] Add Flags for WebEngine 2020-10-27 landrey@webrtc.org Fix bug when state of a measurement wasn't updated If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128357,chromium:1130706 Tbr: zhanliang@google.com Change-Id: I44f1ee7418e95c9f671458da6e8513496090c92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821457}
-
David Bokan authored
This adds the "disables threaded scrolling" flag to web tests unless threaded compositing is enabled (as happens in "threaded" virtual test suites). Traditionally, web tests force-route all input to the main thread unless threaded compositing is explicitly enabled. crbug.com/915926 will change this; like real Chrome, input will always be routed through the compositor first, even when running in single-threaded mode. To preserve existing test coverage, where scrolling would happen on the main thread, this CL adds and disables a "threaded scrolling" WebPreference in web tests which makes Blink give all scrollers a MainThreadScrollingReason. This functionality is already available behind a --disable-threaded-scrolling flag so this preference uses the same mechanism. "threaded" virtual test suites turn threaded scrolling back on by passing --enable-threaded-compositing which will enable the WebPreference. This change means that non-threaded web test input will flow through the compositor but it will fallback to main thread scrolling like it would in the real world (for other compositing-related reasons). However, this CL doesn't change the fact that we force-route input to the main thread. That's done in https://crrev.com/c/2281179. Some tests in compositing/ explicitly check the main thread scrolling reasons so we add an explicit enabling of threaded scrolling in those tests to prevent adding the flag-based reason. Bug: 915926 Change-Id: I43329e86c784c5e116e6a96549fb8676f03f94ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441684Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821456}
-
Steven Bingler authored
Change-Id: Ie17324e4035eff24b50b6f4111cea2f466a8bcdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503574 Auto-Submit: Steven Bingler <bingler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#821455}
-
Chong Gu authored
Change the location on Fuchsia target where result and filter files are stored. Remove unused flag --target-staging-path. Bug: fuchsia:47956 Change-Id: Ic8068dcdd48654e672251b76047fcb9b69f9a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499371Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#821454}
-
Andrew Grieve authored
E.g. chromium-binary-size-trybot-results%2Fandroid-binary-size vs: chromium-binary-size-trybot-results/android-binary-size Bug: 1131568 Change-Id: I8801d04748d0d21bb4bdf2a63a56f78445a23160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503634 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#821453}
-
Yuheng Huang authored
This changes fixed the weird focus collision bug on Linux. Similar patterns can be found in HatsBubbleView and ProfileMenuViewBase. Bug: 1139028,1099917 Change-Id: I4703f631216584feecf117b6a1901fbccfb14e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499086Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#821452}
-
Alex Newcomer authored
We will eventually remove the flag, but due to dogfood messaging we will keep it around for a bit longer. Bug: 1138674 Change-Id: I544fe687f5077e2779e7924e5697c6ce1d9d351f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500022 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821451}
-
Etienne Bergeron authored
This is a reland of b642822f Original change's description: > Move ISpVoice instance to a worker thread > > This CL is moving the speech synthesizer code to a worker thread. > > The TtsPlatformImpl is using an ISpVoice COM interface to perform > text-to-speech actions. The instance was living on the UI Main > Thread which was using STA Apartment. > > This CL is splitting the logic in two parts. The first part is the > control logic which stay on the UI Thread. The second part is the > synthesizer logic which is running on a worker thread. > > Bug: 869399, 1133813 > Change-Id: I8f8d939950cc39637f87d101ed362123a51e985e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462341 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820340} Bug: 869399 Bug: 1133813 Change-Id: I4f1e5bb143472b2d96cf4fe55d3f74d1e5c56877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502948Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821450}
-
Dale Curtis authored
It ought to be enough for everyone! Tests on Window show that normal audio playback only uses 4kB and WebRTC uses ~68kB, so 256kB seems enough to cover our use cases. Fixed: 1141563 Change-Id: I4f119c3985347b45b4d934432792efb0d6e2dc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500432 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#821449}
-
Lijin Shen authored
Add a new general swipe listener, which is derived from SwipeRecognizer. Bug: 1123947, 1142475 Change-Id: I1e1518300bd4dbf36b889970cb89981b0ff3a15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493364 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821448}
-
minch authored
Re-upload IDS_ASH_SCREEN_CAPTURE_TOOLTIP_SCREENSHOT.png and IDS_ASH_SCREEN_CAPTURE_TOOLTIP_SCREENRECORD.png. The old ones were cut incorrectly by a tool and can't be interpreted correctly. Bug: 1142099 Change-Id: I79b08c055ce87ca4cb2bcec16fcb06822ac0b6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503394Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#821447}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1142671 Change-Id: Ied44b2bee60ee3724ec79693f74d857e9a48d5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500577 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821446}
-
Frank Tang authored
1. Only send out timezone change while the override is different than the host. 2. Not reset the timezone override for every change. 3. Compare equality based on canonical value. Bug: 1135960 Change-Id: I03c0a5fc62207f652ba3371509a3699115cd7dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472466Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821445}
-
Lukasz Anforowicz authored
wpt/external/wpt/html/browsers/windows/nested-browsing-contexts/frameElement-siblings.sub.html uses document.domain, which means that it is incompatible with isolating each individual WPT origin (the default) and should only be run as part of virtual/not-site-per-process test suite. Additionally, after a past WPT roll, the test started passing when run in not-site-per-process mode. Based on the above, the CL makes two changes: 1) add the test to the not-site-per-process virtual test suite 2) remove windows/nested-browsing-contexts/frameElement-siblings.sub-expected.txt Fixed: 1099689 Change-Id: I4192736ede4ee1fb4a59992ed8edd42d75cd2a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288380 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821444}
-
Avi Drissman authored
Fixed: 1142806 Change-Id: I633364889de7b1dc3b30847840ead8dadd0afcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503778Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821443}
-
Bill Budge authored
- Remove switches: kDisableBundledPpapiFlash, kPpapiFlashPath, and kPpapiFlashVersion. - Removes some Flash constants that aren't too hard to eliminate. Bug: chromium:1133887 Change-Id: I1c7845141cc2d5b5c839183fde47b3e667f5f017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495974Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#821442}
-
Leszek Swirski authored
Bug: chromium:1011762 Change-Id: I6cc384b5815fb67ccbf516fc358e2825a2fc777f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501622 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#821441}
-
ssid authored
Chained tasks and async tasks are traced using the wrapper class name. Add trace events to track these tasks BUG=1136635 Change-Id: Ibafce336fbfc4f7491bd196b93b92bf42ad143e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491402Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#821440}
-
Samuel Attard authored
This is done so that the arm64 and x64 v8 context snapshots can live side by side in a universal app build of a Chromium based application. All other files can be Mach-O universal binaries generated using "lipo" but these snapshot files have to be uniquely named so that both can exist in the Resources folder at the same time and the correct one is chosen at runtime. Bug: 1142017 Change-Id: I8449b72ba3a36e7ce69b9d9ec7768bd80ecc3e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490980Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821439}
-
Alex Moshchuk authored
The suspected cause of flakiness here is that the page used in the test scrolls an OOPIF, but doesn't properly wait for layout to finish and for visibility/viewport intersection changes to be propagated to the corresponding CrossProcessFrameConnector. This was verified by inserting an artificial delay into RemoteFrameView::VisibilityChanged(). Fix this by inserting a EvalJsAfterLifecycleUpdate, which will trigger requestAnimationFrame and should wait for layout to finish. This usage is similar to a few other uses of EvalJsAfterLifecycleUpdate for syncing viewport intersection changes in other tests in this file. Bug: 1135072 Change-Id: I49434044a617b1530ce121c24d97aa7071760c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503316Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#821438}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ibb4639453b2d172dbdd4d8768be5d0083c66b198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503592Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821437}
-
Nicolás Peña Moreno authored
In this CL we upgrade ExperimentalLargestContentfulPaint to become the default version. To do this, we do the following: * Update the LargestContentfulPaintCalculator in Blink since the web API now should report according to the Experimental version, which is equivalent to reporting by the values in the detectors monotonically. That is, we just store the largest text or image size and we report a new entry whenever we find a candidate with a larger size. * In Blink's PaintTimingDetector, swap the experimental values with the non-experimental ones, so that ExperimentalLCP becomes the 'actual' LCP and the previous LCP becomes 'experimental'. * In the browser side, change the naming of the experimental vs current LCP histogram names in both UMA and UKM, so that the experimental name becomes LCP while the current version becomes LCP2. This means that the current 'experimental' histograms become obsolete as they are no longer reported. This is done to continue reporting LCP for some time to support Finch and other users of these metrics while the transition occurs. In a couple of months or so, we will stop reporting the 'experimental' version of LCP, which means not reporting the LCP (not LCP2) histograms. This will also enable simplifying the Image and Text PaintTimingDetectors in Blink, as we will no longer need to keep track of the paint timestamps of all nodes being painted. Ukm collection review: https://docs.google.com/document/d/1gIQ6XuUZtaRb-BmqW8QWpt_cJdIeCsHsAvPVQkiaOhM/edit Bug: 1045640 Change-Id: I2e27c0f940656b12766feeff3d506c90152f28d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480845 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#821436}
-
Alex Turner authored
base::Bind is deprecated and should be replaced with the more explicit Once/Repeating form. The majority of chrome/tools was already migrated, but one use remained. We fix that and enable the presubmit to avoid any future regressions. Bug: 1141533, 1007644 Change-Id: Iffd78f79fa65caeeb3f4a6764952a2eebd126361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495605Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#821435}
-
Zhaoyang Li authored
Added 2 builders and 3% experiment ios-simulator-coverage-exp mirrors ios-simulator ios-simulator-full-configs-coverage-exp mirrors ios-simulator-full-configs Removed 3% experiment on ios-simulator-code-coverage try builder. Bug: 1090188 Change-Id: Ia797ef663b3ab448387057c77b939af3ed937c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495962Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#821434}
-
Michael Hansen authored
This adds a "pulse" animation to the send discovery dialog, which gives a visual indication that scanning is underway to attempt to discover other devices to share with. This animation will also be added to the high-visibility receive dialog in a separate CL. Screenshot: https://screenshot.googleplex.com/4AYJTgtGcVHAuRi.png Spec: https://carbon.googleplex.com/cros-ux/pages/nearby-share/motion Bug: b:170890753 Change-Id: I7361021ba3ae4fbc03a01d055eb6ba10e5c65716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500279 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#821433}
-
Victor Costan authored
This CL replaces smart pointers (scoped_refptr) with references where the pointers are guaranteed to be non-null, and the objects are only used during the method call. This removes the test's reliance on QuotaClient being ref-counted, which will come in handy when QuotaClient gets mojofied. Bug: 1016065 Change-Id: I0ec5ea2f40c03bbdb4e6af504d6f2b4902115c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496743 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821432}
-
Hoch Hochkeppel authored
Adding support for IDataRequestDeferral to the FakeDataTransferManager, as well as adding a test-only PostDataRequested event for easily intercepting the data shared by a DataRequested handler. Also expanding the corresponding tests to validate this new behavior. Bug: 1035527 Change-Id: I44589302272e432b3ea7201b50faa2d90d254194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500947Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#821431}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/57694c8dab3c..fcbc6efa8fd3 2020-10-27 rharrison@chromium.org [inspector] Extract storage-buffer information If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: Ia7fb9281e954f3a4e7d7291a73b1de5bb48ee25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821430}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1142671 Change-Id: I0826f093bde1723c93139f7d4b7bb388aae7074e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500663 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821429}
-
Shengfa Lin authored
The root level node could be a javascript Proxy object(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy) instead of the document itself. In this case, we cannot use "== document" to check if an element is reachable and generate the stale element error. Instead, we will use "== document.documentElement.parentNode", which should be document or the Proxy node. Bug: chromedriver:3628 Change-Id: Ie7c7c78e0e796dcf3023aa1d5385fa95bd139ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502576Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#821428}
-
Victor Costan authored
This CL replaces smart pointers (scoped_refptr) with references where the pointers are guaranteed to be non-null, and the objects are only used during the method call. This removes the test's reliance on QuotaClient being ref-counted, which will come in handy when QuotaClient gets mojofied. Bug: 1016065 Change-Id: I03493aa3e62d8cac2b8b9d81ace5d44dbfa75915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496744Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821427}
-
James Cook authored
Prior to this CL, files downloaded in Lacros would "disappear" -- they would not show up in the file manager. The downloads code would choose its default directory using the Chrome for Linux path provider, which does not know about Chrome OS paths, and the files would end up in a directory the file manager can't navigate to. Add chrome_paths_lacros.cc to supply the correct paths. Because Lacros does not support Chrome OS multi-signin, we make the decision that lacros-chrome does not need to know about the under-the- hood /home/chronos/u-{hash} multi-signin profile directories. It uses the hard-linked /home/chronos/user path for the system primary profile. This avoids exposing knowledge of the hash to Lacros. Bug: 1139082 Change-Id: I8836760632fd9a1a8f9d49d7f03f1e6f6dfb0841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500278Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#821426}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 655d04d4. With Chromium commits locally applied on WPT: 6eb4060f "Add WP test for referrer policy inheritance when navigating back" a9818a74 "Add epislon to matrix tests to fix 0 = -0 problem" 655d04d4 "Fix referrer policy inheritance WPT for javascript: URLs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I43dfa9e6e04f3e251945589b674b0b1bef42dff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503428Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821425}
-
Jimmy Gong authored
- This change fixes a bug where we previously did not actually attach PhoneStatusProcessor as an observer to MultiDeviceSetupClient::Observer - Fixes a bug where the phone name was not being displayed in the phone hub tray Bug: 1106937 Fixed: 1141642 Test: chromeos_components_unittests Change-Id: I4a7b04e34a5b7950b63a4b32dc633fece7c52e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501063 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821424}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1142671 Change-Id: I2be70e691cb316d4ac5ae5c48b309758d30cfd07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500493 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821423}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=hanxi@chromium.org Bug: 1142671 Change-Id: I527f1a4dda878d289ac3542336b87737bd377f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500590 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821422}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=hanxi@chromium.org Bug: 1142671 Change-Id: I28b7b2eb82e87e409f370d044f1aa2e4845d764d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500605 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821421}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ibfca948636ea19a4da798f38d5056088e93f1772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504028Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#821420}
-